)]}'
{"networking_ovn/tests/functional/octavia/test_ovn_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"74fe5e42eb708930625a8204a4d505adf904b293","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            lbs.append({\u0027name\u0027: lb.name, \u0027protocol\u0027: lb.protocol,"},{"line_number":176,"context_line":"                        \u0027vips\u0027: lb.vips, \u0027external_ids\u0027: external_ids,"},{"line_number":177,"context_line":"                        ovn_const.OVN_PORT_NAME_EXT_ID_KEY:"},{"line_number":178,"context_line":"                            ovn_const.LB_VIP_PORT_PREFIX + lb.name})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return lbs"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_853ad9e4","line":178,"updated":"2019-09-18 13:50:09.000000000","message":"I guess this should be set in external_ids","commit_id":"68fb94e3e9ea61ecb56b7500c06298f36e7fcd31"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"eba517f00b7feb26dc57876cd0305a6a97376920","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        lbs \u003d []"},{"line_number":168,"context_line":"        for lb in self.nb_api.tables[\u0027Load_Balancer\u0027].rows.values():"},{"line_number":169,"context_line":"            external_ids \u003d dict(lb.external_ids)"},{"line_number":170,"context_line":"            external_ids[ovn_const.OVN_PORT_NAME_EXT_ID_KEY] \u003d ("},{"line_number":171,"context_line":"                ovn_const.LB_VIP_PORT_PREFIX + lb.name)"},{"line_number":172,"context_line":"            ls_refs \u003d external_ids.get(ovn_driver.LB_EXT_IDS_LS_REFS_KEY)"},{"line_number":173,"context_line":"            if ls_refs:"},{"line_number":174,"context_line":"                external_ids["}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_88b510f1","line":171,"range":{"start_line":170,"start_character":0,"end_line":171,"end_character":55},"updated":"2019-09-18 14:07:31.000000000","message":"While octavia creates a LB it asks provider driver to create a VIP port. We\u0027re setting this \u0027port name\u0027 field to an information that this particular port is VIP port and then we do some actions on it (while handling LogicalSwitchPortUpdateEvent() events. We shouldn\u0027t be adding this extarnal-id here.\n\nhttps://github.com/openstack/networking-ovn/blob/cb1d0d91d8cba40bb4f7617ab2d995b50d70fbe0/networking_ovn/octavia/ovn_driver.py#L1520","commit_id":"b383d83b5905292c21cdd6bc2671951891ba7837"}]}