)]}'
{"networking_ovn/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"fda5070edbb622ee79ed5d8d8f1aafebc9e0e2f8","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"},{"line_number":679,"context_line":"        for pg in self._tables[\u0027Port_Group\u0027].rows.values():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_81662629","line":676,"range":{"start_line":675,"start_character":0,"end_line":676,"end_character":18},"updated":"2019-09-20 09:16:35.000000000","message":"As this comes from the maint task, what if we do:\n\nhttps://github.com/openstack/networking-ovn/blob/master/networking_ovn/common/maintenance.py#L135\n\n        return (self._nb_idl.get_address_set(uuid) or\n                (self._nb_idl.is_port_groups_supported() and\n                 self._nb_idl.get_port_group(uuid)))","commit_id":"66a96e2f2d582e198a3ba68430702a820a34c062"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"fda5070edbb622ee79ed5d8d8f1aafebc9e0e2f8","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def get_port_groups(self):"},{"line_number":684,"context_line":"        port_groups \u003d {}"},{"line_number":685,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":686,"context_line":"            return port_groups"},{"line_number":687,"context_line":"        for row in self._tables[\u0027Port_Group\u0027].rows.values():"},{"line_number":688,"context_line":"            name \u003d getattr(row, \u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_216df203","line":685,"updated":"2019-09-20 09:16:35.000000000","message":"If we do what i suggested in L676 we don\u0027t need this either I guess","commit_id":"66a96e2f2d582e198a3ba68430702a820a34c062"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6d6c0621dea55e9510dee7909c586db01b7dd956","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b24fee32","line":675,"updated":"2019-09-20 11:32:52.000000000","message":"Given that we aim towards running newer version, I think it would make more sense to catch some exception like \"Table doesn\u0027t exist\", no? On environments with new version, we\u0027ll keep checking for table presence all the time.","commit_id":"067efe46aaacaff0ec8d8efaefe1b58098ddce4d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a4b84ce01ff590232c950e9626da1286298357aa","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_edacab36","line":675,"in_reply_to":"3fa7e38b_12b282e7","updated":"2019-09-23 11:05:47.000000000","message":"+1 to kuba\u0027s suggestion as well. We need something backportable though","commit_id":"067efe46aaacaff0ec8d8efaefe1b58098ddce4d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2bfb3b101d751e123cfa10854e46216584487fbe","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_48ddaa40","line":675,"in_reply_to":"3fa7e38b_12b282e7","updated":"2019-09-20 14:47:00.000000000","message":"I think that will be more convenient :)","commit_id":"067efe46aaacaff0ec8d8efaefe1b58098ddce4d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"3aa41a42b9403f632af91d49b03cbf7b91920448","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_412c9198","line":675,"in_reply_to":"3fa7e38b_48ddaa40","updated":"2019-09-22 19:45:52.000000000","message":"Thanks!","commit_id":"067efe46aaacaff0ec8d8efaefe1b58098ddce4d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a36cdc511c51f4b3db4b25be64bf8e2ac8cbb951","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        return self.is_table_present(\u0027Port_Group\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_port_group(self, pg_name):"},{"line_number":675,"context_line":"        if not self.is_port_groups_supported():"},{"line_number":676,"context_line":"            return"},{"line_number":677,"context_line":"        if uuidutils.is_uuid_like(pg_name):"},{"line_number":678,"context_line":"            pg_name \u003d utils.ovn_port_group_name(pg_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_12b282e7","line":675,"in_reply_to":"3fa7e38b_b24fee32","updated":"2019-09-20 11:44:11.000000000","message":"I can watch for KeyError exception from L680. Agreed?","commit_id":"067efe46aaacaff0ec8d8efaefe1b58098ddce4d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bacd71dcd21a1dc1539b7dccd608615f06b8b829","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            for pg in self._tables[\u0027Port_Group\u0027].rows.values():"},{"line_number":679,"context_line":"                if pg.name \u003d\u003d pg_name:"},{"line_number":680,"context_line":"                    return pg"},{"line_number":681,"context_line":"        except KeyError:"},{"line_number":682,"context_line":"            return"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def get_port_groups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_d6127e09","line":681,"updated":"2019-09-23 10:57:32.000000000","message":"If there will be need for another re-spin, it could be good to leave a comment here we have this KeyError here for the backward compatibility with older core ovn. In a year from now when we\u0027ll go over this code, we\u0027ll wonder :)","commit_id":"2487055339ba2429126eb644ef0e356007a148ab"}],"networking_ovn/tests/unit/ovsdb/test_impl_idl_ovn.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a25ceb1f15e40d5bdbfa52110d54f9807ef08a15","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        with mock.patch.object(self.nb_ovn_idl, \u0027is_port_groups_supported\u0027,"},{"line_number":720,"context_line":"                               return_value\u003dFalse):"},{"line_number":721,"context_line":"            port_groups \u003d self.nb_ovn_idl.get_port_groups()"},{"line_number":722,"context_line":"        self.assertEquals({}, port_groups)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"class TestSBImplIdlOvn(TestDBImplIdlOvn):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7224410e","line":722,"range":{"start_line":722,"start_character":13,"end_line":722,"end_character":25},"updated":"2019-09-18 13:01:29.000000000","message":"2019-09-18 10:24:00.266314 | ubuntu-bionic | ./networking_ovn/tests/unit/ovsdb/test_impl_idl_ovn.py:722:22: H234  assertEquals is deprecated, use assertEqual\n2019-09-18 10:24:00.266588 | ubuntu-bionic |         self.assertEquals({}, port_groups)\n\nsure thing..","commit_id":"4af8ad0f3323209563232988086343cf021560f5"}]}