)]}'
{"networking_ovn/tests/functional/test_router.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"68a3037e3a09aaefde904947ac9b1fb720080cda","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            router_id \u003d router1[\u0027id\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            # Unset gateway (using gw_info\u003dNone)"},{"line_number":226,"context_line":"            set_external_gateway(self.context, self.l3_plugin, router_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"            # Ensure that chassis2 is candidate for ext2 (physnet2)"},{"line_number":229,"context_line":"            gw_info \u003d {\u0027network_id\u0027: ext2[\u0027network\u0027][\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_314bdc59","line":226,"updated":"2019-09-23 11:42:49.000000000","message":"nit: even though the comment says it, it\u0027d be clearer to specify gw_info\u003dNone in the parameters\n\nAfter this, do we want to make sure that the gateway port has been removed?","commit_id":"93424e652f6cf86d16b4d1d0e0b114f682479522"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"781438260ce5123a6c1bcee9e1c5521b2f1c928a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            router_id \u003d router1[\u0027id\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            # Unset gateway (using gw_info\u003dNone)"},{"line_number":226,"context_line":"            set_external_gateway(self.context, self.l3_plugin, router_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"            # Ensure that chassis2 is candidate for ext2 (physnet2)"},{"line_number":229,"context_line":"            gw_info \u003d {\u0027network_id\u0027: ext2[\u0027network\u0027][\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_17b6c63f","line":226,"in_reply_to":"3fa7e38b_314bdc59","updated":"2019-09-23 21:37:52.000000000","message":"Good point. Fixed.","commit_id":"93424e652f6cf86d16b4d1d0e0b114f682479522"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"199009e0596b68918cb333ec66cfcd65ca0df33b","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            # We can\u0027t test call_count for these mocks, as we have disabled"},{"line_number":349,"context_line":"            # maintenance_worker which will trigger chassis events"},{"line_number":350,"context_line":"            # and eventually calling schedule_unhosted_gateways"},{"line_number":351,"context_line":"            self.assertGreaterEqual(client_select.call_count, 3)"},{"line_number":352,"context_line":"            self.assertGreaterEqual(plugin_select.call_count, 4)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_router_gateway_port_binding_host_id(self):"},{"line_number":355,"context_line":"        # Test setting chassis on chassisredirect port in Port_Binding table,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_717fff14","line":352,"range":{"start_line":351,"start_character":12,"end_line":352,"end_character":63},"updated":"2019-09-24 10:34:15.000000000","message":"Sorry for being picky. Why \u003e\u003d 3 and \u003e\u003d4 ? I think I get it but perhaps we can add a comment at the beginning of the test to explain what this test exercises and the expected results. Otherwise 3 and 4 sounds pretty magic.\n\nWe may also want to change the comment above (L348) ato something like \"We can\u0027t test exact call_count ...\" \"But we know for sure that at least X and Y calls had to occur\". What do you think?","commit_id":"7f6af84fea50f792d76baad77de0e2109808b5dd"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"28292df2afd00d2362b59e1dbe08e8cc55ecf43e","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            # We can\u0027t test call_count for these mocks, as we have disabled"},{"line_number":349,"context_line":"            # maintenance_worker which will trigger chassis events"},{"line_number":350,"context_line":"            # and eventually calling schedule_unhosted_gateways"},{"line_number":351,"context_line":"            self.assertGreaterEqual(client_select.call_count, 3)"},{"line_number":352,"context_line":"            self.assertGreaterEqual(plugin_select.call_count, 4)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_router_gateway_port_binding_host_id(self):"},{"line_number":355,"context_line":"        # Test setting chassis on chassisredirect port in Port_Binding table,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5b00d5ab","line":352,"range":{"start_line":351,"start_character":12,"end_line":352,"end_character":63},"in_reply_to":"3fa7e38b_717fff14","updated":"2019-09-24 20:26:25.000000000","message":"Not picky at all, please keep these comments coming!\n\nI made these changes, lmk if that makes more sense.","commit_id":"7f6af84fea50f792d76baad77de0e2109808b5dd"}]}