)]}'
{"networking_ovn/agent/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cd3c3e0c01046afb4f0422c72e9237c647e1cb61","unresolved":false,"context_lines":[{"line_number":297,"context_line":"          for this datapath."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":300,"context_line":"        datapath_ports \u003d [p for p in ports if p.type in OVN_VIF_PORT_TYPES and"},{"line_number":301,"context_line":"                          str(p.datapath.uuid) \u003d\u003d datapath]"},{"line_number":302,"context_line":"        if datapath_ports:"},{"line_number":303,"context_line":"            self.provision_datapath(datapath)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1806751e","line":300,"updated":"2019-10-17 16:01:11.000000000","message":"Should update test_update_datapath_provision() and/or test_update_datapath_teardown() to have an external port.","commit_id":"605041cf8d7b9cb496cb878a927a9660514daadf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9798200f7a84625aa91f61ab97faa7ab4356578d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"          for this datapath."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":300,"context_line":"        datapath_ports \u003d [p for p in ports if p.type in OVN_VIF_PORT_TYPES and"},{"line_number":301,"context_line":"                          str(p.datapath.uuid) \u003d\u003d datapath]"},{"line_number":302,"context_line":"        if datapath_ports:"},{"line_number":303,"context_line":"            self.provision_datapath(datapath)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_99fc9d0d","line":300,"in_reply_to":"3fa7e38b_1806751e","updated":"2019-10-18 09:45:16.000000000","message":"++","commit_id":"605041cf8d7b9cb496cb878a927a9660514daadf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cd3c3e0c01046afb4f0422c72e9237c647e1cb61","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # Retrieve all VIF ports in our Chassis"},{"line_number":433,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":434,"context_line":"        datapaths \u003d {str(p.datapath.uuid) for p in ports if p.type in"},{"line_number":435,"context_line":"                     OVN_VIF_PORT_TYPES}"},{"line_number":436,"context_line":"        namespaces \u003d []"},{"line_number":437,"context_line":"        # Make sure that all those datapaths are serving metadata"},{"line_number":438,"context_line":"        for datapath in datapaths:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7801a904","line":435,"updated":"2019-10-17 16:01:11.000000000","message":"Should update test_ensure_all_networks_provisioned() to have an external port as well.","commit_id":"605041cf8d7b9cb496cb878a927a9660514daadf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9798200f7a84625aa91f61ab97faa7ab4356578d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # Retrieve all VIF ports in our Chassis"},{"line_number":433,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":434,"context_line":"        datapaths \u003d {str(p.datapath.uuid) for p in ports if p.type in"},{"line_number":435,"context_line":"                     OVN_VIF_PORT_TYPES}"},{"line_number":436,"context_line":"        namespaces \u003d []"},{"line_number":437,"context_line":"        # Make sure that all those datapaths are serving metadata"},{"line_number":438,"context_line":"        for datapath in datapaths:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b9015907","line":435,"in_reply_to":"3fa7e38b_7801a904","updated":"2019-10-18 09:45:16.000000000","message":"++","commit_id":"605041cf8d7b9cb496cb878a927a9660514daadf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e7ff13c98f34ea967ca43d3668b7238ae4407fa5","unresolved":false,"context_lines":[{"line_number":297,"context_line":"          for this datapath."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":300,"context_line":"        datapath_ports \u003d [p for p in ports if p.type in OVN_VIF_PORT_TYPES and"},{"line_number":301,"context_line":"                          str(p.datapath.uuid) \u003d\u003d datapath]"},{"line_number":302,"context_line":"        if datapath_ports:"},{"line_number":303,"context_line":"            self.provision_datapath(datapath)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_935eb174","line":300,"updated":"2019-10-18 18:48:11.000000000","message":"Would it be cleaner if we had something like a generator expression:\n\n    def vif_ports(ports):\n        return (p for p in ports if p.type not in OVN_VIF_PORT_TYPES)\n\nand then just use vif_ports(ports) when we wanted to filter?","commit_id":"cbc2736f3051af717ba7b9b5208e99425ab97046"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c48e28db0a4cdd8dafe315e23d07bc4ea249943","unresolved":false,"context_lines":[{"line_number":297,"context_line":"          for this datapath."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":300,"context_line":"        datapath_ports \u003d [p for p in ports if p.type in OVN_VIF_PORT_TYPES and"},{"line_number":301,"context_line":"                          str(p.datapath.uuid) \u003d\u003d datapath]"},{"line_number":302,"context_line":"        if datapath_ports:"},{"line_number":303,"context_line":"            self.provision_datapath(datapath)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ef160ea8","line":300,"in_reply_to":"3fa7e38b_771f5609","updated":"2019-10-21 12:22:22.000000000","message":"Good tip! I will update the code","commit_id":"cbc2736f3051af717ba7b9b5208e99425ab97046"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dae8f177d9a995592c597c85e9e03be303fb78d1","unresolved":false,"context_lines":[{"line_number":297,"context_line":"          for this datapath."},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        ports \u003d self.sb_idl.get_ports_on_chassis(self.chassis)"},{"line_number":300,"context_line":"        datapath_ports \u003d [p for p in ports if p.type in OVN_VIF_PORT_TYPES and"},{"line_number":301,"context_line":"                          str(p.datapath.uuid) \u003d\u003d datapath]"},{"line_number":302,"context_line":"        if datapath_ports:"},{"line_number":303,"context_line":"            self.provision_datapath(datapath)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_771f5609","line":300,"in_reply_to":"3fa7e38b_935eb174","updated":"2019-10-21 08:25:51.000000000","message":"++","commit_id":"cbc2736f3051af717ba7b9b5208e99425ab97046"}]}