)]}'
{"networking_ovn/ml2/trunk_driver.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"277b1a070b0334b46986c1c20c0b44787a505a8c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def _set_sub_ports(self, parent_port, subports):"},{"line_number":45,"context_line":"        context \u003d n_context.get_admin_context()"},{"line_number":46,"context_line":"        for port in subports:"},{"line_number":47,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":48,"context_line":"                self._set_binding_profile(context, port, parent_port)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _unset_sub_ports(self, subports):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1338efd0","line":47,"updated":"2019-10-29 16:27:44.000000000","message":"Do we need to open a separate transaction for every subport now?","commit_id":"e8d097417fea9c53339b80cff95fc602d73eb637"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"277b1a070b0334b46986c1c20c0b44787a505a8c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.debug(\"Port not found while trying to set \""},{"line_number":75,"context_line":"                      \"binding_profile: %s\", subport.port_id)"},{"line_number":76,"context_line":"            return"},{"line_number":77,"context_line":"        self.plugin_driver._nb_ovn.set_lswitch_port("},{"line_number":78,"context_line":"            lport_name\u003dsubport.port_id,"},{"line_number":79,"context_line":"            parent_name\u003dparent_port,"},{"line_number":80,"context_line":"            tag\u003dsubport.segmentation_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_53574702","line":77,"updated":"2019-10-29 16:27:44.000000000","message":"and can\u0027t we again batch this into a single ovn txn?","commit_id":"e8d097417fea9c53339b80cff95fc602d73eb637"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"b42f04e5517059980207c169122617ae2e40f5c4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.debug(\"Port not found while trying to set \""},{"line_number":75,"context_line":"                      \"binding_profile: %s\", subport.port_id)"},{"line_number":76,"context_line":"            return"},{"line_number":77,"context_line":"        self.plugin_driver._nb_ovn.set_lswitch_port("},{"line_number":78,"context_line":"            lport_name\u003dsubport.port_id,"},{"line_number":79,"context_line":"            parent_name\u003dparent_port,"},{"line_number":80,"context_line":"            tag\u003dsubport.segmentation_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_89d6f24e","line":77,"in_reply_to":"3fa7e38b_53574702","updated":"2019-10-29 18:17:48.000000000","message":"Yes, this is basically what I wanted to check with this change.\n\nThe original change was:\n   from 101 sec to 35.6 for 95%ile\n   from 99 sec to 34.2 for 50%ile\n\nBut making big and fat transactions has the adverse effect\nof causing timeouts, which is what we are in need to fix now. So we are seeing how badly we perform by having multiple ovn transactions, but still updating the neutron db\n\"directly\". The numbers are not as bad as the original values and we may need to settle with something similar or\nadd code to make smaller transactions. From the rally run in this initial change set:\n\n\n   from 35.6 sec to 47.6 for 95%ile\n   from 34.2 sec to 42.5 for 50%ile\n\n\nhttps://68f11d6b755a36e21cf1-58818f8d6a88f31ae0841c158a7f2252.ssl.cf1.rackcdn.com/691892/1/check/networking-ovn-rally-task/beb8e57/\n\nhttps://68f11d6b755a36e21cf1-58818f8d6a88f31ae0841c158a7f2252.ssl.cf1.rackcdn.com/691892/1/check/networking-ovn-rally-task/beb8e57/results/report.html.gz#/NeutronTrunks.create_and_list_trunks","commit_id":"e8d097417fea9c53339b80cff95fc602d73eb637"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4607b57598dd06af01db556f1fc6e31b7a748875","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    lport_name\u003dsubport.port_id,"},{"line_number":85,"context_line":"                    parent_name\u003dparent_port,"},{"line_number":86,"context_line":"                    tag\u003dsubport.segmentation_id))"},{"line_number":87,"context_line":"        LOG.debug(\"Setting DONE\")"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _unset_binding_profile(self, context, subport, ovn_txn):"},{"line_number":90,"context_line":"        LOG.debug(\"Unsetting parent for subport %s\", subport.port_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2ef4765a","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":33},"updated":"2019-11-01 13:46:09.000000000","message":"Can we add the ID of the subport and parent to this log (as in L61), otherwise it will be difficult to track which port this message is referring to in the logs.","commit_id":"5d20ee13406b53a0d0da06dd6c26105bbe698a93"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"64cc641d12ff43ed9faaf4370be1770f6b3ce54d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                    lport_name\u003dsubport.port_id,"},{"line_number":85,"context_line":"                    parent_name\u003dparent_port,"},{"line_number":86,"context_line":"                    tag\u003dsubport.segmentation_id))"},{"line_number":87,"context_line":"        LOG.debug(\"Setting DONE\")"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _unset_binding_profile(self, context, subport, ovn_txn):"},{"line_number":90,"context_line":"        LOG.debug(\"Unsetting parent for subport %s\", subport.port_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_49c68c6a","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":33},"in_reply_to":"3fa7e38b_2ef4765a","updated":"2019-11-01 14:16:15.000000000","message":"Done","commit_id":"5d20ee13406b53a0d0da06dd6c26105bbe698a93"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4607b57598dd06af01db556f1fc6e31b7a748875","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    parent_name\u003d[],"},{"line_number":119,"context_line":"                    up\u003dFalse,"},{"line_number":120,"context_line":"                    tag\u003d[]))"},{"line_number":121,"context_line":"        LOG.debug(\"Unsetting DONE\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def trunk_created(self, trunk):"},{"line_number":124,"context_line":"        if trunk.sub_ports:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_aeff0632","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":35},"updated":"2019-11-01 13:46:09.000000000","message":"ditto: add the IDs","commit_id":"5d20ee13406b53a0d0da06dd6c26105bbe698a93"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"64cc641d12ff43ed9faaf4370be1770f6b3ce54d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    parent_name\u003d[],"},{"line_number":119,"context_line":"                    up\u003dFalse,"},{"line_number":120,"context_line":"                    tag\u003d[]))"},{"line_number":121,"context_line":"        LOG.debug(\"Unsetting DONE\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def trunk_created(self, trunk):"},{"line_number":124,"context_line":"        if trunk.sub_ports:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_c9a7dcbb","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":35},"in_reply_to":"3fa7e38b_aeff0632","updated":"2019-11-01 14:16:15.000000000","message":"Very good point! Done.","commit_id":"5d20ee13406b53a0d0da06dd6c26105bbe698a93"}]}