)]}'
{"networking_ovn/ml2/trunk_driver.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"f07a977698dc29f43a3ad39105c452f744544b40","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                break"},{"line_number":52,"context_line":"            except sql_exc.StaleDataError as e:"},{"line_number":53,"context_line":"                if try_cnt \u003c tries - 1:"},{"line_number":54,"context_line":"                    LOG.debug(\"Got StaleDataError exception %s\", e)"},{"line_number":55,"context_line":"                    continue"},{"line_number":56,"context_line":"                else:"},{"line_number":57,"context_line":"                    # re-raise when all tries failed"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5fde0c3f","line":54,"updated":"2019-11-06 08:52:44.000000000","message":"Shall we have a LP bug to proper fix the StaleDataError?\nLooks to me that we\u0027re trying to mitigate or hide the actual issue?","commit_id":"27a8f17cfa1e1a2ea9ae77f9439f320a12fd3929"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"f07a977698dc29f43a3ad39105c452f744544b40","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                self._set_binding_profile(context, port, parent_port, ovn_txn)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _unset_sub_ports(self, subports):"},{"line_number":69,"context_line":"        tries \u003d 10"},{"line_number":70,"context_line":"        for try_cnt in range(tries):"},{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                self._unset_sub_ports_try(subports)"},{"line_number":73,"context_line":"                break"},{"line_number":74,"context_line":"            except sql_exc.StaleDataError as e:"},{"line_number":75,"context_line":"                if try_cnt \u003c tries - 1:"},{"line_number":76,"context_line":"                    LOG.debug(\"Got StaleDataError exception %s\", e)"},{"line_number":77,"context_line":"                    continue"},{"line_number":78,"context_line":"                else:"},{"line_number":79,"context_line":"                    # re-raise when all tries failed"},{"line_number":80,"context_line":"                    raise"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _unset_sub_ports_try(self, subports):"},{"line_number":83,"context_line":"        txn \u003d self.plugin_driver._nb_ovn.transaction"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9fd48421","line":80,"range":{"start_line":69,"start_character":0,"end_line":80,"end_character":25},"updated":"2019-11-06 08:52:44.000000000","message":"This has a lot of dup code from L47 - L58, I\u0027d suggest to wrap it in a method that receives _unset_sub_ports_try / _set_sub_ports_try","commit_id":"27a8f17cfa1e1a2ea9ae77f9439f320a12fd3929"}]}
