)]}'
{"networking_ovn/ml2/trunk_driver.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"891a0c7ed3e02ec7d00d4d5fa0f9e87c81f51df7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      subport.port_id)"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            # Note: We expect binding\u0027s host to be set upon creation and it"},{"line_number":71,"context_line":"            # is to remain unchanged. That is used as primary key in the ml2"},{"line_number":72,"context_line":"            # binding table. Otherwise, sub-port will not transition from"},{"line_number":73,"context_line":"            # DOWN to ACTIVE."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_54675ceb","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":18},"updated":"2019-12-05 10:07:05.000000000","message":"nit: NOTE(flaviof):","commit_id":"f08caa9f323c6f1a94a1c152e2c7336eb5612520"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"1c98658dec8babdfcb6a18f8d7734e7afcdd32b6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      subport.port_id)"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            # Note: We expect binding\u0027s host to be set upon creation and it"},{"line_number":71,"context_line":"            # is to remain unchanged. That is used as primary key in the ml2"},{"line_number":72,"context_line":"            # binding table. Otherwise, sub-port will not transition from"},{"line_number":73,"context_line":"            # DOWN to ACTIVE."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_81701b0b","line":70,"range":{"start_line":70,"start_character":14,"end_line":70,"end_character":18},"in_reply_to":"3fa7e38b_54675ceb","updated":"2019-12-06 20:08:54.000000000","message":"Done","commit_id":"f08caa9f323c6f1a94a1c152e2c7336eb5612520"}],"networking_ovn/tests/unit/ml2/test_trunk_driver.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e1ddf9a198c9b39002c2d554dd08530663eeae1b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            port \u003d Port()"},{"line_number":93,"context_line":"            port.id \u003d port_id"},{"line_number":94,"context_line":"            port.bindings \u003d [PortBinding(profile\u003d{}, host\u003d\u0027foo.com\u0027)]"},{"line_number":95,"context_line":"            port.update \u003d mock.Mock()"},{"line_number":96,"context_line":"        return port"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _assert_calls(self, mock, expected_calls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_f798ad1a","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":37},"updated":"2019-12-06 22:33:44.000000000","message":"Help needed!\n\nw/out this mock, I get the following error:\n\n...\n    b\u0027  File \"/opt/stack/networking-ovn/networking_ovn/ml2/trunk_driver.py\", line 105, in _unset_binding_profile\u0027\n    b\u0027    db_port.update()\u0027\n    b\u0027  File \"/opt/stack/networking-ovn/.tox/py36/lib/python3.6/site-packages/neutron/objects/base.py\", line 336, in decorator\u0027\n    b\u0027    with self.db_context_writer(self.obj_context):\u0027\n    b\u0027  File \"/opt/stack/networking-ovn/.tox/py36/lib/python3.6/site-packages/neutron/objects/base.py\", line 576, in db_context_writer\u0027\n    b\u0027    if cls.new_facade or cls._use_db_facade(context):\u0027\n    b\u0027  File \"/opt/stack/networking-ovn/.tox/py36/lib/python3.6/site-packages/neutron/objects/base.py\", line 568, in _use_db_facade\u0027\n    b\u0027    enginefacade._transaction_ctx_for_context(context)\u0027\n    b\u0027  File \"/opt/stack/networking-ovn/.tox/py36/lib/python3.6/site-packages/oslo_db/sqlalchemy/enginefacade.py\", line 1111, in _transaction_ctx_for_context\u0027\n    b\u0027    by_thread \u003d _transaction_contexts_by_thread(context)\u0027\n    b\u0027  File \"/opt/stack/networking-ovn/.tox/py36/lib/python3.6/site-packages/oslo_db/sqlalchemy/enginefacade.py\", line 1127, in _transaction_contexts_by_thread\u0027\n    b\u0027    context._enginefacade_context \u003d _TransactionContextTLocal()\u0027\n    b\"AttributeError: \u0027NoneType\u0027 object has no attribute \u0027_enginefacade_context\u0027\"","commit_id":"1249dc8f5b30fbf1cd3f41b1da08ae364e6a95ec"}]}
