)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2951fb336945a533c930fea7a3682cfccb95193e","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":607,"context_line":"                ls_name \u003d ovn_utils.ovn_name(subnet.network_id)"},{"line_number":608,"context_line":"            except n_exc.NotFound:"},{"line_number":609,"context_line":"                LOG.exception(\u0027Subnet not found while trying to \u0027"},{"line_number":610,"context_line":"                              \u0027fetch its data.\u0027)"},{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3754d7fc","line":609,"updated":"2020-01-08 08:27:22.000000000","message":"maybe logging the subnet_id would be handy. Also do we need a full trace here?","commit_id":"23a2e3e3a0cdb5a44c010cef87b3872197ceea62"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"514510da7922a84054a9de256039a8b4f77f7d48","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":607,"context_line":"                ls_name \u003d ovn_utils.ovn_name(subnet.network_id)"},{"line_number":608,"context_line":"            except n_exc.NotFound:"},{"line_number":609,"context_line":"                LOG.exception(\u0027Subnet not found while trying to \u0027"},{"line_number":610,"context_line":"                              \u0027fetch its data.\u0027)"},{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_974eeb36","line":609,"in_reply_to":"3fa7e38b_3754d7fc","updated":"2020-01-08 08:51:17.000000000","message":"Ok, good one!","commit_id":"23a2e3e3a0cdb5a44c010cef87b3872197ceea62"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2951fb336945a533c930fea7a3682cfccb95193e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if ls_name:"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":617,"context_line":"                    check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_376db7ca","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":19},"updated":"2020-01-08 08:27:22.000000000","message":"nit: you can use try-except-else here","commit_id":"23a2e3e3a0cdb5a44c010cef87b3872197ceea62"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"12dbb2766a622d188334c718881d81f5f5c9fc78","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if ls_name:"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":617,"context_line":"                    check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5704f37d","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":19},"in_reply_to":"3fa7e38b_17543bc5","updated":"2020-01-08 08:53:28.000000000","message":"ah, I see. You\u0027re right, sorry.","commit_id":"23a2e3e3a0cdb5a44c010cef87b3872197ceea62"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"514510da7922a84054a9de256039a8b4f77f7d48","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if ls_name:"},{"line_number":615,"context_line":"            try:"},{"line_number":616,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":617,"context_line":"                    check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_17543bc5","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":19},"in_reply_to":"3fa7e38b_376db7ca","updated":"2020-01-08 08:51:17.000000000","message":"Hum, not in those terms.\n\nIf network_id is passed the ls_name is get from network_id, else we\u0027re calling network_driver.\n\nSo if network_id will be passed and I\u0027ll move it to try-except-else block the L616 will not be executed, but we need it.\n\nI think I can leave it as it is now.","commit_id":"23a2e3e3a0cdb5a44c010cef87b3872197ceea62"}]}