)]}'
{"networking_ovn/tests/unit/common/test_hash_ring_manager.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e4ee6169542624c65d3498e56e8dd2d379c6c36","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         list(self.hash_ring_manager._hash_ring.nodes.keys()))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Now only \"another_host_node\" is alive, all values should hash to it"},{"line_number":92,"context_line":"        # FIXME(flaviof): waitign for Lucas\u0027 input on this test. It looks to me that"},{"line_number":93,"context_line":"        # the keys and the values should have been reversed here..."},{"line_number":94,"context_line":"        # hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,"},{"line_number":95,"context_line":"        #                              another_host_node: \u0027fake-uuid-0\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e78e5c79","line":92,"updated":"2019-12-13 21:07:12.000000000","message":"\u003e79 chars, found by our trusty flake8 :)","commit_id":"ccb36d05ce15fd78f4ca67b4c68c3cf6bcf4457c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7a08632f0a75e331507b1b67e1e77ab7a476dfa6","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Now only \"another_host_node\" is alive, all values should hash to it"},{"line_number":92,"context_line":"        # FIXME(flaviof): waiting for Lucas\u0027 input on this test. It looks to me"},{"line_number":93,"context_line":"        # that the keys and the values should have been reversed here."},{"line_number":94,"context_line":"        # hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,"},{"line_number":95,"context_line":"        #                              another_host_node: \u0027fake-uuid-0\u0027,"},{"line_number":96,"context_line":"        #                              another_host_node: \u0027fake-uuid-ABCDE\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_156e33fe","line":93,"updated":"2019-12-16 09:48:42.000000000","message":"True, but I think the problem is the _verify_hashes().... Perhaps we should use a list/tuple instead of a dict (cause we can\u0027t have duplicated keys here).\n\nWe need to check if all UUIDs (values) are hashing to the expected nodes (keys).","commit_id":"1ba7c5f3b5a64db92a603d232b233c8067216464"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ead591628c3d49b5583e711903db483ff2880af1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def _verify_hashes_from_tuples(self, hash_tuples):"},{"line_number":43,"context_line":"        for target_node, uuid_ in hash_tuples:"},{"line_number":44,"context_line":"            self.assertEqual(target_node,"},{"line_number":45,"context_line":"                             self.hash_ring_manager.get_node(uuid_))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_get_node(self):"},{"line_number":48,"context_line":"        # Use pre-defined UUIDs to make the hashes predictable"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_10fba148","line":45,"updated":"2019-12-16 10:40:06.000000000","message":"It will be confusing to have two helper methods that basically does the same work IMHO. The use of duplicated keys in the expected dictionary is a programmatic error (my bad), we should fix it.\n\nSince it\u0027s a helper method in a testing class (private one too) I don\u0027t think we will break anything else by updating it.\n\nE.g. See the \"for\" statement has been updated:\n\n    def _verify_hashes(self, hash_dict):\n        for uuid_, target_node in hash_dict.items():\n            self.assertEqual(target_node,\n                           self.hash_ring_manager.get_node(uuid_))\n\nNow we need to change the argument passed to this method where it\u0027s invoked.\n\nWhat do u think ?","commit_id":"f846d8b83c0e698baa26f44cf854119fa65c9f82"}]}