)]}'
{"id":"openstack%2Fnetworking-ovn~699014","triplet_id":"openstack%2Fnetworking-ovn~stable%2Ftrain~If465a957a5b339ed8d1fc68b3e2ceb362cf20277","project":"openstack/networking-ovn","branch":"stable/train","topic":"hacking2.0.0_upgrade","hashtags":[],"change_id":"If465a957a5b339ed8d1fc68b3e2ceb362cf20277","subject":"Fix pep8 errors found by hacking 2.0.0","status":"ABANDONED","created":"2019-12-13 20:30:59.000000000","updated":"2019-12-16 11:29:20.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a9e11196faec0a0835d0b71d3517fb04d81306a8","_number":699014,"virtual_id_number":699014,"owner":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2019-12-16 11:18:36.000000000","_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-13 21:07:12.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2019-12-14 01:21:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-16 10:40:06.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2019-12-16 11:18:36.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"}],"messages":[{"id":"e2155c172406c704a6131390220f41585576cca2","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 20:30:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bdc108d978fdc9c10042b35d030209c16637644","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 20:36:50.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"4ffed99092553cd372b9f4aaf8908d4f7f61ad52","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 20:51:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"188f8769e28fd43ce75540b87de5731608aad6ae","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 20:53:27.000000000","message":"Topic set to hacking2.0.0_upgrade","accounts_in_message":[],"_revision_number":3},{"id":"5e4ee6169542624c65d3498e56e8dd2d379c6c36","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2019-12-13 21:07:12.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"eae7b2de912753e35a452439f68397e029927379","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 21:12:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2781b1104f7f02dba92a8998301d0acea49e1b40","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-13 22:37:52.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"55b490865f5a208a833440e163d34e3aa8d308df","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-14 01:21:17.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/baa7da614d6047b98641264c9379bac6 : SUCCESS in 4m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/025a7c594bd648da8d03c4517a539a68 : SUCCESS in 8m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cb60225325b460ba3ea7e015a998eb1 : SUCCESS in 6m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7a059e5caec64804819c6fe9cb4e52ea : SUCCESS in 10m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/74c4b78c95bf4d43beb5e1fcdbaa8ffd : SUCCESS in 9m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cafe41501e424d5f92f2ba10d51f4d78 : SUCCESS in 12m 13s\n- networking-ovn-tempest-dsvm-ovs-master https://zuul.opendev.org/t/openstack/build/2b489a7dd6b045b88b2d8436f2e96293 : SUCCESS in 2h 10m 51s (non-voting)\n- networking-ovn-tempest-dsvm-ovs-release https://zuul.opendev.org/t/openstack/build/b5c39f2a766c481284ba909587d418a9 : SUCCESS in 2h 20m 56s\n- networking-ovn-tempest-dsvm-ovs-release-python2 https://zuul.opendev.org/t/openstack/build/413aba706df4490fbc600588e56c2faf : SUCCESS in 2h 09m 07s\n- networking-ovn-rally-task https://zuul.opendev.org/t/openstack/build/304f35936a3b470cb50c6a1f3251ba40 : TIMED_OUT in 2h 14m 58s\n- networking-ovn-dsvm-functional-py27 https://zuul.opendev.org/t/openstack/build/d2ee403ae7a949a0aa4ee79f2fa832c4 : FAILURE in 14m 57s\n- networking-ovn-dsvm-functional https://zuul.opendev.org/t/openstack/build/6e42c7a05f1c41369da2261d887c711f : FAILURE in 15m 54s\n- networking-ovn-tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/a220013097c645a0a05b72799d98e2a5 : SUCCESS in 2h 38m 30s\n- networking-ovn-dsvm-grenade https://zuul.opendev.org/t/openstack/build/628f9f82e169493e9ea6a1f5552727a1 : FAILURE in 2h 13m 47s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/27e0220244364255a04e930497ac227a : SUCCESS in 9m 27s\n- networking-ovn-tempest-slow https://zuul.opendev.org/t/openstack/build/d24b93f686de4b24ab356d3da6570e23 : FAILURE in 2h 16m 39s (non-voting)\n- networking-ovn-tempest-full-multinode-ovs-master https://zuul.opendev.org/t/openstack/build/a8a4b55c02a049d0a2ab7f044d122a79 : SUCCESS in 2h 10m 28s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"7a08632f0a75e331507b1b67e1e77ab7a476dfa6","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2019-12-16 09:48:42.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"fd818c5e08ea48cb76dac3156b6d0222d04d5a32","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-16 10:30:37.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ead591628c3d49b5583e711903db483ff2880af1","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2019-12-16 10:40:06.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"7d229eff96139c594b9200211c22569e8d996f02","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-16 10:40:33.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f46ed214958d1ffaf29556769cbe32c2cf6108a8","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-16 11:16:35.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"e7a34f1835cd3347c9a171e1aace318e86174f99","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-16 11:17:24.000000000","message":"Uploaded patch set 9: Commit message was updated.","accounts_in_message":[],"_revision_number":9},{"id":"a9e11196faec0a0835d0b71d3517fb04d81306a8","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2019-12-16 11:29:20.000000000","message":"Abandoned\n\nnow part of https://review.opendev.org/699192","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"807c0a04640b9bf8d873c663f73679753dd875e7","revisions":{"b00c4e750d16c66174e0629de38e940f38034ce1":{"kind":"REWORK","_number":1,"created":"2019-12-13 20:30:59.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/1"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:30:19.000000000","tz":-300},"subject":"pep8: fix issues found by new version of hacking","message":"pep8: fix issues found by new version of hacking\n\nFix the following issues that are now exposed by hacking verion 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/b00c4e750d16c66174e0629de38e940f38034ce1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/b00c4e750d16c66174e0629de38e940f38034ce1"}]},"branch":"refs/heads/stable/train"},"97edb8a1f4e4c7827505b4caf5f1e11c24138c95":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-12-13 20:36:50.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/2"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:36:32.000000000","tz":-300},"subject":"pep8: fix issues found by new version of hacking","message":"pep8: fix issues found by new version of hacking\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/97edb8a1f4e4c7827505b4caf5f1e11c24138c95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/97edb8a1f4e4c7827505b4caf5f1e11c24138c95"}]},"branch":"refs/heads/stable/train"},"ccb36d05ce15fd78f4ca67b4c68c3cf6bcf4457c":{"kind":"REWORK","_number":3,"created":"2019-12-13 20:51:48.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/3"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:50:42.000000000","tz":-300},"subject":"DNM: pep8: fix issues found by new version of hacking","message":"DNM: pep8: fix issues found by new version of hacking\n\nFIXME: Need input from Lucas to determine what we should have the\ntest test_hash_ring_manager really do.\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/ccb36d05ce15fd78f4ca67b4c68c3cf6bcf4457c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/ccb36d05ce15fd78f4ca67b4c68c3cf6bcf4457c"}]},"branch":"refs/heads/stable/train"},"66037f04d24c5cbab8be34954a2f55dc580555d3":{"kind":"REWORK","_number":4,"created":"2019-12-13 21:12:51.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/4"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 21:11:46.000000000","tz":-300},"subject":"DNM: pep8: fix issues found by new version of hacking","message":"DNM: pep8: fix issues found by new version of hacking\n\nFIXME: Need input from Lucas to determine what we should have the\ntest test_hash_ring_manager really do.\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/66037f04d24c5cbab8be34954a2f55dc580555d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/66037f04d24c5cbab8be34954a2f55dc580555d3"}]},"branch":"refs/heads/stable/train"},"1ba7c5f3b5a64db92a603d232b233c8067216464":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2019-12-13 22:37:52.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/5"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 22:37:11.000000000","tz":-300},"subject":"DNM: Fix pep8 errors found by hacking 2.0.0","message":"DNM: Fix pep8 errors found by hacking 2.0.0\n\nFIXME: Need input from Lucas to determine what we should have the\ntest test_hash_ring_manager really do.\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/1ba7c5f3b5a64db92a603d232b233c8067216464"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/1ba7c5f3b5a64db92a603d232b233c8067216464"}]},"branch":"refs/heads/stable/train"},"f846d8b83c0e698baa26f44cf854119fa65c9f82":{"kind":"REWORK","_number":6,"created":"2019-12-16 10:30:37.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/6"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-16 10:30:00.000000000","tz":-300},"subject":"Fix pep8 errors found by hacking 2.0.0","message":"Fix pep8 errors found by hacking 2.0.0\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\nCo-authored-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/f846d8b83c0e698baa26f44cf854119fa65c9f82"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/f846d8b83c0e698baa26f44cf854119fa65c9f82"}]},"branch":"refs/heads/stable/train"},"9ce4e0dc408de78d824985db522da17d0f89ee34":{"kind":"REWORK","_number":7,"created":"2019-12-16 10:40:33.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/7"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-16 10:40:27.000000000","tz":-300},"subject":"Fix pep8 errors found by hacking 2.0.0","message":"Fix pep8 errors found by hacking 2.0.0\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\nCo-authored-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/9ce4e0dc408de78d824985db522da17d0f89ee34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/9ce4e0dc408de78d824985db522da17d0f89ee34"}]},"branch":"refs/heads/stable/train"},"9fc3900e66cdb726b98ebadd11bb5ddb71e98a7f":{"kind":"REWORK","_number":8,"created":"2019-12-16 11:16:35.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/8"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-16 11:16:30.000000000","tz":-300},"subject":"Fix pep8 errors found by hacking 2.0.0","message":"Fix pep8 errors found by hacking 2.0.0\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\nCo-authored-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/9fc3900e66cdb726b98ebadd11bb5ddb71e98a7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/9fc3900e66cdb726b98ebadd11bb5ddb71e98a7f"}]},"branch":"refs/heads/stable/train"},"807c0a04640b9bf8d873c663f73679753dd875e7":{"kind":"NO_CODE_CHANGE","_number":9,"created":"2019-12-16 11:17:24.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/14/699014/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-ovn","ref":"refs/changes/14/699014/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-ovn refs/changes/14/699014/9"}}},"commit":{"parents":[{"commit":"0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0","subject":"tox: Pass OVN and OVS source directories","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/0d603a7e105d2cbe8ca21a1ee752e1f3c81879e0"}]}],"author":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-13 20:26:37.000000000","tz":-300},"committer":{"name":"Flavio Fernandes","email":"flaviof@redhat.com","date":"2019-12-16 11:17:08.000000000","tz":-300},"subject":"Fix pep8 errors found by hacking 2.0.0","message":"Fix pep8 errors found by hacking 2.0.0\n\nFix the following issues that are now exposed by hacking version 2.0.0\n\n./networking_ovn/tests/unit/common/test_hash_ring_manager.py:92:38:\nF602 dictionary key variable another_host_node repeated with different\nvalues\n hash_dict_after_rebalance \u003d {another_host_node: \u0027fake-uuid\u0027,\n\n./networking_ovn/ovsdb/ovsdb_monitor.py:359:13: F841 local variable\n\u0027e\u0027 is assigned to but never used\n\nChange-Id: If465a957a5b339ed8d1fc68b3e2ceb362cf20277\nSigned-off-by: Flavio Fernandes \u003cflaviof@redhat.com\u003e\nCo-authored-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e\nCo-authored-by: Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/807c0a04640b9bf8d873c663f73679753dd875e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-ovn/commit/807c0a04640b9bf8d873c663f73679753dd875e7"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
