)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"63485c35dd1783cac051872fd6142b5b4fbe63f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"multiple rows should be done."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I259c92116f7d3186ae5af45f1407052eb57ac0ba"},{"line_number":17,"context_line":"Related-bug: #1857016"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_8565b2e4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"updated":"2019-12-23 14:43:09.000000000","message":"Why not Closes-Bug?","commit_id":"9584a951c32d3f620ffb0cb0d5910fe528cf3a90"}],"networking_ovn/ovsdb/commands.py":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"09dbd1fb5611003646da3c9197c73b03e993db3c","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                for acl_del_obj in acl_del_objs:"},{"line_number":631,"context_line":"                    try:"},{"line_number":632,"context_line":"                        acl_del_obj.delete()"},{"line_number":633,"context_line":"                    except AssertionError:"},{"line_number":634,"context_line":"                        # If we try to delete a row twice, just continue"},{"line_number":635,"context_line":"                        pass"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6d267bbc","line":633,"range":{"start_line":633,"start_character":27,"end_line":633,"end_character":41},"updated":"2019-12-19 18:53:11.000000000","message":"Is this the most specific we can be about the exception we will get on a double delete situation? If so, lgtm.","commit_id":"9584a951c32d3f620ffb0cb0d5910fe528cf3a90"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"79d7e4bfc161004fd3a56033131052a0ab95ff56","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                for acl_del_obj in acl_del_objs:"},{"line_number":631,"context_line":"                    try:"},{"line_number":632,"context_line":"                        acl_del_obj.delete()"},{"line_number":633,"context_line":"                    except AssertionError:"},{"line_number":634,"context_line":"                        # If we try to delete a row twice, just continue"},{"line_number":635,"context_line":"                        pass"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b8b58f1b","line":633,"range":{"start_line":633,"start_character":27,"end_line":633,"end_character":41},"in_reply_to":"3fa7e38b_6d267bbc","updated":"2019-12-19 20:16:52.000000000","message":"I think so, it references this: https://github.com/openvswitch/ovs/blob/24e6970809483d256c38cfd029ae9469b0d3e961/python/ovs/db/idl.py#L1217\n\nThere are two assertions, but it should be impossible to hit the other one inside a Command \u0027s run_idl() (without literally *nothing* working).","commit_id":"9584a951c32d3f620ffb0cb0d5910fe528cf3a90"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"63485c35dd1783cac051872fd6142b5b4fbe63f2","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                        acl_del_obj.delete()"},{"line_number":633,"context_line":"                    except AssertionError:"},{"line_number":634,"context_line":"                        # If we try to delete a row twice, just continue"},{"line_number":635,"context_line":"                        pass"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"            # Add new ACLs."},{"line_number":638,"context_line":"            acl_add_objs \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e56ee6c6","line":635,"updated":"2019-12-23 14:43:09.000000000","message":"Should we add a log line (maybe on a level that\u0027s logged by default) about the double delete? Based on the bug report it seems to me we don\u0027t fully understand what conditions lead to the double delete. If we make the double delete silent we will likely never get to understand the root cause.","commit_id":"9584a951c32d3f620ffb0cb0d5910fe528cf3a90"}]}