)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cffe3ba98ae5e5742de835cad85347385af495d","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":607,"context_line":"                ls_name \u003d ovn_utils.ovn_name(subnet.network_id)"},{"line_number":608,"context_line":"            except n_exc.NotFound:"},{"line_number":609,"context_line":"                LOG.exception(\u0027Subnet %s not found while trying to \u0027"},{"line_number":610,"context_line":"                              \u0027fetch its data.\u0027, subnet_id)"},{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6ea53548","line":609,"range":{"start_line":609,"start_character":16,"end_line":609,"end_character":29},"updated":"2020-01-15 11:15:19.000000000","message":"I wonder if a warning would be more appropriated here since we this is \"expected\". I mean, if the subnet does not exist it\u0027s not really an error/failure right ?","commit_id":"a688ed33ec204dd1923b181fc0577d56bafea893"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"550ba5354519d22c62125c438f6c1046040a5511","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":607,"context_line":"                ls_name \u003d ovn_utils.ovn_name(subnet.network_id)"},{"line_number":608,"context_line":"            except n_exc.NotFound:"},{"line_number":609,"context_line":"                LOG.exception(\u0027Subnet %s not found while trying to \u0027"},{"line_number":610,"context_line":"                              \u0027fetch its data.\u0027, subnet_id)"},{"line_number":611,"context_line":"                ls_name \u003d None"},{"line_number":612,"context_line":"                ovn_ls \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f41b326c","line":609,"range":{"start_line":609,"start_character":16,"end_line":609,"end_character":29},"in_reply_to":"3fa7e38b_6ea53548","updated":"2020-01-15 13:16:21.000000000","message":"In those terms you\u0027re right. This could be just warning.","commit_id":"a688ed33ec204dd1923b181fc0577d56bafea893"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cffe3ba98ae5e5742de835cad85347385af495d","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":617,"context_line":"                    check_error\u003dTrue)"},{"line_number":618,"context_line":"            except idlutils.RowNotFound:"},{"line_number":619,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found. \","},{"line_number":620,"context_line":"                            ls_name)"},{"line_number":621,"context_line":"                if associate:"},{"line_number":622,"context_line":"                    LOG.warning(\u0027Cannot associate LB %(lb)s to \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0e9e0106","line":619,"range":{"start_line":619,"start_character":64,"end_line":619,"end_character":66},"updated":"2020-01-15 11:15:19.000000000","message":"super nit: extra space","commit_id":"a688ed33ec204dd1923b181fc0577d56bafea893"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"550ba5354519d22c62125c438f6c1046040a5511","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":617,"context_line":"                    check_error\u003dTrue)"},{"line_number":618,"context_line":"            except idlutils.RowNotFound:"},{"line_number":619,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found. \","},{"line_number":620,"context_line":"                            ls_name)"},{"line_number":621,"context_line":"                if associate:"},{"line_number":622,"context_line":"                    LOG.warning(\u0027Cannot associate LB %(lb)s to \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_14212e9f","line":619,"range":{"start_line":619,"start_character":64,"end_line":619,"end_character":66},"in_reply_to":"3fa7e38b_0e9e0106","updated":"2020-01-15 13:16:21.000000000","message":"done","commit_id":"a688ed33ec204dd1923b181fc0577d56bafea893"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cffe3ba98ae5e5742de835cad85347385af495d","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"                )"},{"line_number":1049,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1050,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found. Cannot \""},{"line_number":1051,"context_line":"                            \"delete LB from it\", ls_name)"},{"line_number":1052,"context_line":"        # Delete LB from all Networks the LB is indirectly associated"},{"line_number":1053,"context_line":"        for ls in self._find_lb_in_table(ovn_lb, \u0027Logical_Switch\u0027):"},{"line_number":1054,"context_line":"            commands.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ee3fe5dc","line":1051,"range":{"start_line":1051,"start_character":36,"end_line":1051,"end_character":38},"updated":"2020-01-15 11:15:19.000000000","message":"nit: Load Balancer\n\nSince other resources are not using acronyms","commit_id":"a688ed33ec204dd1923b181fc0577d56bafea893"}]}