)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"abf27eba1c29a1f5eaa915dbd3bd589b52aaaa9d","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"                                   \"provisioning_status\": constants.ERROR,"},{"line_number":1016,"context_line":"                                   \"operating_status\": constants.ERROR}]}"},{"line_number":1017,"context_line":"        # Delete VIP port from neutron."},{"line_number":1018,"context_line":"        self.delete_vip_port(port_id)"},{"line_number":1019,"context_line":"        return status"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"    def _lb_delete(self, loadbalancer, ovn_lb, status):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b667d452","line":1018,"updated":"2020-01-17 20:02:28.000000000","message":"There\u0027s a test for this exception that will need a slight refactor","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b7c04a8f650439305a8bbd84bbc7070b0310946c","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"            \u0027_\u0027)[2]) for meminf in existing_members.split(\u0027,\u0027)]"},{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"    def create_vip_port(self, project_id, lb_id, vip_d):"},{"line_number":1744,"context_line":"        network_driver \u003d get_network_driver()"},{"line_number":1745,"context_line":"        port \u003d {\u0027port\u0027: {\u0027name\u0027: ovn_const.LB_VIP_PORT_PREFIX + str(lb_id),"},{"line_number":1746,"context_line":"                         \u0027network_id\u0027: vip_d[\u0027vip_network_id\u0027],"},{"line_number":1747,"context_line":"                         \u0027fixed_ips\u0027: [{\u0027subnet_id\u0027: vip_d[\u0027vip_subnet_id\u0027]}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4f6a8cec","line":1744,"updated":"2020-01-17 15:56:49.000000000","message":"nit: could have stayed below","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85d23e17cb9ed50a1ea691cd6bb44a12217e9cfd","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"            \u0027_\u0027)[2]) for meminf in existing_members.split(\u0027,\u0027)]"},{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"    def create_vip_port(self, project_id, lb_id, vip_d):"},{"line_number":1744,"context_line":"        network_driver \u003d get_network_driver()"},{"line_number":1745,"context_line":"        port \u003d {\u0027port\u0027: {\u0027name\u0027: ovn_const.LB_VIP_PORT_PREFIX + str(lb_id),"},{"line_number":1746,"context_line":"                         \u0027network_id\u0027: vip_d[\u0027vip_network_id\u0027],"},{"line_number":1747,"context_line":"                         \u0027fixed_ips\u0027: [{\u0027subnet_id\u0027: vip_d[\u0027vip_subnet_id\u0027]}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8a9872cb","line":1744,"in_reply_to":"3fa7e38b_4f6a8cec","updated":"2020-01-17 16:00:45.000000000","message":"yes","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b7c04a8f650439305a8bbd84bbc7070b0310946c","unresolved":false,"context_lines":[{"line_number":1758,"context_line":"            # Sometimes the VIP is already created (race-conditions)"},{"line_number":1759,"context_line":"            # Lets get the it from Neutron API."},{"line_number":1760,"context_line":"            port \u003d network_driver.neutron_client.list_ports("},{"line_number":1761,"context_line":"                name\u003d\u0027%s%s\u0027 % (ovn_const.LB_VIP_PORT_PREFIX, lb_id))"},{"line_number":1762,"context_line":"            if not port[\u0027ports\u0027]:"},{"line_number":1763,"context_line":"                LOG.error(\u0027Cannot create/get LoadBalancer VIP port with \u0027"},{"line_number":1764,"context_line":"                          \u0027fixed IP: %s\u0027, vip_d[\u0027vip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_aa2f6e87","line":1761,"updated":"2020-01-17 15:56:49.000000000","message":"I wonder if name is enough, or if it could return many ports?  We can always add network and fixed_ip, we have that info above.","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85d23e17cb9ed50a1ea691cd6bb44a12217e9cfd","unresolved":false,"context_lines":[{"line_number":1758,"context_line":"            # Sometimes the VIP is already created (race-conditions)"},{"line_number":1759,"context_line":"            # Lets get the it from Neutron API."},{"line_number":1760,"context_line":"            port \u003d network_driver.neutron_client.list_ports("},{"line_number":1761,"context_line":"                name\u003d\u0027%s%s\u0027 % (ovn_const.LB_VIP_PORT_PREFIX, lb_id))"},{"line_number":1762,"context_line":"            if not port[\u0027ports\u0027]:"},{"line_number":1763,"context_line":"                LOG.error(\u0027Cannot create/get LoadBalancer VIP port with \u0027"},{"line_number":1764,"context_line":"                          \u0027fixed IP: %s\u0027, vip_d[\u0027vip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2a9ffeb3","line":1761,"in_reply_to":"3fa7e38b_aa2f6e87","updated":"2020-01-17 16:00:45.000000000","message":"Yes. There is a possibility of it, but the name itself should be unique. (its prefix and uuid of lb).","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b7c04a8f650439305a8bbd84bbc7070b0310946c","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                    \"operating_status\": constants.ERROR}]}"},{"line_number":1769,"context_line":"                self._update_status_to_octavia(status)"},{"line_number":1770,"context_line":"                return"},{"line_number":1771,"context_line":"            LOG.debug(\u0027VIP Port already exist, uuid: %s\u0027,"},{"line_number":1772,"context_line":"                      port[\u0027ports\u0027][0][\u0027id\u0027])"},{"line_number":1773,"context_line":"            return {\u0027port\u0027: port[\u0027ports\u0027][0]}"},{"line_number":1774,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0f1a547f","line":1771,"range":{"start_line":1771,"start_character":40,"end_line":1771,"end_character":45},"updated":"2020-01-17 15:56:49.000000000","message":"nit: exists","commit_id":"3685e67879e5211f1cb1eba87f6aed6311a904a6"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a7634936c3086a2dc5f739cc410a28829d1011b4","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"            return network_driver.neutron_client.create_port(port)"},{"line_number":1756,"context_line":"        except n_exc.IpAddressAlreadyAllocatedClient:"},{"line_number":1757,"context_line":"            # Sometimes the VIP is already created (race-conditions)"},{"line_number":1758,"context_line":"            # Lets get the it from Neutron API."},{"line_number":1759,"context_line":"            ports \u003d network_driver.neutron_client.list_ports("},{"line_number":1760,"context_line":"                network_id\u003dvip_d[\u0027vip_network_id\u0027],"},{"line_number":1761,"context_line":"                name\u003d\u0027%s%s\u0027 % (ovn_const.LB_VIP_PORT_PREFIX, lb_id))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_8e7918fc","line":1758,"range":{"start_line":1758,"start_character":14,"end_line":1758,"end_character":29},"updated":"2020-01-23 13:29:38.000000000","message":"Nit: Let\u0027s get it (or simply \"Get it\")","commit_id":"ed7adedeed9e6567e1ac680796a9b3553adae8f3"}]}