)]}'
{"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e47ee0a646d3df52b47d8b3a31cabc6dab719b7","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            if (port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DHCP and"},{"line_number":255,"context_line":"                    not utils.is_neutron_dhcp_agent_port(port)):"},{"line_number":256,"context_line":"                port_type \u003d \u0027localport\u0027"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                port_type \u003d ovn_const.OVN_NEUTRON_OWNER_TO_PORT_TYPE.get("},{"line_number":259,"context_line":"                    port[\u0027device_owner\u0027], \u0027\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # The \"unknown\" address should only be set for the normal LSP"},{"line_number":262,"context_line":"            # ports (the ones which type is empty)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_7a1ee20c","line":259,"range":{"start_line":257,"start_character":12,"end_line":259,"end_character":45},"updated":"2020-04-22 21:42:34.000000000","message":"These lines are causing the test failure, and they\u0027re not in Rocky, looks like possibly a bad cherry-pick in https://review.opendev.org/#/c/703195/\n\nThink the fix would be to just make these modifications.","commit_id":"6fe5581ff9f3d5e093bfca85295dca8f5721d490"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e47ee0a646d3df52b47d8b3a31cabc6dab719b7","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            # The \"unknown\" address should only be set for the normal LSP"},{"line_number":262,"context_line":"            # ports (the ones which type is empty)"},{"line_number":263,"context_line":"            if not port_security:"},{"line_number":264,"context_line":"                # Port security is disabled for this port."},{"line_number":265,"context_line":"                # So this port can send traffic with any mac address."},{"line_number":266,"context_line":"                # OVN allows any mac address from a port if \"unknown\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_ba186a1d","line":263,"range":{"start_line":263,"start_character":12,"end_line":263,"end_character":33},"updated":"2020-04-22 21:42:34.000000000","message":"In Rocky this is \u0027if not port_security and not port_type:\u0027","commit_id":"6fe5581ff9f3d5e093bfca85295dca8f5721d490"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e47ee0a646d3df52b47d8b3a31cabc6dab719b7","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        if qos_options is None:"},{"line_number":209,"context_line":"            qos_options \u003d self._qos_driver.get_qos_options(port)"},{"line_number":210,"context_line":"        vtep_physical_switch \u003d binding_prof.get(\u0027vtep-physical-switch\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        cidrs \u003d \u0027\u0027"},{"line_number":213,"context_line":"        if vtep_physical_switch:"},{"line_number":214,"context_line":"            vtep_logical_switch \u003d binding_prof.get(\u0027vtep-logical-switch\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_b09b6b70","line":211,"updated":"2020-04-22 21:42:34.000000000","message":"Need to initialize port_type here too, oops","commit_id":"53ecce7b504f82fd3b26bc05384a5f54bb275249"}]}
