)]}'
{"migration/tripleo_environment/playbooks/roles/resources/validate/templates/validate-resources.sh.j2":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aa5a80df9eca93ab00bb901e357aa3e8847eb368","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#             https://bugzilla.redhat.com/show_bug.cgi?id\u003d1788193"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set +e"},{"line_number":19,"context_line":"ping -c 30 $server_ip"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Running ping test with -c 3 to the server ip - $server_ip\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_b4350cf7","line":19,"updated":"2020-02-13 22:48:17.000000000","message":"Is it the number or the duration?  If it\u0027s just the number you could send them really fast with -f, just need to add sudo too","commit_id":"945e9eb762081dd2aa5563cc8a4eaceb57e44250"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"149184cddef9e0fa89aef8dd49ae02a793ca2832","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#             https://bugzilla.redhat.com/show_bug.cgi?id\u003d1788193"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set +e"},{"line_number":19,"context_line":"ping -c 30 $server_ip"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Running ping test with -c 3 to the server ip - $server_ip\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_850bb92b","line":19,"in_reply_to":"3fa7e38b_11fae710","updated":"2020-02-19 09:20:22.000000000","message":"We can\u0027t because ping returns 1 if a single packet out of those 30 is lost and \"set -e\" causes the whole script to fail. So the patch pings first and doesn\u0027t care about the return code and then it really tests the floating ip.","commit_id":"945e9eb762081dd2aa5563cc8a4eaceb57e44250"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"47ab11c8088742fafbb22354ad1e73b9dcb477b2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#             https://bugzilla.redhat.com/show_bug.cgi?id\u003d1788193"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set +e"},{"line_number":19,"context_line":"ping -c 30 $server_ip"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Running ping test with -c 3 to the server ip - $server_ip\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_310e0333","line":19,"in_reply_to":"3fa7e38b_16fadd10","updated":"2020-02-14 13:47:22.000000000","message":"I don\u0027t think these 30 seconds are significant given the time needed for migration to finish. It\u0027s about 30 minutes.","commit_id":"945e9eb762081dd2aa5563cc8a4eaceb57e44250"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a2de9eb5733bae76f31732cb3c6b2515925be32d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#             https://bugzilla.redhat.com/show_bug.cgi?id\u003d1788193"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set +e"},{"line_number":19,"context_line":"ping -c 30 $server_ip"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Running ping test with -c 3 to the server ip - $server_ip\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_11fae710","line":19,"in_reply_to":"3fa7e38b_310e0333","updated":"2020-02-14 14:50:41.000000000","message":"So that leads to my second question, could just change below to 30 and revert when bug fixed :-p","commit_id":"945e9eb762081dd2aa5563cc8a4eaceb57e44250"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dde6d1ee9f697bb94b432cd85d95286d90383418","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#             https://bugzilla.redhat.com/show_bug.cgi?id\u003d1788193"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set +e"},{"line_number":19,"context_line":"ping -c 30 $server_ip"},{"line_number":20,"context_line":"set -e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Running ping test with -c 3 to the server ip - $server_ip\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_16fadd10","line":19,"in_reply_to":"3fa7e38b_b4350cf7","updated":"2020-02-14 13:46:38.000000000","message":"That\u0027s a really good question. I think there is also some time required because you want to reach point where ARP is sent. I haven\u0027t tried to send ICMP packets fast.","commit_id":"945e9eb762081dd2aa5563cc8a4eaceb57e44250"}]}