)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30156,"name":"Igor D.C.","email":"igor.duarte.cardoso@intel.com","username":"igordc"},"change_message_id":"88141e4c1c073f8ea703c932df2cbea690d26c5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xubo Zhang \u003cxubo.zhang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-19 04:43:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If SKIP_OVS_INSTALL is True, don\u0027t compile ovs. networking-ovs-dpdk can compile ovs and networking-ovn can use that ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9d08eb69f261b0da1b04d427720f032bafbe3871"},{"line_number":10,"context_line":"Related-Bug: #1867657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_996c3009","line":7,"updated":"2020-03-19 07:31:34.000000000","message":"commit title too long","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"76fbb06c2c55cbcbb11af72812877cf483df45de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xubo Zhang \u003cxubo.zhang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-19 04:43:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If SKIP_OVS_INSTALL is True, don\u0027t compile ovs. networking-ovs-dpdk can compile ovs and networking-ovn can use that ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9d08eb69f261b0da1b04d427720f032bafbe3871"},{"line_number":10,"context_line":"Related-Bug: #1867657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_2d46e624","line":7,"in_reply_to":"1fa4df85_996c3009","updated":"2020-03-25 05:10:55.000000000","message":"fixed","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"}],"devstack/README.rst":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"baede7116f703f8b05c1060691f6f8e035ebad8d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"     ./stack.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_830d4340","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":43},"updated":"2020-03-25 08:35:34.000000000","message":"in OVS","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"     ./stack.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_45469551","line":31,"range":{"start_line":31,"start_character":33,"end_line":31,"end_character":43},"in_reply_to":"df33271e_830d4340","updated":"2020-03-25 19:27:50.000000000","message":"fixed","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"baede7116f703f8b05c1060691f6f8e035ebad8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_4314db4e","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":33},"updated":"2020-03-25 08:35:34.000000000","message":"Can you explain why we don\u0027t need to compile OVS in OVN plugin?","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e53d311428549f4acda58a0f788bc2bea9ed8e47","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_be35fedc","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":33},"in_reply_to":"df33271e_4314db4e","updated":"2020-03-25 08:44:46.000000000","message":"Yes. For QoS we need to compile OVS and OVN - otherwise we don\u0027t have support for OVS meters.","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_25dd5170","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":33},"in_reply_to":"df33271e_4314db4e","updated":"2020-03-25 19:27:50.000000000","message":"if you don\u0027t use DPDK datapath, you still compile OVS as usual. To enable DPDK in OVS, you will use networking-ovs-dpdk to compile OVS with dpdk","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"4. Note, to enable DPDK datapath in the ovs, you can enable networking-ovs-dpdk"},{"line_number":32,"context_line":"   plugin `networking-ovs-dpdk \u003chttp://opendev.org/x/networking-ovs-dpdk/\u003e`_,"},{"line_number":33,"context_line":"   and set *SKIP_OVS_INSTALL\u003dTrue*, in local.conf."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_655ab94f","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":33},"in_reply_to":"df33271e_be35fedc","updated":"2020-03-25 19:27:50.000000000","message":"is QoS compiled in OVS or are they just flow rules?\n\nAgain, this option is only for someone who chooses to enable dpdk datapath in OVS. There might be some functionality differences caused by enabling DPDK, but that\u0027s up to user\u0027s choice.","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e53d311428549f4acda58a0f788bc2bea9ed8e47","unresolved":false,"context_lines":[{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"},{"line_number":37,"context_line":"     enable_plugin networking-ovs-dpdk https://opendev.org/x/networking-ovs-dpdk"},{"line_number":38,"context_line":"     enable_plugin networking-ovn http://opendev.org/openstack/networking-odl"},{"line_number":39,"context_line":"     SKIP_OVS_INSTALL\u003dTrue"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_7e3b76d0","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":77},"updated":"2020-03-25 08:44:46.000000000","message":"enable_plugin networking_ovn but repo is odl?","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"     \u003e cat local.conf"},{"line_number":36,"context_line":"     [[local|localrc]]"},{"line_number":37,"context_line":"     enable_plugin networking-ovs-dpdk https://opendev.org/x/networking-ovs-dpdk"},{"line_number":38,"context_line":"     enable_plugin networking-ovn http://opendev.org/openstack/networking-odl"},{"line_number":39,"context_line":"     SKIP_OVS_INSTALL\u003dTrue"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df33271e_851d3d75","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":77},"in_reply_to":"df33271e_7e3b76d0","updated":"2020-03-25 19:27:50.000000000","message":"fixed","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"}],"devstack/lib/ovn":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ada8d79a6456aec85a142134a0fd1ecebbd6f82","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_f6f52e58","line":108,"updated":"2020-03-19 11:37:41.000000000","message":"Instead of making this decision here, why don\u0027t you implement this logic where this method is called? [1]\n\nhttps://github.com/openstack/neutron/blob/2d9b2ffcee737ce2035bdaba3844ce977d82c3ae/devstack/lib/ovn_agent#L385","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"60bf88ee9e66531146b0bd77cc1c353ba633857d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_88012909","line":108,"in_reply_to":"1fa4df85_f6f52e58","updated":"2020-03-20 01:24:20.000000000","message":"changed","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ada8d79a6456aec85a142134a0fd1ecebbd6f82","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"},{"line_number":112,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_36a50648","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":27},"updated":"2020-03-19 11:37:41.000000000","message":"Where is this variable defined? This variable was used in networking-ovs-dpdk but is not defined here. You should initialize it assigning a default value (\"False\")","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"60bf88ee9e66531146b0bd77cc1c353ba633857d","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"},{"line_number":112,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_0b0bf323","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":27},"in_reply_to":"1fa4df85_36a50648","updated":"2020-03-20 01:24:20.000000000","message":"defined now","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":30156,"name":"Igor D.C.","email":"igor.duarte.cardoso@intel.com","username":"igordc"},"change_message_id":"88141e4c1c073f8ea703c932df2cbea690d26c5e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    local build_modules\u003d$1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_5976b8da","line":110,"updated":"2020-03-19 07:31:34.000000000","message":"fix tab and whitespaces","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"60bf88ee9e66531146b0bd77cc1c353ba633857d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"# _compile_ovs() - Compile openvswitch and its kernel module"},{"line_number":108,"context_line":"function _compile_ovs {"},{"line_number":109,"context_line":"   if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then  "},{"line_number":110,"context_line":"\treturn                                   "},{"line_number":111,"context_line":"   fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    local build_modules\u003d$1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_cb107b51","line":110,"in_reply_to":"1fa4df85_5976b8da","updated":"2020-03-20 01:24:20.000000000","message":"removed","commit_id":"852fb3d192e1d189a2098b306f4d2928c22e3e3c"},{"author":{"_account_id":30156,"name":"Igor D.C.","email":"igor.duarte.cardoso@intel.com","username":"igordc"},"change_message_id":"8243866880a5617eb78cba3f951ae64c62549d28","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"    \t_compile_ovs $build_modules"},{"line_number":165,"context_line":"    fi"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if [ -n \"$prefix\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df33271e_127d2c1c","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":5},"updated":"2020-03-23 00:12:07.000000000","message":"tab","commit_id":"dfcde1c99a0f9a7f5685fa9eb1e5a0af48a3d03a"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"76fbb06c2c55cbcbb11af72812877cf483df45de","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"    \t_compile_ovs $build_modules"},{"line_number":165,"context_line":"    fi"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    if [ -n \"$prefix\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df33271e_d4fa7040","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":5},"in_reply_to":"df33271e_127d2c1c","updated":"2020-03-25 05:10:55.000000000","message":"fixed","commit_id":"dfcde1c99a0f9a7f5685fa9eb1e5a0af48a3d03a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"baede7116f703f8b05c1060691f6f8e035ebad8d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    # This flag signals that ovs was built by other source such as"},{"line_number":159,"context_line":"    # networking-ovs-dpdk for enabling dpdk datapath in the ovs"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"        _compile_ovs $build_modules"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df33271e_0363f31b","line":161,"range":{"start_line":161,"start_character":30,"end_line":161,"end_character":31},"updated":"2020-03-25 08:35:34.000000000","message":"This is a comparison not an assignation.\nThis should be \u003d\u003d","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e53d311428549f4acda58a0f788bc2bea9ed8e47","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    # This flag signals that ovs was built by other source such as"},{"line_number":159,"context_line":"    # networking-ovs-dpdk for enabling dpdk datapath in the ovs"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"        _compile_ovs $build_modules"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df33271e_3e572e05","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":28},"updated":"2020-03-25 08:44:46.000000000","message":"We have a variable for that, which is \n\n\"OVN_BUILD_MODULES\"\n\nYou can specify it in the local.conf - if it is false the module will not be compiled.","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    # This flag signals that ovs was built by other source such as"},{"line_number":159,"context_line":"    # networking-ovs-dpdk for enabling dpdk datapath in the ovs"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"        _compile_ovs $build_modules"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df33271e_b3a890db","line":161,"range":{"start_line":161,"start_character":30,"end_line":161,"end_character":31},"in_reply_to":"df33271e_0363f31b","updated":"2020-03-25 19:27:50.000000000","message":"it is not an assignment in bash","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"},{"author":{"_account_id":28059,"name":"Xubo Zhang","email":"xubo.zhang@intel.com","username":"xbzhang99"},"change_message_id":"9a04473be46a13d0126d4f5d776145660c5f883c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    # This flag signals that ovs was built by other source such as"},{"line_number":159,"context_line":"    # networking-ovs-dpdk for enabling dpdk datapath in the ovs"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    if [[ \"$SKIP_OVS_INSTALL\" \u003d \"True\" ]]; then"},{"line_number":162,"context_line":"        echo \"Skipping OVS installation.\""},{"line_number":163,"context_line":"    else"},{"line_number":164,"context_line":"        _compile_ovs $build_modules"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df33271e_7850a00b","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":28},"in_reply_to":"df33271e_3e572e05","updated":"2020-03-25 19:27:50.000000000","message":"I think OVN_BUILD_MODULE is not the switch for building OVS, but for building mudules when building OVS","commit_id":"4fb4bc4743d117db582df8e48f34945eec6a62f1"}]}