)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a0f708d3dba18b8f4d1f8cd56a6c7a89b2a025cf","unresolved":true,"context_lines":[{"line_number":471,"context_line":"            except driver_exceptions.UpdateStatusError as e:"},{"line_number":472,"context_line":"                msg \u003d (\"Error while updating the load balancer \""},{"line_number":473,"context_line":"                       \"status: %s\") % e.fault_string"},{"line_number":474,"context_line":"                LOG.error(msg)"},{"line_number":475,"context_line":"                # TODO(haleyb): The resource(s) we were updating status for"},{"line_number":476,"context_line":"                # should be cleaned-up"},{"line_number":477,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"100fe1a8_68fe7606","line":474,"updated":"2021-01-29 15:56:04.000000000","message":"Mostly a nit: Interpolation should be delayed here according to OS guidelines [0].\n\nLOG.error(\"Error... \"\n          \"status %s\", e.fault_string)\n\n[0] https://docs.openstack.org/oslo.log/latest/user/guidelines.html#adding-variables-to-log-messages","commit_id":"ed140e4407ac5bac89a33351f6597e027e4aff85"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3eb4f51407d1dddc511fad72db8ed1e90b7b85f5","unresolved":true,"context_lines":[{"line_number":471,"context_line":"            except driver_exceptions.UpdateStatusError as e:"},{"line_number":472,"context_line":"                msg \u003d (\"Error while updating the load balancer \""},{"line_number":473,"context_line":"                       \"status: %s\") % e.fault_string"},{"line_number":474,"context_line":"                LOG.error(msg)"},{"line_number":475,"context_line":"                # TODO(haleyb): The resource(s) we were updating status for"},{"line_number":476,"context_line":"                # should be cleaned-up"},{"line_number":477,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb4ea5b0_bd65d46e","line":474,"in_reply_to":"100fe1a8_68fe7606","updated":"2021-01-29 16:12:54.000000000","message":"Ack, there\u0027s another one too, i\u0027ll fix over in the provider repo master branch and enable the warnings in tox.ini.","commit_id":"ed140e4407ac5bac89a33351f6597e027e4aff85"}]}