)]}'
{"networking_ovn/common/acl.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0f6066fb70580bd23ad78493be2728532ffdc0ee","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    for r in security_group[\u0027security_group_rules\u0027]:"},{"line_number":332,"context_line":"        acl \u003d _add_sg_rule_acl_for_port_group("},{"line_number":333,"context_line":"            utils.ovn_port_group_name(security_group[\u0027id\u0027]), r)"},{"line_number":334,"context_line":"        txn.add(ovn.pg_acl_add(may_exist\u003dTrue, **acl))"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"18631e7d_0b7c62f6","line":334,"updated":"2021-04-13 10:56:00.000000000","message":"nit:\n\nNot a big deal but in the original patch the parameter was added the other way around:\n\ntxn.add(ovn.pg_acl_add(**acl, may_exist\u003dTrue))\n\nhttps://review.opendev.org/c/openstack/neutron/+/736386/6/neutron/common/ovn/acl.py","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"322a9d31fe14907f5cf162e522d390f39a42a653","unresolved":true,"context_lines":[{"line_number":331,"context_line":"    for r in security_group[\u0027security_group_rules\u0027]:"},{"line_number":332,"context_line":"        acl \u003d _add_sg_rule_acl_for_port_group("},{"line_number":333,"context_line":"            utils.ovn_port_group_name(security_group[\u0027id\u0027]), r)"},{"line_number":334,"context_line":"        txn.add(ovn.pg_acl_add(may_exist\u003dTrue, **acl))"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f358deb_51039fb7","line":334,"in_reply_to":"18631e7d_0b7c62f6","updated":"2021-04-13 12:03:54.000000000","message":"I know but that caused syntax error in python 2.7 so I had to change it","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"775bdce7b3e1bc938e0cc6d01724b3d3c358868a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    for r in security_group[\u0027security_group_rules\u0027]:"},{"line_number":332,"context_line":"        acl \u003d _add_sg_rule_acl_for_port_group("},{"line_number":333,"context_line":"            utils.ovn_port_group_name(security_group[\u0027id\u0027]), r)"},{"line_number":334,"context_line":"        txn.add(ovn.pg_acl_add(may_exist\u003dTrue, **acl))"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c30a53e_e66339e3","line":334,"in_reply_to":"8f358deb_51039fb7","updated":"2021-04-13 19:52:42.000000000","message":"Ack","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0f6066fb70580bd23ad78493be2728532ffdc0ee","unresolved":true,"context_lines":[{"line_number":356,"context_line":"        if not keep_name_severity:"},{"line_number":357,"context_line":"            acl.pop(\u0027name\u0027)"},{"line_number":358,"context_line":"            acl.pop(\u0027severity\u0027)"},{"line_number":359,"context_line":"        ovn.pg_acl_add(may_exist\u003dTrue, **acl).execute(check_error\u003dTrue)"},{"line_number":360,"context_line":"    else:"},{"line_number":361,"context_line":"        ovn.pg_acl_del(acl[\u0027port_group\u0027], acl[\u0027direction\u0027],"},{"line_number":362,"context_line":"                       acl[\u0027priority\u0027], acl[\u0027match\u0027]).execute("}],"source_content_type":"text/x-python","patch_set":4,"id":"37e780d5_71e4d44c","line":359,"updated":"2021-04-13 10:56:00.000000000","message":"ditto","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"322a9d31fe14907f5cf162e522d390f39a42a653","unresolved":true,"context_lines":[{"line_number":356,"context_line":"        if not keep_name_severity:"},{"line_number":357,"context_line":"            acl.pop(\u0027name\u0027)"},{"line_number":358,"context_line":"            acl.pop(\u0027severity\u0027)"},{"line_number":359,"context_line":"        ovn.pg_acl_add(may_exist\u003dTrue, **acl).execute(check_error\u003dTrue)"},{"line_number":360,"context_line":"    else:"},{"line_number":361,"context_line":"        ovn.pg_acl_del(acl[\u0027port_group\u0027], acl[\u0027direction\u0027],"},{"line_number":362,"context_line":"                       acl[\u0027priority\u0027], acl[\u0027match\u0027]).execute("}],"source_content_type":"text/x-python","patch_set":4,"id":"a8748553_5b059913","line":359,"in_reply_to":"37e780d5_71e4d44c","updated":"2021-04-13 12:03:54.000000000","message":"ditto","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"775bdce7b3e1bc938e0cc6d01724b3d3c358868a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        if not keep_name_severity:"},{"line_number":357,"context_line":"            acl.pop(\u0027name\u0027)"},{"line_number":358,"context_line":"            acl.pop(\u0027severity\u0027)"},{"line_number":359,"context_line":"        ovn.pg_acl_add(may_exist\u003dTrue, **acl).execute(check_error\u003dTrue)"},{"line_number":360,"context_line":"    else:"},{"line_number":361,"context_line":"        ovn.pg_acl_del(acl[\u0027port_group\u0027], acl[\u0027direction\u0027],"},{"line_number":362,"context_line":"                       acl[\u0027priority\u0027], acl[\u0027match\u0027]).execute("}],"source_content_type":"text/x-python","patch_set":4,"id":"a6f39707_18adc93d","line":359,"in_reply_to":"a8748553_5b059913","updated":"2021-04-13 19:52:42.000000000","message":"Ack","commit_id":"d4ecbd2a70313ec455f09dd79a461505ccff0b23"}]}