)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"15baa226567c082ed2ca9d2babb84827f3806682","unresolved":true,"context_lines":[{"line_number":1636,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":1637,"context_line":"                    check_error\u003dTrue)"},{"line_number":1638,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baf8bfb7_aacfd1b8","line":1640,"range":{"start_line":1639,"start_character":16,"end_line":1640,"end_character":36},"updated":"2021-06-18 09:23:43.000000000","message":"In neutron, this is just a pass, why the warning level log here?","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"518884f9a1f212e0df54f97984a63d6dbc405945","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":1637,"context_line":"                    check_error\u003dTrue)"},{"line_number":1638,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"}],"source_content_type":"text/x-python","patch_set":6,"id":"41527281_c28f0d30","line":1640,"range":{"start_line":1639,"start_character":16,"end_line":1640,"end_character":36},"in_reply_to":"8de0e941_64aff0c9","updated":"2021-06-21 15:29:05.000000000","message":"Done","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"89e1781a36c90eb68bbf0680b4aadfe18990c0e6","unresolved":true,"context_lines":[{"line_number":1636,"context_line":"                ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":1637,"context_line":"                    check_error\u003dTrue)"},{"line_number":1638,"context_line":"            except idlutils.RowNotFound:"},{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"}],"source_content_type":"text/x-python","patch_set":6,"id":"8de0e941_64aff0c9","line":1640,"range":{"start_line":1639,"start_character":16,"end_line":1640,"end_character":36},"in_reply_to":"baf8bfb7_aacfd1b8","updated":"2021-06-18 17:26:35.000000000","message":"Good point. Let me change that.","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"15baa226567c082ed2ca9d2babb84827f3806682","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"},{"line_number":1644,"context_line":"                if ovn_lr:"},{"line_number":1645,"context_line":"                    for net in self._find_ls_for_lr(ovn_lr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bd474991_d291bcbb","line":1642,"range":{"start_line":1642,"start_character":12,"end_line":1642,"end_character":22},"updated":"2021-06-18 09:23:43.000000000","message":"Is it not possible to use same logic as master patch with larger try block that will make sure we have ovn_ls? In the end it is same logic but it may make further backports simpler","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"518884f9a1f212e0df54f97984a63d6dbc405945","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"},{"line_number":1644,"context_line":"                if ovn_lr:"},{"line_number":1645,"context_line":"                    for net in self._find_ls_for_lr(ovn_lr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"50dfd19d_b90d78ef","line":1642,"range":{"start_line":1642,"start_character":12,"end_line":1642,"end_character":22},"in_reply_to":"24543d54_352228a7","updated":"2021-06-21 15:29:05.000000000","message":"Done","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"89e1781a36c90eb68bbf0680b4aadfe18990c0e6","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"},{"line_number":1644,"context_line":"                if ovn_lr:"},{"line_number":1645,"context_line":"                    for net in self._find_ls_for_lr(ovn_lr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"24543d54_352228a7","line":1642,"range":{"start_line":1642,"start_character":12,"end_line":1642,"end_character":22},"in_reply_to":"641465ab_76fdb901","updated":"2021-06-18 17:26:35.000000000","message":"Ack","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c19ca04728fe14f872353ed69f94d2f1b6eddfee","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"                LOG.warning(\"LogicalSwitch %s could not be found.\","},{"line_number":1640,"context_line":"                            ls_name)"},{"line_number":1641,"context_line":"                ovn_ls \u003d None"},{"line_number":1642,"context_line":"            if ovn_ls:"},{"line_number":1643,"context_line":"                ovn_lr \u003d self._find_lr_of_ls(ovn_ls)"},{"line_number":1644,"context_line":"                if ovn_lr:"},{"line_number":1645,"context_line":"                    for net in self._find_ls_for_lr(ovn_lr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"641465ab_76fdb901","line":1642,"range":{"start_line":1642,"start_character":12,"end_line":1642,"end_character":22},"in_reply_to":"bd474991_d291bcbb","updated":"2021-06-18 17:13:23.000000000","message":"Yes, I see what you mean Bernard and it\u0027s a good idea to make them more similar, like:\n\nif subnet:\n    ls_name \u003d ovn_utils.ovn_name(subnet.network_id)\n    try:\n        do a bunch of stuff\n    except idlutils.RowNotFound:\n        pass\n\nAssuming it behaves the same.","commit_id":"4b58a290ca28b946176918633dc78e971baf3491"}]}