)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"b4073d01c69e1786efc28eed1d0e2dfefe6f0c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"58bd3ed5_d8c83204","updated":"2022-01-24 13:53:42.000000000","message":"Folks, can anyone review and (if needed) continue Kamil\u0027s work on this patch?\nThanks!\n\nPS: VLAN + DVR + OVN depends on this, which is important.","commit_id":"5b9bf28996596b60946c4b4449016bb2960185f3"}],"networking_ovn/common/maintenance.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"260601ddd4e961557e85638bb120f524ce1c26ed","unresolved":true,"context_lines":[{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        cmds \u003d []"},{"line_number":691,"context_line":"        for port in self._nb_idl.lrp_list().execute(check_error\u003dTrue):"},{"line_number":692,"context_line":"            options \u003d self._ovn_client._gen_router_port_options(port)"},{"line_number":693,"context_line":"            cmds.append(self._nb_idl.lrp_set_options(port.name, **options))"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a0f03a0b_9df2f4dd","line":691,"updated":"2021-10-07 14:16:51.000000000","message":"Thinking out loud: On large scale deployments there can be thousands of ports and even more LRPs - wouldn\u0027t it be safer to do this in chunks instead of just one large transaction?","commit_id":"a72bf893b3e5ea42ee16456c2a4bd91aed8a5594"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0d98d90b2c89da611c1a271ca7d84ab8c1d50aab","unresolved":true,"context_lines":[{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        cmds \u003d []"},{"line_number":691,"context_line":"        for port in self._nb_idl.lrp_list().execute(check_error\u003dTrue):"},{"line_number":692,"context_line":"            options \u003d self._ovn_client._gen_router_port_options(port)"},{"line_number":693,"context_line":"            cmds.append(self._nb_idl.lrp_set_options(port.name, **options))"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8c9ea1fb_64e36d09","line":691,"in_reply_to":"628d9a32_44260405","updated":"2022-01-27 14:09:36.000000000","message":"Maybe instead of iterating thru all ports, we could first filter per network type (get_networks() in neutron) and if it\u0027s VLAN we can loop thru the LRP ports for that network.","commit_id":"a72bf893b3e5ea42ee16456c2a4bd91aed8a5594"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"ea05cacea52c936c996bea19228ad3b3283e761b","unresolved":true,"context_lines":[{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        cmds \u003d []"},{"line_number":691,"context_line":"        for port in self._nb_idl.lrp_list().execute(check_error\u003dTrue):"},{"line_number":692,"context_line":"            options \u003d self._ovn_client._gen_router_port_options(port)"},{"line_number":693,"context_line":"            cmds.append(self._nb_idl.lrp_set_options(port.name, **options))"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a9d9e646_8eeb7993","line":691,"in_reply_to":"a0f03a0b_9df2f4dd","updated":"2021-10-11 13:07:23.000000000","message":"Agree that this can be a problem. But then we also should update other tasks which iterate through ports resources etc?","commit_id":"a72bf893b3e5ea42ee16456c2a4bd91aed8a5594"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"edc4fb10b6f1993d01324bd07c90984e37e3bb31","unresolved":true,"context_lines":[{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        cmds \u003d []"},{"line_number":691,"context_line":"        for port in self._nb_idl.lrp_list().execute(check_error\u003dTrue):"},{"line_number":692,"context_line":"            options \u003d self._ovn_client._gen_router_port_options(port)"},{"line_number":693,"context_line":"            cmds.append(self._nb_idl.lrp_set_options(port.name, **options))"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"628d9a32_44260405","line":691,"in_reply_to":"a9d9e646_8eeb7993","updated":"2021-10-13 21:07:43.000000000","message":"That would not be related to this patch.","commit_id":"a72bf893b3e5ea42ee16456c2a4bd91aed8a5594"}]}