)]}'
{"doc/source/sfc_port_chain_tap.rst":[{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"bbc7873c0393006a9115b8f8b58b55d8e0dd1d3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"The Port Pair service-function-parameter attribute allows service specific"},{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_35db73ef","line":34,"updated":"2017-03-07 07:02:48.000000000","message":"Allowed fields in \"insertion mode\" should be extended for L2, TAP support also. Default should be \"l3\". I think \"passive\" refers to mode of deployment of device.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":31,"context_line":"The Port Pair service-function-parameter attribute allows service specific"},{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_7526aabb","line":34,"in_reply_to":"9a30ddce_083bb1ec","updated":"2017-03-07 18:08:25.000000000","message":"Will change \"passive\" to \"tap\". I would prefer to keep the scope of this document as is. Additional functionality (bitw) can be added in another spec.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"The Port Pair service-function-parameter attribute allows service specific"},{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_083bb1ec","line":34,"in_reply_to":"9a30ddce_35db73ef","updated":"2017-03-07 10:02:16.000000000","message":"Right, and perhaps the spec should be renamed to address the broader scope.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"bbc7873c0393006a9115b8f8b58b55d8e0dd1d3c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_7910854f","line":37,"updated":"2017-03-07 07:02:48.000000000","message":"Can this be realized per-hop (SFs in chain) or only originating source port ?","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_e81c9d79","line":37,"in_reply_to":"9a30ddce_7910854f","updated":"2017-03-07 10:02:16.000000000","message":"+1\nI see no reason why it wouldn\u0027t work at any point during the chain.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"passive\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_153f2eb5","line":37,"in_reply_to":"9a30ddce_7910854f","updated":"2017-03-07 18:08:25.000000000","message":"ok this can be done at any hop in the port-chain. I will add text.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then normal behavior"},{"line_number":43,"context_line":"will occur."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_88588158","line":40,"range":{"start_line":39,"start_character":52,"end_line":40,"end_character":34},"updated":"2017-03-07 10:02:16.000000000","message":"Can you clarify this statement?","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then normal behavior"},{"line_number":43,"context_line":"will occur."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_55bc4605","line":40,"range":{"start_line":39,"start_character":52,"end_line":40,"end_character":34},"in_reply_to":"9a30ddce_88588158","updated":"2017-03-07 18:08:25.000000000","message":"the \"tap\" port-pair will only send packets to the SF and not receive packets from the SF. \n\nI will reword.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then normal behavior"},{"line_number":43,"context_line":"will occur."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"OVS Bridge Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_480cc942","line":42,"range":{"start_line":42,"start_character":56,"end_line":42,"end_character":62},"updated":"2017-03-07 10:02:16.000000000","message":"default","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"not receive any packets from a SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then normal behavior"},{"line_number":43,"context_line":"will occur."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"OVS Bridge Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_b5a58205","line":42,"range":{"start_line":42,"start_character":56,"end_line":42,"end_character":62},"in_reply_to":"9a30ddce_480cc942","updated":"2017-03-07 18:08:25.000000000","message":"will correct.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"221015c4c2f1c5c93d4d05ddd87adbc5ddf21a61","unresolved":false,"context_lines":[{"line_number":46,"context_line":"-------------------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"If the insertion-mode for a SF is configured as \"passive\" the"},{"line_number":49,"context_line":"OVS Integration bridge will add a tap. The tap replicates packets received"},{"line_number":50,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of SF 1 on VM1."},{"line_number":51,"context_line":"The other copy is sent to the ingress port P2 of SF 2 on VM2."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_994e19c0","line":49,"updated":"2017-03-07 07:27:50.000000000","message":"Can you add, how this tap will be added and will replicate packet?\nWhat if VM1 \u0026 VM2 (from below diagram) is on different compute node ?","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":46,"context_line":"-------------------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"If the insertion-mode for a SF is configured as \"passive\" the"},{"line_number":49,"context_line":"OVS Integration bridge will add a tap. The tap replicates packets received"},{"line_number":50,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of SF 1 on VM1."},{"line_number":51,"context_line":"The other copy is sent to the ingress port P2 of SF 2 on VM2."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_b5dd8244","line":49,"in_reply_to":"9a30ddce_994e19c0","updated":"2017-03-07 18:08:25.000000000","message":"1. Add an OVS rule action to resubmit the packet to Table 0 but sourced from the tap port.\n2. This will work regardless of where the next hop SF is located: on the same compute node on another compute node. I can add a  diagram to clarify.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"221015c4c2f1c5c93d4d05ddd87adbc5ddf21a61","unresolved":false,"context_lines":[{"line_number":48,"context_line":"If the insertion-mode for a SF is configured as \"passive\" the"},{"line_number":49,"context_line":"OVS Integration bridge will add a tap. The tap replicates packets received"},{"line_number":50,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of SF 1 on VM1."},{"line_number":51,"context_line":"The other copy is sent to the ingress port P2 of SF 2 on VM2."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_d99411ea","line":51,"updated":"2017-03-07 07:27:50.000000000","message":"Can we support to IDS placed in different network from SFs ?","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":48,"context_line":"If the insertion-mode for a SF is configured as \"passive\" the"},{"line_number":49,"context_line":"OVS Integration bridge will add a tap. The tap replicates packets received"},{"line_number":50,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of SF 1 on VM1."},{"line_number":51,"context_line":"The other copy is sent to the ingress port P2 of SF 2 on VM2."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"::"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_752b0aec","line":51,"in_reply_to":"9a30ddce_d99411ea","updated":"2017-03-07 18:08:25.000000000","message":"yes","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Alternatives"},{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_934b5259","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":4},"updated":"2017-03-07 10:02:16.000000000","message":"Can you investigate and document the gaps with using networking-taas alongside the OVS flow manager and networking-sfc?","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"de7cc0021e26d6e2c947b90892b21c9a68a85705","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Alternatives"},{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_1552ce67","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":4},"in_reply_to":"9a30ddce_934b5259","updated":"2017-03-07 18:08:25.000000000","message":"taas has a different focus","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94b9b56d38b6768724c380b6ebbf7f5d248a6daa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Add \"insertion-mode\" to the service-function-parameter."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_933432df","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":54},"updated":"2017-03-07 10:02:16.000000000","message":"-\u003eservice_function_parameters\u003c-\nAlso clarify that this service_function_parameters is a port-pair\u0027s attribute already.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"bbc7873c0393006a9115b8f8b58b55d8e0dd1d3c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Add \"insertion-mode\" to the service-function-parameter."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_55ff0734","line":86,"updated":"2017-03-07 07:02:48.000000000","message":"This should be property of port-pair.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"0c0bd8c142cd63a512ee54ecf198a6fab8502d30","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Add \"insertion-mode\" to the service-function-parameter."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_3530b201","line":86,"in_reply_to":"9a30ddce_55ff0734","updated":"2017-03-07 18:09:48.000000000","message":"it is a port-pair attribute","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"0c0bd8c142cd63a512ee54ecf198a6fab8502d30","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Add \"insertion-mode\" to the service-function-parameter."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_951dde75","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":54},"in_reply_to":"9a30ddce_933432df","updated":"2017-03-07 18:09:48.000000000","message":"ok","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"bbc7873c0393006a9115b8f8b58b55d8e0dd1d3c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Add \"insertion-mode\": \"passive\" to the service-function-parameter."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_3589b3cb","line":91,"updated":"2017-03-07 07:02:48.000000000","message":"I think \"passive\" doesn\u0027t represents type of device but the mode of deployment.","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"0c0bd8c142cd63a512ee54ecf198a6fab8502d30","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Add \"insertion-mode\": \"passive\" to the service-function-parameter."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_f50c5a44","line":91,"in_reply_to":"9a30ddce_3589b3cb","updated":"2017-03-07 18:09:48.000000000","message":"will change to \"tap\"","commit_id":"bb4094446861b89e9f8f3170e6923a30870dd324"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2a9c5852709f2b885ad1b539dafb22bca4ee3831","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_e33737e1","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"updated":"2017-03-07 23:14:15.000000000","message":"Can we have many \"tap\" PPs at the same point?","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_f8c7d80f","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"in_reply_to":"9a30ddce_2f2a112d","updated":"2017-03-08 05:14:21.000000000","message":"Its like more than one TAP devices are deployed and all requires packets to be mirrored.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"1b95ddf93700bd29f692f70da2d5a62cf1d6b50c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_7f83b356","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"in_reply_to":"9a30ddce_aa8fbd21","updated":"2017-03-08 18:27:20.000000000","message":"Multiple PPs can be taps","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9d90127f0fcf84b412cea2d7d3cb06a279889b75","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_2f2a112d","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"in_reply_to":"9a30ddce_e33737e1","updated":"2017-03-07 23:58:21.000000000","message":"@Igor, not sure what you mean be \"at the same point\"?","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e9bda25e5565962f89f1375da25a49f9bcd89015","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to a Service Function."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_aa8fbd21","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":33},"in_reply_to":"9a30ddce_f8c7d80f","updated":"2017-03-08 11:22:10.000000000","message":"Yeah, like traffic going from PP1 to PP2, PP2 to PP3, but also PP2 to PPa, PPb and PPc (without return).","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2a9c5852709f2b885ad1b539dafb22bca4ee3831","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_231b0f74","line":37,"range":{"start_line":37,"start_character":38,"end_line":37,"end_character":49},"updated":"2017-03-07 23:14:15.000000000","message":"Read my 3 questions in the next comment... perhaps instead of looking at the next hop SF, looking at the other PPs of the same PPG would be better. The reason for this is that we would still be able to look at port-chains as a sequence of PPGs like we do today.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_38d250d3","line":37,"range":{"start_line":37,"start_character":38,"end_line":37,"end_character":49},"in_reply_to":"9a30ddce_231b0f74","updated":"2017-03-08 05:14:21.000000000","message":"+1","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9d90127f0fcf84b412cea2d7d3cb06a279889b75","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_4f7d851b","line":37,"range":{"start_line":37,"start_character":38,"end_line":37,"end_character":49},"in_reply_to":"9a30ddce_231b0f74","updated":"2017-03-07 23:58:21.000000000","message":"see my response to next comment - insertion-mode should be applied to all SFs (port-pairs) in a PPG. I will add it to the port-pair-group-parameter.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e9bda25e5565962f89f1375da25a49f9bcd89015","unresolved":false,"context_lines":[{"line_number":34,"context_line":"The service-function-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":35,"context_line":"field. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_6aaea586","line":37,"range":{"start_line":37,"start_character":38,"end_line":37,"end_character":49},"in_reply_to":"9a30ddce_38d250d3","updated":"2017-03-08 11:22:10.000000000","message":"Alright.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2a9c5852709f2b885ad1b539dafb22bca4ee3831","unresolved":false,"context_lines":[{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then default behavior"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_28a84c1f","line":39,"range":{"start_line":39,"start_character":57,"end_line":39,"end_character":66},"updated":"2017-03-07 23:14:15.000000000","message":"How will the relationship with port-pair-group be? Does every PP in a PPG have to \"tap\"? Should you make it possible to have \"tap\" PPs in a PPG? Should a PPG have at least 1 non-\"tap\" PP?","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9d90127f0fcf84b412cea2d7d3cb06a279889b75","unresolved":false,"context_lines":[{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then default behavior"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_cfa175ab","line":39,"range":{"start_line":39,"start_character":57,"end_line":39,"end_character":66},"in_reply_to":"9a30ddce_28a84c1f","updated":"2017-03-07 23:58:21.000000000","message":"I agree - all SFs in the PPG should have the same behavior. I would make more sense to add insertion-mode to the PPG than the  PP. I will post a new patch.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":37,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":38,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":39,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":40,"context_line":"only send packets to the SF and not receive any packets from the SF."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If this parameter is set to none or is not present then default behavior"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_5871c4df","line":39,"range":{"start_line":39,"start_character":57,"end_line":39,"end_character":66},"in_reply_to":"9a30ddce_cfa175ab","updated":"2017-03-08 05:14:21.000000000","message":"TAP devices can be tied with any non TAP SFs. But keeping all SFs in PPG of same behavior will make sense.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2a9c5852709f2b885ad1b539dafb22bca4ee3831","unresolved":false,"context_lines":[{"line_number":43,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"},{"line_number":44,"context_line":"Chain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"OVS Bridge Implementation"},{"line_number":47,"context_line":"-------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"If the insertion-mode for a SF is configured as \"tap\" the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_e83c7431","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":10},"updated":"2017-03-07 23:14:15.000000000","message":"Driver","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9d90127f0fcf84b412cea2d7d3cb06a279889b75","unresolved":false,"context_lines":[{"line_number":43,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"},{"line_number":44,"context_line":"Chain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"OVS Bridge Implementation"},{"line_number":47,"context_line":"-------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"If the insertion-mode for a SF is configured as \"tap\" the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_af1601ef","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":10},"in_reply_to":"9a30ddce_e83c7431","updated":"2017-03-07 23:58:21.000000000","message":"ok","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"OVS Bridge Implementation"},{"line_number":47,"context_line":"-------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"If the insertion-mode for a SF is configured as \"tap\" the"},{"line_number":50,"context_line":"OVS Integration bridge will add a tap to replicate packets received"},{"line_number":51,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of the passive"},{"line_number":52,"context_line":"Service Function (SF 1 on VM1). The other copy is sent to the ingress port (P2)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_b882c092","line":49,"updated":"2017-03-08 05:14:21.000000000","message":"I believe it is per service function chain.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2a9c5852709f2b885ad1b539dafb22bca4ee3831","unresolved":false,"context_lines":[{"line_number":61,"context_line":" |  | Service Function 1 |  | Service Function 2 |  |"},{"line_number":62,"context_line":" |  |      (Passive)     |  |                    |  |"},{"line_number":63,"context_line":" |  +--------------------+  +--------------------+  |"},{"line_number":64,"context_line":" |         P1 |^               P2 |^    P3 |.       |"},{"line_number":65,"context_line":" |            |.                  |.       |.       |"},{"line_number":66,"context_line":" |            |.                  |.       |.       |"},{"line_number":67,"context_line":" |  +----------.-------------------.--------.----+  |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_482bc0eb","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":45},"updated":"2017-03-07 23:14:15.000000000","message":"Correct me if I\u0027m wrong. If P1 is a tap PP, the switch will duplicate the original packets, sending them to both P1 and P2.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9d90127f0fcf84b412cea2d7d3cb06a279889b75","unresolved":false,"context_lines":[{"line_number":61,"context_line":" |  | Service Function 1 |  | Service Function 2 |  |"},{"line_number":62,"context_line":" |  |      (Passive)     |  |                    |  |"},{"line_number":63,"context_line":" |  +--------------------+  +--------------------+  |"},{"line_number":64,"context_line":" |         P1 |^               P2 |^    P3 |.       |"},{"line_number":65,"context_line":" |            |.                  |.       |.       |"},{"line_number":66,"context_line":" |            |.                  |.       |.       |"},{"line_number":67,"context_line":" |  +----------.-------------------.--------.----+  |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_6fcde95c","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":45},"in_reply_to":"9a30ddce_482bc0eb","updated":"2017-03-07 23:58:21.000000000","message":"no, if P1 is a \"tap PP\", the br-int tap (shown as X) will duplicate the packet, send one copy to P1 and the other copy to next downstream ingress port (P2)","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":61,"context_line":" |  | Service Function 1 |  | Service Function 2 |  |"},{"line_number":62,"context_line":" |  |      (Passive)     |  |                    |  |"},{"line_number":63,"context_line":" |  +--------------------+  +--------------------+  |"},{"line_number":64,"context_line":" |         P1 |^               P2 |^    P3 |.       |"},{"line_number":65,"context_line":" |            |.                  |.       |.       |"},{"line_number":66,"context_line":" |            |.                  |.       |.       |"},{"line_number":67,"context_line":" |  +----------.-------------------.--------.----+  |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_383c10e2","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":45},"in_reply_to":"9a30ddce_6fcde95c","updated":"2017-03-08 05:14:21.000000000","message":"What if TAP (Service Function 1) SF2 not part of same network ? Majority of TAP devices gets deployed in different network.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1ccc03b9eb40ff09bb55a48cdf316adb24fa8d1a","unresolved":false,"context_lines":[{"line_number":100,"context_line":" |                     .   |   |   .                     |"},{"line_number":101,"context_line":" +---------------------.---+   +---.---------------------+"},{"line_number":102,"context_line":"                       ............."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Alternatives"},{"line_number":106,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_b8300003","line":103,"updated":"2017-03-08 05:14:21.000000000","message":"I agree with Igor earlier comment on the spec, to make the scope of the spec broader and then take call on implementation. I have sent summarized statement also few days back.","commit_id":"3ec2937203c0c75f68bb9672d97104451804b757"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0eb4823d14076e8684b25446d22a6a88184a4c37","unresolved":false,"context_lines":[{"line_number":36,"context_line":"field. The \"insertion-mode\" field will apply to all Service Functions in"},{"line_number":37,"context_line":"the Port Pair Group. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":38,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":39,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":40,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":41,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":42,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_aa294239","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":65},"updated":"2017-03-09 16:56:45.000000000","message":"Probably related to vikash comment below: rewrite with something like \"The Port Pairs in the Port Pair Group\"","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"dfb7bef1e51fae80013269a6f8648d88c7382300","unresolved":false,"context_lines":[{"line_number":36,"context_line":"field. The \"insertion-mode\" field will apply to all Service Functions in"},{"line_number":37,"context_line":"the Port Pair Group. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":38,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"},{"line_number":39,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":40,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":41,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":42,"context_line":"only send packets to the SF and not receive any packets from the SF."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_e5244dc6","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":65},"in_reply_to":"9a30ddce_aa294239","updated":"2017-03-09 20:37:10.000000000","message":"ok will reword","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"d86ae1563623e897f8cdd75f63a9ad816ba02728","unresolved":false,"context_lines":[{"line_number":39,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":40,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":41,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":42,"context_line":"only send packets to the SF and not receive any packets from the SF."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If this parameter is set to none or is not present then default behavior"},{"line_number":45,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_6cff8167","line":42,"updated":"2017-03-09 06:28:11.000000000","message":"Please revisit L39-L42. TAP ports are port-pair ports.","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"5a5535f5a5a692630db07a3154a2c89ae0d89841","unresolved":false,"context_lines":[{"line_number":39,"context_line":"and also forward these packets to the next hop SF. This port-pair will in"},{"line_number":40,"context_line":"effect operate as a tap by passing packets to the passive SF and also"},{"line_number":41,"context_line":"forwarding these packets to the next downstream SF. This port-pair will"},{"line_number":42,"context_line":"only send packets to the SF and not receive any packets from the SF."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"If this parameter is set to none or is not present then default behavior"},{"line_number":45,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_d612a556","line":42,"in_reply_to":"9a30ddce_6cff8167","updated":"2017-03-09 15:36:19.000000000","message":"Will reword","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"d86ae1563623e897f8cdd75f63a9ad816ba02728","unresolved":false,"context_lines":[{"line_number":52,"context_line":"OVS Integration bridge will add a tap to replicate packets received"},{"line_number":53,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of the passive"},{"line_number":54,"context_line":"Service Function (SF 1 on VM1). The other copy is sent to the ingress port (P2)"},{"line_number":55,"context_line":"of the next downstream Service Function (SF 2 on VM2)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_ec4a91c4","line":55,"updated":"2017-03-09 06:28:11.000000000","message":"TAP SF can present without any other SF also, which means from src to destination, only packet copy can also happen.","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0eb4823d14076e8684b25446d22a6a88184a4c37","unresolved":false,"context_lines":[{"line_number":52,"context_line":"OVS Integration bridge will add a tap to replicate packets received"},{"line_number":53,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of the passive"},{"line_number":54,"context_line":"Service Function (SF 1 on VM1). The other copy is sent to the ingress port (P2)"},{"line_number":55,"context_line":"of the next downstream Service Function (SF 2 on VM2)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_8ae55edd","line":55,"in_reply_to":"9a30ddce_63513d36","updated":"2017-03-09 16:56:45.000000000","message":"Perhaps you mean that it should be possible to have Port Chains made of TAP-insertion-mode PPGs only?","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"dfb7bef1e51fae80013269a6f8648d88c7382300","unresolved":false,"context_lines":[{"line_number":52,"context_line":"OVS Integration bridge will add a tap to replicate packets received"},{"line_number":53,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of the passive"},{"line_number":54,"context_line":"Service Function (SF 1 on VM1). The other copy is sent to the ingress port (P2)"},{"line_number":55,"context_line":"of the next downstream Service Function (SF 2 on VM2)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_52b8732a","line":55,"in_reply_to":"9a30ddce_8ae55edd","updated":"2017-03-09 20:37:10.000000000","message":"yes a Port Chain can be made up of TAP-insertion-mode PPGs only","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"5a5535f5a5a692630db07a3154a2c89ae0d89841","unresolved":false,"context_lines":[{"line_number":52,"context_line":"OVS Integration bridge will add a tap to replicate packets received"},{"line_number":53,"context_line":"from upstream SFs. One copy is sent to the ingress port (P1) of the passive"},{"line_number":54,"context_line":"Service Function (SF 1 on VM1). The other copy is sent to the ingress port (P2)"},{"line_number":55,"context_line":"of the next downstream Service Function (SF 2 on VM2)."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_63513d36","line":55,"in_reply_to":"9a30ddce_ec4a91c4","updated":"2017-03-09 15:36:19.000000000","message":"unclear what you mean: can you clarify?","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"988289178d2baad9f0679fdb8697938bd2b64492","unresolved":false,"context_lines":[{"line_number":117,"context_line":"REST API impact"},{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add \"insertion-mode\": \"tap\" to the port-pair-group-parameter."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Security impact"},{"line_number":123,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_29bd5f02","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":61},"updated":"2017-03-09 17:34:46.000000000","message":"Default value should also be presented in this spec, and should yield the result that networking-sfc has classically provided, i.e. something other than \"tap\". Maybe \"l3\" given how chaining is done today when an SFC Proxy is instantiated at every hop.\n\nSo there\u0027s a bit of a fuzzy line here. When using NSH and no SFC Proxies are instantiated... it\u0027s not L3 insertion type.\n\nI will come back with a proposal, but perhaps it\u0027s best to have a generic insertion mode for now, like None or \"default\" instead of specifically \"l3\" given that it will depend on other factors (the correlations).","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"dfb7bef1e51fae80013269a6f8648d88c7382300","unresolved":false,"context_lines":[{"line_number":117,"context_line":"REST API impact"},{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add \"insertion-mode\": \"tap\" to the port-pair-group-parameter."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Security impact"},{"line_number":123,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_3295bf3e","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":61},"in_reply_to":"9a30ddce_29bd5f02","updated":"2017-03-09 20:37:10.000000000","message":"ok","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"0eb4823d14076e8684b25446d22a6a88184a4c37","unresolved":false,"context_lines":[{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add \"insertion-mode\": \"tap\" to the port-pair-group-parameter."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Security impact"},{"line_number":123,"context_line":"---------------"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_0a1faeb7","line":121,"updated":"2017-03-09 16:56:45.000000000","message":"This is only a change in the validation of the specific port_pair_group_parameters dict.. the API ref will not change (besides documentation, I expect).","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"dfb7bef1e51fae80013269a6f8648d88c7382300","unresolved":false,"context_lines":[{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Add \"insertion-mode\": \"tap\" to the port-pair-group-parameter."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Security impact"},{"line_number":123,"context_line":"---------------"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_b28fef28","line":121,"in_reply_to":"9a30ddce_0a1faeb7","updated":"2017-03-09 20:37:10.000000000","message":"yes","commit_id":"33e204ccd3fed696e71202112b84702f697e366f"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"a821b93ff1bf74dd90d86306977e55a6184e9ba2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to all Service Functions (Port Pairs) in a Port"},{"line_number":33,"context_line":"Pair Group."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The port-pair-group-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":36,"context_line":"field. The \"insertion-mode\" field will apply to all Service Functions in"},{"line_number":37,"context_line":"the Port Pair Group. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":38,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffe62b97_6eec1129","line":35,"range":{"start_line":35,"start_character":58,"end_line":35,"end_character":72},"updated":"2017-03-27 01:13:27.000000000","message":"It was decided to add \"tap_enabled\" field also for TAP services. Let\u0027s say a operator gave both \"insertion_mode\" and \"tap_enabled\" ppg\u0027s port-pair-group-parameter. Then we will need to add additional validations for these.","commit_id":"968feb314063683df6211bd8308d4b1c765136be"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"103fc5fd5644ee50d8c969e30d5c501ea61e3770","unresolved":false,"context_lines":[{"line_number":32,"context_line":"configuration to be applied to all Service Functions (Port Pairs) in a Port"},{"line_number":33,"context_line":"Pair Group."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The port-pair-group-parameter will be enhanced to add an \"insertion-mode\""},{"line_number":36,"context_line":"field. The \"insertion-mode\" field will apply to all Service Functions in"},{"line_number":37,"context_line":"the Port Pair Group. This field is set to \"tap\" to indicate that the data-plane"},{"line_number":38,"context_line":"switch behavior will be to send the packets to the ingress port of the SF"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffe62b97_b99377a3","line":35,"range":{"start_line":35,"start_character":58,"end_line":35,"end_character":72},"in_reply_to":"ffe62b97_6eec1129","updated":"2017-03-27 10:07:02.000000000","message":"https://review.openstack.org/#/c/449754/2/doc/source/sfc_port_chain_tap.rst","commit_id":"968feb314063683df6211bd8308d4b1c765136be"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"7136f1dce460bf9bce865863ca7691f03287785c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"only send packets to the ingress port of the SF and not receive any packets"},{"line_number":43,"context_line":"from the egress port of the SF."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If \"insertion-mode\" is set to \"none\" or is not present then default behavior"},{"line_number":46,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"},{"line_number":47,"context_line":"Chain. A Port Chain can be made up of Port Pair Groups that all have a \"tap\""},{"line_number":48,"context_line":"insertion-mode."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a25e98e_0ce75b13","line":45,"range":{"start_line":45,"start_character":20,"end_line":45,"end_character":36},"updated":"2017-03-13 18:45:32.000000000","message":"either \"isn\u0027t set\" or \"is set to ``None``\"","commit_id":"968feb314063683df6211bd8308d4b1c765136be"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"3046ee0f01b395ac1b34e19b5a5cc6ce6421e569","unresolved":false,"context_lines":[{"line_number":42,"context_line":"only send packets to the ingress port of the SF and not receive any packets"},{"line_number":43,"context_line":"from the egress port of the SF."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If \"insertion-mode\" is set to \"none\" or is not present then default behavior"},{"line_number":46,"context_line":"will occur. The tap insertion-mode may be applied at any hop in the Port"},{"line_number":47,"context_line":"Chain. A Port Chain can be made up of Port Pair Groups that all have a \"tap\""},{"line_number":48,"context_line":"insertion-mode."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a25e98e_e00e7ee4","line":45,"range":{"start_line":45,"start_character":20,"end_line":45,"end_character":36},"in_reply_to":"7a25e98e_0ce75b13","updated":"2017-03-13 20:15:51.000000000","message":"\"or is not present\" should cover that","commit_id":"968feb314063683df6211bd8308d4b1c765136be"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"7136f1dce460bf9bce865863ca7691f03287785c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"-----------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Add \"insertion-mode\" to the Port Pair Group port-pair-group-parameter attribute."},{"line_number":118,"context_line":"The \"insertion-mode\" is set to \"none\" to disable the tap feature."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"REST API impact"},{"line_number":121,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a25e98e_8cb98bef","line":118,"range":{"start_line":118,"start_character":31,"end_line":118,"end_character":37},"updated":"2017-03-13 18:45:32.000000000","message":"ditto","commit_id":"968feb314063683df6211bd8308d4b1c765136be"}]}