)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"893c415a0dac90acb89b320ba558788201d9372a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikash082 \u003cvikash.kumar@oneconvergence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-25 22:06:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] API changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd4bf90d54f4edb443467b192e4e639fde749d4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_c1e099cf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"updated":"2017-03-25 23:32:39.000000000","message":"Doesnt explain anything which would help the reviewer understand what this change is","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"de9dd1754b5d33e52b7704bd71d195b18216b81f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikash082 \u003cvikash.kumar@oneconvergence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-25 22:06:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] API changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd4bf90d54f4edb443467b192e4e639fde749d4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_7744ef1b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"ffe62b97_c1e099cf","updated":"2017-03-26 05:51:31.000000000","message":"Will add more commit message.","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ea534cfb8f7ac027d845f9a8d1fcbcbe7efa5ae6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikash082 \u003cvikash.kumar@oneconvergence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-27 11:28:09 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] API changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"port-pair-group-parameters takes \u0027tap_enabled\u0027 as new field,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffe62b97_ffb9dfe8","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":9},"updated":"2017-03-27 10:55:52.000000000","message":"and CLI","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"4e6fb399d214ea3f62c01e0febf16f0b81b5b1ed","unresolved":false,"context_lines":[{"line_number":10,"context_line":"port-pair-group-parameters takes \u0027tap_enabled\u0027 as new field,"},{"line_number":11,"context_line":"value of which can be set to True/False. By default \u0027tap_enabled\u0027"},{"line_number":12,"context_line":"is set to False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icd4bf90d54f4edb443467b192e4e639fde749d4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"df140735_1f54d0c9","line":13,"updated":"2017-05-29 16:32:43.000000000","message":"Just a note for later: add a release notes file summarizing the changes: https://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes. You can see examples in past networking-sfc patches.","commit_id":"1037124fd8011b643f7bb0f55a2f13e0bae440e5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikash082 \u003cvikash.kumar@oneconvergence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 15:38:36 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API and CLI changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"df3967d1_42209bac","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":35},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vikash082 \u003cvikash.kumar@oneconvergence.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 15:38:36 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API and CLI changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bf3e73b7_4d340e4b","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":35},"in_reply_to":"df3967d1_42209bac","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API and CLI changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"},{"line_number":11,"context_line":"be set to True to configure the port-pairs as TAP SF. By default"},{"line_number":12,"context_line":"the attribute is set to False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"df3967d1_a22d07a9","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":46},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API and CLI changes for Passive TAP SF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"},{"line_number":11,"context_line":"be set to True to configure the port-pairs as TAP SF. By default"},{"line_number":12,"context_line":"the attribute is set to False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bf3e73b7_2d39ca40","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":46},"in_reply_to":"df3967d1_a22d07a9","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"},{"line_number":11,"context_line":"be set to True to configure the port-pairs as TAP SF. By default"},{"line_number":12,"context_line":"the attribute is set to False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icd4bf90d54f4edb443467b192e4e639fde749d4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"df3967d1_621ddf72","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":49},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces insertion of Passive TAP SF."},{"line_number":10,"context_line":"\u0027tap_enabled\u0027 attribute is added in port-pair-group, which can"},{"line_number":11,"context_line":"be set to True to configure the port-pairs as TAP SF. By default"},{"line_number":12,"context_line":"the attribute is set to False."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icd4bf90d54f4edb443467b192e4e639fde749d4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"bf3e73b7_0d3e0629","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":49},"in_reply_to":"df3967d1_621ddf72","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"}],"networking_sfc/cli/port_pair_group.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"893c415a0dac90acb89b320ba558788201d9372a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":80,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":81,"context_line":"        utils.add_boolean_argument("},{"line_number":82,"context_line":"            parser,"},{"line_number":83,"context_line":"            \u0027--tap-enabled\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":85,"context_line":"            help\u003d_(\u0027Specify the port-pair group is TAP device or not\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def args2body(self, parsed_args):"},{"line_number":88,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_a1e7d5e4","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":71},"updated":"2017-03-25 23:32:39.000000000","message":"If you are specifying that the Port Pair Group is TAP-Enabled/Disabled, then would it be a True/False flag or something else that you are expecting here...\nAs pr the commit message it looks like a simple flag","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"de9dd1754b5d33e52b7704bd71d195b18216b81f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":80,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":81,"context_line":"        utils.add_boolean_argument("},{"line_number":82,"context_line":"            parser,"},{"line_number":83,"context_line":"            \u0027--tap-enabled\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":85,"context_line":"            help\u003d_(\u0027Specify the port-pair group is TAP device or not\u0027))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def args2body(self, parsed_args):"},{"line_number":88,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_d7605ba8","line":85,"range":{"start_line":82,"start_character":0,"end_line":85,"end_character":71},"in_reply_to":"ffe62b97_a1e7d5e4","updated":"2017-03-26 05:51:31.000000000","message":"Its a flag only. ts like --tap-enabled True/False .","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        add_common_arguments(parser)"},{"line_number":72,"context_line":"        parser.add_argument("},{"line_number":73,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027[lb_fields\u003dLB_FIELDS, insertion_mode\u003dINSERTION_MODES]\u0027,"},{"line_number":75,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":76,"context_line":"                                                    \u0027insertion_mode\u0027]),"},{"line_number":77,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_a85e910f","line":74,"range":{"start_line":74,"start_character":43,"end_line":74,"end_character":73},"updated":"2017-03-26 20:09:56.000000000","message":"change insertion_mode to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"3eceedef21f8af867fc7109047cb5a7c9a0f7ec2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        add_common_arguments(parser)"},{"line_number":72,"context_line":"        parser.add_argument("},{"line_number":73,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027[lb_fields\u003dLB_FIELDS, insertion_mode\u003dINSERTION_MODES]\u0027,"},{"line_number":75,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":76,"context_line":"                                                    \u0027insertion_mode\u0027]),"},{"line_number":77,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_2e038211","line":74,"range":{"start_line":74,"start_character":43,"end_line":74,"end_character":73},"in_reply_to":"ffe62b97_2b171b54","updated":"2017-03-27 17:42:26.000000000","message":"see https://review.openstack.org/#/c/449754/","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"da2970701effe4759ea392e64ac4e1a67e13ee9e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        add_common_arguments(parser)"},{"line_number":72,"context_line":"        parser.add_argument("},{"line_number":73,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027[lb_fields\u003dLB_FIELDS, insertion_mode\u003dINSERTION_MODES]\u0027,"},{"line_number":75,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":76,"context_line":"                                                    \u0027insertion_mode\u0027]),"},{"line_number":77,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_2b171b54","line":74,"range":{"start_line":74,"start_character":43,"end_line":74,"end_character":73},"in_reply_to":"ffe62b97_a85e910f","updated":"2017-03-27 01:04:18.000000000","message":"can you add this in bp?","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027[lb_fields\u003dLB_FIELDS, insertion_mode\u003dINSERTION_MODES]\u0027,"},{"line_number":75,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":76,"context_line":"                                                    \u0027insertion_mode\u0027]),"},{"line_number":77,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"},{"line_number":78,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":79,"context_line":"                   \u0027and insertion_mode \\\u0027tap\\\u0027 and \\\u0027default\\\u0027 \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_689e49b9","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":67},"updated":"2017-03-26 20:09:56.000000000","message":"ditto","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                    \u0027insertion_mode\u0027]),"},{"line_number":77,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"},{"line_number":78,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":79,"context_line":"                   \u0027and insertion_mode \\\u0027tap\\\u0027 and \\\u0027default\\\u0027 \u0027"},{"line_number":80,"context_line":"                   \u0027mode is supported.\u0027))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_48a5c503","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":38},"updated":"2017-03-26 20:09:56.000000000","message":"ditto","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"76ba9dd72ad92da3cb735d0cd153c9104d580e92","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":77,"context_line":"                                                    \u0027ppg_n_tuple_mapping\u0027,"},{"line_number":78,"context_line":"                                                    \u0027tap_enabled\u0027]),"},{"line_number":79,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"},{"line_number":80,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields, \u0027"},{"line_number":81,"context_line":"                   \u0027ppg_n_tuple_mapping and tap_enabled True/False are \u0027"},{"line_number":82,"context_line":"                   \u0027supported. For ppg_n_tuple_mapping the supported command \u0027"},{"line_number":83,"context_line":"                   \u0027is \\\u0027key\u003dvalue\\\u0027 separated by \\\u0027\u0026\\\u0027. Support \u0027"},{"line_number":84,"context_line":"                   \u0027ppg_n_tuple_mapping keys are: source_ip_prefix_ingress, \u0027"},{"line_number":85,"context_line":"                   \u0027source_ip_prefix_egress, destination_ip_prefix_ingress, \u0027"},{"line_number":86,"context_line":"                   \u0027destination_ip_prefix_egress, source_port_ingress, \u0027"},{"line_number":87,"context_line":"                   \u0027source_port_egress, destination_port_ingress, \u0027"},{"line_number":88,"context_line":"                   \u0027destination_port_egress\u0027))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def args2body(self, parsed_args):"},{"line_number":91,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f0e0f27_34cfc980","line":88,"range":{"start_line":79,"start_character":20,"end_line":88,"end_character":44},"updated":"2017-06-09 15:03:22.000000000","message":"We could rework this now that we have multiple parameter (and make a clearer distinction between key and allowed values). Ideas?\n\nAlso, sync it with the OSC client part","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c6171ab510abb904689218dbcbd5f14d464b7224","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            type\u003dutils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":77,"context_line":"                                                    \u0027ppg_n_tuple_mapping\u0027,"},{"line_number":78,"context_line":"                                                    \u0027tap_enabled\u0027]),"},{"line_number":79,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"},{"line_number":80,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields, \u0027"},{"line_number":81,"context_line":"                   \u0027ppg_n_tuple_mapping and tap_enabled True/False are \u0027"},{"line_number":82,"context_line":"                   \u0027supported. For ppg_n_tuple_mapping the supported command \u0027"},{"line_number":83,"context_line":"                   \u0027is \\\u0027key\u003dvalue\\\u0027 separated by \\\u0027\u0026\\\u0027. Support \u0027"},{"line_number":84,"context_line":"                   \u0027ppg_n_tuple_mapping keys are: source_ip_prefix_ingress, \u0027"},{"line_number":85,"context_line":"                   \u0027source_ip_prefix_egress, destination_ip_prefix_ingress, \u0027"},{"line_number":86,"context_line":"                   \u0027destination_ip_prefix_egress, source_port_ingress, \u0027"},{"line_number":87,"context_line":"                   \u0027source_port_egress, destination_port_ingress, \u0027"},{"line_number":88,"context_line":"                   \u0027destination_port_egress\u0027))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def args2body(self, parsed_args):"},{"line_number":91,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_3d8e7778","line":88,"range":{"start_line":79,"start_character":20,"end_line":88,"end_character":44},"in_reply_to":"9f0e0f27_34cfc980","updated":"2017-06-12 07:24:33.000000000","message":"Hi Bernard I have tried to address the comment. Kindly review same.","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"9850f83438cd5159f4888943c4b14581b5087ab7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                                    \u0027ppg_n_tuple_mapping\u0027,"},{"line_number":78,"context_line":"                                                    \u0027tap_enabled\u0027]),"},{"line_number":79,"context_line":"            help\u003d_(\u0027Supported Port pair group parameters and allowed \u0027"},{"line_number":80,"context_line":"                   \u0027\\\u0027\u0026\\\u0027 separated values:  \u0027"},{"line_number":81,"context_line":"                   \u0027lb_fields\u003deth_src \u0026 eth_dst \u0026 \u0027"},{"line_number":82,"context_line":"                   \u0027ip_src \u0026 ip_dst \u0026 tcp_src \u0026 tcp_dst\u0027"},{"line_number":83,"context_line":"                   \u0027 \u0026 udp_src \u0026 udp_dst               \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_80d75ec0","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":22},"updated":"2017-06-12 08:13:45.000000000","message":"if you change outer quote to double quote, you will not need to escape this single quote","commit_id":"8746c6d90ed2467195258fc220931f6882c7d280"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"9fa948813d724364978259db4fb368095eb5eaaf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                                                    \u0027ppg_n_tuple_mapping\u0027,"},{"line_number":78,"context_line":"                                                    \u0027tap_enabled\u0027]),"},{"line_number":79,"context_line":"            help\u003d_(\u0027Supported Port pair group parameters and allowed \u0027"},{"line_number":80,"context_line":"                   \u0027\\\u0027\u0026\\\u0027 separated values:  \u0027"},{"line_number":81,"context_line":"                   \u0027lb_fields\u003deth_src \u0026 eth_dst \u0026 \u0027"},{"line_number":82,"context_line":"                   \u0027ip_src \u0026 ip_dst \u0026 tcp_src \u0026 tcp_dst\u0027"},{"line_number":83,"context_line":"                   \u0027 \u0026 udp_src \u0026 udp_dst               \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_6ec9d376","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":22},"in_reply_to":"7f231b9d_80d75ec0","updated":"2017-06-12 08:58:18.000000000","message":"Done","commit_id":"8746c6d90ed2467195258fc220931f6882c7d280"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"9850f83438cd5159f4888943c4b14581b5087ab7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                   \u0027 \u0026 udp_src \u0026 udp_dst               \u0027"},{"line_number":84,"context_line":"                   \u0027ppg_n_tuple_mapping\u003dsource_ip_prefix_ingress\u003d\\\u0027IP \u0027"},{"line_number":85,"context_line":"                   \u0027prefix\\\u0027 \u0026\u0027"},{"line_number":86,"context_line":"                   \u0027 source_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":87,"context_line":"                   \u0027 destination_ip_prefix_ingress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":88,"context_line":"                   \u0027 destination_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":89,"context_line":"                   \u0027 source_port_ingress\u003d\\\u0027Valid Port Number\\\u0027 \u0026\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_2062ca3f","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":21},"updated":"2017-06-12 08:13:45.000000000","message":"why is this space not at the end of line?","commit_id":"8746c6d90ed2467195258fc220931f6882c7d280"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"9fa948813d724364978259db4fb368095eb5eaaf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                   \u0027 \u0026 udp_src \u0026 udp_dst               \u0027"},{"line_number":84,"context_line":"                   \u0027ppg_n_tuple_mapping\u003dsource_ip_prefix_ingress\u003d\\\u0027IP \u0027"},{"line_number":85,"context_line":"                   \u0027prefix\\\u0027 \u0026\u0027"},{"line_number":86,"context_line":"                   \u0027 source_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":87,"context_line":"                   \u0027 destination_ip_prefix_ingress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":88,"context_line":"                   \u0027 destination_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":89,"context_line":"                   \u0027 source_port_ingress\u003d\\\u0027Valid Port Number\\\u0027 \u0026\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_0ea6dfc2","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":21},"in_reply_to":"7f231b9d_2062ca3f","updated":"2017-06-12 08:58:18.000000000","message":"Done","commit_id":"8746c6d90ed2467195258fc220931f6882c7d280"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"9b6c5aea46f9fc12a26266ce8b8e555541e10fc8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":89,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":90,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":91,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def args2body(self, parsed_args):"},{"line_number":94,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_544abeab","line":91,"updated":"2017-06-14 22:02:01.000000000","message":"This is getting pretty unwieldy. I think at some point we pass a threshold where it needs to be broken out into multiple separate parameters.","commit_id":"9cd61fdd94e8c2d39a72980ea8cb322cb773dae7"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"11cf0cd4aa19042102422c66ee10677d1610a645","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":89,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":90,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":91,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def args2body(self, parsed_args):"},{"line_number":94,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_b147cb4c","line":91,"in_reply_to":"7f231b9d_544abeab","updated":"2017-06-15 14:50:56.000000000","message":"We can discuss this in IRC. If it is likely to get expanded, probably we should think of separate API for port-pair-group-parameters.","commit_id":"9cd61fdd94e8c2d39a72980ea8cb322cb773dae7"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"e33d4023da50f6275377aa8f16aabea471dcdb84","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":89,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":90,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":91,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def args2body(self, parsed_args):"},{"line_number":94,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_c1947839","line":91,"in_reply_to":"7f231b9d_b147cb4c","updated":"2017-06-18 22:45:28.000000000","message":"Agree, lets discuss on IRC","commit_id":"9cd61fdd94e8c2d39a72980ea8cb322cb773dae7"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"07d70059aa59f914697e7be316c9c01aed42de85","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":89,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":90,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":91,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def args2body(self, parsed_args):"},{"line_number":94,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_7bc14c2e","line":91,"range":{"start_line":91,"start_character":19,"end_line":91,"end_character":43},"updated":"2017-07-03 16:38:37.000000000","message":"Suggest this is a separate option rather part of part pair group parameters","commit_id":"643cd2c42314bdc6528831422228442d8dac42bf"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"d9d34ba8dd60f30afbf3ce985c5057007f8eb053","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        parser,"},{"line_number":54,"context_line":"        \u0027--tap-enabled\u0027,"},{"line_number":55,"context_line":"        dest\u003d\u0027tap_enabled\u0027,"},{"line_number":56,"context_line":"        help\u003d_(\u0027Port-pairs in the port-pair-group belongs to TAP service\u0027"},{"line_number":57,"context_line":"               \u0027 functions or not.\u0027)"},{"line_number":58,"context_line":"    )"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bf3e73b7_a5bcaabb","line":56,"range":{"start_line":56,"start_character":61,"end_line":56,"end_character":64},"updated":"2017-08-06 20:11:45.000000000","message":"Tap","commit_id":"557c2b1275e1f2df3e2a8fc4022d94f4d5636228"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"d3ec3a710bc287123dc1ac8f73b68fe2c259164e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027ID or name of the Port Pair. \u0027"},{"line_number":51,"context_line":"               \u0027This option can be repeated.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def update_common_args2body(client, body, parsed_args):"},{"line_number":55,"context_line":"    if parsed_args.port_pairs:"},{"line_number":56,"context_line":"        body[\u0027port_pairs\u0027] \u003d [(pp.get_port_pair_id(client, pp1))"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_c4b7b2d8","line":53,"updated":"2017-08-08 13:48:52.000000000","message":"This file should be removed. No further changes should be made to the CLI and actually all CLI should be removed altogether. Unless there was some deprecation period agreed? Louis, Cathy? Even if there was, existing CLI should not be changed.","commit_id":"371ec6769c22ee46a32bc4733c5d4a315c9449a0"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c328716521b6f4bfac2b5c9a011bc0bb13093495","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               \u0027This option can be repeated.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def update_common_args2body(client, body, parsed_args):"},{"line_number":55,"context_line":"    if parsed_args.port_pairs:"},{"line_number":56,"context_line":"        body[\u0027port_pairs\u0027] \u003d [(pp.get_port_pair_id(client, pp1))"},{"line_number":57,"context_line":"                              for pp1 in parsed_args.port_pairs]"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f5c4f37_6d08df27","line":54,"updated":"2017-09-21 12:19:07.000000000","message":"As Igor mentioned, I think we should let the old CLI rest and focus on OSC one (now that it is merged, and the neutron CLI showing deprecated warnings on each run)","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"47719f235cdbdde36c1ba3010ed94555392b71b0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               \u0027This option can be repeated.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def update_common_args2body(client, body, parsed_args):"},{"line_number":55,"context_line":"    if parsed_args.port_pairs:"},{"line_number":56,"context_line":"        body[\u0027port_pairs\u0027] \u003d [(pp.get_port_pair_id(client, pp1))"},{"line_number":57,"context_line":"                              for pp1 in parsed_args.port_pairs]"}],"source_content_type":"text/x-python","patch_set":24,"id":"7f515b1d_17cf3b80","line":54,"in_reply_to":"9f5c4f37_6d08df27","updated":"2017-09-22 05:25:20.000000000","message":"Sorry, I am just back from vacation. I will remove the old cli files, once test cases failing for extension is resolved.","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"}],"networking_sfc/db/migration/alembic_migrations/versions/pike/expand/4fe093637f79_ppg_tap_mode_support.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"893c415a0dac90acb89b320ba558788201d9372a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_01d681f2","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":26},"updated":"2017-03-25 23:32:39.000000000","message":"If this is a new file, then why do you have 2015 here...\nIs it 2 year old patch :D","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"de9dd1754b5d33e52b7704bd71d195b18216b81f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_97cc13bd","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":26},"in_reply_to":"ffe62b97_01d681f2","updated":"2017-03-26 05:51:31.000000000","message":"This got generated from the script. Will fix this though. Thanks for pointing this. :)","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"}],"networking_sfc/db/migration/alembic_migrations/versions/pike/expand/d6fb381b65f2_tap_enabled_attribute_port_pair_group.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c328716521b6f4bfac2b5c9a011bc0bb13093495","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f5c4f37_e203be0e","line":1,"updated":"2017-09-21 12:19:07.000000000","message":"As others: should be moved to queens","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"}],"networking_sfc/db/sfc_db.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"bddb700c4a7ca0e78c64e802041dd1d7eb71c168","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    group_id \u003d sa.Column(sa.Integer(), unique\u003dTrue, nullable\u003dFalse)"},{"line_number":147,"context_line":"    name \u003d sa.Column(sa.String(db_const.NAME_FIELD_SIZE))"},{"line_number":148,"context_line":"    description \u003d sa.Column(sa.String(db_const.DESCRIPTION_FIELD_SIZE))"},{"line_number":149,"context_line":"    tap_enabled \u003d sa.Column(sa.Boolean)"},{"line_number":150,"context_line":"    port_pairs \u003d orm.relationship("},{"line_number":151,"context_line":"        PortPair,"},{"line_number":152,"context_line":"        backref\u003d\u0027port_pair_group\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_54744c68","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":15},"updated":"2017-03-25 16:45:50.000000000","message":"Add to port_pair_group_parameters attribute, not separate attribute","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"893c415a0dac90acb89b320ba558788201d9372a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    group_id \u003d sa.Column(sa.Integer(), unique\u003dTrue, nullable\u003dFalse)"},{"line_number":147,"context_line":"    name \u003d sa.Column(sa.String(db_const.NAME_FIELD_SIZE))"},{"line_number":148,"context_line":"    description \u003d sa.Column(sa.String(db_const.DESCRIPTION_FIELD_SIZE))"},{"line_number":149,"context_line":"    tap_enabled \u003d sa.Column(sa.Boolean)"},{"line_number":150,"context_line":"    port_pairs \u003d orm.relationship("},{"line_number":151,"context_line":"        PortPair,"},{"line_number":152,"context_line":"        backref\u003d\u0027port_pair_group\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e106fd86","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":15},"in_reply_to":"ffe62b97_54744c68","updated":"2017-03-25 23:32:39.000000000","message":"And its default value, false , which you mentioned in the migration script","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            for pg_id in pg_ids:"},{"line_number":219,"context_line":"                pg \u003d self._get_port_pair_group(context, pg_id)"},{"line_number":220,"context_line":"                curr_pg_tap_enabled \u003d pg[\u0027tap_enabled\u0027]"},{"line_number":221,"context_line":"                if last_pg_tap_enabled and curr_pg_tap_enabled:"},{"line_number":222,"context_line":"                    raise ext_sfc.ConsecutiveTAPPPGNotSupported()"},{"line_number":223,"context_line":"                else:"},{"line_number":224,"context_line":"                    last_pg_tap_enabled \u003d curr_pg_tap_enabled"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_821b23c8","line":221,"range":{"start_line":221,"start_character":19,"end_line":221,"end_character":23},"updated":"2017-08-04 15:52:44.000000000","message":"use \"previous\": prev_pg_tap_enabled","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            for pg_id in pg_ids:"},{"line_number":219,"context_line":"                pg \u003d self._get_port_pair_group(context, pg_id)"},{"line_number":220,"context_line":"                curr_pg_tap_enabled \u003d pg[\u0027tap_enabled\u0027]"},{"line_number":221,"context_line":"                if last_pg_tap_enabled and curr_pg_tap_enabled:"},{"line_number":222,"context_line":"                    raise ext_sfc.ConsecutiveTAPPPGNotSupported()"},{"line_number":223,"context_line":"                else:"},{"line_number":224,"context_line":"                    last_pg_tap_enabled \u003d curr_pg_tap_enabled"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_ed3aa232","line":221,"range":{"start_line":221,"start_character":19,"end_line":221,"end_character":23},"in_reply_to":"df3967d1_821b23c8","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"}],"networking_sfc/extensions/sfc.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"893c415a0dac90acb89b320ba558788201d9372a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        },"},{"line_number":323,"context_line":"        \u0027tap_enabled\u0027: {"},{"line_number":324,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":325,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: DEFAULT_TAB_ENABLED,"},{"line_number":326,"context_line":"            \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":327,"context_line":"        }"},{"line_number":328,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_21f4e585","line":325,"range":{"start_line":325,"start_character":43,"end_line":325,"end_character":62},"updated":"2017-03-25 23:32:39.000000000","message":"ths constant is a misnomer to the actual behavior","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"de9dd1754b5d33e52b7704bd71d195b18216b81f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        },"},{"line_number":323,"context_line":"        \u0027tap_enabled\u0027: {"},{"line_number":324,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":325,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: DEFAULT_TAB_ENABLED,"},{"line_number":326,"context_line":"            \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":327,"context_line":"        }"},{"line_number":328,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b73a7795","line":325,"range":{"start_line":325,"start_character":43,"end_line":325,"end_character":62},"in_reply_to":"ffe62b97_21f4e585","updated":"2017-03-26 05:51:31.000000000","message":"Will change","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"DEFAULT_CHAIN_CORRELATION \u003d \u0027mpls\u0027"},{"line_number":42,"context_line":"DEFAULT_CHAIN_SYMMETRY \u003d False"},{"line_number":43,"context_line":"DEFAULT_INSERTION_MODE \u003d None"},{"line_number":44,"context_line":"DEFAULT_CHAIN_PARAMETERS \u003d {\u0027correlation\u0027: DEFAULT_CHAIN_CORRELATION,"},{"line_number":45,"context_line":"                            \u0027symmetric\u0027: DEFAULT_CHAIN_SYMMETRY}"},{"line_number":46,"context_line":"DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_28a841d9","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":22},"updated":"2017-03-26 20:09:56.000000000","message":"change to TAP_ENABLED","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                            \u0027symmetric\u0027: DEFAULT_CHAIN_SYMMETRY}"},{"line_number":46,"context_line":"DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"},{"line_number":47,"context_line":"DEFAULT_PPG_PARAMETERS \u003d {\u0027lb_fields\u0027: [],"},{"line_number":48,"context_line":"                          \u0027insertion_mode\u0027: DEFAULT_INSERTION_MODE}"},{"line_number":49,"context_line":"SUPPORTED_LB_FIELDS \u003d ["},{"line_number":50,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":51,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_08afbde3","line":48,"range":{"start_line":48,"start_character":27,"end_line":48,"end_character":41},"updated":"2017-03-26 20:09:56.000000000","message":"change to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \"eth_src\", \"eth_dst\", \"ip_src\", \"ip_dst\","},{"line_number":51,"context_line":"    \"tcp_src\", \"tcp_dst\", \"udp_src\", \"udp_dst\""},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":"INSERTION_MODE_TAP \u003d \"tap\""},{"line_number":54,"context_line":"INSERTION_MODE_DEFAULT \u003d None"},{"line_number":55,"context_line":"SUPPORTED_INSERTION_MODES \u003d [INSERTION_MODE_TAP, INSERTION_MODE_DEFAULT]"},{"line_number":56,"context_line":"MAX_CHAIN_ID \u003d 65535"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e8a939dd","line":53,"range":{"start_line":53,"start_character":1,"end_line":53,"end_character":26},"updated":"2017-03-26 20:09:56.000000000","message":"change to tap enabled.","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                        \u0027default\u0027: DEFAULT_PPG_PARAMETERS[\u0027lb_fields\u0027],"},{"line_number":320,"context_line":"                        \u0027type:list_of_allowed_values\u0027: SUPPORTED_LB_FIELDS"},{"line_number":321,"context_line":"                    },"},{"line_number":322,"context_line":"                    \u0027insertion_mode\u0027: {"},{"line_number":323,"context_line":"                        \u0027default\u0027: DEFAULT_PPG_PARAMETERS[\u0027insertion_mode\u0027],"},{"line_number":324,"context_line":"                        \u0027type:values\u0027: SUPPORTED_INSERTION_MODES"},{"line_number":325,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_c8b8b52b","line":322,"range":{"start_line":322,"start_character":21,"end_line":322,"end_character":35},"updated":"2017-03-26 20:09:56.000000000","message":"change to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ea534cfb8f7ac027d845f9a8d1fcbcbe7efa5ae6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"DEFAULT_CHAIN_CORRELATION \u003d \u0027mpls\u0027"},{"line_number":42,"context_line":"DEFAULT_CHAIN_SYMMETRY \u003d False"},{"line_number":43,"context_line":"TAP_ENABLED \u003d False"},{"line_number":44,"context_line":"DEFAULT_CHAIN_PARAMETERS \u003d {\u0027correlation\u0027: DEFAULT_CHAIN_CORRELATION,"},{"line_number":45,"context_line":"                            \u0027symmetric\u0027: DEFAULT_CHAIN_SYMMETRY}"},{"line_number":46,"context_line":"DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_ffae7f96","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":11},"updated":"2017-03-27 10:55:52.000000000","message":"DEFAULT_TAP_ENABLED","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"3f67e8bb74cc0d72c1c19fa2e6c26e45ea470397","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"DEFAULT_CHAIN_CORRELATION \u003d \u0027mpls\u0027"},{"line_number":42,"context_line":"DEFAULT_CHAIN_SYMMETRY \u003d False"},{"line_number":43,"context_line":"TAP_ENABLED \u003d False"},{"line_number":44,"context_line":"DEFAULT_CHAIN_PARAMETERS \u003d {\u0027correlation\u0027: DEFAULT_CHAIN_CORRELATION,"},{"line_number":45,"context_line":"                            \u0027symmetric\u0027: DEFAULT_CHAIN_SYMMETRY}"},{"line_number":46,"context_line":"DEFAULT_SF_PARAMETERS \u003d {\u0027correlation\u0027: None, \u0027weight\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_0571d0e0","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":11},"in_reply_to":"ffe62b97_ffae7f96","updated":"2017-03-27 11:28:16.000000000","message":"Will fix this.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(neutron_exc.InvalidInput):"},{"line_number":201,"context_line":"    \"\"\"Multiple Port Pairs in TAP PPG not allowed\"\"\""},{"line_number":202,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed.\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ConsecutiveTAPPPGNotSupported(neutron_exc.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_82a56349","line":202,"range":{"start_line":202,"start_character":40,"end_line":202,"end_character":43},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(neutron_exc.InvalidInput):"},{"line_number":201,"context_line":"    \"\"\"Multiple Port Pairs in TAP PPG not allowed\"\"\""},{"line_number":202,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed.\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ConsecutiveTAPPPGNotSupported(neutron_exc.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_cd47debc","line":202,"range":{"start_line":202,"start_character":40,"end_line":202,"end_character":43},"in_reply_to":"df3967d1_82a56349","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ConsecutiveTAPPPGNotSupported(neutron_exc.InvalidInput):"},{"line_number":206,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":207,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now.\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"def normalize_port_pair_groups(port_pair_groups):"}],"source_content_type":"text/x-python","patch_set":19,"id":"df3967d1_026f33fc","line":207,"range":{"start_line":207,"start_character":29,"end_line":207,"end_character":32},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class ConsecutiveTAPPPGNotSupported(neutron_exc.InvalidInput):"},{"line_number":206,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":207,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now.\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"def normalize_port_pair_groups(port_pair_groups):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf3e73b7_ad449ab8","line":207,"range":{"start_line":207,"start_character":29,"end_line":207,"end_character":32},"in_reply_to":"df3967d1_026f33fc","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f44bbd4f16f6eb1ac6be72748538a48e01d75e06","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":393,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: DEFAULT_TAP_ENABLED,"},{"line_number":394,"context_line":"            \u0027convert_to\u0027: lib_converters.convert_to_boolean"},{"line_number":395,"context_line":"        },"},{"line_number":396,"context_line":"        \u0027port_pair_group_parameters\u0027: {"},{"line_number":397,"context_line":"            \u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":398,"context_line":"            \u0027is_visible\u0027: True, \u0027default\u0027: None,"}],"source_content_type":"text/x-python","patch_set":22,"id":"bf3e73b7_f7c4a042","line":395,"updated":"2017-08-07 06:09:23.000000000","message":"This is an API change, so you need to add a new extension rather than changing the existing API extension.","commit_id":"1c972a4d6f18bde36f812f376d90d983410dce82"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f44bbd4f16f6eb1ac6be72748538a48e01d75e06","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                            }"},{"line_number":423,"context_line":"                        },"},{"line_number":424,"context_line":"                        \u0027convert_to\u0027: lib_converters.convert_none_to_empty_dict"},{"line_number":425,"context_line":"                    },"},{"line_number":426,"context_line":"                }"},{"line_number":427,"context_line":"            },"},{"line_number":428,"context_line":"            \u0027convert_to\u0027: normalize_ppg_parameters"}],"source_content_type":"text/x-python","patch_set":22,"id":"bf3e73b7_b7dcd818","line":425,"range":{"start_line":425,"start_character":21,"end_line":425,"end_character":22},"updated":"2017-08-07 06:09:23.000000000","message":"unrelated","commit_id":"1c972a4d6f18bde36f812f376d90d983410dce82"}],"networking_sfc/extensions/tap.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"cd864d5fcbccf047a701b4b3cd9b4bb7bd5fc97f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class Tap(extensions.ExtensionDescriptor):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7f515b1d_9ef21c06","line":46,"updated":"2017-09-22 13:03:27.000000000","message":"Apart from the test cases, is this new extension working fine for you?","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"b38d372fac3697f10dbf2b1ce039a5fefdb3dd55","unresolved":false,"context_lines":[{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class Tap(extensions.ExtensionDescriptor):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7f515b1d_cd732b80","line":46,"in_reply_to":"7f515b1d_9ef21c06","updated":"2017-09-25 05:28:15.000000000","message":"yes, i tested on the system before uploading the patch, it worked fine. Are you able to see your extension in :\n\n\u0027neutron ext-list\u0027 ?","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6b913e365ca2313396b029b56c59cce2d236e659","unresolved":false,"context_lines":[{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class Tap(extensions.ExtensionDescriptor):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7f515b1d_c3608ca8","line":46,"in_reply_to":"7f515b1d_cd732b80","updated":"2017-10-11 09:49:45.000000000","message":"It\u0027s working fine now, thanks.. get_resources wasn\u0027t correct..","commit_id":"456630c3ed4fcc372a0f38c102edf3316bcd1ce4"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api import extensions"},{"line_number":19,"context_line":"from neutron_lib import exceptions as neutron_exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DEFAULT_TAP_ENABLED \u003d False"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_776a81b3","line":21,"updated":"2017-10-13 10:43:39.000000000","message":"This class could use a global description alias that can be used around in the repo, like:\nTAP_EXT\u003d\"networking-sfc-tap\"","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron_lib.api import extensions"},{"line_number":19,"context_line":"from neutron_lib import exceptions as neutron_exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DEFAULT_TAP_ENABLED \u003d False"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_5bf6c7fb","line":21,"in_reply_to":"5f4e5783_776a81b3","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def get_updated(cls):"},{"line_number":62,"context_line":"        return \"2017-08-07T10:00:00-00:00\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_extended_resources(self, version):"},{"line_number":65,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_f77671a4","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":26},"updated":"2017-10-13 10:43:39.000000000","message":"Probably worth setting something more recent, service graphs went in with 2017-09-20","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def get_updated(cls):"},{"line_number":62,"context_line":"        return \"2017-08-07T10:00:00-00:00\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_extended_resources(self, version):"},{"line_number":65,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_3bdd4b70","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":26},"in_reply_to":"5f4e5783_f77671a4","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @classmethod"},{"line_number":61,"context_line":"    def get_updated(cls):"},{"line_number":62,"context_line":"        return \"2017-08-07T10:00:00-00:00\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_extended_resources(self, version):"},{"line_number":65,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_127c7bb3","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":26},"in_reply_to":"5f4e5783_f77671a4","updated":"2017-10-13 12:04:20.000000000","message":"OK","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"}],"networking_sfc/osc/sfc/port_pair_group.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"bddb700c4a7ca0e78c64e802041dd1d7eb71c168","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":59,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--tap-enabled\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027TAP_ENABLED\u0027,"},{"line_number":63,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":64,"context_line":"            action\u003d\u0027store_false\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_346f8893","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":28},"updated":"2017-03-25 16:45:50.000000000","message":"Add to port-port-group-parameters","commit_id":"78c1dd0aeb40ba27553c0692fa8ed6f6fc26762b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":53,"context_line":"        parser.add_argument("},{"line_number":54,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":55,"context_line":"            metavar\u003d\u0027[lb_fields\u003dLB_FIELDS, insertion_mode\u003dINSERTION_MODES]\u0027,"},{"line_number":56,"context_line":"            type\u003dnc_utils.str2dict_type(optional_keys\u003d[\u0027lb_fields\u0027,"},{"line_number":57,"context_line":"                                                       \u0027insertion_mode\u0027]),"},{"line_number":58,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8884ed5f","line":55,"range":{"start_line":55,"start_character":43,"end_line":55,"end_character":57},"updated":"2017-03-26 20:09:56.000000000","message":"change to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                                       \u0027insertion_mode\u0027]),"},{"line_number":58,"context_line":"            help\u003d_(\u0027Dictionary of Port pair group parameters. \u0027"},{"line_number":59,"context_line":"                   \u0027Currently, \\\u0027\u0026\\\u0027 separated string of the lb_fields and \u0027"},{"line_number":60,"context_line":"                   \u0027insertion_mode are supported.\u0027))"},{"line_number":61,"context_line":"        return parser"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_68876963","line":60,"range":{"start_line":60,"start_character":20,"end_line":60,"end_character":34},"updated":"2017-03-26 20:09:56.000000000","message":"ditto","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"76ba9dd72ad92da3cb735d0cd153c9104d580e92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f0e0f27_141e050c","line":1,"updated":"2017-06-09 15:03:22.000000000","message":"I hope we will have the osc client merged soon in python-neutronclient, else there will be more and more parts to remember to update (like this one)","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9e659dff98701709c5a7071dda5c0a2acdd8b290","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_a79597e6","line":1,"in_reply_to":"7f231b9d_fdd6bf4f","updated":"2017-06-13 15:09:23.000000000","message":"Not yet, just noting that once https://review.openstack.org/#/c/409759/ is merged, we should check that everything was (or will be) moved properly to python-neutronclient. But for now, yes please keep updating it here","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c6171ab510abb904689218dbcbd5f14d464b7224","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_fdd6bf4f","line":1,"in_reply_to":"9f0e0f27_141e050c","updated":"2017-06-12 07:24:33.000000000","message":"Do you mean this should be removed ?","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"9850f83438cd5159f4888943c4b14581b5087ab7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                                       \u0027ppg_n_tuple_mapping\u0027,"},{"line_number":59,"context_line":"                                                       \u0027tap_enabled\u0027]),"},{"line_number":60,"context_line":"            help\u003d_(\u0027Supported Port pair group parameters and allowed \u0027"},{"line_number":61,"context_line":"                   \u0027\\\u0027\u0026\\\u0027 separated values:  \u0027"},{"line_number":62,"context_line":"                   \u0027lb_fields\u003deth_src \u0026 eth_dst \u0026 \u0027"},{"line_number":63,"context_line":"                   \u0027ip_src \u0026 ip_dst \u0026 tcp_src \u0026 tcp_dst\u0027"},{"line_number":64,"context_line":"                   \u0027 \u0026 udp_src \u0026 udp_dst               \u0027"},{"line_number":65,"context_line":"                   \u0027ppg_n_tuple_mapping\u003dsource_ip_prefix_ingress\u003d\\\u0027IP \u0027"},{"line_number":66,"context_line":"                   \u0027prefix\\\u0027 \u0026\u0027"},{"line_number":67,"context_line":"                   \u0027 source_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":68,"context_line":"                   \u0027 destination_ip_prefix_ingress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":69,"context_line":"                   \u0027 destination_ip_prefix_egress\u003d\\\u0027IP prefix\\\u0027 \u0026\u0027"},{"line_number":70,"context_line":"                   \u0027 source_port_ingress\u003d\\\u0027Valid Port Number\\\u0027 \u0026\u0027"},{"line_number":71,"context_line":"                   \u0027 source_port_egress\u003d\\\u0027Valid Port Number\\\u0027 \u0026\u0027"},{"line_number":72,"context_line":"                   \u0027 destination_port_ingress\u003d\\\u0027Valid Port Number\\\u0027 \u0026\u0027"},{"line_number":73,"context_line":"                   \u0027 destination_port_egress\u003d\\\u0027Valid Port Number\\\u0027\u0027"},{"line_number":74,"context_line":"                   \u0027 tap_enabled\u003dTrue/False\u0027))"},{"line_number":75,"context_line":"        return parser"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_20be4a65","line":74,"range":{"start_line":61,"start_character":20,"end_line":74,"end_character":46},"updated":"2017-06-12 08:13:45.000000000","message":"this too","commit_id":"8746c6d90ed2467195258fc220931f6882c7d280"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"13b734e7c4b7efd675ce471dcbe276f34220bd0b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":70,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":71,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":72,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":73,"context_line":"        return parser"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff346bd7_aa41aa0d","line":72,"updated":"2017-07-26 12:09:06.000000000","message":"OSC client plugin is merged, so this should now be moved in a separate patch to python-neutronclient (probably depending on this patchset)","commit_id":"643cd2c42314bdc6528831422228442d8dac42bf"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"994d5bbce074e8b172349aaff71030c4f3b19b93","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   \"source_port_egress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":70,"context_line":"                   \"destination_port_ingress\u003d\u0027Valid Port Number\u0027 \u0026 \""},{"line_number":71,"context_line":"                   \"destination_port_egress\u003d\u0027Valid Port Number\u0027 \""},{"line_number":72,"context_line":"                   \"tap_enabled\u003dTrue/False\"))"},{"line_number":73,"context_line":"        return parser"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff346bd7_cf8e0e78","line":72,"in_reply_to":"ff346bd7_aa41aa0d","updated":"2017-07-27 13:57:58.000000000","message":"OK will move to separate patch.","commit_id":"643cd2c42314bdc6528831422228442d8dac42bf"}],"networking_sfc/services/sfc/common/exceptions.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"There is no %(type)s assigned.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_487ee56b","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":16},"updated":"2017-03-26 20:09:56.000000000","message":"Tap","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_2881614b","line":54,"range":{"start_line":54,"start_character":17,"end_line":54,"end_character":51},"updated":"2017-03-26 20:09:56.000000000","message":"not sure what this means? However, more than one sequential PPG in a port chain can act as a tap. A use case would be a port chain that has one PPG with passive monitoring  SFs, and another PPG with passive IDS SFs.","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"da2970701effe4759ea392e64ac4e1a67e13ee9e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_4e570d04","line":54,"range":{"start_line":54,"start_character":17,"end_line":54,"end_character":51},"in_reply_to":"ffe62b97_2881614b","updated":"2017-03-27 01:04:18.000000000","message":"Then the 2 IDS in the said use case should belong to same PPG and both will get a copy. Consecutive Passive TAPs cannot be deployed.","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"cd864d5fcbccf047a701b4b3cd9b4bb7bd5fc97f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_a8bfb7ce","line":54,"range":{"start_line":54,"start_character":17,"end_line":54,"end_character":51},"in_reply_to":"ffe62b97_41f1f7cc","updated":"2017-09-22 13:03:27.000000000","message":"And you","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"3eceedef21f8af867fc7109047cb5a7c9a0f7ec2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_41f1f7cc","line":54,"range":{"start_line":54,"start_character":17,"end_line":54,"end_character":51},"in_reply_to":"ffe62b97_4e570d04","updated":"2017-03-27 17:42:26.000000000","message":"No, the PPG is used for scaling of SFs of the same type, for example all SFs in a PPG would be IDS SFs, or all VOpt SFs. The case cited needs two PPGs: one containing one or more passive monitoring SFs and another PPG containing one or more IDS SFs.","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ea534cfb8f7ac027d845f9a8d1fcbcbe7efa5ae6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_7fef0fb0","line":54,"range":{"start_line":53,"start_character":17,"end_line":54,"end_character":72},"updated":"2017-03-27 10:55:52.000000000","message":"Hmm so only 1 location per port-chain?","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"3f67e8bb74cc0d72c1c19fa2e6c26e45ea470397","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_c5d648c4","line":54,"range":{"start_line":53,"start_character":17,"end_line":54,"end_character":72},"in_reply_to":"ffe62b97_7fef0fb0","updated":"2017-03-27 11:28:16.000000000","message":"No, its like one can\u0027t specify like src -\u003e TAP PPG -\u003e TAP PPG -\u003e DEFAULT PPG -\u003e DEST . Can we realize consecutive TAP ? :)\n\nHowever, src -\u003e TAP PPG -\u003e DEFAULT PPG -\u003e TAP PPG -\u003e DEST should be fine. \n\nThere can be multiple TAP PPs in a single PPG and each should get the copy.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f162f436190c3b40cd8f3a5de4b582e57f101951","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"There is no %(type)s assigned.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class InvalidTAPDeployment(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Invalid TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Invalid TAP Port-Pair-Group deployment. TAP PPG cannot be \""},{"line_number":54,"context_line":"                \"deployed consecutive in port-chain. %(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_41f45786","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":26},"updated":"2017-03-27 17:47:54.000000000","message":"see comment on PS2","commit_id":"334c41f73d426b96df54be1265879fb86dc1c37c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"c68f57231dbd7c8ad30a95fc1bb38db506c6e7b7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"There is no %(type)s assigned.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_a88d7732","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":35},"updated":"2017-05-16 15:45:06.000000000","message":"From your earlier response, this exception should already be handled by networking-sfc as you already can\u0027t have a PPG consecutively multiple times in a port-chain (before this patch).","commit_id":"39855f31368cfd339897df99c6b271a642509add"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e986234417033bdd9d37329a1362cf29eaccd9e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"There is no %(type)s assigned.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_cf491d61","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":35},"in_reply_to":"1f013ff3_a88d7732","updated":"2017-05-17 14:10:47.000000000","message":"I didn\u0027t understand the part \u0027exception should already be handled by networking-sfc\u0027. Can you please clarify further?","commit_id":"39855f31368cfd339897df99c6b271a642509add"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"9638fef6d328d7242211263dcf679015dc216b5b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_89113360","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":71},"updated":"2017-05-23 17:53:13.000000000","message":"why is this a restriction?","commit_id":"28dca295f7023d855d5d499308e22fb13b2b4152"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1d67a5219314c8b4a530a2758015b305b345401c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_ac01973a","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":71},"in_reply_to":"ff0f0b1f_89113360","updated":"2017-05-24 04:16:36.000000000","message":"Didn\u0027t found a uniform way to realise this. This is a case where user can provide \u0027n\u0027 TAP consecutively. For TAP SF, SRC Port attributes acts as classifier and for all \u0027n\u0027 SFs source is going to be same. So the question is,  based on what attr  classification will happen and traffic will redirected to appropriate SF. I have kept this for future enhancement. I guess because of similar limitations even TAAS doesn\u0027t support this scenario.","commit_id":"28dca295f7023d855d5d499308e22fb13b2b4152"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"074d2255af5d530b743c1e1e3b3c40f5a4233bb6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_3b133a10","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":50},"updated":"2017-05-28 23:25:23.000000000","message":"Add some explanation in the OVS driver patch from the discussion in the networking-sfc meeting http://eavesdrop.openstack.org/meetings/service_chaining/2017/service_chaining.2017-05-25-17.00.log.html","commit_id":"1037124fd8011b643f7bb0f55a2f13e0bae440e5"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6daa0a1a992a67ae26d8d845e89282507f7776a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_bcb737d9","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":50},"in_reply_to":"df140735_3b133a10","updated":"2017-05-29 12:15:10.000000000","message":"Should we use any existing spec or a new spec to explain the working ? Or just comment in code (ovs driver) would suffice ?","commit_id":"1037124fd8011b643f7bb0f55a2f13e0bae440e5"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"7ea1bee38d613b8a1410bbd04e1039f0182b641d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_95032043","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":50},"in_reply_to":"df140735_bcb737d9","updated":"2017-05-29 20:49:37.000000000","message":"Update the spec https://review.openstack.org/#/c/449754/3/doc/source/sfc_port_chain_tap.rst","commit_id":"1037124fd8011b643f7bb0f55a2f13e0bae440e5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39a6f769f619ed94f9ade4f3e216bb54c3c60a9c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f0e0f27_5627e565","line":53,"range":{"start_line":53,"start_character":68,"end_line":53,"end_character":72},"updated":"2017-06-09 13:19:55.000000000","message":"missing space","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c6171ab510abb904689218dbcbd5f14d464b7224","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now\""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_9daeabe5","line":53,"range":{"start_line":53,"start_character":68,"end_line":53,"end_character":72},"in_reply_to":"9f0e0f27_5627e565","updated":"2017-06-12 07:24:33.000000000","message":"Done","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"76ba9dd72ad92da3cb735d0cd153c9104d580e92","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed\""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_f6960095","line":57,"updated":"2017-06-09 15:03:22.000000000","message":"I suppose this is a \"for now\" too limitation?","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9e659dff98701709c5a7071dda5c0a2acdd8b290","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed\""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_e7594f5a","line":57,"in_reply_to":"7f231b9d_dd7d436f","updated":"2017-06-13 15:09:23.000000000","message":"OK, thanks!","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c6171ab510abb904689218dbcbd5f14d464b7224","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                \"%(method)s failed.\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed\""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_dd7d436f","line":57,"in_reply_to":"7f231b9d_f6960095","updated":"2017-06-12 07:24:33.000000000","message":"Looking for ways to address this, if possible.","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39a6f769f619ed94f9ade4f3e216bb54c3c60a9c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed\""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f0e0f27_362c7146","line":58,"range":{"start_line":58,"start_character":67,"end_line":58,"end_character":75},"updated":"2017-06-09 13:19:55.000000000","message":"missing space","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c6171ab510abb904689218dbcbd5f14d464b7224","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed\""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f231b9d_9d97cb91","line":58,"range":{"start_line":58,"start_character":67,"end_line":58,"end_character":75},"in_reply_to":"9f0e0f27_362c7146","updated":"2017-06-12 07:24:33.000000000","message":"Done","commit_id":"e46bca7bdbc00c9619df5cd13270ed77989da1a6"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2982223aa4339069708f179a43daa1bbadb360f0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed \""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_4e5bc253","line":58,"updated":"2017-06-20 11:23:12.000000000","message":"Doc String missing","commit_id":"9cd61fdd94e8c2d39a72980ea8cb322cb773dae7"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"3f0c20c9ab046fe424bc6e0a293760c5a6ea47b1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class MultiplePortPairsInTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Multiple port pairs in TAP port-pair-group is not allowed \""},{"line_number":59,"context_line":"                \"%(method)s failed\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f201791_e0124b09","line":58,"in_reply_to":"7f231b9d_4e5bc253","updated":"2017-06-23 10:11:12.000000000","message":"Done","commit_id":"9cd61fdd94e8c2d39a72980ea8cb322cb773dae7"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e607b39ae7c6783d033b1eaf5a2c7cddf147989d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    message \u003d _(\"There is no %(type)s assigned.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ConsecutiveTAPPPGNotSupported(exceptions.NeutronException):"},{"line_number":52,"context_line":"    \"\"\"Unsupported TAP deployment\"\"\""},{"line_number":53,"context_line":"    message \u003d _(\"Consecutive TAP PPG in port-chain is not supported now \""},{"line_number":54,"context_line":"                \"%(method)s failed.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_6fdbc31a","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":35},"updated":"2017-06-23 14:08:12.000000000","message":"But multiple TAPs per port-chain are supported right?","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"}],"networking_sfc/services/sfc/plugin.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"SFC plugin implementation.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    supported_extension_aliases \u003d [sfc_ext.SFC_EXT, sg_ext.SG_EXT,"},{"line_number":36,"context_line":"                                   \"networking-sfc-tap\"]"},{"line_number":37,"context_line":"    path_prefix \u003d sfc_ext.SFC_PREFIX"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_376409e4","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":55},"updated":"2017-10-13 10:43:39.000000000","message":"Better move that string constant to extension (same in tests)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"SFC plugin implementation.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    supported_extension_aliases \u003d [sfc_ext.SFC_EXT, sg_ext.SG_EXT,"},{"line_number":36,"context_line":"                                   \"networking-sfc-tap\"]"},{"line_number":37,"context_line":"    path_prefix \u003d sfc_ext.SFC_PREFIX"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_7bcce3bb","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":55},"in_reply_to":"5f4e5783_0dc57a5b","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"SFC plugin implementation.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    supported_extension_aliases \u003d [sfc_ext.SFC_EXT, sg_ext.SG_EXT,"},{"line_number":36,"context_line":"                                   \"networking-sfc-tap\"]"},{"line_number":37,"context_line":"    path_prefix \u003d sfc_ext.SFC_PREFIX"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_ed28de86","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":55},"in_reply_to":"5f4e5783_376409e4","updated":"2017-10-13 12:04:20.000000000","message":"framework can autoload through string. Do we need to load file explicitly just for string ?","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fa28290bb74e3af4d5bcdf484c95be999371704b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"SFC plugin implementation.\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    supported_extension_aliases \u003d [sfc_ext.SFC_EXT, sg_ext.SG_EXT,"},{"line_number":36,"context_line":"                                   \"networking-sfc-tap\"]"},{"line_number":37,"context_line":"    path_prefix \u003d sfc_ext.SFC_PREFIX"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_0dc57a5b","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":55},"in_reply_to":"5f4e5783_ed28de86","updated":"2017-10-13 12:43:18.000000000","message":"Sorry badly phrased, I meant the module (not the extension), as is currently done for the current extensions (sfc, fc and service graphs).\n\nNothing functionally breaking of course (in the end, it is just the strings), but for consistency I\u0027d lean on using the same behavior everywhere","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"67f065a00aa4db512897d54534ae44b9c7ace1e0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from networking_sfc.db import sfc_db"},{"line_number":22,"context_line":"from networking_sfc.extensions import servicegraph as sg_ext"},{"line_number":23,"context_line":"from networking_sfc.extensions import sfc as sfc_ext"},{"line_number":24,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":25,"context_line":"from networking_sfc.services.sfc.common import context as sfc_ctx"},{"line_number":26,"context_line":"from networking_sfc.services.sfc.common import exceptions as sfc_exc"},{"line_number":27,"context_line":"from networking_sfc.services.sfc import driver_manager as sfc_driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_5677b9d5","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":49},"updated":"2017-10-20 12:33:04.000000000","message":"For consistency would import this in the same way as the others.","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c858d4df4a5420094e7adcd73815c0a11722527a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from networking_sfc.db import sfc_db"},{"line_number":22,"context_line":"from networking_sfc.extensions import servicegraph as sg_ext"},{"line_number":23,"context_line":"from networking_sfc.extensions import sfc as sfc_ext"},{"line_number":24,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":25,"context_line":"from networking_sfc.services.sfc.common import context as sfc_ctx"},{"line_number":26,"context_line":"from networking_sfc.services.sfc.common import exceptions as sfc_exc"},{"line_number":27,"context_line":"from networking_sfc.services.sfc import driver_manager as sfc_driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_dd8aa419","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":49},"in_reply_to":"3f4b6375_5677b9d5","updated":"2017-10-20 15:16:07.000000000","message":"Done","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"}],"networking_sfc/tests/unit/db/test_sfc_db.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            \u0027port_pairs\u0027: port_pair_group.get(\u0027port_pairs\u0027) or [],"},{"line_number":182,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":183,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":184,"context_line":"            ) or {\u0027lb_fields\u0027: [], \u0027insertion_mode\u0027: None}"},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":187,"context_line":"            ret[\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_0898ddbd","line":184,"range":{"start_line":184,"start_character":36,"end_line":184,"end_character":50},"updated":"2017-03-26 20:09:56.000000000","message":"change insertion_mode to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e607b39ae7c6783d033b1eaf5a2c7cddf147989d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            with self.port_pair(port_pair\u003dport_pair) as pp:"},{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_af28bbe1","line":176,"updated":"2017-06-23 14:08:12.000000000","message":"A test making sure that a TAP port pair group cannot be created with multiple port pairs?","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4a14031140423e31c2f58d8d9e6813d2fd57c4ef","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            with self.port_pair(port_pair\u003dport_pair) as pp:"},{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_af2f4e3d","line":176,"in_reply_to":"5f201791_75acb633","updated":"2017-06-27 10:19:25.000000000","message":"Done","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9db7b12c3238bf08d618763f07ff22616a60ccb4","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            with self.port_pair(port_pair\u003dport_pair) as pp:"},{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_58f44a86","line":176,"in_reply_to":"5f201791_75acb633","updated":"2017-06-23 19:02:50.000000000","message":"Well, as much as possible the API should be consistent across drivers, so it should be validated at this level. Is OVS not capable of handling a tap group with many port pairs?","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"63f27f927202f847b9aab7abdca71d9c0e90ba65","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            with self.port_pair(port_pair\u003dport_pair) as pp:"},{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_75acb633","line":176,"in_reply_to":"5f201791_af28bbe1","updated":"2017-06-23 17:03:39.000000000","message":"Will add this validation on driver side. It won\u0027t be proper to restrict in DB side, as there may be other type of drivers which can support this without issue. Will that be OK ?","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e607b39ae7c6783d033b1eaf5a2c7cddf147989d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":180,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_ef5c737f","line":177,"updated":"2017-06-23 14:08:12.000000000","message":"A test making sure that consecutive TAP PPGs cannot be created?","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9db7b12c3238bf08d618763f07ff22616a60ccb4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":180,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_d835fa47","line":177,"in_reply_to":"5f201791_63ad1c87","updated":"2017-06-23 19:02:50.000000000","message":"ditto","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4a14031140423e31c2f58d8d9e6813d2fd57c4ef","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":180,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_8f349294","line":177,"in_reply_to":"5f201791_d835fa47","updated":"2017-06-27 10:19:25.000000000","message":"Done","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"63f27f927202f847b9aab7abdca71d9c0e90ba65","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                for k, v in expected_port_pair.items():"},{"line_number":175,"context_line":"                    self.assertEqual(pp[\u0027port_pair\u0027][k], v)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _get_expected_port_pair_group(self, port_pair_group):"},{"line_number":178,"context_line":"        ret \u003d {"},{"line_number":179,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":180,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_63ad1c87","line":177,"in_reply_to":"5f201791_ef5c737f","updated":"2017-06-23 17:03:39.000000000","message":"ditto","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e607b39ae7c6783d033b1eaf5a2c7cddf147989d","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"                \u0027ppg_n_tuple_mapping\u0027: {"},{"line_number":1289,"context_line":"                    \u0027ingress_n_tuple\u0027: {\u0027source_ip_prefix\u0027: None},"},{"line_number":1290,"context_line":"                    \u0027egress_n_tuple\u0027: {\u0027destination_ip_prefix\u0027: None}},"},{"line_number":1291,"context_line":"                \u0027tap_enabled\u0027: True"},{"line_number":1292,"context_line":"            }"},{"line_number":1293,"context_line":"        })"},{"line_number":1294,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_8ff5ff85","line":1291,"range":{"start_line":1291,"start_character":16,"end_line":1291,"end_character":35},"updated":"2017-06-23 14:08:12.000000000","message":"This test shouldn\u0027t be changed like this, keep it with tap_enabled: False and include a new variant with tap_enabled: True.","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4a14031140423e31c2f58d8d9e6813d2fd57c4ef","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"                \u0027ppg_n_tuple_mapping\u0027: {"},{"line_number":1289,"context_line":"                    \u0027ingress_n_tuple\u0027: {\u0027source_ip_prefix\u0027: None},"},{"line_number":1290,"context_line":"                    \u0027egress_n_tuple\u0027: {\u0027destination_ip_prefix\u0027: None}},"},{"line_number":1291,"context_line":"                \u0027tap_enabled\u0027: True"},{"line_number":1292,"context_line":"            }"},{"line_number":1293,"context_line":"        })"},{"line_number":1294,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_ef18a61e","line":1291,"range":{"start_line":1291,"start_character":16,"end_line":1291,"end_character":35},"in_reply_to":"5f201791_38f98e4c","updated":"2017-06-27 10:19:25.000000000","message":"Done","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"63f27f927202f847b9aab7abdca71d9c0e90ba65","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"                \u0027ppg_n_tuple_mapping\u0027: {"},{"line_number":1289,"context_line":"                    \u0027ingress_n_tuple\u0027: {\u0027source_ip_prefix\u0027: None},"},{"line_number":1290,"context_line":"                    \u0027egress_n_tuple\u0027: {\u0027destination_ip_prefix\u0027: None}},"},{"line_number":1291,"context_line":"                \u0027tap_enabled\u0027: True"},{"line_number":1292,"context_line":"            }"},{"line_number":1293,"context_line":"        })"},{"line_number":1294,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_f809db2b","line":1291,"range":{"start_line":1291,"start_character":16,"end_line":1291,"end_character":35},"in_reply_to":"5f201791_8ff5ff85","updated":"2017-06-23 17:03:39.000000000","message":"I think same is done in : test_create_port_pair_group_with_default_parameters\n\nL 1311.\n\nPls let me know, if thats not the case then I will add new test case.","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9db7b12c3238bf08d618763f07ff22616a60ccb4","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"                \u0027ppg_n_tuple_mapping\u0027: {"},{"line_number":1289,"context_line":"                    \u0027ingress_n_tuple\u0027: {\u0027source_ip_prefix\u0027: None},"},{"line_number":1290,"context_line":"                    \u0027egress_n_tuple\u0027: {\u0027destination_ip_prefix\u0027: None}},"},{"line_number":1291,"context_line":"                \u0027tap_enabled\u0027: True"},{"line_number":1292,"context_line":"            }"},{"line_number":1293,"context_line":"        })"},{"line_number":1294,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f201791_38f98e4c","line":1291,"range":{"start_line":1291,"start_character":16,"end_line":1291,"end_character":35},"in_reply_to":"5f201791_f809db2b","updated":"2017-06-23 19:02:50.000000000","message":"L1311 doesn\u0027t include the same input. One thing is appending a new parameter where it makes sense, in a neutral way (indeed, it makes sense both as a default and as one of \"all fields\"), another thing is appending an attribute in a non-neutral way to an existing test. This isn\u0027t critical but still..\n\ntest_create_port_pair_group_all_fields should be updated in a neutral way, to make sure whatever it\u0027s testing is still essentially being tested. And a new test should be added specifically for your feature.","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"de8b8cb12610522bf58fb9ea0ca5600eace154ef","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"                ) as pg1, self.port_pair_group("},{"line_number":1417,"context_line":"                    self.fmt,"},{"line_number":1418,"context_line":"                    {"},{"line_number":1419,"context_line":"                        \u0027port_pairs\u0027: [tap_pp2[\u0027port_pair\u0027][\u0027id\u0027]],"},{"line_number":1420,"context_line":"                        \u0027port_pair_group_parameters\u0027: {"},{"line_number":1421,"context_line":"                            \u0027tap_enabled\u0027: False}"},{"line_number":1422,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f1a1f67_00dac74a","line":1419,"range":{"start_line":1419,"start_character":39,"end_line":1419,"end_character":46},"updated":"2017-07-17 08:52:45.000000000","message":"nit: maybe not call this var \"tap_*\"","commit_id":"643cd2c42314bdc6528831422228442d8dac42bf"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":335,"context_line":"            sfc.SFC_EXT, sg_ext.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":336,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":337,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":338,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_97a85ddb","line":335,"range":{"start_line":335,"start_character":40,"end_line":335,"end_character":60},"updated":"2017-10-13 10:43:39.000000000","message":"Same comment on common string variable","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":335,"context_line":"            sfc.SFC_EXT, sg_ext.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":336,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":337,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":338,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_9bd55f46","line":335,"range":{"start_line":335,"start_character":40,"end_line":335,"end_character":60},"in_reply_to":"5f4e5783_2dc6f649","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fa28290bb74e3af4d5bcdf484c95be999371704b","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":335,"context_line":"            sfc.SFC_EXT, sg_ext.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":336,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":337,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":338,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_2dc6f649","line":335,"range":{"start_line":335,"start_character":40,"end_line":335,"end_character":60},"in_reply_to":"5f4e5783_3208972a","updated":"2017-10-13 12:43:18.000000000","message":"Same discussion as services/sfc/plugin.py in the end\nIndeed neutron does it by direct string, though I\u0027d prefer consistency between extensions (note that updating current code to use direct strings for other extensions would be fine too)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":333,"context_line":"        }"},{"line_number":334,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":335,"context_line":"            sfc.SFC_EXT, sg_ext.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":336,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":337,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":338,"context_line":"            fc_ext.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_3208972a","line":335,"range":{"start_line":335,"start_character":40,"end_line":335,"end_character":60},"in_reply_to":"5f4e5783_97a85ddb","updated":"2017-10-13 12:04:20.000000000","message":"Since I just need to pass string here and framework discover extension itself. Exporting from a global name from extension file just for loading can be avoided. I saw neutron doing same way. Or Am I wrong ?","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            self.flowclassifier_plugin \u003d importutils.import_object("},{"line_number":350,"context_line":"                flowclassifier_plugin)"},{"line_number":351,"context_line":"            # Note (vks1): Auto-load extensions."},{"line_number":352,"context_line":"            ext_mgr \u003d api_ext.PluginAwareExtensionManager.get_instance()"},{"line_number":353,"context_line":"            app \u003d config.load_paste_app(\u0027extensions_test_app\u0027)"},{"line_number":354,"context_line":"            self.ext_api \u003d api_ext.ExtensionMiddleware(app, ext_mgr\u003dext_mgr)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_57aae5d1","line":352,"range":{"start_line":352,"start_character":58,"end_line":352,"end_character":70},"updated":"2017-10-13 10:43:39.000000000","message":"Nice :)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"67f065a00aa4db512897d54534ae44b9c7ace1e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_sfc.extensions import flowclassifier as fc_ext"},{"line_number":31,"context_line":"from networking_sfc.extensions import servicegraph as sg_ext"},{"line_number":32,"context_line":"from networking_sfc.extensions import sfc"},{"line_number":33,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":34,"context_line":"from networking_sfc.tests import base"},{"line_number":35,"context_line":"from networking_sfc.tests.unit.db import test_flowclassifier_db"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_b64f0d91","line":33,"range":{"start_line":33,"start_character":42,"end_line":33,"end_character":49},"updated":"2017-10-20 12:33:04.000000000","message":"ditto","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c858d4df4a5420094e7adcd73815c0a11722527a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_sfc.extensions import flowclassifier as fc_ext"},{"line_number":31,"context_line":"from networking_sfc.extensions import servicegraph as sg_ext"},{"line_number":32,"context_line":"from networking_sfc.extensions import sfc"},{"line_number":33,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":34,"context_line":"from networking_sfc.tests import base"},{"line_number":35,"context_line":"from networking_sfc.tests.unit.db import test_flowclassifier_db"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_bd8da832","line":33,"range":{"start_line":33,"start_character":42,"end_line":33,"end_character":49},"in_reply_to":"3f4b6375_b64f0d91","updated":"2017-10-20 15:16:07.000000000","message":"Done","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"}],"networking_sfc/tests/unit/extensions/test_sfc.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"8b4af1d50c878e6ef6f2dfae71a124d4c3d62c55","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            \u0027project_id\u0027: port_pair_group[\u0027project_id\u0027],"},{"line_number":348,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":349,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":350,"context_line":"            ) or {\u0027lb_fields\u0027: [], \u0027insertion_mode\u0027: None}"},{"line_number":351,"context_line":"        }}"},{"line_number":352,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":353,"context_line":"            ret[\u0027port_pair_group\u0027][\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e892599f","line":350,"range":{"start_line":350,"start_character":36,"end_line":350,"end_character":50},"updated":"2017-03-26 20:09:56.000000000","message":"change insertion_mode to tap_enabled","commit_id":"4ac5af3883b09fc845c4e3cecc1783c44377dfa5"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ea534cfb8f7ac027d845f9a8d1fcbcbe7efa5ae6","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":498,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":499,"context_line":"            \u0027port_pairs\u0027: [_uuid()],"},{"line_number":500,"context_line":"            \u0027port_pair_group_parameters\u0027: {\u0027abc\u0027: True},"},{"line_number":501,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":502,"context_line":"        }}"},{"line_number":503,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_df285be3","line":500,"range":{"start_line":500,"start_character":43,"end_line":500,"end_character":54},"updated":"2017-03-27 10:55:52.000000000","message":"This doesn\u0027t seem to be specifically about tap-enabled as the function name suggests.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"3f67e8bb74cc0d72c1c19fa2e6c26e45ea470397","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":498,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":499,"context_line":"            \u0027port_pairs\u0027: [_uuid()],"},{"line_number":500,"context_line":"            \u0027port_pair_group_parameters\u0027: {\u0027abc\u0027: True},"},{"line_number":501,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":502,"context_line":"        }}"},{"line_number":503,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_855040d6","line":500,"range":{"start_line":500,"start_character":43,"end_line":500,"end_character":54},"in_reply_to":"ffe62b97_df285be3","updated":"2017-03-27 11:28:16.000000000","message":"This doesn\u0027t hold purpose now, carried over from earlier insertion_mode text case. Will delete this.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ea534cfb8f7ac027d845f9a8d1fcbcbe7efa5ae6","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":512,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":513,"context_line":"            \u0027port_pairs\u0027: [_uuid()],"},{"line_number":514,"context_line":"            \u0027port_pair_group_parameters\u0027: {\u0027tap_enabled\u0027: \u0027two\u0027},"},{"line_number":515,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":516,"context_line":"        }}"},{"line_number":517,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_ff867fdb","line":514,"range":{"start_line":514,"start_character":43,"end_line":514,"end_character":63},"updated":"2017-03-27 10:55:52.000000000","message":"This seems to be what you wanted above, and overall not about the insertion mode.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"3f67e8bb74cc0d72c1c19fa2e6c26e45ea470397","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":512,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":513,"context_line":"            \u0027port_pairs\u0027: [_uuid()],"},{"line_number":514,"context_line":"            \u0027port_pair_group_parameters\u0027: {\u0027tap_enabled\u0027: \u0027two\u0027},"},{"line_number":515,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":516,"context_line":"        }}"},{"line_number":517,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_6a1bcb80","line":514,"range":{"start_line":514,"start_character":43,"end_line":514,"end_character":63},"in_reply_to":"ffe62b97_ff867fdb","updated":"2017-03-27 11:28:16.000000000","message":"This is a typo, will fix this.","commit_id":"c92fbac036c34a496afebecb83a9e23b01f76b78"}],"networking_sfc/tests/unit/extensions/test_tap.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            plural_mappings\u003d{}"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _mock_unnecessary_logging(self):"},{"line_number":54,"context_line":"        mock_log_cfg_p \u003d mock.patch.object(cfg, \u0027LOG\u0027)"},{"line_number":55,"context_line":"        self.mock_log_cfg \u003d mock_log_cfg_p.start()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_log_manager_p \u003d mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":58,"context_line":"        self.mock_log_manager \u003d mock_log_manager_p.start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        mock_log_nova_p \u003d mock.patch.object(nova_log, \u0027LOG\u0027)"},{"line_number":61,"context_line":"        self.mock_log_nova \u003d mock_log_nova_p.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        mock_log_api_res_log_p \u003d mock.patch.object(api_res_log, \u0027LOG\u0027)"},{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_57466523","line":64,"range":{"start_line":53,"start_character":0,"end_line":64,"end_character":66},"updated":"2017-10-13 10:43:39.000000000","message":"This looks like the same as the parent class function?","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fa28290bb74e3af4d5bcdf484c95be999371704b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            plural_mappings\u003d{}"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _mock_unnecessary_logging(self):"},{"line_number":54,"context_line":"        mock_log_cfg_p \u003d mock.patch.object(cfg, \u0027LOG\u0027)"},{"line_number":55,"context_line":"        self.mock_log_cfg \u003d mock_log_cfg_p.start()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_log_manager_p \u003d mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":58,"context_line":"        self.mock_log_manager \u003d mock_log_manager_p.start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        mock_log_nova_p \u003d mock.patch.object(nova_log, \u0027LOG\u0027)"},{"line_number":61,"context_line":"        self.mock_log_nova \u003d mock_log_nova_p.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        mock_log_api_res_log_p \u003d mock.patch.object(api_res_log, \u0027LOG\u0027)"},{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_cd09a295","line":64,"range":{"start_line":53,"start_character":0,"end_line":64,"end_character":66},"in_reply_to":"5f4e5783_12e0fb95","updated":"2017-10-13 12:43:18.000000000","message":"Others have it as the parent class is test_api_v2_extension.ExtensionTestCase but yours uses SfcExtensionTestCase so you already have that function available :)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            plural_mappings\u003d{}"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _mock_unnecessary_logging(self):"},{"line_number":54,"context_line":"        mock_log_cfg_p \u003d mock.patch.object(cfg, \u0027LOG\u0027)"},{"line_number":55,"context_line":"        self.mock_log_cfg \u003d mock_log_cfg_p.start()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_log_manager_p \u003d mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":58,"context_line":"        self.mock_log_manager \u003d mock_log_manager_p.start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        mock_log_nova_p \u003d mock.patch.object(nova_log, \u0027LOG\u0027)"},{"line_number":61,"context_line":"        self.mock_log_nova \u003d mock_log_nova_p.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        mock_log_api_res_log_p \u003d mock.patch.object(api_res_log, \u0027LOG\u0027)"},{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_12e0fb95","line":64,"range":{"start_line":53,"start_character":0,"end_line":64,"end_character":66},"in_reply_to":"5f4e5783_57466523","updated":"2017-10-13 12:04:20.000000000","message":"I didn\u0027t understood it\u0027s use in first place. Thought there must be some reason why other 2 extensions are having that. So, kept it. :) \n\nIf that is required by both the extensions we should have moved other twos also in common class.\n\nWill remove it.","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            plural_mappings\u003d{}"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _mock_unnecessary_logging(self):"},{"line_number":54,"context_line":"        mock_log_cfg_p \u003d mock.patch.object(cfg, \u0027LOG\u0027)"},{"line_number":55,"context_line":"        self.mock_log_cfg \u003d mock_log_cfg_p.start()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_log_manager_p \u003d mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":58,"context_line":"        self.mock_log_manager \u003d mock_log_manager_p.start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        mock_log_nova_p \u003d mock.patch.object(nova_log, \u0027LOG\u0027)"},{"line_number":61,"context_line":"        self.mock_log_nova \u003d mock_log_nova_p.start()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        mock_log_api_res_log_p \u003d mock.patch.object(api_res_log, \u0027LOG\u0027)"},{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_1bc16f81","line":64,"range":{"start_line":53,"start_character":0,"end_line":64,"end_character":66},"in_reply_to":"5f4e5783_cd09a295","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"},{"line_number":68,"context_line":"        ret \u003d {\u0027port_pair_group\u0027: {"},{"line_number":69,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"},{"line_number":70,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":71,"context_line":"            \u0027port_pairs\u0027: port_pair_group.get(\u0027port_pairs\u0027) or [],"},{"line_number":72,"context_line":"            \u0027tenant_id\u0027: port_pair_group[\u0027tenant_id\u0027],"},{"line_number":73,"context_line":"            \u0027project_id\u0027: port_pair_group[\u0027project_id\u0027],"},{"line_number":74,"context_line":"            \u0027tap_enabled\u0027: port_pair_group.get(\u0027tap_enabled\u0027, False),"},{"line_number":75,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":76,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":77,"context_line":"            ) or {\u0027lb_fields\u0027: [],"},{"line_number":78,"context_line":"                  \u0027ppg_n_tuple_mapping\u0027: {\u0027ingress_n_tuple\u0027: {},"},{"line_number":79,"context_line":"                                          \u0027egress_n_tuple\u0027: {}}"},{"line_number":80,"context_line":"                  }"},{"line_number":81,"context_line":"        }}"},{"line_number":82,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":83,"context_line":"            ret[\u0027port_pair_group\u0027][\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"},{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_57cb0571","line":84,"range":{"start_line":67,"start_character":0,"end_line":84,"end_character":18},"updated":"2017-10-13 10:43:39.000000000","message":"We should call the parent function here, and just add the tap_enabled param (more common code)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fa28290bb74e3af4d5bcdf484c95be999371704b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"},{"line_number":68,"context_line":"        ret \u003d {\u0027port_pair_group\u0027: {"},{"line_number":69,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"},{"line_number":70,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":71,"context_line":"            \u0027port_pairs\u0027: port_pair_group.get(\u0027port_pairs\u0027) or [],"},{"line_number":72,"context_line":"            \u0027tenant_id\u0027: port_pair_group[\u0027tenant_id\u0027],"},{"line_number":73,"context_line":"            \u0027project_id\u0027: port_pair_group[\u0027project_id\u0027],"},{"line_number":74,"context_line":"            \u0027tap_enabled\u0027: port_pair_group.get(\u0027tap_enabled\u0027, False),"},{"line_number":75,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":76,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":77,"context_line":"            ) or {\u0027lb_fields\u0027: [],"},{"line_number":78,"context_line":"                  \u0027ppg_n_tuple_mapping\u0027: {\u0027ingress_n_tuple\u0027: {},"},{"line_number":79,"context_line":"                                          \u0027egress_n_tuple\u0027: {}}"},{"line_number":80,"context_line":"                  }"},{"line_number":81,"context_line":"        }}"},{"line_number":82,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":83,"context_line":"            ret[\u0027port_pair_group\u0027][\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"},{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_cd98821c","line":84,"range":{"start_line":67,"start_character":0,"end_line":84,"end_character":18},"in_reply_to":"5f4e5783_52ff9333","updated":"2017-10-13 12:43:18.000000000","message":"Changes on the parent should not break this (common code should help here), it\u0027s just that after going through the function I realized it was just the same ending result, with tap_enabled added.\nBut again, minor point","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"},{"line_number":68,"context_line":"        ret \u003d {\u0027port_pair_group\u0027: {"},{"line_number":69,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"},{"line_number":70,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":71,"context_line":"            \u0027port_pairs\u0027: port_pair_group.get(\u0027port_pairs\u0027) or [],"},{"line_number":72,"context_line":"            \u0027tenant_id\u0027: port_pair_group[\u0027tenant_id\u0027],"},{"line_number":73,"context_line":"            \u0027project_id\u0027: port_pair_group[\u0027project_id\u0027],"},{"line_number":74,"context_line":"            \u0027tap_enabled\u0027: port_pair_group.get(\u0027tap_enabled\u0027, False),"},{"line_number":75,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":76,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":77,"context_line":"            ) or {\u0027lb_fields\u0027: [],"},{"line_number":78,"context_line":"                  \u0027ppg_n_tuple_mapping\u0027: {\u0027ingress_n_tuple\u0027: {},"},{"line_number":79,"context_line":"                                          \u0027egress_n_tuple\u0027: {}}"},{"line_number":80,"context_line":"                  }"},{"line_number":81,"context_line":"        }}"},{"line_number":82,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":83,"context_line":"            ret[\u0027port_pair_group\u0027][\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"},{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_52ff9333","line":84,"range":{"start_line":67,"start_character":0,"end_line":84,"end_character":18},"in_reply_to":"5f4e5783_57cb0571","updated":"2017-10-13 12:04:20.000000000","message":"I thought it would be more discrete to have separate method. No, need to worry on any change in parent method.","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.mock_log_api_res_log \u003d mock_log_api_res_log_p.start()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _get_expected_port_pair_group(self, data):"},{"line_number":67,"context_line":"        port_pair_group \u003d data[\u0027port_pair_group\u0027]"},{"line_number":68,"context_line":"        ret \u003d {\u0027port_pair_group\u0027: {"},{"line_number":69,"context_line":"            \u0027description\u0027: port_pair_group.get(\u0027description\u0027) or \u0027\u0027,"},{"line_number":70,"context_line":"            \u0027name\u0027: port_pair_group.get(\u0027name\u0027) or \u0027\u0027,"},{"line_number":71,"context_line":"            \u0027port_pairs\u0027: port_pair_group.get(\u0027port_pairs\u0027) or [],"},{"line_number":72,"context_line":"            \u0027tenant_id\u0027: port_pair_group[\u0027tenant_id\u0027],"},{"line_number":73,"context_line":"            \u0027project_id\u0027: port_pair_group[\u0027project_id\u0027],"},{"line_number":74,"context_line":"            \u0027tap_enabled\u0027: port_pair_group.get(\u0027tap_enabled\u0027, False),"},{"line_number":75,"context_line":"            \u0027port_pair_group_parameters\u0027: port_pair_group.get("},{"line_number":76,"context_line":"                \u0027port_pair_group_parameters\u0027"},{"line_number":77,"context_line":"            ) or {\u0027lb_fields\u0027: [],"},{"line_number":78,"context_line":"                  \u0027ppg_n_tuple_mapping\u0027: {\u0027ingress_n_tuple\u0027: {},"},{"line_number":79,"context_line":"                                          \u0027egress_n_tuple\u0027: {}}"},{"line_number":80,"context_line":"                  }"},{"line_number":81,"context_line":"        }}"},{"line_number":82,"context_line":"        if port_pair_group.get(\u0027group_id\u0027):"},{"line_number":83,"context_line":"            ret[\u0027port_pair_group\u0027][\u0027group_id\u0027] \u003d port_pair_group[\u0027group_id\u0027]"},{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_fbbfb3f8","line":84,"range":{"start_line":67,"start_character":0,"end_line":84,"end_character":18},"in_reply_to":"5f4e5783_cd98821c","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"},{"line_number":88,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":89,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":90,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":91,"context_line":"        }}"},{"line_number":92,"context_line":"        expected_data \u003d self._get_expected_port_pair_group(data)"},{"line_number":93,"context_line":"        return_value \u003d copy.copy(expected_data[\u0027port_pair_group\u0027])"},{"line_number":94,"context_line":"        return_value.update({\u0027id\u0027: portpairgroup_id})"},{"line_number":95,"context_line":"        instance \u003d self.plugin.return_value"},{"line_number":96,"context_line":"        instance.create_port_pair_group.return_value \u003d return_value"},{"line_number":97,"context_line":"        res \u003d self.api.post("},{"line_number":98,"context_line":"            _get_path(test_sfc_ext.PORT_PAIR_GROUP_PATH, fmt\u003dself.fmt),"},{"line_number":99,"context_line":"            self.serialize(data),"},{"line_number":100,"context_line":"            content_type\u003d\u0027application/%s\u0027 % self.fmt)"},{"line_number":101,"context_line":"        instance.create_port_pair_group.assert_called_with("},{"line_number":102,"context_line":"            mock.ANY,"},{"line_number":103,"context_line":"            port_pair_group\u003dexpected_data)"},{"line_number":104,"context_line":"        self.assertEqual(exc.HTTPCreated.code, res.status_int)"},{"line_number":105,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":106,"context_line":"        self.assertIn(\u0027port_pair_group\u0027, res)"},{"line_number":107,"context_line":"        self.assertEqual(return_value, res[\u0027port_pair_group\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_create_port_pair_group_with_tap_enabled(self):"},{"line_number":110,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_f78f9120","line":107,"range":{"start_line":87,"start_character":0,"end_line":107,"end_character":62},"updated":"2017-10-13 10:43:39.000000000","message":"Instead calling parent test_create_port_pair_group() (with the overloaded _get_expected_port_pair_group()) should work here?","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"fa28290bb74e3af4d5bcdf484c95be999371704b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"},{"line_number":88,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":89,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":90,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":91,"context_line":"        }}"},{"line_number":92,"context_line":"        expected_data \u003d self._get_expected_port_pair_group(data)"},{"line_number":93,"context_line":"        return_value \u003d copy.copy(expected_data[\u0027port_pair_group\u0027])"},{"line_number":94,"context_line":"        return_value.update({\u0027id\u0027: portpairgroup_id})"},{"line_number":95,"context_line":"        instance \u003d self.plugin.return_value"},{"line_number":96,"context_line":"        instance.create_port_pair_group.return_value \u003d return_value"},{"line_number":97,"context_line":"        res \u003d self.api.post("},{"line_number":98,"context_line":"            _get_path(test_sfc_ext.PORT_PAIR_GROUP_PATH, fmt\u003dself.fmt),"},{"line_number":99,"context_line":"            self.serialize(data),"},{"line_number":100,"context_line":"            content_type\u003d\u0027application/%s\u0027 % self.fmt)"},{"line_number":101,"context_line":"        instance.create_port_pair_group.assert_called_with("},{"line_number":102,"context_line":"            mock.ANY,"},{"line_number":103,"context_line":"            port_pair_group\u003dexpected_data)"},{"line_number":104,"context_line":"        self.assertEqual(exc.HTTPCreated.code, res.status_int)"},{"line_number":105,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":106,"context_line":"        self.assertIn(\u0027port_pair_group\u0027, res)"},{"line_number":107,"context_line":"        self.assertEqual(return_value, res[\u0027port_pair_group\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_create_port_pair_group_with_tap_enabled(self):"},{"line_number":110,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_ad9f8601","line":107,"range":{"start_line":87,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"5f4e5783_5272f3e4","updated":"2017-10-13 12:43:18.000000000","message":"Indeed, I meant keep the test, but just do something like:\n\u003e super(SFCTapExtensionTestCase, self).test_create_port_pair_group()\n\nWhich will use the TAP test _get_expected_port_pair_group() method","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return ret"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_port_pair_group_with_default_fields(self):"},{"line_number":87,"context_line":"        portpairgroup_id \u003d _uuid()"},{"line_number":88,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":89,"context_line":"        data \u003d {\u0027port_pair_group\u0027: {"},{"line_number":90,"context_line":"            \u0027tenant_id\u0027: tenant_id, \u0027project_id\u0027: tenant_id"},{"line_number":91,"context_line":"        }}"},{"line_number":92,"context_line":"        expected_data \u003d self._get_expected_port_pair_group(data)"},{"line_number":93,"context_line":"        return_value \u003d copy.copy(expected_data[\u0027port_pair_group\u0027])"},{"line_number":94,"context_line":"        return_value.update({\u0027id\u0027: portpairgroup_id})"},{"line_number":95,"context_line":"        instance \u003d self.plugin.return_value"},{"line_number":96,"context_line":"        instance.create_port_pair_group.return_value \u003d return_value"},{"line_number":97,"context_line":"        res \u003d self.api.post("},{"line_number":98,"context_line":"            _get_path(test_sfc_ext.PORT_PAIR_GROUP_PATH, fmt\u003dself.fmt),"},{"line_number":99,"context_line":"            self.serialize(data),"},{"line_number":100,"context_line":"            content_type\u003d\u0027application/%s\u0027 % self.fmt)"},{"line_number":101,"context_line":"        instance.create_port_pair_group.assert_called_with("},{"line_number":102,"context_line":"            mock.ANY,"},{"line_number":103,"context_line":"            port_pair_group\u003dexpected_data)"},{"line_number":104,"context_line":"        self.assertEqual(exc.HTTPCreated.code, res.status_int)"},{"line_number":105,"context_line":"        res \u003d self.deserialize(res)"},{"line_number":106,"context_line":"        self.assertIn(\u0027port_pair_group\u0027, res)"},{"line_number":107,"context_line":"        self.assertEqual(return_value, res[\u0027port_pair_group\u0027])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_create_port_pair_group_with_tap_enabled(self):"},{"line_number":110,"context_line":"        portpairgroup_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_5272f3e4","line":107,"range":{"start_line":87,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"5f4e5783_f78f9120","updated":"2017-10-13 12:04:20.000000000","message":"I feel \u0027_get_expected_port_pair_group()\u0027, this should be separate for TAP extension.","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"}],"networking_sfc/tests/unit/services/sfc/drivers/ovs/test_driver.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            flowclassifier.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":100,"context_line":"            sfc.SFC_EXT, servicegraph.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":101,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":102,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":103,"context_line":"            flowclassifier.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f4e5783_77a3a19f","line":100,"range":{"start_line":100,"start_character":46,"end_line":100,"end_character":66},"updated":"2017-10-13 10:43:39.000000000","message":"Same comment on common string variable","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            flowclassifier.FLOW_CLASSIFIER_EXT: flowclassifier_plugin"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"        sfc_db.SfcDbPlugin.supported_extension_aliases \u003d ["},{"line_number":100,"context_line":"            sfc.SFC_EXT, servicegraph.SG_EXT, \"networking-sfc-tap\"]"},{"line_number":101,"context_line":"        sfc_db.SfcDbPlugin.path_prefix \u003d sfc.SFC_PREFIX"},{"line_number":102,"context_line":"        fdb.FlowClassifierDbPlugin.supported_extension_aliases \u003d ["},{"line_number":103,"context_line":"            flowclassifier.FLOW_CLASSIFIER_EXT]"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_dbbab708","line":100,"range":{"start_line":100,"start_character":46,"end_line":100,"end_character":66},"in_reply_to":"5f4e5783_77a3a19f","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"67f065a00aa4db512897d54534ae44b9c7ace1e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from networking_sfc.extensions import flowclassifier"},{"line_number":29,"context_line":"from networking_sfc.extensions import servicegraph"},{"line_number":30,"context_line":"from networking_sfc.extensions import sfc"},{"line_number":31,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":32,"context_line":"from networking_sfc.services.sfc.common import context as sfc_ctx"},{"line_number":33,"context_line":"from networking_sfc.services.sfc.common import exceptions as sfc_exc"},{"line_number":34,"context_line":"from networking_sfc.services.sfc.drivers.ovs import driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_a99e92b5","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":49},"updated":"2017-10-20 12:33:04.000000000","message":"ditto","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"c858d4df4a5420094e7adcd73815c0a11722527a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from networking_sfc.extensions import flowclassifier"},{"line_number":29,"context_line":"from networking_sfc.extensions import servicegraph"},{"line_number":30,"context_line":"from networking_sfc.extensions import sfc"},{"line_number":31,"context_line":"from networking_sfc.extensions.tap import TAP_EXT"},{"line_number":32,"context_line":"from networking_sfc.services.sfc.common import context as sfc_ctx"},{"line_number":33,"context_line":"from networking_sfc.services.sfc.common import exceptions as sfc_exc"},{"line_number":34,"context_line":"from networking_sfc.services.sfc.drivers.ovs import driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_3d79b82e","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":49},"in_reply_to":"3f4b6375_a99e92b5","updated":"2017-10-20 15:16:07.000000000","message":"Done","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"}],"releasenotes/notes/sfc-tap-port-pair-db6b2f3d29520c9b.yaml":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"29df108a7028d2e8e792118ab7483816dafe579a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Function."},{"line_number":5,"context_line":"    These SFs are deployed to monitor/analyze network traffic. One of the"},{"line_number":6,"context_line":"    widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` key of ``port-chain-parameters``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bf091321_4873ab16","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":76},"updated":"2017-06-08 16:13:53.000000000","message":"Functions","commit_id":"1b3567895ccea92dc0c1e71d723bdb7eaf3887ee"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4063d1afa290602be14b82a7b87f54750ad01d19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Function."},{"line_number":5,"context_line":"    These SFs are deployed to monitor/analyze network traffic. One of the"},{"line_number":6,"context_line":"    widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` key of ``port-chain-parameters``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f0e0f27_6cc21fec","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":76},"in_reply_to":"bf091321_4873ab16","updated":"2017-06-09 11:42:16.000000000","message":"Done","commit_id":"1b3567895ccea92dc0c1e71d723bdb7eaf3887ee"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"29df108a7028d2e8e792118ab7483816dafe579a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Function."},{"line_number":5,"context_line":"    These SFs are deployed to monitor/analyze network traffic. One of the"},{"line_number":6,"context_line":"    widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` key of ``port-chain-parameters``"},{"line_number":8,"context_line":"    set to True."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bf091321_8852e366","line":5,"range":{"start_line":5,"start_character":30,"end_line":5,"end_character":37},"updated":"2017-06-08 16:13:53.000000000","message":"passively monitor ....","commit_id":"1b3567895ccea92dc0c1e71d723bdb7eaf3887ee"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4063d1afa290602be14b82a7b87f54750ad01d19","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Function."},{"line_number":5,"context_line":"    These SFs are deployed to monitor/analyze network traffic. One of the"},{"line_number":6,"context_line":"    widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` key of ``port-chain-parameters``"},{"line_number":8,"context_line":"    set to True."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f0e0f27_2cbc2768","line":5,"range":{"start_line":5,"start_character":30,"end_line":5,"end_character":37},"in_reply_to":"bf091321_8852e366","updated":"2017-06-09 11:42:16.000000000","message":"Done","commit_id":"1b3567895ccea92dc0c1e71d723bdb7eaf3887ee"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"e607b39ae7c6783d033b1eaf5a2c7cddf147989d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    to True."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp"},{"line_number":11,"context_line":"    --port-chain-parameters tap_enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f201791_2fc82b20","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":27},"updated":"2017-06-23 14:08:12.000000000","message":"--port-pair-group-parameters","commit_id":"e320f896375dd273813943fc0ad4476a9d7bad9b"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"df3967d1_45054510","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":59},"updated":"2017-08-04 15:52:44.000000000","message":"Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf3e73b7_8d1316b9","line":4,"range":{"start_line":4,"start_character":56,"end_line":4,"end_character":59},"in_reply_to":"df3967d1_45054510","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"b11c8214421b145a3728a79cd084cc39e8cd331f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"df3967d1_8201e308","line":6,"range":{"start_line":6,"start_character":60,"end_line":6,"end_character":63},"updated":"2017-08-04 15:52:44.000000000","message":"a Tap","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"32537aca9018fc7f31143855c83ee191ea79cd12","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of TAP Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be TAP, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf3e73b7_6d18f2d2","line":6,"range":{"start_line":6,"start_character":60,"end_line":6,"end_character":63},"in_reply_to":"df3967d1_8201e308","updated":"2017-08-05 18:01:16.000000000","message":"Done","commit_id":"b2f7baa88540fd5557b7097de58c03d349962663"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of Tap Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5f4e5783_f7dd5114","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":40},"updated":"2017-10-13 10:43:39.000000000","message":"enable-tap from current discussions in https://review.openstack.org/#/c/491185/","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of Tap Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3f4b6375_7b41830b","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":40},"in_reply_to":"5f4e5783_2d64b6e3","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f214cab638ebcbebb3b0663c157dfda574750497","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Service Function Chaining now supports insertion of Tap Service Functions."},{"line_number":5,"context_line":"    These SFs are deployed to passively monitor/analyze network traffic. One of"},{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5f4e5783_2d64b6e3","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":40},"in_reply_to":"5f4e5783_f7dd5114","updated":"2017-10-13 12:04:20.000000000","message":"Oops :) I am sorry, will fix this.","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e8684fcdd1153771bd6de397fee590dbc421e8de","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5f4e5783_17a8ed74","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":80},"updated":"2017-10-13 10:43:39.000000000","message":"To update to the OSC version :)","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"959050d5f1a587f54bc0a6e8bdd7d3c7e65e7172","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair Group"},{"line_number":7,"context_line":"    should be created with ``tap_enabled`` parameter set to True."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --tap-enabled\u003dTrue"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3f4b6375_9b3aff95","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":80},"in_reply_to":"5f4e5783_17a8ed74","updated":"2017-10-20 08:49:48.000000000","message":"Done","commit_id":"446297ae5e9135a1ea2f312e7c931b93067ded86"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"dabd4dd9542c65bff38211b77d33c85586236257","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair"},{"line_number":7,"context_line":"    Group should be created with ``--enable-tap`` flag."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --enable-tap"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f4b6375_4c7e0c1a","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":34},"updated":"2017-10-20 13:26:36.000000000","message":"openstack port pair group create","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"539155d7e6edae883ad190b8d55521ffa8b47cf4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the widely deployed use case is IDS. To flag a SF to be Tap, Port Pair"},{"line_number":7,"context_line":"    Group should be created with ``--enable-tap`` flag."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    neutron port-pair-group-create tap-ppg --port-pair tap-pp --enable-tap"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f4b6375_3d9e5854","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":34},"in_reply_to":"3f4b6375_4c7e0c1a","updated":"2017-10-20 15:16:36.000000000","message":"Done","commit_id":"b6ef5b3abc43a6dda4f1268fce6252ecefca9413"}]}
