)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"eaad2c958738cb5c709340dc220a1e0f4dff6519","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Follow OVSCookieBridge refactoring in neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The refactoring made in I55835a34d8fba7a139dce93f99cbff54584d695c"},{"line_number":10,"context_line":"requires some adjustements in n8g-sfc unit tests, and also"},{"line_number":11,"context_line":"allow simplifying the code a bit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For this change, it ended up being simpler to not check in each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ffe62b97_36d82579","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":37},"updated":"2017-03-29 09:40:26.000000000","message":"I think I\u0027m gonna steal this.","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"209befe2c45a0a93bc508fb77498f38a4185d211","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Follow OVSCookieBridge refactoring in neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The refactoring made in I55835a34d8fba7a139dce93f99cbff54584d695c"},{"line_number":10,"context_line":"requires some adjustements in n8g-sfc unit tests, and also"},{"line_number":11,"context_line":"allow simplifying the code a bit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For this change, it ended up being simpler to not check in each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ffe62b97_d251fe37","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"ffe62b97_36d82579","updated":"2017-03-29 18:44:09.000000000","message":":)","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5b14ff33b2be7681061a69d890ae61c9ea3c61d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Follow OVSCookieBridge refactoring in neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The refactoring made in I55835a34d8fba7a139dce93f99cbff54584d695c"},{"line_number":10,"context_line":"requires some adjustements in n8g-sfc unit tests, and also"},{"line_number":11,"context_line":"allow simplifying the code a bit."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For this change, it ended up being simpler to not check in each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ffe62b97_26069753","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"ffe62b97_d251fe37","updated":"2017-03-29 19:13:24.000000000","message":"++ ;)","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"}],"networking_sfc/services/sfc/common/ovs_ext_lib.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5b14ff33b2be7681061a69d890ae61c9ea3c61d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_c6480bb4","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":56},"updated":"2017-03-29 19:13:24.000000000","message":"If you\u0027ll respin, could you do this in more secure way?\n\n \"-O {}\".format(sfc_ovs_bridge.of_version)\n\nor at least\n\n \"-O %s\" % sfc_ovs_bridge.of_version","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e04ac89bd77027748454ab902a548530a255fcb3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_b9050a7d","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":56},"in_reply_to":"dfeb2761_5634924a","updated":"2017-03-31 00:33:16.000000000","message":"See. Would make sense :) Now we can refactor it ;)","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a953094e71e2412e171489f34102a6355ae341fa","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_5634924a","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":56},"in_reply_to":"ffe62b97_c6480bb4","updated":"2017-03-30 20:54:12.000000000","message":"Well, I actually mean to remove this completely, see I16a35b5d6c54901899d24fc94bd3438c1f1be05e where \u0027-O\u0027 and the version are actually made separate args, which I think is even cleaner.","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"d5b14ff33b2be7681061a69d890ae61c9ea3c61d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return masks"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class SfcOVSBridgeExt(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_067b9327","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":20},"updated":"2017-03-29 19:13:24.000000000","message":"Nice piece of code.","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e04ac89bd77027748454ab902a548530a255fcb3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return masks"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class SfcOVSBridgeExt(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_990a4688","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":20},"in_reply_to":"dfeb2761_36eb4eb1","updated":"2017-03-31 00:33:16.000000000","message":"It still, doesn\u0027t change beauty of it :)","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a953094e71e2412e171489f34102a6355ae341fa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return masks"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def decorate_run_ofctl(f, sfc_ovs_bridge):"},{"line_number":49,"context_line":"    @six.wraps(f)"},{"line_number":50,"context_line":"    def run_ofctl(cmd, args, process_input\u003dNone):"},{"line_number":51,"context_line":"        return f(cmd, [\"-O \" + sfc_ovs_bridge.of_version] + args,"},{"line_number":52,"context_line":"                 process_input)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return run_ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class SfcOVSBridgeExt(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_36eb4eb1","line":54,"range":{"start_line":48,"start_character":0,"end_line":54,"end_character":20},"in_reply_to":"ffe62b97_067b9327","updated":"2017-03-30 20:54:12.000000000","message":"I\u0027d be happy to say I\u0027m proud, but I learned the pattern from a suggestion from Kevin Benton on another change.","commit_id":"794dc51398b45db5515fdaa05a609244b5637dfd"}]}
