)]}'
{"networking_sfc/services/sfc/common/ovs_ext_lib.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"bf131c329059b6e349189d972d2d92e9b9f827df","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def __init__(self, ovs_bridge):"},{"line_number":51,"context_line":"        self.bridge \u003d ovs_bridge"},{"line_number":52,"context_line":"        # OpenFlow 1.1 for groups"},{"line_number":53,"context_line":"        # OpenFlow 1.3 for xxxxx?"},{"line_number":54,"context_line":"        # self.bridge.add_protocols(ovs_consts.OPENFLOW13)"},{"line_number":55,"context_line":"        self.bridge.add_protocols(ovs_consts.OPENFLOW11)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_fd194022","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":32},"updated":"2017-03-30 13:04:10.000000000","message":"What is xxxxx? Is this going to get filled in before or after this change merges?","commit_id":"876a5e5b68121da15c4ca71336a55bd839a8f45c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9e9cdda0990eb2ad6a01ae55e47bc1bd8778da5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def __init__(self, ovs_bridge):"},{"line_number":51,"context_line":"        self.bridge \u003d ovs_bridge"},{"line_number":52,"context_line":"        # OpenFlow 1.1 for groups"},{"line_number":53,"context_line":"        # OpenFlow 1.3 for xxxxx?"},{"line_number":54,"context_line":"        # self.bridge.add_protocols(ovs_consts.OPENFLOW13)"},{"line_number":55,"context_line":"        self.bridge.add_protocols(ovs_consts.OPENFLOW11)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e572ba49","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":32},"in_reply_to":"ffe62b97_fd194022","updated":"2017-03-30 16:36:27.000000000","message":"I suppose the comment is there as sfc_driver.py currently sets version up to 1.3.\nBut indeed as far as I know 1.1 is the only one really needed? That specific bit requires some more digging, but at least tests still look happy","commit_id":"876a5e5b68121da15c4ca71336a55bd839a8f45c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"16b32d69b9776b6520d8e91ba4d0a6929642a552","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __init__(self, ovs_bridge):"},{"line_number":50,"context_line":"        self.bridge \u003d ovs_bridge"},{"line_number":51,"context_line":"        # OpenFlow 1.1 for groups"},{"line_number":52,"context_line":"        # OpenFlow 1.3 for xxxxx?"},{"line_number":53,"context_line":"        # self.bridge.add_protocols(ovs_consts.OPENFLOW13)"},{"line_number":54,"context_line":"        self.bridge.add_protocols(ovs_consts.OPENFLOW11)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # proxy most methods to self.bridge"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_d850be35","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":58},"updated":"2017-03-31 09:02:53.000000000","message":"I\u0027ll -1 since there\u0027s no need to keep this 1.1 vs 1.3 debate in the code.","commit_id":"3d6e28d4f892c81378114835e5bc554de9f025fe"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"fe8c00d9deed22d481a7322d104852490f705168","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __init__(self, ovs_bridge):"},{"line_number":50,"context_line":"        self.bridge \u003d ovs_bridge"},{"line_number":51,"context_line":"        # OpenFlow 1.1 for groups"},{"line_number":52,"context_line":"        # OpenFlow 1.3 for xxxxx?"},{"line_number":53,"context_line":"        # self.bridge.add_protocols(ovs_consts.OPENFLOW13)"},{"line_number":54,"context_line":"        self.bridge.add_protocols(ovs_consts.OPENFLOW11)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # proxy most methods to self.bridge"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_318a1c1b","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":58},"in_reply_to":"dfeb2761_d850be35","updated":"2017-03-31 14:32:17.000000000","message":"Agreed, this was not intended to be kept.\nI wanted to see if the CI tempest jobs would be happy with it.","commit_id":"3d6e28d4f892c81378114835e5bc554de9f025fe"}]}