)]}'
{"networking_sfc/db/migration/alembic_migrations/versions/pike/expand/a3ad63aa834f_extra_attributes_for_pathnode.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15025507210d17b09f87fafc99df9e6e728c5bb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_f555b91e","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":26},"updated":"2017-06-12 05:12:03.000000000","message":"Please update accordingly","commit_id":"014853525c5e7cfb75e542ca3497ba78ff1d1c8d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15025507210d17b09f87fafc99df9e6e728c5bb6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                  sa.Column(\u0027tap_enabled\u0027, sa.Boolean(), nullable\u003dFalse,"},{"line_number":35,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":36,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027previous_node_id\u0027, sa.String(length\u003d36)))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_f52a598e","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":45},"updated":"2017-06-12 05:12:03.000000000","message":"What is the significance of this field?","commit_id":"014853525c5e7cfb75e542ca3497ba78ff1d1c8d"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"247c12e15b9b85bf02aceba613f235d312dd5f67","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                  sa.Column(\u0027tap_enabled\u0027, sa.Boolean(), nullable\u003dFalse,"},{"line_number":35,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":36,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027previous_node_id\u0027, sa.String(length\u003d36)))"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_09301956","line":37,"range":{"start_line":37,"start_character":28,"end_line":37,"end_character":45},"in_reply_to":"7f231b9d_f52a598e","updated":"2017-06-12 09:29:34.000000000","message":"Hi Vikram, Thanks for review. Need this node-id to configure OVS flows for SF deployed next to TAP. For eg.\n\nSrc Port -\u003e SF-1 -\u003e TAP SF -\u003e SF-2 -\u003e Dest Port \n\nSF-1 sends packet to both TAP SF \u0026 SF-2. To configure egress flows from SF-1 to SF-2, it is needed to know the egress ports of previous node of TAP SF. This flow gets realised during TAP node processing.","commit_id":"014853525c5e7cfb75e542ca3497ba78ff1d1c8d"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027tap_enabled\u0027, sa.Boolean(), nullable\u003dFalse,"},{"line_number":35,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":36,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027previous_node_id\u0027, sa.String(length\u003d36)))"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_2e4a56ab","line":37,"range":{"start_line":36,"start_character":19,"end_line":37,"end_character":70},"updated":"2017-06-25 18:15:54.000000000","message":"Foreign Key?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027tap_enabled\u0027, sa.Boolean(), nullable\u003dFalse,"},{"line_number":35,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":36,"context_line":"    op.add_column(\u0027sfc_path_nodes\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027previous_node_id\u0027, sa.String(length\u003d36)))"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_4de9ae7e","line":37,"range":{"start_line":36,"start_character":19,"end_line":37,"end_character":70},"in_reply_to":"5f201791_2e4a56ab","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b331edfd177a63d2970aa6186e23cc55ebb4c1c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f5c4f37_42b16a8f","line":1,"updated":"2017-09-21 12:06:42.000000000","message":"To move to queens before merging this","commit_id":"c9d54beedf27df75fb7824ebe4412e22a0720f3a"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"55f5f83d23bb23331a76c8a44709499640d3761b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Futurewei. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"7f515b1d_97a0cba7","line":1,"in_reply_to":"9f5c4f37_42b16a8f","updated":"2017-09-22 05:25:48.000000000","message":"Will be done.","commit_id":"c9d54beedf27df75fb7824ebe4412e22a0720f3a"}],"networking_sfc/services/sfc/agent/extensions/openvswitch/sfc_driver.py":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"c4344ddb8f06080057554bad7c8f816da36e765b","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        match_field \u003d self._build_ingress_common_match_field(vif_port, vlan)"},{"line_number":516,"context_line":"        if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":517,"context_line":"            match_field.pop(\u0027dl_dst\u0027, None)"},{"line_number":518,"context_line":"            match_field.update(dl_src\u003dflowrule[\u0027mac_address\u0027])"},{"line_number":519,"context_line":"        match_field[\u0027dl_type\u0027] \u003d constants.ETH_TYPE_MPLS"},{"line_number":520,"context_line":"        match_field[\u0027mpls_label\u0027] \u003d flowrule[\u0027nsp\u0027] \u003c\u003c 8 | flowrule[\u0027nsi\u0027] + 1"},{"line_number":521,"context_line":"        return match_field"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_93a20f4b","line":518,"range":{"start_line":518,"start_character":31,"end_line":518,"end_character":37},"updated":"2017-05-26 17:50:28.000000000","message":"why is this done?","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e3fbaca4342f9e73bcf591a709fce17921b157c8","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        match_field \u003d self._build_ingress_common_match_field(vif_port, vlan)"},{"line_number":516,"context_line":"        if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":517,"context_line":"            match_field.pop(\u0027dl_dst\u0027, None)"},{"line_number":518,"context_line":"            match_field.update(dl_src\u003dflowrule[\u0027mac_address\u0027])"},{"line_number":519,"context_line":"        match_field[\u0027dl_type\u0027] \u003d constants.ETH_TYPE_MPLS"},{"line_number":520,"context_line":"        match_field[\u0027mpls_label\u0027] \u003d flowrule[\u0027nsp\u0027] \u003c\u003c 8 | flowrule[\u0027nsi\u0027] + 1"},{"line_number":521,"context_line":"        return match_field"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_7c0e3fe6","line":518,"range":{"start_line":518,"start_character":31,"end_line":518,"end_character":37},"in_reply_to":"ff0f0b1f_93a20f4b","updated":"2017-05-29 12:13:23.000000000","message":"For TAP the classification happens based on \u0027dl_src\u0027. As like default insertion, \u0027dst_mac\u0027 for TAP SF is not rewritten.","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"c4344ddb8f06080057554bad7c8f816da36e765b","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":587,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":588,"context_line":"            # can use OXM reg also"},{"line_number":589,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":590,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""},{"line_number":591,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":592,"context_line":"                                copy_reg0, copy_reg1]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_f3602b38","line":589,"range":{"start_line":589,"start_character":25,"end_line":589,"end_character":41},"updated":"2017-05-26 17:50:28.000000000","message":"explain how REG0, 1 are being used","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e3fbaca4342f9e73bcf591a709fce17921b157c8","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":587,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":588,"context_line":"            # can use OXM reg also"},{"line_number":589,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":590,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""},{"line_number":591,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":592,"context_line":"                                copy_reg0, copy_reg1]"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_bc2df747","line":589,"range":{"start_line":589,"start_character":25,"end_line":589,"end_character":41},"in_reply_to":"ff0f0b1f_f3602b38","updated":"2017-05-29 12:13:23.000000000","message":"They are used to store \u0027eth_dst\u0027 of original pkt.","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"c4344ddb8f06080057554bad7c8f816da36e765b","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                    ACROSS_SUBNET_TABLE))"},{"line_number":660,"context_line":"        buckets.append(bucket)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def _update_encactions(self, enc_actions, flow_rule):"},{"line_number":663,"context_line":"        copy_src_eth_hdr1 \u003d \"move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\""},{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_93032f74","line":662,"range":{"start_line":662,"start_character":8,"end_line":662,"end_character":26},"updated":"2017-05-26 17:50:28.000000000","message":"rename this _update_tap_enc_actions, as this is specific to tap operations","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e3fbaca4342f9e73bcf591a709fce17921b157c8","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                    ACROSS_SUBNET_TABLE))"},{"line_number":660,"context_line":"        buckets.append(bucket)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def _update_encactions(self, enc_actions, flow_rule):"},{"line_number":663,"context_line":"        copy_src_eth_hdr1 \u003d \"move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\""},{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_fc1a4f15","line":662,"range":{"start_line":662,"start_character":8,"end_line":662,"end_character":26},"in_reply_to":"ff0f0b1f_93032f74","updated":"2017-05-29 12:13:23.000000000","message":"L673 - it returns the original actions for tap_enabled\u003dFalse node.","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"c4344ddb8f06080057554bad7c8f816da36e765b","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        buckets.append(bucket)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def _update_encactions(self, enc_actions, flow_rule):"},{"line_number":663,"context_line":"        copy_src_eth_hdr1 \u003d \"move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\""},{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"},{"line_number":666,"context_line":"        if flow_rule.get(\u0027next_hop_tap_enabled\u0027):"},{"line_number":667,"context_line":"            return copy_src_eth_header + (\"NORMAL,resubmit(,%s)\" %"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_d32e47f9","line":664,"range":{"start_line":663,"start_character":8,"end_line":664,"end_character":77},"updated":"2017-05-26 17:50:28.000000000","message":"can you explain what this does?","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e3fbaca4342f9e73bcf591a709fce17921b157c8","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        buckets.append(bucket)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    def _update_encactions(self, enc_actions, flow_rule):"},{"line_number":663,"context_line":"        copy_src_eth_hdr1 \u003d \"move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\""},{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"},{"line_number":666,"context_line":"        if flow_rule.get(\u0027next_hop_tap_enabled\u0027):"},{"line_number":667,"context_line":"            return copy_src_eth_header + (\"NORMAL,resubmit(,%s)\" %"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3ce68718","line":664,"range":{"start_line":663,"start_character":8,"end_line":664,"end_character":77},"in_reply_to":"ff0f0b1f_d32e47f9","updated":"2017-05-29 12:13:23.000000000","message":"Before OVS starts any processing on pkts coming to wire, it stores the pkt\u0027s dst ethernet address.","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"c4344ddb8f06080057554bad7c8f816da36e765b","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"},{"line_number":666,"context_line":"        if flow_rule.get(\u0027next_hop_tap_enabled\u0027):"},{"line_number":667,"context_line":"            return copy_src_eth_header + (\"NORMAL,resubmit(,%s)\" %"},{"line_number":668,"context_line":"                                          TAP_CLASSIFIER_TABLE)"},{"line_number":669,"context_line":"        elif flow_rule.get(\u0027tap_enabled\u0027) and flow_rule[\u0027next_hops\u0027]:"},{"line_number":670,"context_line":"            return (copy_src_eth_header + enc_actions +"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_9338cf3d","line":667,"range":{"start_line":667,"start_character":43,"end_line":667,"end_character":63},"updated":"2017-05-26 17:50:28.000000000","message":"explain this","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e3fbaca4342f9e73bcf591a709fce17921b157c8","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        copy_src_eth_hdr2 \u003d \"move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\""},{"line_number":665,"context_line":"        copy_src_eth_header \u003d (copy_src_eth_hdr1 + copy_src_eth_hdr2)"},{"line_number":666,"context_line":"        if flow_rule.get(\u0027next_hop_tap_enabled\u0027):"},{"line_number":667,"context_line":"            return copy_src_eth_header + (\"NORMAL,resubmit(,%s)\" %"},{"line_number":668,"context_line":"                                          TAP_CLASSIFIER_TABLE)"},{"line_number":669,"context_line":"        elif flow_rule.get(\u0027tap_enabled\u0027) and flow_rule[\u0027next_hops\u0027]:"},{"line_number":670,"context_line":"            return (copy_src_eth_header + enc_actions +"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_7cb51fee","line":667,"range":{"start_line":667,"start_character":43,"end_line":667,"end_character":63},"in_reply_to":"ff0f0b1f_9338cf3d","updated":"2017-05-29 12:13:23.000000000","message":"This is when the source is not any SF but any other port (for eg. logical_src_port/logical_dst_port). Packet should traverse normal path also.\n\nDid you meant to keep comment in code ?","commit_id":"4b35e91ac3c192c4dcbc5702c456581143fbf8cc"},{"author":{"_account_id":23142,"name":"Freya Dian Yu","email":"freyadyu@gmail.com","username":"dianyu"},"change_message_id":"804ca0aee2413fbecf72bcfa4833e6a2c9c33000","unresolved":false,"context_lines":[{"line_number":574,"context_line":"                                      subnet_actions_list, dl_type):"},{"line_number":575,"context_line":"        if item.get(\u0027tap_enabled\u0027):"},{"line_number":576,"context_line":"            egress_port \u003d self.br_int.get_vif_port_by_id(flowrule[\u0027egress\u0027])"},{"line_number":577,"context_line":"            if not egress_port:"},{"line_number":578,"context_line":"                return"},{"line_number":579,"context_line":"            in_port \u003d egress_port.ofport"},{"line_number":580,"context_line":"            vif_mac \u003d egress_port.vif_mac"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_b1cbb951","line":577,"range":{"start_line":577,"start_character":12,"end_line":577,"end_character":30},"updated":"2017-05-30 22:15:32.000000000","message":"On driver.py L:1475 passed egress\u003dNone to agent with TAP flowrule, will this statement always return True? On the other hand, could you please add comments where you duplicate flow packet deliver to both passive SF ingress and its next downstream SF?","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"a222016e62a794409d7e634364f9dd73cb911edf","unresolved":false,"context_lines":[{"line_number":574,"context_line":"                                      subnet_actions_list, dl_type):"},{"line_number":575,"context_line":"        if item.get(\u0027tap_enabled\u0027):"},{"line_number":576,"context_line":"            egress_port \u003d self.br_int.get_vif_port_by_id(flowrule[\u0027egress\u0027])"},{"line_number":577,"context_line":"            if not egress_port:"},{"line_number":578,"context_line":"                return"},{"line_number":579,"context_line":"            in_port \u003d egress_port.ofport"},{"line_number":580,"context_line":"            vif_mac \u003d egress_port.vif_mac"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_6013ff5d","line":577,"range":{"start_line":577,"start_character":12,"end_line":577,"end_character":30},"in_reply_to":"df140735_b1cbb951","updated":"2017-05-31 12:11:09.000000000","message":"driver.py L:1475 -\u003e is meant to construct the flow which outputs the copied pkt to ingress port of TAP SF. \n\nThis function is to classify \u0026 build flow coming out from src_port destined to Logical Dest. Port/Default SF.\n\nI will add comment, pls chk L657-L667 for same.","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"REVERSE_GROUP_NUMBER_OFFSET \u003d 7000"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"TAP_CLASSIFIER_TABLE \u003d 7"},{"line_number":56,"context_line":"# This table flood TAP packets on tunnel ports"},{"line_number":57,"context_line":"TAP_TUNNEL_OUTPUT_TABLE \u003d 25"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_eecd7e31","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":18},"updated":"2017-06-25 18:15:54.000000000","message":"nit: floods","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"REVERSE_GROUP_NUMBER_OFFSET \u003d 7000"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"TAP_CLASSIFIER_TABLE \u003d 7"},{"line_number":56,"context_line":"# This table flood TAP packets on tunnel ports"},{"line_number":57,"context_line":"TAP_TUNNEL_OUTPUT_TABLE \u003d 25"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_2dee6a88","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":18},"in_reply_to":"5f201791_eecd7e31","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.local_ip \u003d None"},{"line_number":83,"context_line":"        self.patch_tun_ofport \u003d None"},{"line_number":84,"context_line":"        self.vlan_manager \u003d None"},{"line_number":85,"context_line":"        self.br_tun \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def consume_api(self, agent_api):"},{"line_number":88,"context_line":"        self.agent_api \u003d agent_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_6ed96ef1","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":26},"updated":"2017-06-25 18:15:54.000000000","message":"nit: move to L81","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.local_ip \u003d None"},{"line_number":83,"context_line":"        self.patch_tun_ofport \u003d None"},{"line_number":84,"context_line":"        self.vlan_manager \u003d None"},{"line_number":85,"context_line":"        self.br_tun \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def consume_api(self, agent_api):"},{"line_number":88,"context_line":"        self.agent_api \u003d agent_api"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_0d03a644","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":26},"in_reply_to":"5f201791_6ed96ef1","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            for item in next_hops:"},{"line_number":360,"context_line":"                # all next hops share same pp_corr, enforced by higher layers"},{"line_number":361,"context_line":"                flowrule.update(next_hop_tap_enabled\u003ditem.get(\u0027tap_enabled\u0027))"},{"line_number":362,"context_line":"                pp_corr_nh \u003d item.get(\u0027pp_corr\u0027, None)"},{"line_number":363,"context_line":"                if flowrule[\u0027fwd_path\u0027]:"},{"line_number":364,"context_line":"                    bucket \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_6e028e3f","line":361,"range":{"start_line":361,"start_character":16,"end_line":361,"end_character":77},"updated":"2017-06-25 18:15:54.000000000","message":"flowrule already contains the needed information inside the next_hops, why copy it to the flowrule root?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            for item in next_hops:"},{"line_number":360,"context_line":"                # all next hops share same pp_corr, enforced by higher layers"},{"line_number":361,"context_line":"                flowrule.update(next_hop_tap_enabled\u003ditem.get(\u0027tap_enabled\u0027))"},{"line_number":362,"context_line":"                pp_corr_nh \u003d item.get(\u0027pp_corr\u0027, None)"},{"line_number":363,"context_line":"                if flowrule[\u0027fwd_path\u0027]:"},{"line_number":364,"context_line":"                    bucket \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_edff4232","line":361,"range":{"start_line":361,"start_character":16,"end_line":361,"end_character":77},"in_reply_to":"5f201791_6e028e3f","updated":"2017-08-05 19:00:32.000000000","message":"Changed.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                rev_group_id \u003d group_id + REVERSE_GROUP_NUMBER_OFFSET"},{"line_number":421,"context_line":"                enc_actions +\u003d \"group:%d\" % rev_group_id"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            enc_actions \u003d self._update_encactions(enc_actions, flowrule)"},{"line_number":424,"context_line":"            # to uninstall the removed flow classifiers"},{"line_number":425,"context_line":"            self._setup_local_switch_flows_on_int_br("},{"line_number":426,"context_line":"                flowrule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_8e8a8abc","line":423,"range":{"start_line":423,"start_character":39,"end_line":423,"end_character":49},"updated":"2017-06-25 18:15:54.000000000","message":"nit: looks like a word mispelled (like encapsulations), maybe add the underscore here too.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                rev_group_id \u003d group_id + REVERSE_GROUP_NUMBER_OFFSET"},{"line_number":421,"context_line":"                enc_actions +\u003d \"group:%d\" % rev_group_id"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            enc_actions \u003d self._update_encactions(enc_actions, flowrule)"},{"line_number":424,"context_line":"            # to uninstall the removed flow classifiers"},{"line_number":425,"context_line":"            self._setup_local_switch_flows_on_int_br("},{"line_number":426,"context_line":"                flowrule,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_cdfc7e40","line":423,"range":{"start_line":423,"start_character":39,"end_line":423,"end_character":49},"in_reply_to":"5f201791_8e8a8abc","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                add_flow\u003dTrue,"},{"line_number":437,"context_line":"                match_inport\u003dmatch_inport)"},{"line_number":438,"context_line":"        else:"},{"line_number":439,"context_line":"            if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":440,"context_line":"                return"},{"line_number":441,"context_line":"            end_of_chain_actions \u003d \u0027normal\u0027"},{"line_number":442,"context_line":"            # at the end of the chain, the header must be removed (if used)"},{"line_number":443,"context_line":"            if (node_type !\u003d constants.SRC_NODE) and pp_corr:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_ee521e3b","line":440,"range":{"start_line":439,"start_character":12,"end_line":440,"end_character":22},"updated":"2017-06-25 18:15:54.000000000","message":"Maybe move this to L352, with no elses.. it seems that something is going to get done here, but then it\u0027s simply a return.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                add_flow\u003dTrue,"},{"line_number":437,"context_line":"                match_inport\u003dmatch_inport)"},{"line_number":438,"context_line":"        else:"},{"line_number":439,"context_line":"            if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":440,"context_line":"                return"},{"line_number":441,"context_line":"            end_of_chain_actions \u003d \u0027normal\u0027"},{"line_number":442,"context_line":"            # at the end of the chain, the header must be removed (if used)"},{"line_number":443,"context_line":"            if (node_type !\u003d constants.SRC_NODE) and pp_corr:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_8d9436ea","line":440,"range":{"start_line":439,"start_character":12,"end_line":440,"end_character":22},"in_reply_to":"5f201791_ee521e3b","updated":"2017-08-05 19:00:32.000000000","message":"Modified code","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                                            end_of_chain_actions))"},{"line_number":448,"context_line":"            # to uninstall the removed flow classifiers"},{"line_number":449,"context_line":"            self._setup_local_switch_flows_on_int_br("},{"line_number":450,"context_line":"                flowrule,"},{"line_number":451,"context_line":"                flowrule[\u0027del_fcs\u0027],"},{"line_number":452,"context_line":"                None,"},{"line_number":453,"context_line":"                add_flow\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_2e8db6d2","line":450,"updated":"2017-06-25 18:15:54.000000000","message":"Nice that the longevity of this method was moved to other methods.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def _build_ingress_match_field_sfc_mpls(self, flowrule, vif_port, vlan):"},{"line_number":510,"context_line":"        match_field \u003d self._build_ingress_common_match_field(vif_port, vlan)"},{"line_number":511,"context_line":"        if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":512,"context_line":"            match_field.pop(\u0027dl_dst\u0027, None)"},{"line_number":513,"context_line":"            match_field.update(dl_src\u003dflowrule[\u0027mac_address\u0027])"},{"line_number":514,"context_line":"        match_field[\u0027dl_type\u0027] \u003d constants.ETH_TYPE_MPLS"},{"line_number":515,"context_line":"        match_field[\u0027mpls_label\u0027] \u003d flowrule[\u0027nsp\u0027] \u003c\u003c 8 | flowrule[\u0027nsi\u0027] + 1"},{"line_number":516,"context_line":"        return match_field"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_0e331a16","line":513,"range":{"start_line":511,"start_character":8,"end_line":513,"end_character":62},"updated":"2017-06-25 18:15:54.000000000","message":"This function is meant to deal with the MPLS header matching... dl_type is here only because MPLS is under it. Please move this TAP-related code to L477 for example.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def _build_ingress_match_field_sfc_mpls(self, flowrule, vif_port, vlan):"},{"line_number":510,"context_line":"        match_field \u003d self._build_ingress_common_match_field(vif_port, vlan)"},{"line_number":511,"context_line":"        if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":512,"context_line":"            match_field.pop(\u0027dl_dst\u0027, None)"},{"line_number":513,"context_line":"            match_field.update(dl_src\u003dflowrule[\u0027mac_address\u0027])"},{"line_number":514,"context_line":"        match_field[\u0027dl_type\u0027] \u003d constants.ETH_TYPE_MPLS"},{"line_number":515,"context_line":"        match_field[\u0027mpls_label\u0027] \u003d flowrule[\u0027nsp\u0027] \u003c\u003c 8 | flowrule[\u0027nsi\u0027] + 1"},{"line_number":516,"context_line":"        return match_field"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_6d99121e","line":513,"range":{"start_line":511,"start_character":8,"end_line":513,"end_character":62},"in_reply_to":"5f201791_0e331a16","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            in_port \u003d egress_port.ofport"},{"line_number":580,"context_line":"            vif_mac \u003d egress_port.vif_mac"},{"line_number":581,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":582,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":583,"context_line":"            # can use OXM reg also"},{"line_number":584,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":585,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_2e29369a","line":582,"range":{"start_line":582,"start_character":12,"end_line":582,"end_character":48},"updated":"2017-06-25 18:15:54.000000000","message":"MPLS won\u0027t be there at this point if the PP/PPG correlation is None.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            in_port \u003d egress_port.ofport"},{"line_number":580,"context_line":"            vif_mac \u003d egress_port.vif_mac"},{"line_number":581,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":582,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":583,"context_line":"            # can use OXM reg also"},{"line_number":584,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":585,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_6e58ea2f","line":582,"range":{"start_line":582,"start_character":12,"end_line":582,"end_character":48},"in_reply_to":"5f201791_2e29369a","updated":"2017-08-05 19:00:32.000000000","message":"Will fix this.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":582,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":583,"context_line":"            # can use OXM reg also"},{"line_number":584,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":585,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""},{"line_number":586,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":587,"context_line":"                                copy_reg0, copy_reg1]"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_ce3882ef","line":584,"range":{"start_line":584,"start_character":17,"end_line":584,"end_character":21},"updated":"2017-06-25 18:15:54.000000000","message":"Service Graphs is also using reg0 at the moment.. whichever patch merges first can keep it I guess..","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            strip_vlan_action \u003d \"strip_vlan,\""},{"line_number":582,"context_line":"            pop_mpls_action \u003d \"pop_mpls:0x0800,\""},{"line_number":583,"context_line":"            # can use OXM reg also"},{"line_number":584,"context_line":"            copy_reg0 \u003d \"move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\""},{"line_number":585,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""},{"line_number":586,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":587,"context_line":"                                copy_reg0, copy_reg1]"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_4d9e4e08","line":584,"range":{"start_line":584,"start_character":17,"end_line":584,"end_character":21},"in_reply_to":"5f201791_ce3882ef","updated":"2017-08-05 19:00:32.000000000","message":"Have changed the code, Service Graph can use reg0","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":585,"context_line":"            copy_reg1 \u003d \"move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\""},{"line_number":586,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":587,"context_line":"                                copy_reg0, copy_reg1]"},{"line_number":588,"context_line":"            tap_actions_list +\u003d subnet_actions_list"},{"line_number":589,"context_line":"            self.br_int.add_flow("},{"line_number":590,"context_line":"                table\u003dTAP_CLASSIFIER_TABLE,"},{"line_number":591,"context_line":"                priority\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_314f5b35","line":588,"range":{"start_line":588,"start_character":12,"end_line":588,"end_character":51},"updated":"2017-06-25 18:15:54.000000000","message":"So these actions will move to br-tun?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":587,"context_line":"                                copy_reg0, copy_reg1]"},{"line_number":588,"context_line":"            tap_actions_list +\u003d subnet_actions_list"},{"line_number":589,"context_line":"            self.br_int.add_flow("},{"line_number":590,"context_line":"                table\u003dTAP_CLASSIFIER_TABLE,"},{"line_number":591,"context_line":"                priority\u003d0,"},{"line_number":592,"context_line":"                in_port\u003din_port,"},{"line_number":593,"context_line":"                dl_src\u003dvif_mac,"},{"line_number":594,"context_line":"                dl_type\u003ddl_type,"},{"line_number":595,"context_line":"                actions\u003d\"%s\" % \u0027\u0027.join(tap_actions_list)"},{"line_number":596,"context_line":"            )"},{"line_number":597,"context_line":"            if item[\u0027local_endpoint\u0027] !\u003d self.local_ip:"},{"line_number":598,"context_line":"                self._configure_tunnel_bridge_flows(flowrule, vif_mac)"},{"line_number":599,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_8e0f2a36","line":596,"range":{"start_line":589,"start_character":0,"end_line":596,"end_character":13},"updated":"2017-06-25 18:15:54.000000000","message":"The function name hints that it will deal with the ACROSS_SUBNET_TABLE, but this condition deals with TAP_CLASSIFIER_TABLE, maybe reorganize this differently?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            tap_actions_list \u003d [strip_vlan_action, pop_mpls_action,"},{"line_number":587,"context_line":"                                copy_reg0, copy_reg1]"},{"line_number":588,"context_line":"            tap_actions_list +\u003d subnet_actions_list"},{"line_number":589,"context_line":"            self.br_int.add_flow("},{"line_number":590,"context_line":"                table\u003dTAP_CLASSIFIER_TABLE,"},{"line_number":591,"context_line":"                priority\u003d0,"},{"line_number":592,"context_line":"                in_port\u003din_port,"},{"line_number":593,"context_line":"                dl_src\u003dvif_mac,"},{"line_number":594,"context_line":"                dl_type\u003ddl_type,"},{"line_number":595,"context_line":"                actions\u003d\"%s\" % \u0027\u0027.join(tap_actions_list)"},{"line_number":596,"context_line":"            )"},{"line_number":597,"context_line":"            if item[\u0027local_endpoint\u0027] !\u003d self.local_ip:"},{"line_number":598,"context_line":"                self._configure_tunnel_bridge_flows(flowrule, vif_mac)"},{"line_number":599,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_2da30a52","line":596,"range":{"start_line":589,"start_character":0,"end_line":596,"end_character":13},"in_reply_to":"5f201791_8e0f2a36","updated":"2017-08-05 19:00:32.000000000","message":"Reorganized","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9213afcf1c65a4f1753b1792544d36bb6a253f44","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        return match_field"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def _delete_flows_mpls(self, flowrule, vif_port):"},{"line_number":569,"context_line":"        if flowrule.get(\u0027tap_enabled\u0027):"},{"line_number":570,"context_line":"            self.br_int.delete_flows("},{"line_number":571,"context_line":"                table\u003dINGRESS_TABLE,"},{"line_number":572,"context_line":"                eth_type\u003dconstants.ETH_TYPE_MPLS,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_0c268d69","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":38},"updated":"2017-10-24 10:04:22.000000000","message":"Not needed in this patch, but what about NSH? Will it work after adding some similar code? Or exclusive feature","commit_id":"ce58a3af6fbfcfc1c455233a30aa113ce444fc52"}],"networking_sfc/services/sfc/drivers/ovs/db.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    tap_enabled \u003d sa.Column(sa.Boolean(),"},{"line_number":173,"context_line":"                            nullable\u003dFalse,"},{"line_number":174,"context_line":"                            server_default\u003dsa.sql.false())"},{"line_number":175,"context_line":"    previous_node_id \u003d sa.Column(sa.String(36))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class OVSSfcDriverDB(common_db_mixin.CommonDbMixin):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_eef69e63","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":20},"updated":"2017-06-25 18:15:54.000000000","message":"Foreign Key?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    tap_enabled \u003d sa.Column(sa.Boolean(),"},{"line_number":173,"context_line":"                            nullable\u003dFalse,"},{"line_number":174,"context_line":"                            server_default\u003dsa.sql.false())"},{"line_number":175,"context_line":"    previous_node_id \u003d sa.Column(sa.String(36))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class OVSSfcDriverDB(common_db_mixin.CommonDbMixin):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_2d71cae1","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":20},"in_reply_to":"5f201791_eef69e63","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"}],"networking_sfc/services/sfc/drivers/ovs/driver.py":[{"author":{"_account_id":23142,"name":"Freya Dian Yu","email":"freyadyu@gmail.com","username":"dianyu"},"change_message_id":"804ca0aee2413fbecf72bcfa4833e6a2c9c33000","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        dst_node \u003d self.update_path_node("},{"line_number":477,"context_line":"            dst_node[\u0027id\u0027],"},{"line_number":478,"context_line":"            {\u0027previous_node_id\u0027: previous_node_id})"},{"line_number":479,"context_line":"        path_nodes.append(dst_node)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        return path_nodes"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_45bedb65","line":479,"range":{"start_line":479,"start_character":8,"end_line":479,"end_character":35},"updated":"2017-05-30 22:15:32.000000000","message":"no need, dst_node already appended onto path_nodes on line 381","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"a222016e62a794409d7e634364f9dd73cb911edf","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        dst_node \u003d self.update_path_node("},{"line_number":477,"context_line":"            dst_node[\u0027id\u0027],"},{"line_number":478,"context_line":"            {\u0027previous_node_id\u0027: previous_node_id})"},{"line_number":479,"context_line":"        path_nodes.append(dst_node)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        return path_nodes"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_7e56005f","line":479,"range":{"start_line":479,"start_character":8,"end_line":479,"end_character":35},"in_reply_to":"df140735_45bedb65","updated":"2017-05-31 12:11:09.000000000","message":"Thanks for pointing, result of bad rebase. Will fix this.","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":23142,"name":"Freya Dian Yu","email":"freyadyu@gmail.com","username":"dianyu"},"change_message_id":"804ca0aee2413fbecf72bcfa4833e6a2c9c33000","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"            \u0027id\u0027: node[\u0027id\u0027]"},{"line_number":1434,"context_line":"        }"},{"line_number":1435,"context_line":"        node_copy.update(id\u003dprev_node[\u0027id\u0027],"},{"line_number":1436,"context_line":"                         portpair_details\u003dprev_node[\u0027portpair_details\u0027],"},{"line_number":1437,"context_line":"                         node_type\u003dprev_node[\u0027node_type\u0027],"},{"line_number":1438,"context_line":"                         skip_ingress_flow_config\u003dTrue)  # Flags driver to"},{"line_number":1439,"context_line":"        # skip ingress flow configuration."}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_62043518","line":1436,"range":{"start_line":1436,"start_character":25,"end_line":1436,"end_character":71},"updated":"2017-05-30 22:15:32.000000000","message":"Why replace node[\u0027portpair_details\u0027] by prev_node[\u0027portpair_details\u0027]? Explain this.","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"a222016e62a794409d7e634364f9dd73cb911edf","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"            \u0027id\u0027: node[\u0027id\u0027]"},{"line_number":1434,"context_line":"        }"},{"line_number":1435,"context_line":"        node_copy.update(id\u003dprev_node[\u0027id\u0027],"},{"line_number":1436,"context_line":"                         portpair_details\u003dprev_node[\u0027portpair_details\u0027],"},{"line_number":1437,"context_line":"                         node_type\u003dprev_node[\u0027node_type\u0027],"},{"line_number":1438,"context_line":"                         skip_ingress_flow_config\u003dTrue)  # Flags driver to"},{"line_number":1439,"context_line":"        # skip ingress flow configuration."}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_fe845060","line":1436,"range":{"start_line":1436,"start_character":25,"end_line":1436,"end_character":71},"in_reply_to":"df140735_62043518","updated":"2017-05-31 12:11:09.000000000","message":"TAP doesn\u0027t send out packets to next-hop. Ports from previous-hop will acts as source for TAP\u0027s next, that\u0027s why the replacement.","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":23142,"name":"Freya Dian Yu","email":"freyadyu@gmail.com","username":"dianyu"},"change_message_id":"804ca0aee2413fbecf72bcfa4833e6a2c9c33000","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"                    \u0027nsi\u0027: node[\u0027nsi\u0027],"},{"line_number":1459,"context_line":"                    \u0027pc_corr\u0027: pc_corr,"},{"line_number":1460,"context_line":"                    \u0027id\u0027: node[\u0027id\u0027],"},{"line_number":1461,"context_line":"                    \u0027fwd_path\u0027: True,"},{"line_number":1462,"context_line":"                    \u0027node_type\u0027: node[\u0027node_type\u0027]}"},{"line_number":1463,"context_line":"        for each in node[\u0027prev_node\u0027][\u0027portpair_details\u0027]:"},{"line_number":1464,"context_line":"            port \u003d self.get_port_detail_by_filter(dict(id\u003deach))"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_42f01168","line":1461,"range":{"start_line":1461,"start_character":20,"end_line":1461,"end_character":36},"updated":"2017-05-30 22:15:32.000000000","message":"{\u0027fwd_path\u0027: fwd_path} instead of {\u0027fwd_path\u0027: True}","commit_id":"2b6696c76801a967a971ab9e1e9fcd50476ee3da"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":592,"context_line":"                )"},{"line_number":593,"context_line":"                self._build_tap_ingress_flow(pc_corr,"},{"line_number":594,"context_line":"                                             updated_pd,"},{"line_number":595,"context_line":"                                             pd[\u0027fwd_path\u0027],"},{"line_number":596,"context_line":"                                             delete\u003dTrue)"},{"line_number":597,"context_line":"            for pd in pds:"},{"line_number":598,"context_line":"                self.delete_path_node(pd[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_7172737d","line":595,"range":{"start_line":595,"start_character":45,"end_line":595,"end_character":59},"updated":"2017-06-25 18:15:54.000000000","message":"Tap is only compatible with fwd_path\u003dtrue right?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":592,"context_line":"                )"},{"line_number":593,"context_line":"                self._build_tap_ingress_flow(pc_corr,"},{"line_number":594,"context_line":"                                             updated_pd,"},{"line_number":595,"context_line":"                                             pd[\u0027fwd_path\u0027],"},{"line_number":596,"context_line":"                                             delete\u003dTrue)"},{"line_number":597,"context_line":"            for pd in pds:"},{"line_number":598,"context_line":"                self.delete_path_node(pd[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_0d7606da","line":595,"range":{"start_line":595,"start_character":45,"end_line":595,"end_character":59},"in_reply_to":"5f201791_7172737d","updated":"2017-08-05 19:00:32.000000000","message":"Code is compatible with both direction.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"                if egress_port[\u0027host_id\u0027] !\u003d host:"},{"line_number":1197,"context_line":"                    egress_port.update(dict(host_id\u003dhost))"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"            if ingress_port \u003d\u003d egress_port:"},{"line_number":1200,"context_line":"                # For TAP port only ingress flows are configured"},{"line_number":1201,"context_line":"                return self._get_tap_port_ingress_flow(context,"},{"line_number":1202,"context_line":"                                                       sfc_plugin,"},{"line_number":1203,"context_line":"                                                       port_chain_flowrules,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_f1344395","line":1200,"range":{"start_line":1199,"start_character":12,"end_line":1200,"end_character":64},"updated":"2017-06-25 18:15:54.000000000","message":"Does nothing need to be done for condition at L1189?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"                if egress_port[\u0027host_id\u0027] !\u003d host:"},{"line_number":1197,"context_line":"                    egress_port.update(dict(host_id\u003dhost))"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"            if ingress_port \u003d\u003d egress_port:"},{"line_number":1200,"context_line":"                # For TAP port only ingress flows are configured"},{"line_number":1201,"context_line":"                return self._get_tap_port_ingress_flow(context,"},{"line_number":1202,"context_line":"                                                       sfc_plugin,"},{"line_number":1203,"context_line":"                                                       port_chain_flowrules,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_ed72a2e3","line":1200,"range":{"start_line":1199,"start_character":12,"end_line":1200,"end_character":64},"in_reply_to":"5f201791_f1344395","updated":"2017-08-05 19:00:32.000000000","message":"No. Have introduced new check to additional scenario.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"    def _build_tap_ingress_flow(self, pc_corr, node, fwd_path, delete\u003dFalse,"},{"line_number":1443,"context_line":"                                configure\u003dTrue):"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        \"\"\"Build and call agent to add/delete ingress flows of TAP node."},{"line_number":1446,"context_line":""},{"line_number":1447,"context_line":"        :param pc_corr:"},{"line_number":1448,"context_line":"        :param node:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_1130df9e","line":1445,"range":{"start_line":1445,"start_character":17,"end_line":1445,"end_character":31},"updated":"2017-06-25 18:15:54.000000000","message":"Agent is not called here.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                    flowrule.update("},{"line_number":1475,"context_line":"                        mac_address\u003d(port[\u0027in_mac_address\u0027]"},{"line_number":1476,"context_line":"                                     or port[\u0027mac_address\u0027]))"},{"line_number":1477,"context_line":"            else:"},{"line_number":1478,"context_line":"                continue"},{"line_number":1479,"context_line":"            for pp_id in node[\u0027curr_node\u0027][\u0027portpair_details\u0027]:"},{"line_number":1480,"context_line":"                _port \u003d self.get_port_detail_by_filter(dict(id\u003dpp_id))"},{"line_number":1481,"context_line":"                if _port:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_510097ab","line":1478,"range":{"start_line":1477,"start_character":0,"end_line":1478,"end_character":24},"updated":"2017-06-25 18:15:54.000000000","message":"A bit odd and confusing to first look at, consider moving this up as \"if not port: continue\" and getting rid of the \"if port:\"","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                    flowrule.update("},{"line_number":1475,"context_line":"                        mac_address\u003d(port[\u0027in_mac_address\u0027]"},{"line_number":1476,"context_line":"                                     or port[\u0027mac_address\u0027]))"},{"line_number":1477,"context_line":"            else:"},{"line_number":1478,"context_line":"                continue"},{"line_number":1479,"context_line":"            for pp_id in node[\u0027curr_node\u0027][\u0027portpair_details\u0027]:"},{"line_number":1480,"context_line":"                _port \u003d self.get_port_detail_by_filter(dict(id\u003dpp_id))"},{"line_number":1481,"context_line":"                if _port:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_cd7fdea9","line":1478,"range":{"start_line":1477,"start_character":0,"end_line":1478,"end_character":24},"in_reply_to":"5f201791_510097ab","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2cbc53167f9e72f53da98123b2adcebf591c5cdc","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"        # This method updates \u0027nsi\u0027 of nodes in service chain. \u0027nsi\u0027 is"},{"line_number":1508,"context_line":"        # assigned to nodes in decreasing order. For eg., if the nodes are"},{"line_number":1509,"context_line":"        # like: SRC_NODE -\u003e TAP_NODE -\u003e DEFAULT_NODE -\u003e DST_NODE - \u0027nsi\u0027 for"},{"line_number":1510,"context_line":"        # corresponding nodes will be - 511 -\u003e 510 -\u003e 509 -\u003e 508 , where 510"},{"line_number":1511,"context_line":"        # is of TAP_NODE. In this method, TAP_NODES \u0027nsi\u0027 are re-assigned"},{"line_number":1512,"context_line":"        # from the DST_NODE onward, for eg. the new TAP_NODE \u0027nsi\u0027 would be"},{"line_number":1513,"context_line":"        # 508 instead of 510, the resultant chain \u0027nsi\u0027 - SRC_NODE (511) -\u003e"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_4421824d","line":1510,"range":{"start_line":1510,"start_character":40,"end_line":1510,"end_character":64},"updated":"2017-08-08 13:46:26.000000000","message":"nsi is 8bit - these numbers are for nsp\u003d1 x8 shifted left plus the nsi.","commit_id":"5a1558b34051fc6fb74ce84b38575cfffcb99afd"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"85feeeacc8bbfbc82f3a8f99dbe327cce0973757","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"        # This method updates \u0027nsi\u0027 of nodes in service chain. \u0027nsi\u0027 is"},{"line_number":1508,"context_line":"        # assigned to nodes in decreasing order. For eg., if the nodes are"},{"line_number":1509,"context_line":"        # like: SRC_NODE -\u003e TAP_NODE -\u003e DEFAULT_NODE -\u003e DST_NODE - \u0027nsi\u0027 for"},{"line_number":1510,"context_line":"        # corresponding nodes will be - 511 -\u003e 510 -\u003e 509 -\u003e 508 , where 510"},{"line_number":1511,"context_line":"        # is of TAP_NODE. In this method, TAP_NODES \u0027nsi\u0027 are re-assigned"},{"line_number":1512,"context_line":"        # from the DST_NODE onward, for eg. the new TAP_NODE \u0027nsi\u0027 would be"},{"line_number":1513,"context_line":"        # 508 instead of 510, the resultant chain \u0027nsi\u0027 - SRC_NODE (511) -\u003e"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_952c329a","line":1510,"range":{"start_line":1510,"start_character":40,"end_line":1510,"end_character":64},"in_reply_to":"9f436f4f_4421824d","updated":"2017-08-08 15:08:50.000000000","message":"Aah mistake, will correct the description. Thanks for pointing.","commit_id":"5a1558b34051fc6fb74ce84b38575cfffcb99afd"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9213afcf1c65a4f1753b1792544d36bb6a253f44","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            host_id, local_endpoint, network_type, segment_id, mac_address \u003d ("},{"line_number":1134,"context_line":"                self._get_port_detail_info(e_port))"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        pp_corr \u003d port_pair.get(\u0027service_function_parameters\u0027)"},{"line_number":1137,"context_line":"        if pp_corr:"},{"line_number":1138,"context_line":"            pp_corr \u003d pp_corr.get(\u0027correlation\u0027, None)"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_384bd859","line":1136,"range":{"start_line":1136,"start_character":8,"end_line":1136,"end_character":15},"updated":"2017-10-24 10:04:22.000000000","message":"Not a real fan of that rename, but I guess as it removes one variable in scope and it gets its proper value on next line, it\u0027s ok to go in","commit_id":"ce58a3af6fbfcfc1c455233a30aa113ce444fc52"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"167f04496811fc057a75c906ef432cbbccd97605","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            host_id, local_endpoint, network_type, segment_id, mac_address \u003d ("},{"line_number":1134,"context_line":"                self._get_port_detail_info(e_port))"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        pp_corr \u003d port_pair.get(\u0027service_function_parameters\u0027)"},{"line_number":1137,"context_line":"        if pp_corr:"},{"line_number":1138,"context_line":"            pp_corr \u003d pp_corr.get(\u0027correlation\u0027, None)"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_55176446","line":1136,"range":{"start_line":1136,"start_character":8,"end_line":1136,"end_character":15},"in_reply_to":"3f4b6375_384bd859","updated":"2017-10-24 11:33:50.000000000","message":"Sorry, that got overwritten during rebase. Fixed that.","commit_id":"ce58a3af6fbfcfc1c455233a30aa113ce444fc52"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"9213afcf1c65a4f1753b1792544d36bb6a253f44","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                                                       port_chain_flowrules,"},{"line_number":1208,"context_line":"                                                       port_detail_list)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"            # this is a SF if there are both egress and engress."},{"line_number":1211,"context_line":"            for i, port in enumerate(port_detail_list):"},{"line_number":1212,"context_line":"                nodes_assocs \u003d port[\u0027path_nodes\u0027]"},{"line_number":1213,"context_line":"                for assoc in nodes_assocs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_f87660a4","line":1210,"range":{"start_line":1210,"start_character":56,"end_line":1210,"end_character":63},"updated":"2017-10-24 10:04:22.000000000","message":"ingress :)","commit_id":"ce58a3af6fbfcfc1c455233a30aa113ce444fc52"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"167f04496811fc057a75c906ef432cbbccd97605","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                                                       port_chain_flowrules,"},{"line_number":1208,"context_line":"                                                       port_detail_list)"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"            # this is a SF if there are both egress and engress."},{"line_number":1211,"context_line":"            for i, port in enumerate(port_detail_list):"},{"line_number":1212,"context_line":"                nodes_assocs \u003d port[\u0027path_nodes\u0027]"},{"line_number":1213,"context_line":"                for assoc in nodes_assocs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_352aa87e","line":1210,"range":{"start_line":1210,"start_character":56,"end_line":1210,"end_character":63},"in_reply_to":"3f4b6375_f87660a4","updated":"2017-10-24 11:33:50.000000000","message":"Done","commit_id":"ce58a3af6fbfcfc1c455233a30aa113ce444fc52"}],"networking_sfc/tests/unit/services/sfc/agent/extensions/openvswitch/test_sfc_driver.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":2517,"context_line":"            None)"},{"line_number":2518,"context_line":"        self.assertEqual("},{"line_number":2519,"context_line":"            [{"},{"line_number":2520,"context_line":"                \u0027actions\u0027: (\u0027strip_vlan,pop_mpls:0x0800,\u0027"},{"line_number":2521,"context_line":"                            \u0027move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\u0027"},{"line_number":2522,"context_line":"                            \u0027move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\u0027"},{"line_number":2523,"context_line":"                            \u0027push_mpls:0x8847,set_mpls_label:65791,\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_51ee57ed","line":2520,"range":{"start_line":2520,"start_character":40,"end_line":2520,"end_character":55},"updated":"2017-06-25 18:15:54.000000000","message":"As I mentioned in sfc_driver.py, this action doesn\u0027t belong to this case.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":2517,"context_line":"            None)"},{"line_number":2518,"context_line":"        self.assertEqual("},{"line_number":2519,"context_line":"            [{"},{"line_number":2520,"context_line":"                \u0027actions\u0027: (\u0027strip_vlan,pop_mpls:0x0800,\u0027"},{"line_number":2521,"context_line":"                            \u0027move:NXM_NX_REG0[]-\u003eNXM_OF_ETH_DST[0..31],\u0027"},{"line_number":2522,"context_line":"                            \u0027move:NXM_NX_REG1[0..9]-\u003eNXM_OF_ETH_DST[32..41],\u0027"},{"line_number":2523,"context_line":"                            \u0027push_mpls:0x8847,set_mpls_label:65791,\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_ad7c9ab5","line":2520,"range":{"start_line":2520,"start_character":40,"end_line":2520,"end_character":55},"in_reply_to":"5f201791_51ee57ed","updated":"2017-08-05 19:00:32.000000000","message":"Done","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":2528,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2529,"context_line":"                \u0027table\u0027: 7"},{"line_number":2530,"context_line":"            }, {"},{"line_number":2531,"context_line":"                \u0027actions\u0027: \u0027resubmit(,25)\u0027,"},{"line_number":2532,"context_line":"                \u0027dl_src\u0027: \u002700:01:02:03:06:08\u0027,"},{"line_number":2533,"context_line":"                \u0027dl_type\u0027: 34887,"},{"line_number":2534,"context_line":"                \u0027in_port\u0027: 1,"},{"line_number":2535,"context_line":"                \u0027mpls_label\u0027: 65791,"},{"line_number":2536,"context_line":"                \u0027priority\u0027: 30,"},{"line_number":2537,"context_line":"                \u0027table\u0027: 0"},{"line_number":2538,"context_line":"            }, {"},{"line_number":2539,"context_line":"                \u0027actions\u0027: \u0027strip_vlan,load:0x21-\u003eNXM_NX_TUN_ID[],\u0027"},{"line_number":2540,"context_line":"                           \u0027output:77,output:88\u0027,"},{"line_number":2541,"context_line":"                \u0027dl_src\u0027: \u002700:01:02:03:06:08\u0027,"},{"line_number":2542,"context_line":"                \u0027dl_type\u0027: 34887,"},{"line_number":2543,"context_line":"                \u0027in_port\u0027: 1,"},{"line_number":2544,"context_line":"                \u0027mpls_label\u0027: 65791,"},{"line_number":2545,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2546,"context_line":"                \u0027table\u0027: 25"},{"line_number":2547,"context_line":"            }, {"},{"line_number":2548,"context_line":"                \u0027actions\u0027: (\u0027move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\u0027"},{"line_number":2549,"context_line":"                            \u0027move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\u0027"},{"line_number":2550,"context_line":"                            \u0027NORMAL,resubmit(,7)\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_b1dfeb38","line":2547,"range":{"start_line":2531,"start_character":0,"end_line":2547,"end_character":14},"updated":"2017-06-25 18:15:54.000000000","message":"Something should check what went to br-int and what went to br-tun..","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2546,"context_line":"                \u0027table\u0027: 25"},{"line_number":2547,"context_line":"            }, {"},{"line_number":2548,"context_line":"                \u0027actions\u0027: (\u0027move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\u0027"},{"line_number":2549,"context_line":"                            \u0027move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\u0027"},{"line_number":2550,"context_line":"                            \u0027NORMAL,resubmit(,7)\u0027),"},{"line_number":2551,"context_line":"                \u0027dl_type\u0027: 2048,"},{"line_number":2552,"context_line":"                \u0027in_port\u0027: 42,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_51c77765","line":2549,"range":{"start_line":2548,"start_character":28,"end_line":2549,"end_character":76},"updated":"2017-06-25 18:15:54.000000000","message":"I probably missed something, but why are we saving the MAC addresses to registers only to restore them in the next table?","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":2546,"context_line":"                \u0027table\u0027: 25"},{"line_number":2547,"context_line":"            }, {"},{"line_number":2548,"context_line":"                \u0027actions\u0027: (\u0027move:NXM_OF_ETH_DST[0..31]-\u003eNXM_NX_REG0[],\u0027"},{"line_number":2549,"context_line":"                            \u0027move:NXM_OF_ETH_DST[32..41]-\u003eNXM_NX_REG1[0..9],\u0027"},{"line_number":2550,"context_line":"                            \u0027NORMAL,resubmit(,7)\u0027),"},{"line_number":2551,"context_line":"                \u0027dl_type\u0027: 2048,"},{"line_number":2552,"context_line":"                \u0027in_port\u0027: 42,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_8d4b1686","line":2549,"range":{"start_line":2548,"start_character":28,"end_line":2549,"end_character":76},"in_reply_to":"5f201791_51c77765","updated":"2017-08-05 19:00:32.000000000","message":"I have changed the implementation.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"76a782ed43f2695c2593679ccbf8e1d8ee4fa12d","unresolved":false,"context_lines":[{"line_number":2922,"context_line":"    def test_delete_flow_rules_tap_node_next_hop_default_sf_del_fcs(self):"},{"line_number":2923,"context_line":"        self._prepare_delete_flow_rules_tap_node_next_hop_default_sf_del_fcs("},{"line_number":2924,"context_line":"            \u0027mpls\u0027,"},{"line_number":2925,"context_line":"            None"},{"line_number":2926,"context_line":"        )"},{"line_number":2927,"context_line":"        self.assertEqual(["},{"line_number":2928,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_b1adab9c","line":2925,"range":{"start_line":2925,"start_character":12,"end_line":2925,"end_character":16},"updated":"2017-06-25 18:15:54.000000000","message":"Please add a test with pp_corr_nh\u003d\u0027mpls\u0027.\nWhen next_hop is correlated, the pop_mpls at table 7 above (where I commented) would make sense, and the push_mpls (also in table 7) would have to be removed.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"f6303b8feabfa7771c5b765c5e9dd4e3caa420d0","unresolved":false,"context_lines":[{"line_number":2922,"context_line":"    def test_delete_flow_rules_tap_node_next_hop_default_sf_del_fcs(self):"},{"line_number":2923,"context_line":"        self._prepare_delete_flow_rules_tap_node_next_hop_default_sf_del_fcs("},{"line_number":2924,"context_line":"            \u0027mpls\u0027,"},{"line_number":2925,"context_line":"            None"},{"line_number":2926,"context_line":"        )"},{"line_number":2927,"context_line":"        self.assertEqual(["},{"line_number":2928,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_6d50f233","line":2925,"range":{"start_line":2925,"start_character":12,"end_line":2925,"end_character":16},"in_reply_to":"5f201791_b1adab9c","updated":"2017-08-05 19:00:32.000000000","message":"Added.","commit_id":"fad862d7bf813070f26a8fa5ef6dc19e54f59b05"}],"networking_sfc/tests/unit/services/sfc/drivers/ovs/test_driver.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2cbc53167f9e72f53da98123b2adcebf591c5cdc","unresolved":false,"context_lines":[{"line_number":5761,"context_line":"                self.driver.create_port_pair(pp_context)"},{"line_number":5762,"context_line":"                with self.port_pair_group(port_pair_group\u003d{"},{"line_number":5763,"context_line":"                    \u0027port_pairs\u0027: [pp[\u0027port_pair\u0027][\u0027id\u0027]],"},{"line_number":5764,"context_line":"                    \u0027tap_enabled\u0027: True"},{"line_number":5765,"context_line":"                }) as pg:"},{"line_number":5766,"context_line":"                    pg_context \u003d sfc_ctx.PortPairGroupContext("},{"line_number":5767,"context_line":"                        self.sfc_plugin, self.ctx,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_a4a5ceb7","line":5764,"range":{"start_line":5764,"start_character":20,"end_line":5764,"end_character":39},"updated":"2017-08-08 13:46:26.000000000","message":"When I mentioned the TAP should be validated at the API level I didn\u0027t mean putting it as a whole new param, but rather making sure the API was abstracted from the implementing drivers. But this is fine.","commit_id":"5a1558b34051fc6fb74ce84b38575cfffcb99afd"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"85feeeacc8bbfbc82f3a8f99dbe327cce0973757","unresolved":false,"context_lines":[{"line_number":5761,"context_line":"                self.driver.create_port_pair(pp_context)"},{"line_number":5762,"context_line":"                with self.port_pair_group(port_pair_group\u003d{"},{"line_number":5763,"context_line":"                    \u0027port_pairs\u0027: [pp[\u0027port_pair\u0027][\u0027id\u0027]],"},{"line_number":5764,"context_line":"                    \u0027tap_enabled\u0027: True"},{"line_number":5765,"context_line":"                }) as pg:"},{"line_number":5766,"context_line":"                    pg_context \u003d sfc_ctx.PortPairGroupContext("},{"line_number":5767,"context_line":"                        self.sfc_plugin, self.ctx,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_550daa35","line":5764,"range":{"start_line":5764,"start_character":20,"end_line":5764,"end_character":39},"in_reply_to":"9f436f4f_a4a5ceb7","updated":"2017-08-08 15:08:50.000000000","message":"This was done as part of separate comment given by Louis \u0026 bcafarel not yours.","commit_id":"5a1558b34051fc6fb74ce84b38575cfffcb99afd"}]}
