)]}'
{"doc/api_samples/sfc-service-graphs/service-graph-create-req.json":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5b13c7c3b4685eeaa774c6d5a88ab5bdcac97fde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{  "},{"line_number":2,"context_line":"   \"service_graph\":{  "},{"line_number":3,"context_line":"      \"name\":\"graph\","},{"line_number":4,"context_line":"      \"description\":\"one graph that uses 6 port chains\","}],"source_content_type":"application/json","patch_set":1,"id":"5f201791_7561c811","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":3},"updated":"2017-06-28 22:49:49.000000000","message":"Will clear the whitespaces.","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"}],"doc/source/contributor/ietf_sfc_encapsulation.rst":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      (Avoid deeper levels because they do not render well.)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"IETF SFC Encapsulation"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This section explains SFC Encapsulation support in networking-sfc."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_fb7c6a73","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":22},"updated":"2017-07-10 19:02:34.000000000","message":"Although this is a patch for service graphs there is a lot of other descriptive material in the document. Maybe there should be separate documents, one for SFC encap and the other for SFC graphs?","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      (Avoid deeper levels because they do not render well.)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"IETF SFC Encapsulation"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This section explains SFC Encapsulation support in networking-sfc."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_ca88d272","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":22},"in_reply_to":"3f1d235d_fb7c6a73","updated":"2017-07-23 18:07:04.000000000","message":"The reasoning is that Service Graphs is a key use case of SFC Encapsulation. Without the latter it would be impossible to create SFP dependencies and guarantee that traffic flows stick to the correct paths. By bringing Service Graphs to networking-sfc, we are ultimately proving that networking-sfc is capable of SFC Encapsulation (except for the handling of metadata, which is fine as long as it doesn\u0027t get destroyed) - as a concept, not as a protocol.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":77,"context_line":"classification criteria, just like a normal Port Chain, via Flow Classifier)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Terminology"},{"line_number":81,"context_line":"-----------"},{"line_number":82,"context_line":"* **Branching Point**: Or branch point, is a point in a Service Graph that"},{"line_number":83,"context_line":"  leads to new SFPs."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_80aaa516","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":11},"updated":"2017-07-10 19:02:34.000000000","message":"Define a Join Point and the behavior of the port chain classifiers for source port chains and the destination port chain.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"classification criteria, just like a normal Port Chain, via Flow Classifier)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Terminology"},{"line_number":81,"context_line":"-----------"},{"line_number":82,"context_line":"* **Branching Point**: Or branch point, is a point in a Service Graph that"},{"line_number":83,"context_line":"  leads to new SFPs."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_4a94e28b","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":11},"in_reply_to":"3f1d235d_80aaa516","updated":"2017-07-23 18:07:04.000000000","message":"Done","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Terminology"},{"line_number":81,"context_line":"-----------"},{"line_number":82,"context_line":"* **Branching Point**: Or branch point, is a point in a Service Graph that"},{"line_number":83,"context_line":"  leads to new SFPs."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* **Correlation**: Related to SFC Encapsulation, but focused on the fact that"},{"line_number":86,"context_line":"  a Port Chain (an **SFP**) will be mapped to a unique identifier (the **SPI**)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_c0b09d8e","line":83,"range":{"start_line":82,"start_character":2,"end_line":83,"end_character":20},"updated":"2017-07-10 19:02:34.000000000","message":"how does the flow classifier of the source port chain work with the flow classifiers of each destination port chain?\n\nNeed to specify this behavior.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Terminology"},{"line_number":81,"context_line":"-----------"},{"line_number":82,"context_line":"* **Branching Point**: Or branch point, is a point in a Service Graph that"},{"line_number":83,"context_line":"  leads to new SFPs."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* **Correlation**: Related to SFC Encapsulation, but focused on the fact that"},{"line_number":86,"context_line":"  a Port Chain (an **SFP**) will be mapped to a unique identifier (the **SPI**)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_eae83617","line":83,"range":{"start_line":82,"start_character":2,"end_line":83,"end_character":20},"in_reply_to":"3f1d235d_c0b09d8e","updated":"2017-07-23 18:07:04.000000000","message":"Done","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  and that the hops of that chain will also have a unique index associated"},{"line_number":88,"context_line":"  (the **SI**), with the forwarding of traffic based on those two parameters."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* **Dependency Chain**: Same as **Source Chain**."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* **Dependent Chain**: Same as **Destination Chain**."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":95,"context_line":"  (the **Source Chain**). May or may not be a **Source Chain** as well."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_a07241e2","line":92,"range":{"start_line":90,"start_character":2,"end_line":92,"end_character":53},"updated":"2017-07-10 19:02:34.000000000","message":"suggest remove \"dependency/dependent\" as \"source\" and \"destination\" port chain are clear enough","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  and that the hops of that chain will also have a unique index associated"},{"line_number":88,"context_line":"  (the **SI**), with the forwarding of traffic based on those two parameters."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* **Dependency Chain**: Same as **Source Chain**."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* **Dependent Chain**: Same as **Destination Chain**."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":95,"context_line":"  (the **Source Chain**). May or may not be a **Source Chain** as well."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_0ae37a35","line":92,"range":{"start_line":90,"start_character":2,"end_line":92,"end_character":53},"in_reply_to":"3f1d235d_a07241e2","updated":"2017-07-23 18:07:04.000000000","message":"Throughout the code I use the terms interchangeably and this was an attempt to unify them. I can fix all the patches to converge into a single set of terms.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":170,"context_line":"In the Python language, the dictionary of Port Chains provided above via the"},{"line_number":171,"context_line":"OpenStack Client would look like this::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  {"},{"line_number":174,"context_line":"      \u0027port_chains\u0027: {"},{"line_number":175,"context_line":"          \u0027pc1\u0027: [\u0027pc2\u0027, \u0027pc3\u0027],"},{"line_number":176,"context_line":"          \u0027pc2\u0027: [\u0027pc4\u0027],"},{"line_number":177,"context_line":"          \u0027pc3\u0027: [\u0027pc4\u0027]"},{"line_number":178,"context_line":"      }"},{"line_number":179,"context_line":"  }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Note that, because pc2, pc3 and pc4 depend on other chains, their Flow"},{"line_number":182,"context_line":"Classifiers\u0027 Logical Source Ports will be ignored."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_009e9506","line":179,"range":{"start_line":173,"start_character":2,"end_line":179,"end_character":3},"updated":"2017-07-10 19:02:34.000000000","message":"The traffic entering pc1 is determined by fc1, so only traffic with udp with source-port\u003d2001 will transit and egress from pc1. \n\nHow will pc2/pc3 that branch from pc1 and use fc2/fc3 (with udp and source-port\u003d2002/2003) be able to receive their traffic?\n\nSimilarly, how will pc4 with fc4 (udp and source-port\u003d2004) that joins pc2 and pc3 receive any traffic?","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"In the Python language, the dictionary of Port Chains provided above via the"},{"line_number":171,"context_line":"OpenStack Client would look like this::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  {"},{"line_number":174,"context_line":"      \u0027port_chains\u0027: {"},{"line_number":175,"context_line":"          \u0027pc1\u0027: [\u0027pc2\u0027, \u0027pc3\u0027],"},{"line_number":176,"context_line":"          \u0027pc2\u0027: [\u0027pc4\u0027],"},{"line_number":177,"context_line":"          \u0027pc3\u0027: [\u0027pc4\u0027]"},{"line_number":178,"context_line":"      }"},{"line_number":179,"context_line":"  }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Note that, because pc2, pc3 and pc4 depend on other chains, their Flow"},{"line_number":182,"context_line":"Classifiers\u0027 Logical Source Ports will be ignored."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_ea36f6b4","line":179,"range":{"start_line":173,"start_character":2,"end_line":179,"end_character":3},"in_reply_to":"1f1a1f67_e61b707e","updated":"2017-07-23 18:07:04.000000000","message":"To the first set of questions, responses in the meeting log. To the last request, yes I\u0027ll be adding that in the next patchset.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"300db8e9e2281d28a90468b94d43d123559ac144","unresolved":false,"context_lines":[{"line_number":170,"context_line":"In the Python language, the dictionary of Port Chains provided above via the"},{"line_number":171,"context_line":"OpenStack Client would look like this::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  {"},{"line_number":174,"context_line":"      \u0027port_chains\u0027: {"},{"line_number":175,"context_line":"          \u0027pc1\u0027: [\u0027pc2\u0027, \u0027pc3\u0027],"},{"line_number":176,"context_line":"          \u0027pc2\u0027: [\u0027pc4\u0027],"},{"line_number":177,"context_line":"          \u0027pc3\u0027: [\u0027pc4\u0027]"},{"line_number":178,"context_line":"      }"},{"line_number":179,"context_line":"  }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Note that, because pc2, pc3 and pc4 depend on other chains, their Flow"},{"line_number":182,"context_line":"Classifiers\u0027 Logical Source Ports will be ignored."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f1a1f67_e61b707e","line":179,"range":{"start_line":173,"start_character":2,"end_line":179,"end_character":3},"in_reply_to":"3f1d235d_009e9506","updated":"2017-07-16 15:07:05.000000000","message":"Can  you add text that clarifies the flow classifier values for each destination port chain in a SFC graph as discussed in the networking-sfc meeting\nhttp://eavesdrop.openstack.org/meetings/service_chaining/2017/service_chaining.2017-07-13-17.00.log.txt\n\n\"the flow classifier values of each dest pc in a SFC graph can take into consideration possible N-tuple changes by SFs in the src pc\"","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":407,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":408,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":409,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":410,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":411,"context_line":"  to be different to prevent ambiguity."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"},{"line_number":414,"context_line":"``create_service_graph_postcommit`` and ``delete_service_graph_postcommit``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_3bd1c258","line":411,"range":{"start_line":410,"start_character":1,"end_line":411,"end_character":38},"updated":"2017-07-10 19:02:34.000000000","message":"explain more about how the flow classifiers on source, destination port chains behave at the branch and join points.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":407,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":408,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":409,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":410,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":411,"context_line":"  to be different to prevent ambiguity."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"},{"line_number":414,"context_line":"``create_service_graph_postcommit`` and ``delete_service_graph_postcommit``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_ca3b329a","line":411,"range":{"start_line":410,"start_character":1,"end_line":411,"end_character":38},"in_reply_to":"3f1d235d_3bd1c258","updated":"2017-07-23 18:07:04.000000000","message":"Done","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"2bd466923b2c01305f2d477e49b3d65408ec776a","unresolved":false,"context_lines":[{"line_number":407,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":408,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":409,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":410,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":411,"context_line":"  to be different to prevent ambiguity."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"},{"line_number":414,"context_line":"``create_service_graph_postcommit`` and ``delete_service_graph_postcommit``."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_0e049c16","line":411,"range":{"start_line":410,"start_character":1,"end_line":411,"end_character":38},"in_reply_to":"ff346bd7_ca3b329a","updated":"2017-07-24 13:27:40.000000000","message":"I\u0027ve addressed this above where the OVS flows are.","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":504,"context_line":"References"},{"line_number":505,"context_line":"----------"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d1"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_056fc7c5","line":507,"range":{"start_line":507,"start_character":4,"end_line":507,"end_character":60},"updated":"2017-07-10 19:02:34.000000000","message":"use https://datatracker.ietf.org/doc/rfc7665/","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":504,"context_line":"References"},{"line_number":505,"context_line":"----------"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d1"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_aa40ee08","line":507,"range":{"start_line":507,"start_character":4,"end_line":507,"end_character":60},"in_reply_to":"3f1d235d_056fc7c5","updated":"2017-07-23 18:07:04.000000000","message":"Done","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d1"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"[3] http://i.imgur.com/nzgatKB.png"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_6531dbec","line":509,"range":{"start_line":509,"start_character":0,"end_line":509,"end_character":34},"updated":"2017-07-10 19:02:34.000000000","message":"where is this referenced from? If is is needed can it be included as a diagram in the document","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d1"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"[3] http://i.imgur.com/nzgatKB.png"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_6a4a0628","line":509,"range":{"start_line":509,"start_character":0,"end_line":509,"end_character":34},"in_reply_to":"3f1d235d_6531dbec","updated":"2017-07-23 18:07:04.000000000","message":"Do you mean to reference it in the document or re-draw it in ascii and put it in the document?","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"a10630a10e948beb63ff06189caa3f38595a06ca","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"[3] http://i.imgur.com/nzgatKB.png"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"[4] https://bugs.launchpad.net/networking-sfc/+bug/1587486"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_e55a8b28","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":34},"updated":"2017-07-10 19:02:34.000000000","message":"ditto","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"21194a429a0724859c0ca6ebee3c15075538d6b7","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"[3] http://i.imgur.com/nzgatKB.png"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"[4] https://bugs.launchpad.net/networking-sfc/+bug/1587486"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_4a47421f","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":34},"in_reply_to":"3f1d235d_e55a8b28","updated":"2017-07-23 18:07:04.000000000","message":"ditto","commit_id":"93af407b67255509f38be6b8f6787290dedeea33"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a18f4ea19048c7fe5054e9aaadad6773a513a146","unresolved":false,"context_lines":[{"line_number":90,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":91,"context_line":"  (the **Source Chain**), i.e. a dependent chain."},{"line_number":92,"context_line":"  May or may not be a **Source Chain** as well."},{"line_number":93,"context_line":"  For traffic to be accepted into a Destination Chain, it has to have come "},{"line_number":94,"context_line":"  from the **Source Chains** that the Destination Chain depends on plus"},{"line_number":95,"context_line":"  the Destination Chain\u0027s own flow classifier (except logical source ports,"},{"line_number":96,"context_line":"  which will be ignored as that would clash with the traffic coming out of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_0f55681d","line":93,"updated":"2017-07-26 11:56:35.000000000","message":"whitespace","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6779d7b5b09f5d0d02cad19007567b409c41e5cb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":91,"context_line":"  (the **Source Chain**), i.e. a dependent chain."},{"line_number":92,"context_line":"  May or may not be a **Source Chain** as well."},{"line_number":93,"context_line":"  For traffic to be accepted into a Destination Chain, it has to have come "},{"line_number":94,"context_line":"  from the **Source Chains** that the Destination Chain depends on plus"},{"line_number":95,"context_line":"  the Destination Chain\u0027s own flow classifier (except logical source ports,"},{"line_number":96,"context_line":"  which will be ignored as that would clash with the traffic coming out of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_a8cde1b7","line":93,"in_reply_to":"ff346bd7_0f55681d","updated":"2017-07-28 09:46:38.000000000","message":"Done","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a18f4ea19048c7fe5054e9aaadad6773a513a146","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  Source Chain, the only difference in the entire flow being the value of"},{"line_number":244,"context_line":"  that register (reflecting each of the Source Chains\u0027 SFP infos). Two flows"},{"line_number":245,"context_line":"  can be seen above in table 0, matching on traffic meant for pc4."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Implementation"},{"line_number":248,"context_line":"--------------"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_af141c4f","line":246,"updated":"2017-07-26 11:56:35.000000000","message":"Thanks for adding that part, it helped a lot reading the code","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6779d7b5b09f5d0d02cad19007567b409c41e5cb","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  Source Chain, the only difference in the entire flow being the value of"},{"line_number":244,"context_line":"  that register (reflecting each of the Source Chains\u0027 SFP infos). Two flows"},{"line_number":245,"context_line":"  can be seen above in table 0, matching on traffic meant for pc4."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Implementation"},{"line_number":248,"context_line":"--------------"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_48be75ff","line":246,"in_reply_to":"ff346bd7_af141c4f","updated":"2017-07-28 09:46:38.000000000","message":":)","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a18f4ea19048c7fe5054e9aaadad6773a513a146","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  +----------------+---------+---------+"},{"line_number":454,"context_line":"  |service_graph_id|src_chain|dst_chain|"},{"line_number":455,"context_line":"  +----------------+---------+---------+"},{"line_number":456,"context_line":"  |SG1\u0027s ID        |PC1\u0027s ID |PC2\u0027s ID |"},{"line_number":457,"context_line":"  |SG1\u0027s ID        |PC1\u0027s ID |PC3\u0027s ID |"},{"line_number":458,"context_line":"  |SG1\u0027s ID        |PC2\u0027s ID |PC4\u0027s ID |"},{"line_number":459,"context_line":"  |SG1\u0027s ID        |PC3\u0027s ID |PC4\u0027s ID |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_2f5a6c4e","line":456,"updated":"2017-07-26 11:56:35.000000000","message":"For the sake of nitpicking, the quotes change the text color (as this is interpreted as code)","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6779d7b5b09f5d0d02cad19007567b409c41e5cb","unresolved":false,"context_lines":[{"line_number":453,"context_line":"  +----------------+---------+---------+"},{"line_number":454,"context_line":"  |service_graph_id|src_chain|dst_chain|"},{"line_number":455,"context_line":"  +----------------+---------+---------+"},{"line_number":456,"context_line":"  |SG1\u0027s ID        |PC1\u0027s ID |PC2\u0027s ID |"},{"line_number":457,"context_line":"  |SG1\u0027s ID        |PC1\u0027s ID |PC3\u0027s ID |"},{"line_number":458,"context_line":"  |SG1\u0027s ID        |PC2\u0027s ID |PC4\u0027s ID |"},{"line_number":459,"context_line":"  |SG1\u0027s ID        |PC3\u0027s ID |PC4\u0027s ID |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff346bd7_28b9f113","line":456,"in_reply_to":"ff346bd7_2f5a6c4e","updated":"2017-07-28 09:46:38.000000000","message":"Done","commit_id":"a717f760c1e82a79b49eebe777dca3984b130813"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":64,"context_line":"a good workaround to exercise the IETF SFC Encapsulation"},{"line_number":65,"context_line":"architectural concept in networking-sfc until NSH is added."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Service Graphs is a concept mentioned in [1] but further defined and"},{"line_number":68,"context_line":"refined in [5] that builds on top of Reclassification and Branching (from [1])."},{"line_number":69,"context_line":"Service Graphs make use of the full encapsulation of frames the SFC"},{"line_number":70,"context_line":"Encapsulation provides, and the Service Function Path information that is"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_ebabaa72","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":15},"updated":"2017-08-06 02:07:38.000000000","message":"Add a diagram which shows Source, Destination, Initial Port Chains as well as Branch and Join points:\n\n       Branch1       Join1\n    pc1 --+--\u003e pc2 ------\u003e  pc4\n          |           ^\n          |           |\n           --\u003e pc3 ---\n         \n Branch1: pc1 \u003d initial (source)\n          pc2 \u003d destination\n          pc3 \u003d destination\n\n Join1:   pc2 \u003d source\n          pc3 \u003d source\n          pc4 \u003d destination","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"a good workaround to exercise the IETF SFC Encapsulation"},{"line_number":65,"context_line":"architectural concept in networking-sfc until NSH is added."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Service Graphs is a concept mentioned in [1] but further defined and"},{"line_number":68,"context_line":"refined in [5] that builds on top of Reclassification and Branching (from [1])."},{"line_number":69,"context_line":"Service Graphs make use of the full encapsulation of frames the SFC"},{"line_number":70,"context_line":"Encapsulation provides, and the Service Function Path information that is"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_fe27c4b5","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":15},"in_reply_to":"bf3e73b7_ebabaa72","updated":"2017-08-09 11:08:46.000000000","message":"Good idea.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":91,"context_line":"  (the **Source Chain**), i.e. a dependent chain."},{"line_number":92,"context_line":"  May or may not be a **Source Chain** as well."},{"line_number":93,"context_line":"  For traffic to be accepted into a Destination Chain, it has to have come"},{"line_number":94,"context_line":"  from the **Source Chains** that the Destination Chain depends on plus"},{"line_number":95,"context_line":"  the Destination Chain\u0027s own flow classifier (except logical source ports,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_0b914e53","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":47},"updated":"2017-08-06 02:07:38.000000000","message":"A Destination chain may be a Source Chain also.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* **Destination Chain**: A Port Chain that branches from a previous chain"},{"line_number":91,"context_line":"  (the **Source Chain**), i.e. a dependent chain."},{"line_number":92,"context_line":"  May or may not be a **Source Chain** as well."},{"line_number":93,"context_line":"  For traffic to be accepted into a Destination Chain, it has to have come"},{"line_number":94,"context_line":"  from the **Source Chains** that the Destination Chain depends on plus"},{"line_number":95,"context_line":"  the Destination Chain\u0027s own flow classifier (except logical source ports,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_fe8ea425","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":47},"in_reply_to":"bf3e73b7_0b914e53","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  words, this chain only matches on a Flow Classifier and takes into account"},{"line_number":102,"context_line":"  the Logical Source Port defined by it (unlike **Destination Chains**)."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_ab892227","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":23},"updated":"2017-08-06 02:07:38.000000000","message":"For","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  words, this chain only matches on a Flow Classifier and takes into account"},{"line_number":102,"context_line":"  the Logical Source Port defined by it (unlike **Destination Chains**)."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_3eac2c8b","line":104,"range":{"start_line":104,"start_character":21,"end_line":104,"end_character":23},"in_reply_to":"bf3e73b7_ab892227","updated":"2017-08-09 11:08:46.000000000","message":"Just removed everything before the comma.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  the Logical Source Port defined by it (unlike **Destination Chains**)."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* **NSP**: Network Service Path (same as **SPI**)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_4b88761e","line":105,"range":{"start_line":105,"start_character":2,"end_line":105,"end_character":14},"updated":"2017-08-06 02:07:38.000000000","message":"merges","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  the Logical Source Port defined by it (unlike **Destination Chains**)."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* **NSP**: Network Service Path (same as **SPI**)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_beb13ce4","line":105,"range":{"start_line":105,"start_character":2,"end_line":105,"end_character":14},"in_reply_to":"bf3e73b7_4b88761e","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* **NSP**: Network Service Path (same as **SPI**)."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_0b7a6e23","line":106,"range":{"start_line":106,"start_character":25,"end_line":106,"end_character":58},"updated":"2017-08-06 02:07:38.000000000","message":"not quite sure what you mean here?","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* **Joining Point**: Or joining branches, a point in a Service Graph that"},{"line_number":105,"context_line":"  results from multiple incoming branches (**Source Chains**) into the same"},{"line_number":106,"context_line":"  **Destination Chain**, i.e. multiple chain dependencies."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* **NSP**: Network Service Path (same as **SPI**)."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_de0ac088","line":106,"range":{"start_line":106,"start_character":25,"end_line":106,"end_character":58},"in_reply_to":"bf3e73b7_0b7a6e23","updated":"2017-08-09 11:08:46.000000000","message":"I meant that the incoming chains are effectively dependencies of the destination chain (traffic needs to go through them first) but I\u0027ll remove this to avoid confusion.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* **SI**: Service Index."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* **Source Chain**: The Port Chain that provides a branching point"},{"line_number":117,"context_line":"  to Destination Chains, i.e. a dependency chain. May or may not be"},{"line_number":118,"context_line":"  an **Initial Chain** or a **Destination Chain** as well."},{"line_number":119,"context_line":"  Traffic that leaves a Source Chain, i.e. the egressing traffic"},{"line_number":120,"context_line":"  from the last SF of the chain (and encapsulated for that particular chain)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_cb73464d","line":117,"range":{"start_line":117,"start_character":30,"end_line":117,"end_character":48},"updated":"2017-08-06 02:07:38.000000000","message":"remove","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* **SI**: Service Index."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* **Source Chain**: The Port Chain that provides a branching point"},{"line_number":117,"context_line":"  to Destination Chains, i.e. a dependency chain. May or may not be"},{"line_number":118,"context_line":"  an **Initial Chain** or a **Destination Chain** as well."},{"line_number":119,"context_line":"  Traffic that leaves a Source Chain, i.e. the egressing traffic"},{"line_number":120,"context_line":"  from the last SF of the chain (and encapsulated for that particular chain)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_def4005e","line":117,"range":{"start_line":117,"start_character":30,"end_line":117,"end_character":48},"in_reply_to":"bf3e73b7_cb73464d","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* **SI**: Service Index."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* **Source Chain**: The Port Chain that provides a branching point"},{"line_number":117,"context_line":"  to Destination Chains, i.e. a dependency chain. May or may not be"},{"line_number":118,"context_line":"  an **Initial Chain** or a **Destination Chain** as well."},{"line_number":119,"context_line":"  Traffic that leaves a Source Chain, i.e. the egressing traffic"},{"line_number":120,"context_line":"  from the last SF of the chain (and encapsulated for that particular chain)"},{"line_number":121,"context_line":"  will be put into either one or no Destination Chains respective to this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_8b93fe4f","line":118,"range":{"start_line":117,"start_character":50,"end_line":118,"end_character":57},"updated":"2017-08-06 02:07:38.000000000","message":"A Source Chain may also be an Initial Chain or a Destination Chain.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* **SI**: Service Index."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* **Source Chain**: The Port Chain that provides a branching point"},{"line_number":117,"context_line":"  to Destination Chains, i.e. a dependency chain. May or may not be"},{"line_number":118,"context_line":"  an **Initial Chain** or a **Destination Chain** as well."},{"line_number":119,"context_line":"  Traffic that leaves a Source Chain, i.e. the egressing traffic"},{"line_number":120,"context_line":"  from the last SF of the chain (and encapsulated for that particular chain)"},{"line_number":121,"context_line":"  will be put into either one or no Destination Chains respective to this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_bee93c81","line":118,"range":{"start_line":117,"start_character":50,"end_line":118,"end_character":57},"in_reply_to":"bf3e73b7_8b93fe4f","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":156,"context_line":"chains, essentially describing each of the branching points of the chain."},{"line_number":157,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":158,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":159,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":160,"context_line":"single chain ``pc4`` (if that\u0027s what the user intended)::"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # we assume that the Neutron ports p0..p4 are already created and bound"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_cbc5865d","line":159,"range":{"start_line":159,"start_character":49,"end_line":159,"end_character":50},"updated":"2017-08-06 02:07:38.000000000","message":"continue line","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":156,"context_line":"chains, essentially describing each of the branching points of the chain."},{"line_number":157,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":158,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":159,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":160,"context_line":"single chain ``pc4`` (if that\u0027s what the user intended)::"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # we assume that the Neutron ports p0..p4 are already created and bound"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_ebc84a75","line":159,"range":{"start_line":159,"start_character":30,"end_line":159,"end_character":38},"updated":"2017-08-06 02:07:38.000000000","message":"joins","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"chains, essentially describing each of the branching points of the chain."},{"line_number":157,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":158,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":159,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":160,"context_line":"single chain ``pc4`` (if that\u0027s what the user intended)::"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # we assume that the Neutron ports p0..p4 are already created and bound"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_dec2c0e9","line":159,"in_reply_to":"bf3e73b7_cbc5865d","updated":"2017-08-09 11:08:46.000000000","message":"Doesn\u0027t fit but I extended the first line closer to the limit.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"chains, essentially describing each of the branching points of the chain."},{"line_number":157,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":158,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":159,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":160,"context_line":"single chain ``pc4`` (if that\u0027s what the user intended)::"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # we assume that the Neutron ports p0..p4 are already created and bound"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_beb7fc86","line":159,"in_reply_to":"bf3e73b7_ebc84a75","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":428,"context_line":"``port_chains`` that maps source chains to (lists of) destination chains."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Service Graphs \"glue\" existing Port Chains, creating dependencies between them,"},{"line_number":431,"context_line":"in effect changing the criteria to get into each of the chains by not relying"},{"line_number":432,"context_line":"solely on the Flow Classifier anymore (except for the initial chain of the"},{"line_number":433,"context_line":"graph)."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"In the database, Service Graphs are stored as 2 tables:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_ebc4ca42","line":432,"range":{"start_line":431,"start_character":64,"end_line":432,"end_character":37},"updated":"2017-08-06 02:07:38.000000000","message":"Add \"Traffic entering a destination chain of a Service Graph is dependent on its source chain and its own flow classifiers.\"","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Service Graphs \"glue\" existing Port Chains, creating dependencies between them,"},{"line_number":431,"context_line":"in effect changing the criteria to get into each of the chains by not relying"},{"line_number":432,"context_line":"solely on the Flow Classifier anymore (except for the initial chain of the"},{"line_number":433,"context_line":"graph)."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"In the database, Service Graphs are stored as 2 tables:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_5e7370e8","line":432,"in_reply_to":"bf3e73b7_ebc4ca42","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":470,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":471,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":472,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":473,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":474,"context_line":"  to be different to prevent ambiguity."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_abdc8218","line":473,"range":{"start_line":473,"start_character":66,"end_line":473,"end_character":72},"updated":"2017-08-06 02:07:38.000000000","message":"Add: (destination chain)","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"f9aa0d8bfe66c9e8f09dc4969982df6bfa72d795","unresolved":false,"context_lines":[{"line_number":470,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":471,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":472,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":473,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":474,"context_line":"  to be different to prevent ambiguity."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_cd06be21","line":473,"range":{"start_line":473,"start_character":73,"end_line":473,"end_character":77},"updated":"2017-08-06 02:07:38.000000000","message":"has","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":470,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":471,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":472,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":473,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":474,"context_line":"  to be different to prevent ambiguity."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_3e59cc59","line":473,"in_reply_to":"bf3e73b7_abdc8218","updated":"2017-08-09 11:08:46.000000000","message":"Better.","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"1d88d650ae1d1c7433612973058c5fad14de58c8","unresolved":false,"context_lines":[{"line_number":470,"context_line":"* Port Chains cannot be part of more than one graph at any given time."},{"line_number":471,"context_line":"* Branching points have to support the MPLS correlation."},{"line_number":472,"context_line":"* The correlation protocol has to be the same for every included Port Chain."},{"line_number":473,"context_line":"* For a given branching point, the traffic classification of each branch have"},{"line_number":474,"context_line":"  to be different to prevent ambiguity."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"At the OVS driver level, all of the logic takes place in the postcommit methods,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_59738ae8","line":473,"range":{"start_line":473,"start_character":73,"end_line":473,"end_character":77},"in_reply_to":"bf3e73b7_cd06be21","updated":"2017-08-09 11:08:46.000000000","message":"Done","commit_id":"e5d26e89a82bc9004df0b95b82537083f13af8fd"}],"doc/source/ietf_sfc_encapsulation.rst":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"fef2f2c82e8a00df41d7ea7e6ffd4dbce000945b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":147,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":148,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":149,"context_line":"single chain ``pc6`` (if that\u0027s what the user intended)::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg1 --flow-classifier fc1 pc1"},{"line_number":152,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg2 --flow-classifier fc2 pc2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_f72eaf41","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":18},"updated":"2017-07-01 22:29:08.000000000","message":"pc4?","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":146,"context_line":"The following example, using the OpenStack Client, illustrates this (by"},{"line_number":147,"context_line":"creating a graph that starts from an initial chain ``pc1`` which forks into"},{"line_number":148,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":149,"context_line":"single chain ``pc6`` (if that\u0027s what the user intended)::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg1 --flow-classifier fc1 pc1"},{"line_number":152,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg2 --flow-classifier fc2 pc2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_9e717647","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":18},"in_reply_to":"3f1d235d_f72eaf41","updated":"2017-07-05 15:00:58.000000000","message":"Yes, the example was a bit more extensive before, with 6 pcs, and I forgot to change this ref.","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"fef2f2c82e8a00df41d7ea7e6ffd4dbce000945b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":149,"context_line":"single chain ``pc6`` (if that\u0027s what the user intended)::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg1 --flow-classifier fc1 pc1"},{"line_number":152,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg2 --flow-classifier fc2 pc2"},{"line_number":153,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg3 --flow-classifier fc3 pc3"},{"line_number":154,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg4 --flow-classifier fc4 pc4"},{"line_number":155,"context_line":"  $ openstack sfc service graph create --port-chains pc1:pc2,pc3;pc2:pc4;pc3:pc4 sg1"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"In the Python language, the dictionary of Port Chains provided above via the"},{"line_number":158,"context_line":"OpenStack Client would look like this::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_d7d61328","line":155,"range":{"start_line":151,"start_character":1,"end_line":155,"end_character":82},"updated":"2017-07-01 22:29:08.000000000","message":"Can you show the values for fc1-fc4?","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":148,"context_line":"``pc2`` and ``pc3``, and then converge back into a"},{"line_number":149,"context_line":"single chain ``pc6`` (if that\u0027s what the user intended)::"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg1 --flow-classifier fc1 pc1"},{"line_number":152,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg2 --flow-classifier fc2 pc2"},{"line_number":153,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg3 --flow-classifier fc3 pc3"},{"line_number":154,"context_line":"  $ openstack sfc port chain create --port-pair-group ppg4 --flow-classifier fc4 pc4"},{"line_number":155,"context_line":"  $ openstack sfc service graph create --port-chains pc1:pc2,pc3;pc2:pc4;pc3:pc4 sg1"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"In the Python language, the dictionary of Port Chains provided above via the"},{"line_number":158,"context_line":"OpenStack Client would look like this::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_fea3ca9c","line":155,"range":{"start_line":151,"start_character":1,"end_line":155,"end_character":82},"in_reply_to":"3f1d235d_d7d61328","updated":"2017-07-05 15:00:58.000000000","message":"Yes, they will have to be have different classification bodies (LSP can be the same).","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b0b2391d5c0e66b9c8dfce8bf62269fe99619899","unresolved":false,"context_lines":[{"line_number":350,"context_line":"and ``project_id``, this resource expects to have a dictionary called"},{"line_number":351,"context_line":"``port_chains`` that maps source chains to (lists of) destination chains."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"Service Graphs \"glue\" existing Port Chains, creating depedencies between them,"},{"line_number":354,"context_line":"in effect changing the criteria to get into each of the chains by not relying"},{"line_number":355,"context_line":"solely on the Flow Classifier anymore (except for the initial chain of the"},{"line_number":356,"context_line":"graph)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_4306691e","line":353,"range":{"start_line":353,"start_character":53,"end_line":353,"end_character":64},"updated":"2017-07-05 14:48:32.000000000","message":"dependencies","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":350,"context_line":"and ``project_id``, this resource expects to have a dictionary called"},{"line_number":351,"context_line":"``port_chains`` that maps source chains to (lists of) destination chains."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"Service Graphs \"glue\" existing Port Chains, creating depedencies between them,"},{"line_number":354,"context_line":"in effect changing the criteria to get into each of the chains by not relying"},{"line_number":355,"context_line":"solely on the Flow Classifier anymore (except for the initial chain of the"},{"line_number":356,"context_line":"graph)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_bea9d27c","line":353,"range":{"start_line":353,"start_character":53,"end_line":353,"end_character":64},"in_reply_to":"3f1d235d_4306691e","updated":"2017-07-05 15:00:58.000000000","message":"Done","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b0b2391d5c0e66b9c8dfce8bf62269fe99619899","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"In the database, Service Graphs are stored as 2 tables:"},{"line_number":359,"context_line":"* ``sfc_service_graphs``:"},{"line_number":360,"context_line":"  This table stores each of Service Graph\u0027s basic information and has a field"},{"line_number":361,"context_line":"  that references associations with Port Chains"},{"line_number":362,"context_line":"  (``graph_chain_associations``), which is a foreign key to"},{"line_number":363,"context_line":"  ``sfc_service_graph_chain_associations.service_graph_id``."},{"line_number":364,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_a3e09d27","line":361,"range":{"start_line":360,"start_character":70,"end_line":361,"end_character":47},"updated":"2017-07-05 14:48:32.000000000","message":"At first read I thought this was a new field, but that is just the id right? Maybe reword to something like \"the ID field is used as a foreign key to reference...\"","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"In the database, Service Graphs are stored as 2 tables:"},{"line_number":359,"context_line":"* ``sfc_service_graphs``:"},{"line_number":360,"context_line":"  This table stores each of Service Graph\u0027s basic information and has a field"},{"line_number":361,"context_line":"  that references associations with Port Chains"},{"line_number":362,"context_line":"  (``graph_chain_associations``), which is a foreign key to"},{"line_number":363,"context_line":"  ``sfc_service_graph_chain_associations.service_graph_id``."},{"line_number":364,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_decece58","line":361,"range":{"start_line":360,"start_character":70,"end_line":361,"end_character":47},"in_reply_to":"3f1d235d_a3e09d27","updated":"2017-07-05 15:00:58.000000000","message":"Yes I can improve.","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b0b2391d5c0e66b9c8dfce8bf62269fe99619899","unresolved":false,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"With ``\u0027on_add\u0027: False``, the agent will replace the above flow with the"},{"line_number":465,"context_line":"original flow for the ``src_node`` of that Port Chain, matching only on the"},{"line_number":466,"context_line":"Flow Classifiers\u0027 fields."},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Known Limitations"},{"line_number":469,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_a342dda9","line":466,"updated":"2017-07-05 14:48:32.000000000","message":"and restoring the logical source port match I suppose? (probably not important here, just checking)","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":463,"context_line":""},{"line_number":464,"context_line":"With ``\u0027on_add\u0027: False``, the agent will replace the above flow with the"},{"line_number":465,"context_line":"original flow for the ``src_node`` of that Port Chain, matching only on the"},{"line_number":466,"context_line":"Flow Classifiers\u0027 fields."},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"Known Limitations"},{"line_number":469,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_3e32625f","line":466,"in_reply_to":"3f1d235d_a342dda9","updated":"2017-07-05 15:00:58.000000000","message":"Yes indeed, I\u0027ll include that bit.","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"b0b2391d5c0e66b9c8dfce8bf62269fe99619899","unresolved":false,"context_lines":[{"line_number":483,"context_line":"References"},{"line_number":484,"context_line":"----------"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":489,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_036e312e","line":486,"updated":"2017-07-05 14:48:32.000000000","message":"Lost the \"1\" to show full text","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":483,"context_line":"References"},{"line_number":484,"context_line":"----------"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"[1] https://datatracker.ietf.org/doc/rfc7665/?include_text\u003d"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"[2] http://i.imgur.com/rxzNNUZ.png"},{"line_number":489,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f1d235d_7e157a9b","line":486,"in_reply_to":"3f1d235d_036e312e","updated":"2017-07-05 15:00:58.000000000","message":"Done","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"f6864b1b38ea908855144ec1e84305e4fac9788b","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"In the database, Service Graphs are stored as 2 tables:"},{"line_number":372,"context_line":"* ``sfc_service_graphs``:"},{"line_number":373,"context_line":"  This table stores each of the basic Service Graph resources, specifically"},{"line_number":374,"context_line":"  the name, description and project ID."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"* ``sfc_service_graph_chain_associations``:"},{"line_number":377,"context_line":"  This table stores the actual associations between Service Graphs and Port"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_9a3e1f89","line":374,"range":{"start_line":373,"start_character":28,"end_line":374,"end_character":12},"updated":"2017-07-05 15:55:04.000000000","message":"Re-reading now and not the best wording I confess, I\u0027ll improve it slightly if there are more comments to address.","commit_id":"4b866b02c20d0604bd9bd1adde72153a4276278a"}],"releasenotes/notes/service-graphs-4a1e54f6bbbfe805.yaml":[{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"fef2f2c82e8a00df41d7ea7e6ffd4dbce000945b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduced new API resource, Service Graphs. Based on IETF"},{"line_number":5,"context_line":"    SFC Encapsulation, this construct allows Port Chains to be linked"},{"line_number":6,"context_line":"    connected, forming dependencies between them (beyond simple flow"},{"line_number":7,"context_line":"    classification). This is also known as Reclassification and Branching."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_fe848eb3","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":13},"updated":"2017-07-01 22:29:08.000000000","message":"remove \"connected\" or \"linked\"","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"b46cd790bd3208d48bf9f3fb056634187c01df45","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduced new API resource, Service Graphs. Based on IETF"},{"line_number":5,"context_line":"    SFC Encapsulation, this construct allows Port Chains to be linked"},{"line_number":6,"context_line":"    connected, forming dependencies between them (beyond simple flow"},{"line_number":7,"context_line":"    classification). This is also known as Reclassification and Branching."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f1d235d_3ea262fd","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":13},"in_reply_to":"3f1d235d_fe848eb3","updated":"2017-07-05 15:00:58.000000000","message":"Done","commit_id":"b9e5438e9a84c0c68fc1f48901df74b2bba3b20e"}]}
