)]}'
{"networking_sfc/services/sfc/drivers/ovs/driver.py":[{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"89a57529ad4374bfc6cf61bab12ce206d06b80e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.common.constants as nc_const"},{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":"import neutron.plugins.ml2.drivers.l2pop.db as l2pop_db"},{"line_number":19,"context_line":"import neutron.plugins.ml2.drivers.l2pop.rpc as l2pop_rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_eb71fbdf","side":"PARENT","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":43},"updated":"2019-04-16 07:47:11.000000000","message":"Should it be changed to: from neutron_lib import constants?\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py","commit_id":"a96923819c0e94fa2c7a41c1649b8de54f90acee"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a844d12de3aad757bf2b1e3c75ebbc386395e5b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.common.constants as nc_const"},{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":"import neutron.plugins.ml2.drivers.l2pop.db as l2pop_db"},{"line_number":19,"context_line":"import neutron.plugins.ml2.drivers.l2pop.rpc as l2pop_rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_33353547","side":"PARENT","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":43},"in_reply_to":"3fce034c_80bcd1dc","updated":"2019-04-16 09:37:37.000000000","message":"It was using constants from both neutron-lib and neutron, nice to see now only neutron-lib is needed!","commit_id":"a96923819c0e94fa2c7a41c1649b8de54f90acee"},{"author":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"change_message_id":"5d13549ec2ff139ab6c0df7defd6eb8e30a4a52c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.common.constants as nc_const"},{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":"import neutron.plugins.ml2.drivers.l2pop.db as l2pop_db"},{"line_number":19,"context_line":"import neutron.plugins.ml2.drivers.l2pop.rpc as l2pop_rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_80bcd1dc","side":"PARENT","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":43},"in_reply_to":"3fce034c_eb71fbdf","updated":"2019-04-16 08:49:24.000000000","message":"yes, but check line 20 in the old file or 19 in the new file, it is already there. I don\u0027t know why we were importing both","commit_id":"a96923819c0e94fa2c7a41c1649b8de54f90acee"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"89a57529ad4374bfc6cf61bab12ce206d06b80e1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # Agent is removing its last activated port in this network,"},{"line_number":107,"context_line":"        # other agents needs to be notified to delete their flooding entry."},{"line_number":108,"context_line":"        other_fdb_entries[network_id][\u0027ports\u0027][agent_ip].append("},{"line_number":109,"context_line":"            const.FLOODING_ENTRY)"},{"line_number":110,"context_line":"        # Notify other agents to remove fdb rules for current port"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] !\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            fdb_entries \u003d port_fdb_entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_ab7bf3bb","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":17},"updated":"2019-04-16 07:47:11.000000000","message":"constants","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"},{"author":{"_account_id":30156,"name":"Igor D.C.","email":"igor.duarte.cardoso@intel.com","username":"igordc"},"change_message_id":"f0590542fc9fda86d21d568e05f843ae26cc24b4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # Agent is removing its last activated port in this network,"},{"line_number":107,"context_line":"        # other agents needs to be notified to delete their flooding entry."},{"line_number":108,"context_line":"        other_fdb_entries[network_id][\u0027ports\u0027][agent_ip].append("},{"line_number":109,"context_line":"            const.FLOODING_ENTRY)"},{"line_number":110,"context_line":"        # Notify other agents to remove fdb rules for current port"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] !\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            fdb_entries \u003d port_fdb_entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_fcc2f958","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":17},"in_reply_to":"3fce034c_ab7bf3bb","updated":"2019-04-17 18:58:18.000000000","message":"We have two \"constants\" imports so might as well keep both of them renamed.","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1e8f25a2b916ec65208520b1bd4ad32fce42279a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # Agent is removing its last activated port in this network,"},{"line_number":107,"context_line":"        # other agents needs to be notified to delete their flooding entry."},{"line_number":108,"context_line":"        other_fdb_entries[network_id][\u0027ports\u0027][agent_ip].append("},{"line_number":109,"context_line":"            const.FLOODING_ENTRY)"},{"line_number":110,"context_line":"        # Notify other agents to remove fdb rules for current port"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] !\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            fdb_entries \u003d port_fdb_entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_22a368b4","line":109,"range":{"start_line":109,"start_character":12,"end_line":109,"end_character":17},"in_reply_to":"3fce034c_fcc2f958","updated":"2019-04-18 15:56:19.000000000","message":"We don\u0027t want to be using the neutron.common.constnats... it\u0027s deleted now. see https://review.openstack.org/#/c/653586/","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"89a57529ad4374bfc6cf61bab12ce206d06b80e1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        other_fdb_entries[network_id][\u0027ports\u0027][agent_ip].append("},{"line_number":109,"context_line":"            const.FLOODING_ENTRY)"},{"line_number":110,"context_line":"        # Notify other agents to remove fdb rules for current port"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] !\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            fdb_entries \u003d port_fdb_entries"},{"line_number":113,"context_line":"            other_fdb_entries[network_id][\u0027ports\u0027][agent_ip] +\u003d fdb_entries"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_6b4f4b92","line":111,"range":{"start_line":111,"start_character":35,"end_line":111,"end_character":40},"updated":"2019-04-16 07:47:11.000000000","message":"ditto","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"89a57529ad4374bfc6cf61bab12ce206d06b80e1","unresolved":false,"context_lines":[{"line_number":710,"context_line":"            new_fc.pop(\u0027name\u0027)"},{"line_number":711,"context_line":"            new_fc.pop(\u0027project_id\u0027)"},{"line_number":712,"context_line":"            new_fc.pop(\u0027description\u0027)"},{"line_number":713,"context_line":"            router_ints \u003d const.ROUTER_INTERFACE_OWNERS"},{"line_number":714,"context_line":"            logical_source_port \u003d new_fc[\u0027logical_source_port\u0027]"},{"line_number":715,"context_line":"            if logical_source_port is not None:"},{"line_number":716,"context_line":"                port_src \u003d model_query.get_by_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_eb1fbb6d","line":713,"range":{"start_line":713,"start_character":26,"end_line":713,"end_character":31},"updated":"2019-04-16 07:47:11.000000000","message":"ditto","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"89a57529ad4374bfc6cf61bab12ce206d06b80e1","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"            network_type \u003d network_info[\u0027provider:network_type\u0027]"},{"line_number":1112,"context_line":"            segment_id \u003d network_info[\u0027provider:segmentation_id\u0027]"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        if network_type !\u003d const.TYPE_VXLAN:"},{"line_number":1115,"context_line":"            LOG.warning(\"Currently only support vxlan network\")"},{"line_number":1116,"context_line":"            return ((None, ) * 5)"},{"line_number":1117,"context_line":"        elif not host_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_ab545322","line":1114,"range":{"start_line":1114,"start_character":27,"end_line":1114,"end_character":32},"updated":"2019-04-16 07:47:11.000000000","message":"ditto","commit_id":"a42d5fad7952a98b59227d4ac26b02bf0d29080e"}]}