)]}'
{"id":"openstack%2Fnetworking-sfc~684977","triplet_id":"openstack%2Fnetworking-sfc~master~I22629c59da983f47ef8b1862afb9a62bdfd78b02","project":"openstack/networking-sfc","branch":"master","topic":"bug/1842659","hashtags":[],"change_id":"I22629c59da983f47ef8b1862afb9a62bdfd78b02","subject":"[Functional tests] Fix SIGHUP handling tests","status":"MERGED","created":"2019-09-26 09:09:38.000000000","updated":"2019-11-28 08:40:06.000000000","submitted":"2019-09-26 16:07:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"684977-1569514070570-e985b01a","meta_rev_id":"698a558eb9e5e863de40968773246c458a1f1da6","_number":684977,"virtual_id_number":684977,"owner":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-26 16:07:50.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":2,"date":"2019-09-26 14:21:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":1,"date":"2019-09-26 14:18:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":2,"date":"2019-09-26 11:40:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":1,"date":"2019-09-26 14:21:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-26 11:40:53.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2019-09-26 14:18:32.000000000","updated_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"reviewer":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"state":"REVIEWER"},{"updated":"2019-09-26 14:21:29.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2019-09-26 16:07:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9a699d1a8bc8c984a293737e031a0a7a65458659","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-09-26 09:09:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"589a29f16b8a6c6ac00c1bce22b2855e8af6646c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 11:31:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/367aa1256d3e45db9ce2ebebba8346ce : SUCCESS in 8m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/494ec2e4639647a9b5c02362ba124389 : SUCCESS in 4m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6289c6b3bab84da7af4c5c6f02edddb4 : SUCCESS in 7m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb1ee682170748cfa22083d97ec26e3b : SUCCESS in 5m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dedbcd0b313048b4bce9b213d88843c8 : SUCCESS in 8m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7c61c72115074bba98b483c2990961b2 : SUCCESS in 8m 30s\n- networking-sfc-functional https://zuul.opendev.org/t/openstack/build/2ded0f1c0e6342ad8828883648551f78 : SUCCESS in 14m 28s\n- networking-sfc-tempest https://zuul.opendev.org/t/openstack/build/f2f51fdd60f44f2287ac7944279c1174 : SUCCESS in 1h 39m 14s\n- networking-sfc-tempest-multinode https://zuul.opendev.org/t/openstack/build/44e073fb08d147a8bd314bf5e3ad1b4c : FAILURE in 2h 12m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8275ca9fd5c728c837a2434702c4135056dc3ecc","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2019-09-26 11:40:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0227dfa36b18f4629585da03e718059f221d7c84","author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"date":"2019-09-26 14:18:32.000000000","message":"Patch Set 1: Code-Review+1\n\nMakes sense, especially with how close it is modeled on neutron similar functional test.\nAnd test is passing!","accounts_in_message":[],"_revision_number":1},{"id":"13694b27b845385e98ad8d5e62f764c3d5635919","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-09-26 14:21:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ee985e1c398019da711ecb7ee1a92c484a1a4a73","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 14:21:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a2dde5030527e50cb9f59c3272ee1100946e7ef1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 16:07:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/472c5bd32de247f28fd087ab0605b476 : SUCCESS in 8m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/24c05a28f1e240cb8b2a622f8bdc9933 : SUCCESS in 10m 17s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/90872348cde84ecf855faf3b563da27a : SUCCESS in 8m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf8bdd87a84d46d0a4cb0c5566ac43d6 : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/44d40e0217194c23bb99149ac53c5c2c : SUCCESS in 8m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fd490a33702044ad97535ffe2f93510f : SUCCESS in 7m 47s\n- networking-sfc-functional https://zuul.opendev.org/t/openstack/build/beb85db2c14c4e8898eca4ccc542ede7 : SUCCESS in 16m 58s\n- networking-sfc-tempest https://zuul.opendev.org/t/openstack/build/965f3a2a464f4eed9d9340b2ca427360 : SUCCESS in 1h 43m 15s","accounts_in_message":[],"_revision_number":1},{"id":"8d9ffab038938886307cef80b71640689ad1b47a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 16:07:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"868b9b833177baad8039a5e3603aa93d66c24184","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-26 16:08:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bda204fd7b6243b096380a374ebd0d3f : SUCCESS in 49s","accounts_in_message":[],"_revision_number":1},{"id":"50beaa62317488bab1926a30deab41301ac06253","author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"date":"2019-11-28 08:40:06.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit cd6a4b53e8ff552af4f01428d2596b0bcdf139e0","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0644862c8beedd902a7d739be524699edc9b61d3","revisions":{"0644862c8beedd902a7d739be524699edc9b61d3":{"kind":"REWORK","_number":1,"created":"2019-09-26 09:09:38.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/77/684977/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-sfc","ref":"refs/changes/77/684977/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-sfc refs/changes/77/684977/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-sfc refs/changes/77/684977/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-sfc refs/changes/77/684977/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-sfc refs/changes/77/684977/1"}}},"commit":{"parents":[{"commit":"32702b57bd43357b5f6754e6b9d2adff040a47e5","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-sfc/commit/32702b57bd43357b5f6754e6b9d2adff040a47e5"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-09-26 09:06:41.000000000","tz":120},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2019-09-26 09:09:32.000000000","tz":120},"subject":"[Functional tests] Fix SIGHUP handling tests","message":"[Functional tests] Fix SIGHUP handling tests\n\nTests in networking_sfc.functional.test_server module are testing how\nservice is handling SIGHUP signal.\n\nRecently this was changed in Oslo.service with [1] and our tests\nwere failing because they were still expecting that after sending\nSIGHUP to the process, stop() and than start() method will be called.\n\nBut as our services uses \"mutate\" as restart method, since [1] such\nprocess don\u0027t executes stop() and start() after SIGHUP. It now executes\nonly reset() method.\nSimilar change was recently done in Neutron\u0027s functional tests in [2].\nThis patch reflects that change in networking-sfc functional tests.\n\n[1] https://review.opendev.org/#/c/641907/\n[2] https://review.opendev.org/#/c/680001/\n\nChange-Id: I22629c59da983f47ef8b1862afb9a62bdfd78b02\nCloses-Bug: #1842659\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-sfc/commit/0644862c8beedd902a7d739be524699edc9b61d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-sfc/commit/0644862c8beedd902a7d739be524699edc9b61d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}