)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In delete_port, it passes a port id directly to"},{"line_number":10,"context_line":"and _delete_ports_flowrules_by_id will iterate"},{"line_number":11,"context_line":"through each character of port. This causes"},{"line_number":12,"context_line":"a noticeable delay when delete a port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: shenjiatong \u003cyshxxsjt715@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: Ie72fb9e46ccdafac6d862337434af67d2bb56065"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bb494db5_bace5859","line":12,"range":{"start_line":11,"start_character":32,"end_line":12,"end_character":18},"updated":"2022-04-25 14:14:54.000000000","message":"This is a valid bug (beyond \u0027simple\u0027 typo), can you open a launchpad bug and mention it in commit message?","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In delete_port, it passes a port id directly to"},{"line_number":10,"context_line":"and _delete_ports_flowrules_by_id will iterate"},{"line_number":11,"context_line":"through each character of port. This causes"},{"line_number":12,"context_line":"a noticeable delay when delete a port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: shenjiatong \u003cyshxxsjt715@gmail.com\u003e"},{"line_number":15,"context_line":"Change-Id: Ie72fb9e46ccdafac6d862337434af67d2bb56065"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"493fb2fa_e84804cd","line":12,"range":{"start_line":11,"start_character":32,"end_line":12,"end_character":18},"in_reply_to":"bb494db5_bace5859","updated":"2022-04-27 07:33:47.000000000","message":"Done","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ebd4188_04158a36","updated":"2022-04-25 14:14:54.000000000","message":"Thanks for finding this indeed valid bug! -1 mostly on question on how to fix it (and opening a LP)","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83d67855_648ec1bc","updated":"2022-04-27 07:33:47.000000000","message":"Please have a look, thank you.","commit_id":"7e5ec507dbe102233cd8e0e4481b3e5379c3c9e4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4c4b67b2198a4b5494370d9dd4281e504a9bc770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d878cb0_6f38184f","updated":"2022-12-12 09:35:53.000000000","message":"To be honest, what I don\u0027t know is how this method was initially tested. This change deserves at least a unit test, this is not only a typo change.","commit_id":"7e5ec507dbe102233cd8e0e4481b3e5379c3c9e4"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"0d3b726025d4807494dce26001051ffc23a2c35c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65e1e230_4f4ec3db","updated":"2022-12-11 12:11:55.000000000","message":"eh, can this be merged?","commit_id":"7e5ec507dbe102233cd8e0e4481b3e5379c3c9e4"}],"networking_sfc/services/sfc/agent/extensions/sfc.py":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        resync \u003d False"},{"line_number":120,"context_line":"        LOG.info(\"a device %s is removed\", port_id)"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            self._delete_ports_flowrules_by_id(context, [port_id])"},{"line_number":123,"context_line":"        except Exception as e:"},{"line_number":124,"context_line":"            LOG.exception(e)"},{"line_number":125,"context_line":"            LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a4f8c67_48765ac3","line":122,"range":{"start_line":122,"start_character":56,"end_line":122,"end_character":65},"updated":"2022-04-25 14:14:54.000000000","message":"Wow, this error has been around for a long while! While this works as quick fix, I would go ahead and just simplify _delete_ports_flowrules_by_id() itself (see below)","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        resync \u003d False"},{"line_number":120,"context_line":"        LOG.info(\"a device %s is removed\", port_id)"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            self._delete_ports_flowrules_by_id(context, [port_id])"},{"line_number":123,"context_line":"        except Exception as e:"},{"line_number":124,"context_line":"            LOG.exception(e)"},{"line_number":125,"context_line":"            LOG.error("}],"source_content_type":"text/x-python","patch_set":1,"id":"16f1b508_bc3ec089","line":122,"range":{"start_line":122,"start_character":56,"end_line":122,"end_character":65},"in_reply_to":"5a4f8c67_48765ac3","updated":"2022-04-27 07:33:47.000000000","message":"Done","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":true,"context_lines":[{"line_number":181,"context_line":"            self.topic,"},{"line_number":182,"context_line":"            consumers)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _delete_ports_flowrules_by_id(self, context, ports_id):"},{"line_number":185,"context_line":"        flowrule_status \u003d []"},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, ports_id\u003d %s\", ports_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df95a0fa_b95b582e","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":37},"updated":"2022-04-25 14:14:54.000000000","message":"This is only used once in delete_port() we can update it to handle single port_id","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            self.topic,"},{"line_number":182,"context_line":"            consumers)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _delete_ports_flowrules_by_id(self, context, ports_id):"},{"line_number":185,"context_line":"        flowrule_status \u003d []"},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, ports_id\u003d %s\", ports_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f615a05b_51f1aad4","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":37},"in_reply_to":"df95a0fa_b95b582e","updated":"2022-04-27 07:33:47.000000000","message":"Done","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, ports_id\u003d %s\", ports_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if ports_id:"},{"line_number":190,"context_line":"                for port_id in ports_id:"},{"line_number":191,"context_line":"                    flowrule \u003d ("},{"line_number":192,"context_line":"                        self.sfc_plugin_rpc.get_flowrules_by_host_portid("},{"line_number":193,"context_line":"                            context, port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8ebb54b_28344231","line":190,"range":{"start_line":190,"start_character":16,"end_line":190,"end_character":19},"updated":"2022-04-25 14:14:54.000000000","message":"We can drop the for loop","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, ports_id\u003d %s\", ports_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if ports_id:"},{"line_number":190,"context_line":"                for port_id in ports_id:"},{"line_number":191,"context_line":"                    flowrule \u003d ("},{"line_number":192,"context_line":"                        self.sfc_plugin_rpc.get_flowrules_by_host_portid("},{"line_number":193,"context_line":"                            context, port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2bd8526_a6f1c202","line":190,"range":{"start_line":190,"start_character":16,"end_line":190,"end_character":19},"in_reply_to":"f8ebb54b_28344231","updated":"2022-04-27 07:33:47.000000000","message":"Done","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d97c83d41780ef19726a9635d7ad231a2aa8ce5a","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                        self.sfc.driver.delete_flow_rule("},{"line_number":198,"context_line":"                            flowrule, flowrule_status)"},{"line_number":199,"context_line":"            LOG.debug("},{"line_number":200,"context_line":"                \"_delete_ports_flowrules_by_id received, count\u003d %s\", count)"},{"line_number":201,"context_line":"        except Exception as e:"},{"line_number":202,"context_line":"            LOG.exception(e)"},{"line_number":203,"context_line":"            LOG.error(\"delete_port_id_flows failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c6c22c2_5ea358a5","line":200,"range":{"start_line":200,"start_character":57,"end_line":200,"end_character":66},"updated":"2022-04-25 14:14:54.000000000","message":"And drop that count that would stay at 0 anyway","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"bb8bacac78a07459cbe2f71628f49a3cca9809f9","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                        self.sfc.driver.delete_flow_rule("},{"line_number":198,"context_line":"                            flowrule, flowrule_status)"},{"line_number":199,"context_line":"            LOG.debug("},{"line_number":200,"context_line":"                \"_delete_ports_flowrules_by_id received, count\u003d %s\", count)"},{"line_number":201,"context_line":"        except Exception as e:"},{"line_number":202,"context_line":"            LOG.exception(e)"},{"line_number":203,"context_line":"            LOG.error(\"delete_port_id_flows failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfb4f8a8_bf0280cf","line":200,"range":{"start_line":200,"start_character":57,"end_line":200,"end_character":66},"in_reply_to":"2c6c22c2_5ea358a5","updated":"2022-04-27 07:33:47.000000000","message":"Done","commit_id":"42fa2c13789a486bcfc6b6d97beae5a927d020e3"}]}