)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fb565520e3706c148fd6c6dd3a74aeb96e23a3a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"efa4541f_2dbb16c8","updated":"2024-02-01 12:56:10.000000000","message":"looks ok, and it works for me on py312 and py38","commit_id":"44a5e93136089491f19593161827990353c93685"}],"networking_sfc/tests/unit/services/sfc/drivers/ovs/test_driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"219a943e87d22929fe9883caeaabee249a495de9","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def assertDictContainsSubset(self, a, b):"},{"line_number":93,"context_line":"        \"\"\"Check whether dict a is a subset of dict b.\"\"\""},{"line_number":94,"context_line":"        self.assertEqual(b, b | a)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        sfc_plugin \u003d test_sfc_db.DB_SFC_PLUGIN_CLASS"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca84a64c_a17b7122","line":94,"range":{"start_line":94,"start_character":28,"end_line":94,"end_character":33},"updated":"2024-01-24 15:46:28.000000000","message":"seems this does not work in Python 3.8. Can\u0027t we just use assertLessEqual ?\n\n```\nself.assertLessEqual(a, b)\n```","commit_id":"1ca61166c6e3af9806030c7aa84a03bc90f2a3f8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3eeb3482aac5051d4905900660facf7262a3b149","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def assertDictContainsSubset(self, a, b):"},{"line_number":93,"context_line":"        \"\"\"Check whether dict a is a subset of dict b.\"\"\""},{"line_number":94,"context_line":"        self.assertEqual(b, b | a)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        sfc_plugin \u003d test_sfc_db.DB_SFC_PLUGIN_CLASS"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5fc42a4_9662672e","line":94,"range":{"start_line":94,"start_character":28,"end_line":94,"end_character":33},"in_reply_to":"5ec16f18_637eb407","updated":"2024-01-31 17:19:17.000000000","message":"sorry it should have been\n\n``self.assertLessEqual(a.items(), b.items())``\n\nSee https://review.opendev.org/c/openstack/networking-sfc/+/907339 though this one is still valid.","commit_id":"1ca61166c6e3af9806030c7aa84a03bc90f2a3f8"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"3431d1de83f815361a8d0e202f8dacfbc4b60999","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def assertDictContainsSubset(self, a, b):"},{"line_number":93,"context_line":"        \"\"\"Check whether dict a is a subset of dict b.\"\"\""},{"line_number":94,"context_line":"        self.assertEqual(b, b | a)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        sfc_plugin \u003d test_sfc_db.DB_SFC_PLUGIN_CLASS"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ec16f18_637eb407","line":94,"range":{"start_line":94,"start_character":28,"end_line":94,"end_character":33},"in_reply_to":"ca84a64c_a17b7122","updated":"2024-01-29 09:56:31.000000000","message":"I don\u0027t think that actually validates that a is a subset of b - I\u0027ve updated the syntax for the dict comparison to be compatible with older Pythons.\n\nBasically the dicts get merged and then compared to the original.","commit_id":"1ca61166c6e3af9806030c7aa84a03bc90f2a3f8"}]}
