)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8378bbf472eb71b4533c4dfec4a6ce604b403f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c3c3d86_be03de22","updated":"2024-08-22 13:44:57.000000000","message":"Still have tempest failures 😞","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"893102b35d07581807ccd0d606e03082fb4f312d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47955458_41a921bd","updated":"2024-08-22 16:53:07.000000000","message":"Just nits, getting the gate green is more important.","commit_id":"94d303464bfc9dc2eb244004924ad685e78053f8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"946ee9e31da37afed519e130a4df15ab402c7ad9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b118f05e_31cf55e8","updated":"2024-08-23 14:00:23.000000000","message":"Thanks","commit_id":"94d303464bfc9dc2eb244004924ad685e78053f8"}],"networking_sfc/services/sfc/agent/extensions/sfc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8378bbf472eb71b4533c4dfec4a6ce604b403f5","unresolved":true,"context_lines":[{"line_number":184,"context_line":"    def _delete_port_flowrules_by_id(self, context, port_id):"},{"line_number":185,"context_line":"        flowrule_status \u003d []"},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, port_id\u003d %s\", port_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if port_id:"},{"line_number":190,"context_line":"                flowrule \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"093372ac_3bbd898c","line":187,"range":{"start_line":187,"start_character":23,"end_line":187,"end_character":43},"updated":"2024-08-22 13:44:57.000000000","message":"That doesn\u0027t match the function name 😊","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"978eb782fae307ea1bf1ef7924542b754a0268b2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def _delete_port_flowrules_by_id(self, context, port_id):"},{"line_number":185,"context_line":"        flowrule_status \u003d []"},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, port_id\u003d %s\", port_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if port_id:"},{"line_number":190,"context_line":"                flowrule \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"7971fd54_e470397a","line":187,"range":{"start_line":187,"start_character":23,"end_line":187,"end_character":43},"in_reply_to":"093372ac_3bbd898c","updated":"2024-08-22 14:43:37.000000000","message":"Done","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8378bbf472eb71b4533c4dfec4a6ce604b403f5","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, port_id\u003d %s\", port_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if port_id:"},{"line_number":190,"context_line":"                flowrule \u003d ("},{"line_number":191,"context_line":"                    self.sfc_plugin_rpc.get_flowrules_by_host_portid("},{"line_number":192,"context_line":"                        context, port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"337d0788_26d40374","line":189,"updated":"2024-08-22 13:44:57.000000000","message":"nit: can probably check port_id at beginning and just return","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"978eb782fae307ea1bf1ef7924542b754a0268b2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            LOG.debug(\"delete_port_id_flows received, port_id\u003d %s\", port_id)"},{"line_number":188,"context_line":"            count \u003d 0"},{"line_number":189,"context_line":"            if port_id:"},{"line_number":190,"context_line":"                flowrule \u003d ("},{"line_number":191,"context_line":"                    self.sfc_plugin_rpc.get_flowrules_by_host_portid("},{"line_number":192,"context_line":"                        context, port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"006b6fb6_7c579b4f","line":189,"in_reply_to":"337d0788_26d40374","updated":"2024-08-22 14:43:37.000000000","message":"Done","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8378bbf472eb71b4533c4dfec4a6ce604b403f5","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                    self.sfc.driver.delete_flow_rule("},{"line_number":197,"context_line":"                        flowrule, flowrule_status)"},{"line_number":198,"context_line":"            LOG.debug("},{"line_number":199,"context_line":"                \"_delete_port_flowrules_by_id received, count\u003d %s\", count)"},{"line_number":200,"context_line":"        except Exception as e:"},{"line_number":201,"context_line":"            LOG.exception(e)"},{"line_number":202,"context_line":"            LOG.error(\"delete_port_id_flows failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d80b27cd_62b93ab2","line":199,"range":{"start_line":199,"start_character":46,"end_line":199,"end_character":54},"updated":"2024-08-22 13:44:57.000000000","message":"The word \u0027received\u0027 doesn\u0027t really fit here, or even above if you ask me","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"978eb782fae307ea1bf1ef7924542b754a0268b2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    self.sfc.driver.delete_flow_rule("},{"line_number":197,"context_line":"                        flowrule, flowrule_status)"},{"line_number":198,"context_line":"            LOG.debug("},{"line_number":199,"context_line":"                \"_delete_port_flowrules_by_id received, count\u003d %s\", count)"},{"line_number":200,"context_line":"        except Exception as e:"},{"line_number":201,"context_line":"            LOG.exception(e)"},{"line_number":202,"context_line":"            LOG.error(\"delete_port_id_flows failed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d93e60a2_1ef98098","line":199,"range":{"start_line":199,"start_character":46,"end_line":199,"end_character":54},"in_reply_to":"d80b27cd_62b93ab2","updated":"2024-08-22 14:43:37.000000000","message":"I changed this log message and the one above too 😊","commit_id":"41508e5c17cfbebea01b168c93fdf6f2345e9775"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"893102b35d07581807ccd0d606e03082fb4f312d","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            consumers)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _delete_port_flowrules_by_id(self, context, port_id):"},{"line_number":185,"context_line":"        flowrule_status \u003d []"},{"line_number":186,"context_line":"        if not port_id:"},{"line_number":187,"context_line":"            return"},{"line_number":188,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"37cdf5b7_d300ca2f","line":185,"updated":"2024-08-22 16:53:07.000000000","message":"nit: can be after port_id check","commit_id":"94d303464bfc9dc2eb244004924ad685e78053f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"893102b35d07581807ccd0d606e03082fb4f312d","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        if not port_id:"},{"line_number":187,"context_line":"            return"},{"line_number":188,"context_line":"        try:"},{"line_number":189,"context_line":"            LOG.debug(\"delete_port_flowrules_by_id for port_id\u003d %s\","},{"line_number":190,"context_line":"                      port_id)"},{"line_number":191,"context_line":"            flowrule \u003d ("},{"line_number":192,"context_line":"                self.sfc_plugin_rpc.get_flowrules_by_host_portid("}],"source_content_type":"text/x-python","patch_set":3,"id":"90cde6dd_344387ec","line":189,"updated":"2024-08-22 16:53:07.000000000","message":"nit: _delete... if you have to respin, doesn\u0027t affect operation. And technically these LOGs don\u0027t need to be in the try/except","commit_id":"94d303464bfc9dc2eb244004924ad685e78053f8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"893102b35d07581807ccd0d606e03082fb4f312d","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                      port_id)"},{"line_number":201,"context_line":"        except Exception as e:"},{"line_number":202,"context_line":"            LOG.exception(e)"},{"line_number":203,"context_line":"            LOG.error(\"delete_port_id_flows failed\")"},{"line_number":204,"context_line":"        if flowrule_status:"},{"line_number":205,"context_line":"            self.sfc_plugin_rpc.update_flowrules_status("},{"line_number":206,"context_line":"                context, flowrule_status)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bcaa72b0_3a80d333","line":203,"range":{"start_line":203,"start_character":23,"end_line":203,"end_character":43},"updated":"2024-08-22 16:53:07.000000000","message":"nit: didn\u0027t even notice the typo here too","commit_id":"94d303464bfc9dc2eb244004924ad685e78053f8"}]}