)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"aedcbe32ac20a66bc983ec49f6743580e2749679","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yuyangbj \u003cyangyu@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 18:12:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"(WIP)Refactor the code to support agentless BGP driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id98d3d61f3c1bad65db52a482828714398c03f82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_66f62bd8","line":7,"updated":"2016-08-07 03:54:48.000000000","message":"No bug for this change?","commit_id":"fae1a66c73ba3683cee03d8d16bc8a7bfbccb814"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":11,"context_line":"service_provider for default agent driver should be:"},{"line_number":12,"context_line":"DYNAMIC_ROUTING:RPCDriver:neutron_dynamic_routing.services.bgp.service_drivers.rpc_driver.BgpRpcPluginDriver:default"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For more detail information, please check the bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1611632"},{"line_number":17,"context_line":"Change-Id: Id98d3d61f3c1bad65db52a482828714398c03f82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3a71b18c_61dc93e4","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":15},"updated":"2016-12-12 14:17:59.000000000","message":"detailed","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"b3771b0b3f54363245e6d215c476ba073f769a52","unresolved":false,"context_lines":[{"line_number":11,"context_line":"service_provider for default agent driver should be:"},{"line_number":12,"context_line":"DYNAMIC_ROUTING:RPCDriver:neutron_dynamic_routing.services.bgp.service_drivers.rpc_driver.BgpRpcPluginDriver:default"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"For more detail information, please check the bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1611632"},{"line_number":17,"context_line":"Change-Id: Id98d3d61f3c1bad65db52a482828714398c03f82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a6eadb0_b3f21999","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":15},"in_reply_to":"3a71b18c_61dc93e4","updated":"2016-12-13 06:39:50.000000000","message":":) Thanks.","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"}],"devstack/lib/dr":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"241c4af1a3851ed17596888fdb187730a547db82","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"#This API will be called for phase \"extra\""},{"line_number":80,"context_line":"function start_dr_agent {"},{"line_number":81,"context_line":"    local process\u003d\"$DR_AGENT_BINARY --config-file $NEUTRON_CONF --config-file $DR_BGP_CONF_FILE \""},{"line_number":82,"context_line":"    local bgp_parameter"},{"line_number":83,"context_line":"    if is_protocol_enabled BGP; then"},{"line_number":84,"context_line":"        bgp_parameter\u003d\"--config-file $DR_AGENT_BGP_CONF_FILE\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a98d1f4_d1514764","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":96},"updated":"2016-09-29 05:56:15.000000000","message":"Do we really need to run the agent for agent-less drivers?","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"97aca944792b0ac754601f447f58a2a2248c748f","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"#This API will be called for phase \"extra\""},{"line_number":80,"context_line":"function start_dr_agent {"},{"line_number":81,"context_line":"    local process\u003d\"$DR_AGENT_BINARY --config-file $NEUTRON_CONF --config-file $DR_BGP_CONF_FILE \""},{"line_number":82,"context_line":"    local bgp_parameter"},{"line_number":83,"context_line":"    if is_protocol_enabled BGP; then"},{"line_number":84,"context_line":"        bgp_parameter\u003d\"--config-file $DR_AGENT_BGP_CONF_FILE\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ba5da102_c7f4ac5c","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":96},"in_reply_to":"3a98d1f4_d1514764","updated":"2016-11-02 08:08:57.000000000","message":"No, but that is not defined here.","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d463afa8ac295e2130d51090795fa0a6d2145ee","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    dr_generate_config_files"},{"line_number":66,"context_line":"    configure_dr_service_provider_config"},{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_347369b3","line":71,"range":{"start_line":68,"start_character":8,"end_line":71,"end_character":10},"updated":"2016-11-07 13:10:45.000000000","message":"This should not be dependent upon dr-agent any more.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"5dc9048fbf2abac49b01358e63a081b0a99527d1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    dr_generate_config_files"},{"line_number":66,"context_line":"    configure_dr_service_provider_config"},{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_928a45be","line":71,"range":{"start_line":68,"start_character":8,"end_line":71,"end_character":10},"in_reply_to":"9a629dbe_347369b3","updated":"2016-11-08 16:46:27.000000000","message":"Right, the agent config is now decoupled from these settings. Maybe what could be done here is to check whether the rpc service driver has been configured rather than \"if is_protocol_enabled BGP;\". Unless you use the rpc service driver the agent config doesn\u0027t need to be triggered.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8efb13f750269b69134fca53758d65b287728a42","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    dr_generate_config_files"},{"line_number":66,"context_line":"    configure_dr_service_provider_config"},{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_eccc386c","line":71,"range":{"start_line":68,"start_character":8,"end_line":71,"end_character":10},"in_reply_to":"9a629dbe_928a45be","updated":"2016-11-10 07:43:33.000000000","message":"i am a little confused here. I added the check if the q-dr-agent is enabled. If it is enabled, it means the RPC driver should be used. So we should configure the speaker backend (ryu, for example) for the RPC driver.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"259cfb77adaa3e2c6f69968a0a515ccd906f0d58","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3a71b18c_13704d0a","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":41},"updated":"2016-12-07 11:23:20.000000000","message":"IMO, the driver part should be independent of agent now..","commit_id":"d0a17dbac74b673f3231cd040d52fe605346b385"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"982764952d2ac0e8ce1df18cfecb549085342992","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3a71b18c_d7bb7ac2","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":41},"in_reply_to":"3a71b18c_13704d0a","updated":"2016-12-12 06:32:37.000000000","message":"Hi Vikram,\n\nMaybe we need to rename this method? It is a little misleading.\n\nHere the bgp driver is to configure the ryu, maybe quagga in future. Refer to the configuration below. This is for the agent provider. So I think it should be related to the agent.\n\nbgp_speaker_driver \u003d neutron_dynamic_routing.services.bgp.agent.driver.ryu.driver.RyuBgpDriver\nbgp_router_id \u003d 127.0.0.1","commit_id":"d0a17dbac74b673f3231cd040d52fe605346b385"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6913d8a877c1e60cb8812a6b04a9cd4709c0511a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"function dr_post_configure {"},{"line_number":65,"context_line":"    dr_generate_config_files"},{"line_number":66,"context_line":"    configure_dr_service_provider_config"},{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"#############################"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"7a3c09a3_644b2ab1","line":72,"range":{"start_line":67,"start_character":4,"end_line":72,"end_character":6},"updated":"2017-01-16 11:45:32.000000000","message":"IMO, driver deployment should be independent of dragent.","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"f03cddb426d1d8b2ace2975b21344b6e558fb601","unresolved":false,"context_lines":[{"line_number":64,"context_line":"function dr_post_configure {"},{"line_number":65,"context_line":"    dr_generate_config_files"},{"line_number":66,"context_line":"    configure_dr_service_provider_config"},{"line_number":67,"context_line":"    if is_service_enabled q-dr-agent; then"},{"line_number":68,"context_line":"        if is_protocol_enabled BGP; then"},{"line_number":69,"context_line":"            configure_dr_agent_bgp_config"},{"line_number":70,"context_line":"            configure_dr_agent_bgp_driver"},{"line_number":71,"context_line":"        fi"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"#############################"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"7a3c09a3_6a54acfe","line":72,"range":{"start_line":67,"start_character":4,"end_line":72,"end_character":6},"in_reply_to":"7a3c09a3_644b2ab1","updated":"2017-01-17 03:35:30.000000000","message":"You are correct, but for the RPC driver, it should depend on the dr agent enablement. So I will change the code to enable the RPC driver.","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"}],"devstack/settings":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d463afa8ac295e2130d51090795fa0a6d2145ee","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case $DR_MODE in"},{"line_number":29,"context_line":"    allinone)"},{"line_number":30,"context_line":"        enable_service q-dr q-dr-agent"},{"line_number":31,"context_line":"        ;;"},{"line_number":32,"context_line":"    dr_plugin)"},{"line_number":33,"context_line":"        enable_service q-dr"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_14574503","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":38},"updated":"2016-11-07 13:10:45.000000000","message":"I think you need to refactor this.. AFAIU, we need to deploy dr-agent iff the service provider is RPC..","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"5dc9048fbf2abac49b01358e63a081b0a99527d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case $DR_MODE in"},{"line_number":29,"context_line":"    allinone)"},{"line_number":30,"context_line":"        enable_service q-dr q-dr-agent"},{"line_number":31,"context_line":"        ;;"},{"line_number":32,"context_line":"    dr_plugin)"},{"line_number":33,"context_line":"        enable_service q-dr"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_d282fd93","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":38},"in_reply_to":"9a629dbe_14574503","updated":"2016-11-08 16:46:27.000000000","message":"Yes, I think this needs a little more thought.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8efb13f750269b69134fca53758d65b287728a42","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case $DR_MODE in"},{"line_number":29,"context_line":"    allinone)"},{"line_number":30,"context_line":"        enable_service q-dr q-dr-agent"},{"line_number":31,"context_line":"        ;;"},{"line_number":32,"context_line":"    dr_plugin)"},{"line_number":33,"context_line":"        enable_service q-dr"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a629dbe_ac58808b","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":38},"in_reply_to":"9a629dbe_d282fd93","updated":"2016-11-10 07:43:33.000000000","message":"As you guys known, this is for the devstack, I assume all the behaviours are kept consistent before the refactor. In the setting, we use the RPC driver by default, so we enable the dr-agent for allinone mode.\n\nYou can refer to the setting BGP_SERVICE_PROVIDER below, we used the RPC driver.\n\nActually, if we want to enable the agent less driver, we can set the DR_MODE in local.conf.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"}],"neutron_dynamic_routing/db/bgp_dragentscheduler_db.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"241c4af1a3851ed17596888fdb187730a547db82","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_71d153cd","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":51},"updated":"2016-09-29 05:56:15.000000000","message":"Why we have included this?","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"97aca944792b0ac754601f447f58a2a2248c748f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_aa75bf98","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":51},"in_reply_to":"3a98d1f4_71d153cd","updated":"2016-11-02 08:08:57.000000000","message":"I remember the code depends on this module, I will test it again. And try to see if we can remove it.","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"259cfb77adaa3e2c6f69968a0a515ccd906f0d58","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_33cc6988","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":51},"updated":"2016-12-07 11:23:20.000000000","message":"This change looks irrelevant, I believe.","commit_id":"d0a17dbac74b673f3231cd040d52fe605346b385"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"982764952d2ac0e8ce1df18cfecb549085342992","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_77d8e61e","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":51},"in_reply_to":"3a71b18c_33cc6988","updated":"2016-12-12 06:32:37.000000000","message":"Will remove it. Thanks.","commit_id":"d0a17dbac74b673f3231cd040d52fe605346b385"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"#from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_219c5b0d","line":26,"updated":"2016-12-12 14:17:59.000000000","message":"can we remove this?","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"b3771b0b3f54363245e6d215c476ba073f769a52","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.db import agents_db"},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db as as_db"},{"line_number":26,"context_line":"#from neutron.db import common_db_mixin as common_db"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron_dynamic_routing._i18n import _"},{"line_number":29,"context_line":"from neutron_dynamic_routing._i18n import _LW"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_b3b93931","line":26,"in_reply_to":"3a71b18c_219c5b0d","updated":"2016-12-13 06:39:50.000000000","message":"Thanks. Updated in next patch.","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"}],"neutron_dynamic_routing/services/bgp/bgp_plugin.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def get_bgp_speakers(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":77,"context_line":"                         sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":78,"context_line":"                         page_reverse\u003dFalse):"},{"line_number":79,"context_line":"        return super(BgpPlugin, self).get_bgp_speakers("},{"line_number":80,"context_line":"                                                    context,"},{"line_number":81,"context_line":"                                                    filters\u003dfilters,"},{"line_number":82,"context_line":"                                                    fields\u003dfields,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_65e86fe3","line":79,"updated":"2016-08-16 10:25:45.000000000","message":"This should also be driver specific.. correct?","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                    page_reverse\u003dpage_reverse)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def get_bgp_speaker(self, context, bgp_speaker_id, fields\u003dNone):"},{"line_number":89,"context_line":"        return super(BgpPlugin, self).get_bgp_speaker(context,"},{"line_number":90,"context_line":"                                                      bgp_speaker_id,"},{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_e5ba9fe0","line":89,"updated":"2016-08-16 10:25:45.000000000","message":"ditto","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_bgp_peers(self, context, fields\u003dNone, filters\u003dNone, sorts\u003dNone,"},{"line_number":105,"context_line":"                      limit\u003dNone, marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":106,"context_line":"        return super(BgpPlugin, self).get_bgp_peers("},{"line_number":107,"context_line":"                                                 context, fields\u003dfields,"},{"line_number":108,"context_line":"                                                 filters\u003dfilters, sorts\u003dsorts,"},{"line_number":109,"context_line":"                                                 limit\u003dlimit, marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_052a5b2c","line":106,"updated":"2016-08-16 10:25:45.000000000","message":"ditto","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                                 page_reverse\u003dpage_reverse)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def get_bgp_peer(self, context, bgp_peer_id, fields\u003dNone):"},{"line_number":113,"context_line":"        return super(BgpPlugin, self).get_bgp_peer(context,"},{"line_number":114,"context_line":"                                                   bgp_peer_id,"},{"line_number":115,"context_line":"                                                   fields\u003dfields)"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_65218f4d","line":113,"updated":"2016-08-16 10:25:45.000000000","message":"ditto","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                                                  network_info)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def get_advertised_routes(self, context, bgp_speaker_id):"},{"line_number":161,"context_line":"        return super(BgpPlugin, self).get_advertised_routes(context,"},{"line_number":162,"context_line":"                                                            bgp_speaker_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_a51b871a","line":161,"updated":"2016-08-16 10:25:45.000000000","message":"ditto","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"241c4af1a3851ed17596888fdb187730a547db82","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                    speaker_id)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def list_bgp_speaker_on_dragent(self, context, agent_id):"},{"line_number":145,"context_line":"        return self.driver.list_bgp_speaker_on_dragent(context, agent_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def list_dragent_hosting_bgp_speaker(self, context, speaker_id):"},{"line_number":148,"context_line":"        return self.driver.list_dragent_hosting_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_51f37773","line":145,"range":{"start_line":145,"start_character":15,"end_line":145,"end_character":26},"updated":"2016-09-29 05:56:15.000000000","message":"Why we want to make a call to the driver? IMO, fetching the available information from the neutron server db would suffice.\n\nIf we decide to call driver interface only then why call for get_bgp_peers \u0026 get_bgp_peer are not directed to the driver?","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"97aca944792b0ac754601f447f58a2a2248c748f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                    speaker_id)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def list_bgp_speaker_on_dragent(self, context, agent_id):"},{"line_number":145,"context_line":"        return self.driver.list_bgp_speaker_on_dragent(context, agent_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def list_dragent_hosting_bgp_speaker(self, context, speaker_id):"},{"line_number":148,"context_line":"        return self.driver.list_dragent_hosting_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_6a1ba773","line":145,"range":{"start_line":145,"start_character":15,"end_line":145,"end_character":26},"in_reply_to":"3a98d1f4_51f37773","updated":"2016-11-02 08:08:57.000000000","message":"Per my understanding, this bgp_plugin is an unified interface, all the real ops will be delegated to the driver itself. If I query the DB directly, but for the agent less driver we do not need to query it because the agent less driver does not support it. So that is why I delegated all ops.","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"241c4af1a3851ed17596888fdb187730a547db82","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        return self.driver.list_bgp_speaker_on_dragent(context, agent_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def list_dragent_hosting_bgp_speaker(self, context, speaker_id):"},{"line_number":148,"context_line":"        return self.driver.list_dragent_hosting_bgp_speaker(context,"},{"line_number":149,"context_line":"                                                            speaker_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def add_gateway_network(self, context, bgp_speaker_id, network_info):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_71e8737d","line":148,"range":{"start_line":148,"start_character":15,"end_line":148,"end_character":26},"updated":"2016-09-29 05:56:15.000000000","message":"ditto","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"97aca944792b0ac754601f447f58a2a2248c748f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        return self.driver.list_bgp_speaker_on_dragent(context, agent_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def list_dragent_hosting_bgp_speaker(self, context, speaker_id):"},{"line_number":148,"context_line":"        return self.driver.list_dragent_hosting_bgp_speaker(context,"},{"line_number":149,"context_line":"                                                            speaker_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def add_gateway_network(self, context, bgp_speaker_id, network_info):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_8a18fb76","line":148,"range":{"start_line":148,"start_character":15,"end_line":148,"end_character":26},"in_reply_to":"3a98d1f4_71e8737d","updated":"2016-11-02 08:08:57.000000000","message":"see the response above.","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7dd82046250ca20871348072724c62544ba63f89","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_bgp_speaker(self, context, bgp_speaker):"},{"line_number":94,"context_line":"        return self.driver.create_bgp_speaker(context, bgp_speaker)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_bgp_speaker(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":97,"context_line":"        return self.driver.update_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_77fc46b8","line":94,"updated":"2017-01-06 23:31:40.000000000","message":"I\u0027d like to see the core plugin handle managing the model, then delegate to the driver.\n\nPerhaps consider using the callbacks framework here to notify the driver. That could give us a nice decoupling of the various backends from the core plugin.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"62ac9fad30f28f263a8d8ce44b4b960b39b1d9eb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_bgp_speaker(self, context, bgp_speaker):"},{"line_number":94,"context_line":"        return self.driver.create_bgp_speaker(context, bgp_speaker)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_bgp_speaker(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":97,"context_line":"        return self.driver.update_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_96c50c0c","line":94,"in_reply_to":"ba5201f7_77fc46b8","updated":"2017-01-09 10:17:23.000000000","message":"Will update it in next patch.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"392906b02c0a8030e942139fc1528d4d343a6da2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_bgp_speaker(self, context, bgp_speaker):"},{"line_number":94,"context_line":"        return self.driver.create_bgp_speaker(context, bgp_speaker)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_bgp_speaker(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":97,"context_line":"        return self.driver.update_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_02552f1c","line":94,"in_reply_to":"ba5201f7_96c50c0c","updated":"2017-01-10 06:32:13.000000000","message":"also consider pre/postcommit pattern, which is used by ml2, l2gw, tap-as-a-service, etc.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6913d8a877c1e60cb8812a6b04a9cd4709c0511a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return super(BgpPlugin, self).get_advertised_routes(context,"},{"line_number":162,"context_line":"                                                            bgp_speaker_id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_bgp_speaker_db_inf(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":165,"context_line":"        return super(BgpPlugin, self).update_bgp_speaker(context,"},{"line_number":166,"context_line":"                                                         bgp_speaker_id,"},{"line_number":167,"context_line":"                                                         bgp_speaker)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_bgp_speaker_db_inf(self, context, bgp_speaker):"},{"line_number":170,"context_line":"        return super(BgpPlugin, self).create_bgp_speaker(context,"},{"line_number":171,"context_line":"                                                         bgp_speaker)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_bgp_speaker_db_inf(self, context, bgp_speaker_id):"},{"line_number":174,"context_line":"        super(BgpPlugin, self).delete_bgp_speaker(context, bgp_speaker_id)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def create_bgp_peer_db_inf(self, context, bgp_peer):"},{"line_number":177,"context_line":"        return super(BgpPlugin, self).create_bgp_peer(context, bgp_peer)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def update_bgp_peer_db_inf(self, context, bgp_peer_id, bgp_peer):"},{"line_number":180,"context_line":"        return super(BgpPlugin, self).update_bgp_peer(context,"},{"line_number":181,"context_line":"                                                      bgp_peer_id,"},{"line_number":182,"context_line":"                                                      bgp_peer)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def delete_bgp_peer_db_inf(self, context, bgp_peer_id):"},{"line_number":185,"context_line":"        super(BgpPlugin, self).delete_bgp_peer(context, bgp_peer_id)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def add_bgp_peer_db_inf(self, context, bgp_speaker_id, bgp_peer_info):"},{"line_number":188,"context_line":"        return super(BgpPlugin, self).add_bgp_peer(context,"},{"line_number":189,"context_line":"                                                   bgp_speaker_id,"},{"line_number":190,"context_line":"                                                   bgp_peer_info)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def remove_bgp_peer_db_inf(self, context, bgp_speaker_id, bgp_peer_info):"},{"line_number":193,"context_line":"        return super(BgpPlugin, self).remove_bgp_peer(context,"},{"line_number":194,"context_line":"                                                      bgp_speaker_id,"},{"line_number":195,"context_line":"                                                      bgp_peer_info)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def add_gateway_network_db_inf(self, context,"},{"line_number":198,"context_line":"                                   bgp_speaker_id, network_info):"},{"line_number":199,"context_line":"        super(BgpPlugin, self).add_gateway_network(context,"},{"line_number":200,"context_line":"                                                   bgp_speaker_id,"},{"line_number":201,"context_line":"                                                   network_info)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def remove_gateway_network_db_inf(self, context, bgp_speaker_id,"},{"line_number":204,"context_line":"                                      network_info):"},{"line_number":205,"context_line":"        super(BgpPlugin, self).remove_gateway_network(context, bgp_speaker_id,"},{"line_number":206,"context_line":"                                                      network_info)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_7f4e5770","line":206,"range":{"start_line":164,"start_character":4,"end_line":206,"end_character":67},"updated":"2017-01-16 11:45:32.000000000","message":"Why we need these interfaces?","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"f03cddb426d1d8b2ace2975b21344b6e558fb601","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return super(BgpPlugin, self).get_advertised_routes(context,"},{"line_number":162,"context_line":"                                                            bgp_speaker_id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_bgp_speaker_db_inf(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":165,"context_line":"        return super(BgpPlugin, self).update_bgp_speaker(context,"},{"line_number":166,"context_line":"                                                         bgp_speaker_id,"},{"line_number":167,"context_line":"                                                         bgp_speaker)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_bgp_speaker_db_inf(self, context, bgp_speaker):"},{"line_number":170,"context_line":"        return super(BgpPlugin, self).create_bgp_speaker(context,"},{"line_number":171,"context_line":"                                                         bgp_speaker)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_bgp_speaker_db_inf(self, context, bgp_speaker_id):"},{"line_number":174,"context_line":"        super(BgpPlugin, self).delete_bgp_speaker(context, bgp_speaker_id)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def create_bgp_peer_db_inf(self, context, bgp_peer):"},{"line_number":177,"context_line":"        return super(BgpPlugin, self).create_bgp_peer(context, bgp_peer)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def update_bgp_peer_db_inf(self, context, bgp_peer_id, bgp_peer):"},{"line_number":180,"context_line":"        return super(BgpPlugin, self).update_bgp_peer(context,"},{"line_number":181,"context_line":"                                                      bgp_peer_id,"},{"line_number":182,"context_line":"                                                      bgp_peer)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def delete_bgp_peer_db_inf(self, context, bgp_peer_id):"},{"line_number":185,"context_line":"        super(BgpPlugin, self).delete_bgp_peer(context, bgp_peer_id)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def add_bgp_peer_db_inf(self, context, bgp_speaker_id, bgp_peer_info):"},{"line_number":188,"context_line":"        return super(BgpPlugin, self).add_bgp_peer(context,"},{"line_number":189,"context_line":"                                                   bgp_speaker_id,"},{"line_number":190,"context_line":"                                                   bgp_peer_info)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def remove_bgp_peer_db_inf(self, context, bgp_speaker_id, bgp_peer_info):"},{"line_number":193,"context_line":"        return super(BgpPlugin, self).remove_bgp_peer(context,"},{"line_number":194,"context_line":"                                                      bgp_speaker_id,"},{"line_number":195,"context_line":"                                                      bgp_peer_info)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def add_gateway_network_db_inf(self, context,"},{"line_number":198,"context_line":"                                   bgp_speaker_id, network_info):"},{"line_number":199,"context_line":"        super(BgpPlugin, self).add_gateway_network(context,"},{"line_number":200,"context_line":"                                                   bgp_speaker_id,"},{"line_number":201,"context_line":"                                                   network_info)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def remove_gateway_network_db_inf(self, context, bgp_speaker_id,"},{"line_number":204,"context_line":"                                      network_info):"},{"line_number":205,"context_line":"        super(BgpPlugin, self).remove_gateway_network(context, bgp_speaker_id,"},{"line_number":206,"context_line":"                                                      network_info)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_8a071817","line":206,"range":{"start_line":164,"start_character":4,"end_line":206,"end_character":67},"in_reply_to":"7a3c09a3_7f4e5770","updated":"2017-01-17 03:35:30.000000000","message":"This is the db interface for rpc driver, the driver will not invoke the db directly.","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a6205e5140cfb19125770cad92380c7645ba802e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_bgp_speaker(self, context, bgp_speaker):"},{"line_number":94,"context_line":"        return self.driver.create_bgp_speaker(context, bgp_speaker)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_bgp_speaker(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":97,"context_line":"        return self.driver.update_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_525ec612","line":94,"updated":"2017-01-17 04:58:53.000000000","message":"it\u0027s still not clear why you want this uncommon construct.\nwon\u0027t it be a problem if/when we want to support multiple drivers later?\n\nafter looking at your driver [1]\ni guess you may want before-db-operation hooks for it, in addition to pre/post commit.\nbut i\u0027m not sure if it\u0027s a good idea in general, as usually we consider neutron db as an authoritative source of the logical topology which the backend will follow, not the other way around.\n\nhow do you and others think?\n\n[1] https://review.openstack.org/#/c/355775/","commit_id":"d2b6d1503020b9f301ccca43e4b11649f432a652"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"50c29cba6b0e1d9c4ad1605e06279221f73c9d0a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                      fields\u003dfields)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def create_bgp_speaker(self, context, bgp_speaker):"},{"line_number":94,"context_line":"        return self.driver.create_bgp_speaker(context, bgp_speaker)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_bgp_speaker(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":97,"context_line":"        return self.driver.update_bgp_speaker(context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_d2eb9676","line":94,"in_reply_to":"7a3c09a3_525ec612","updated":"2017-01-17 05:23:04.000000000","message":"For multiple drivers (besides vmware_nsx) support in future, they just need to load the driver directly and define the interface in their own driver. This is what I am thinking and other projects such as neutron_lbaas are doing like it.\n\nFor vmware_nsx driver, that is not enough using a simple pre/post commit because  it is difficult to define what is pre commit and what is post commit. And sometimes need to get the db information to address the vmware edge. \n\nAnd I still do not know why this is a uncommon construct. The API interface delegates task to driver, and the driver does the real job. The service plugin only provides the overall api interface and db operation like you guys said. Maybe you do not like I define some interfaces to invoke the db, but that is because our service plugin interface has same name as db interface, if you like I can change the interface name such as create_bgp_speaker and create_bgp_peer to different ones, what do you think?","commit_id":"d2b6d1503020b9f301ccca43e4b11649f432a652"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a6205e5140cfb19125770cad92380c7645ba802e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return super(BgpPlugin, self).get_advertised_routes(context,"},{"line_number":162,"context_line":"                                                            bgp_speaker_id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_bgp_speaker_db_inf(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":165,"context_line":"        return super(BgpPlugin, self).update_bgp_speaker(context,"},{"line_number":166,"context_line":"                                                         bgp_speaker_id,"},{"line_number":167,"context_line":"                                                         bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_f2c6d298","line":164,"range":{"start_line":164,"start_character":29,"end_line":164,"end_character":33},"updated":"2017-01-17 04:58:53.000000000","message":"what _inf stands for?","commit_id":"d2b6d1503020b9f301ccca43e4b11649f432a652"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"50c29cba6b0e1d9c4ad1605e06279221f73c9d0a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return super(BgpPlugin, self).get_advertised_routes(context,"},{"line_number":162,"context_line":"                                                            bgp_speaker_id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def update_bgp_speaker_db_inf(self, context, bgp_speaker_id, bgp_speaker):"},{"line_number":165,"context_line":"        return super(BgpPlugin, self).update_bgp_speaker(context,"},{"line_number":166,"context_line":"                                                         bgp_speaker_id,"},{"line_number":167,"context_line":"                                                         bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a3c09a3_32da1a18","line":164,"range":{"start_line":164,"start_character":29,"end_line":164,"end_character":33},"in_reply_to":"7a3c09a3_f2c6d298","updated":"2017-01-17 05:23:04.000000000","message":"interface \u003d\u003d intf, if you like, I can change it.","commit_id":"d2b6d1503020b9f301ccca43e4b11649f432a652"}],"neutron_dynamic_routing/services/bgp/common/constants.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"aedcbe32ac20a66bc983ec49f6743580e2749679","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"BGP_PLUGIN \u003d \u0027q-bgp-plugin\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DYNAMIC_ROUTING \u003d \u0027DYNAMICROUTING\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# List of supported authentication types."},{"line_number":25,"context_line":"SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_460de7e6","line":22,"updated":"2016-08-07 03:54:48.000000000","message":"I would suggest this to be \u0027dynamic_routing\u0027..","commit_id":"fae1a66c73ba3683cee03d8d16bc8a7bfbccb814"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"a6d749b75cb5294129ce9b08b493bec84103fd40","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"BGP_PLUGIN \u003d \u0027q-bgp-plugin\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DYNAMIC_ROUTING \u003d \u0027DYNAMICROUTING\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# List of supported authentication types."},{"line_number":25,"context_line":"SUPPORTED_AUTH_TYPES \u003d [\u0027none\u0027, \u0027md5\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_c8447db8","line":22,"in_reply_to":"bacf61ea_460de7e6","updated":"2016-08-11 03:32:09.000000000","message":"@Vikram,\n\nThanks for your review.\n\nAll service providers for service_type property are using the upper case such as LOADBALANCERV2, LOADBALANCER, FWAAS. So I change it to DYNAMIC_ROUTING, any comment?","commit_id":"fae1a66c73ba3683cee03d8d16bc8a7bfbccb814"}],"neutron_dynamic_routing/services/bgp/common/opts.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"878290e26b9b021257a28e4c73a9e85fca443ef1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def list_opts():"},{"line_number":35,"context_line":"    return ["},{"line_number":36,"context_line":"        (\u0027service_providers\u0027,"},{"line_number":37,"context_line":"         neutron.services.provider_configuration.serviceprovider_opts)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_a5770739","line":34,"updated":"2016-08-16 10:25:45.000000000","message":"How about \"list_service_provider_opt\"?","commit_id":"834949b21cdf2c9fb7a24b05ea7449319bb0589b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"241c4af1a3851ed17596888fdb187730a547db82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def list_opts():"},{"line_number":35,"context_line":"    return ["},{"line_number":36,"context_line":"        (\u0027service_providers\u0027,"},{"line_number":37,"context_line":"         neutron.services.provider_configuration.serviceprovider_opts)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_b1891bcd","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":13},"updated":"2016-09-29 05:56:15.000000000","message":"How about renaming to list_provider_opts?","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"97aca944792b0ac754601f447f58a2a2248c748f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def list_opts():"},{"line_number":35,"context_line":"    return ["},{"line_number":36,"context_line":"        (\u0027service_providers\u0027,"},{"line_number":37,"context_line":"         neutron.services.provider_configuration.serviceprovider_opts)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_ea1df762","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":13},"in_reply_to":"3a98d1f4_b1891bcd","updated":"2016-11-02 08:08:57.000000000","message":"sure, fixed in next patch. Thanks.","commit_id":"5c5df60a56d36ffaa84eb5b294b8217b82195fab"}],"neutron_dynamic_routing/services/bgp/service_drivers/rpc_bgp.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d463afa8ac295e2130d51090795fa0a6d2145ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a629dbe_34b9a9ea","line":1,"updated":"2016-11-07 13:10:45.000000000","message":"Since we are inside services/bgp having a suffix \u0027_bgp\u0027 in the filename sounds redundant.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8efb13f750269b69134fca53758d65b287728a42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a629dbe_2c2e30a5","line":1,"in_reply_to":"9a629dbe_34b9a9ea","updated":"2016-11-10 07:43:33.000000000","message":"Great advice. Will fix it in next patch.","commit_id":"7472f8a9125792eb784d18315c35bc36eab02975"}],"neutron_dynamic_routing/services/bgp/service_drivers/rpc_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from netaddr import IPAddress"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_a1a78b4e","line":15,"updated":"2016-12-12 14:17:59.000000000","message":"this should just be import netaddr and the you should use netaddr.IPAddress","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"b3771b0b3f54363245e6d215c476ba073f769a52","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from netaddr import IPAddress"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_53f8e5e5","line":15,"in_reply_to":"3a71b18c_a1a78b4e","updated":"2016-12-13 06:39:50.000000000","message":"I think so. Thanks.","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        dest \u003d floating_ip_address + \u0027/32\u0027"},{"line_number":164,"context_line":"        bgp_speakers \u003d self.bgp_db._bgp_speakers_for_gw_network_by_family("},{"line_number":165,"context_line":"            ctx,"},{"line_number":166,"context_line":"            kwargs[\u0027floating_network_id\u0027],"},{"line_number":167,"context_line":"            n_const.IP_VERSION_4)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        if last_router_id and new_router_id !\u003d last_router_id:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_4146b77b","line":166,"updated":"2016-12-12 14:17:59.000000000","message":"to be safe maybe use kwargs.get","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if event \u003d\u003d events.AFTER_CREATE:"},{"line_number":185,"context_line":"            self._handle_router_interface_after_create(**kwargs)"},{"line_number":186,"context_line":"        if event \u003d\u003d events.AFTER_DELETE:"},{"line_number":187,"context_line":"            gw_network \u003d kwargs[\u0027network_id\u0027]"},{"line_number":188,"context_line":"            next_hops \u003d self._next_hops_from_gateway_ips("},{"line_number":189,"context_line":"                                                        kwargs[\u0027gateway_ips\u0027])"},{"line_number":190,"context_line":"            ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_615f3341","line":187,"updated":"2016-12-12 14:17:59.000000000","message":"ditto","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            speakers \u003d self._bgp_speakers_for_gateway_network(ctx, gw_network)"},{"line_number":192,"context_line":"            for speaker in speakers:"},{"line_number":193,"context_line":"                routes \u003d self._route_list_from_prefixes_and_next_hop("},{"line_number":194,"context_line":"                                                kwargs[\u0027cidrs\u0027],"},{"line_number":195,"context_line":"                                                next_hops[speaker.ip_version])"},{"line_number":196,"context_line":"                self._handle_router_interface_after_delete(gw_network, routes)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_c152c734","line":194,"updated":"2016-12-12 14:17:59.000000000","message":"ditto","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self._handle_router_interface_after_delete(gw_network, routes)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _handle_router_interface_after_create(self, **kwargs):"},{"line_number":199,"context_line":"        gw_network \u003d kwargs[\u0027network_id\u0027]"},{"line_number":200,"context_line":"        if not gw_network:"},{"line_number":201,"context_line":"            return"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_612653cf","line":199,"updated":"2016-12-12 14:17:59.000000000","message":"ditto","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            speakers \u003d self.bgp_db._bgp_speakers_for_gateway_network(ctx,"},{"line_number":206,"context_line":"                                                              gw_network)"},{"line_number":207,"context_line":"            next_hops \u003d self._next_hops_from_gateway_ips("},{"line_number":208,"context_line":"                                                    kwargs[\u0027gateway_ips\u0027])"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            for speaker in speakers:"},{"line_number":211,"context_line":"                prefixes \u003d self.bgp_db._tenant_prefixes_by_router("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_a12cebac","line":208,"updated":"2016-12-12 14:17:59.000000000","message":"ditto","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cce54997760951979d232e0cb254497d8548999","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            for speaker in speakers:"},{"line_number":211,"context_line":"                prefixes \u003d self.bgp_db._tenant_prefixes_by_router("},{"line_number":212,"context_line":"                                                      ctx,"},{"line_number":213,"context_line":"                                                      kwargs[\u0027router_id\u0027],"},{"line_number":214,"context_line":"                                                      speaker.id)"},{"line_number":215,"context_line":"                next_hop \u003d next_hops.get(speaker.ip_version)"},{"line_number":216,"context_line":"                if next_hop:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_c129e79c","line":213,"updated":"2016-12-12 14:17:59.000000000","message":"ditto","commit_id":"39489d34adada79e4efcdd3bcef52b5cdfca2711"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"94dd5f2c2ec9cb5478c2fb29f08d5a930f3121da","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cfg.CONF.bgp_drscheduler_driver)"},{"line_number":43,"context_line":"        self._setup_rpc()"},{"line_number":44,"context_line":"        self._register_callbacks()"},{"line_number":45,"context_line":"        self.bgp_db \u003d bgp_db.BgpDbMixin()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @property"},{"line_number":48,"context_line":"    def service_type(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_21c72a65","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":41},"updated":"2017-01-05 06:41:17.000000000","message":"why to make db stuff a part of rpc driver?","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"60ba81ad637982b9732ab4643bfd37b402d3f47e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cfg.CONF.bgp_drscheduler_driver)"},{"line_number":43,"context_line":"        self._setup_rpc()"},{"line_number":44,"context_line":"        self._register_callbacks()"},{"line_number":45,"context_line":"        self.bgp_db \u003d bgp_db.BgpDbMixin()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @property"},{"line_number":48,"context_line":"    def service_type(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_3853b13a","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":41},"in_reply_to":"ba5201f7_21c72a65","updated":"2017-01-06 05:22:10.000000000","message":"The RPC driver needs to call the db ops. Refer to line 85.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6adfeea77b9c689768ac51873e3c35624ad18192","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cfg.CONF.bgp_drscheduler_driver)"},{"line_number":43,"context_line":"        self._setup_rpc()"},{"line_number":44,"context_line":"        self._register_callbacks()"},{"line_number":45,"context_line":"        self.bgp_db \u003d bgp_db.BgpDbMixin()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @property"},{"line_number":48,"context_line":"    def service_type(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_db99bfc5","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":41},"in_reply_to":"ba5201f7_3853b13a","updated":"2017-01-06 05:32:50.000000000","message":"yes. but other drivers also likely do.\n\ni guess it\u0027s more common to update db in the plugin core and\nmake drivers use it when necessary.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7dd82046250ca20871348072724c62544ba63f89","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cfg.CONF.bgp_drscheduler_driver)"},{"line_number":43,"context_line":"        self._setup_rpc()"},{"line_number":44,"context_line":"        self._register_callbacks()"},{"line_number":45,"context_line":"        self.bgp_db \u003d bgp_db.BgpDbMixin()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @property"},{"line_number":48,"context_line":"    def service_type(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_f76036a7","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":41},"in_reply_to":"ba5201f7_db99bfc5","updated":"2017-01-06 23:31:40.000000000","message":"Agreed. I think it makes sense to have the plugin core update the model, then delegate to the proper backend to render the model. I don\u0027t think we should be updating the model here.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"62ac9fad30f28f263a8d8ce44b4b960b39b1d9eb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            cfg.CONF.bgp_drscheduler_driver)"},{"line_number":43,"context_line":"        self._setup_rpc()"},{"line_number":44,"context_line":"        self._register_callbacks()"},{"line_number":45,"context_line":"        self.bgp_db \u003d bgp_db.BgpDbMixin()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @property"},{"line_number":48,"context_line":"    def service_type(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_561f24b7","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":41},"in_reply_to":"ba5201f7_f76036a7","updated":"2017-01-09 10:17:23.000000000","message":"Ok, thanks. I will try to update the comment in the next patch.","commit_id":"ccdedf05287d84893c3f3b96958a88368293ae04"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6039058416fff2b56e31e3fd420e6de214c0e9b5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_71a5abb3","line":15,"updated":"2017-01-16 12:08:18.000000000","message":"nit - this should be in the section below (also 3rd party)","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"876a27b864af40bb688d8f342eb16ec69cb2cf48","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_f2d09221","line":15,"in_reply_to":"7a3c09a3_2c19e122","updated":"2017-01-17 04:58:33.000000000","message":"we usually group imports that way.","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"f03cddb426d1d8b2ace2975b21344b6e558fb601","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a3c09a3_2c19e122","line":15,"in_reply_to":"7a3c09a3_71a5abb3","updated":"2017-01-17 03:35:30.000000000","message":"Sorry, I do not understand","commit_id":"aca1170ce5273a3eba1922b69e06dc12609edc14"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f67ce5fd9e3f49cfe9f33727a41a6d6b1ae86d60","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron_dynamic_routing.db import bgp_dragentscheduler_db"},{"line_number":27,"context_line":"from neutron_dynamic_routing.services.bgp.common import constants as bgp_consts"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_config import cfg"},{"line_number":30,"context_line":"from oslo_log import log as logging"},{"line_number":31,"context_line":"from oslo_utils import importutils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a3c09a3_2bbfc0aa","line":29,"updated":"2017-01-18 08:02:59.000000000","message":"this should be in the setcion above with neutron_lib","commit_id":"4ea8d9546fa80081d51aea335395cc914016ab07"}]}
