)]}'
{"devstack/lib/dr":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a10eea5a510e7f9ab1f7defb0bd1c286270ee60d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"# Create public IPv4 subnet"},{"line_number":309,"context_line":"function _ndr_create_public_subnet_v4 {"},{"line_number":310,"context_line":"    local subnet_params\u003d\"--ip-version 4 \""},{"line_number":311,"context_line":"    # subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":312,"context_line":"    # if [[ -n \"$PUBLIC_NETWORK_GATEWAY\" ]]; then"},{"line_number":313,"context_line":"    #     subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""},{"line_number":314,"context_line":"    # fi"},{"line_number":315,"context_line":"    subnet_params+\u003d\"--network $EXT_NET_ID --no-dhcp \""},{"line_number":316,"context_line":"    subnet_params+\u003d\"$PUBLIC_SUBNET_NAME\""},{"line_number":317,"context_line":"    local public_subnetpool_v4_id"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_c0ec8a93","line":314,"range":{"start_line":311,"start_character":0,"end_line":314,"end_character":8},"updated":"2020-01-28 11:13:27.000000000","message":"do we need those commented lines?","commit_id":"3fa503b5a5e685545ab008f64a90bb4f311cc39b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"00ec93711ad14eba44e8841297a71963de02e8e6","unresolved":false,"context_lines":[{"line_number":308,"context_line":"# Create public IPv4 subnet"},{"line_number":309,"context_line":"function _ndr_create_public_subnet_v4 {"},{"line_number":310,"context_line":"    local subnet_params\u003d\"--ip-version 4 \""},{"line_number":311,"context_line":"    # subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":312,"context_line":"    # if [[ -n \"$PUBLIC_NETWORK_GATEWAY\" ]]; then"},{"line_number":313,"context_line":"    #     subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""},{"line_number":314,"context_line":"    # fi"},{"line_number":315,"context_line":"    subnet_params+\u003d\"--network $EXT_NET_ID --no-dhcp \""},{"line_number":316,"context_line":"    subnet_params+\u003d\"$PUBLIC_SUBNET_NAME\""},{"line_number":317,"context_line":"    local public_subnetpool_v4_id"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_fc6fd88f","line":314,"range":{"start_line":311,"start_character":0,"end_line":314,"end_character":8},"in_reply_to":"3fa7e38b_c0ec8a93","updated":"2020-01-29 15:31:32.000000000","message":"Hmm, not sure why I commented these out, will have to do some local testing.","commit_id":"3fa503b5a5e685545ab008f64a90bb4f311cc39b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7e3e779c97c888a9dece9d7d0e152a42914e6e96","unresolved":false,"context_lines":[{"line_number":308,"context_line":"# Create public IPv4 subnet"},{"line_number":309,"context_line":"function _ndr_create_public_subnet_v4 {"},{"line_number":310,"context_line":"    local subnet_params\u003d\"--ip-version 4 \""},{"line_number":311,"context_line":"    # subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":312,"context_line":"    # if [[ -n \"$PUBLIC_NETWORK_GATEWAY\" ]]; then"},{"line_number":313,"context_line":"    #     subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""},{"line_number":314,"context_line":"    # fi"},{"line_number":315,"context_line":"    subnet_params+\u003d\"--network $EXT_NET_ID --no-dhcp \""},{"line_number":316,"context_line":"    subnet_params+\u003d\"$PUBLIC_SUBNET_NAME\""},{"line_number":317,"context_line":"    local public_subnetpool_v4_id"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bf51134e_58ef8b86","line":314,"range":{"start_line":311,"start_character":0,"end_line":314,"end_character":8},"in_reply_to":"3fa7e38b_fc6fd88f","updated":"2020-07-06 14:45:48.000000000","message":"Actually this was a TODO item. While we cannot specify the allocation pool and gateway when creating a subnet from a subnet pool, we can modify them once the subnet exists. New PS upcoming.","commit_id":"3fa503b5a5e685545ab008f64a90bb4f311cc39b"}],"neutron_dynamic_routing/tests/tempest/api/test_bgp_speaker_extensions.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"127a4259e138587327cb53cc1ac4308b8e08762d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self.bgp_adm_client.add_bgp_gateway_network(bgp_speaker_id,"},{"line_number":244,"context_line":"                                                  self.ext_net_id)"},{"line_number":245,"context_line":"        routes \u003d self.bgp_adm_client.get_bgp_advertised_routes(bgp_speaker_id)"},{"line_number":246,"context_line":"        self.assertEqual(1, len(routes[\u0027advertised_routes\u0027]))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u0027cae9cdb1-ad65-423c-9604-d4cd0073616e\u0027)"},{"line_number":249,"context_line":"    def test_get_advertised_routes_floating_ips(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_218c302c","line":246,"updated":"2018-11-14 17:01:18.000000000","message":"We could probably get more explicit in checking for the exact prefixes being advertised. That way we can allow some boilerplate BGP resources to be spun up in the devstack plugin without affecting the tests. Getting explicit about checking the exact prefixes is acutally an enhancement not a nuisance, so I\u0027m supportive of refactoring these tests in that way.","commit_id":"491a698e7e4f6649e9f8f0cdfa389da4adf42a03"}]}