)]}'
{"neutron_dynamic_routing/services/bgp/bgp_plugin.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"4b24fbc5dd1572ba28ea39ee4b220b92c15b36ba","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        last_router_id \u003d kwargs.get(\u0027last_known_router_id\u0027)"},{"line_number":234,"context_line":"        floating_ip_address \u003d kwargs[\u0027floating_ip_address\u0027]"},{"line_number":235,"context_line":"        dest \u003d \u0027%s/32\u0027 % floating_ip_address"},{"line_number":236,"context_line":"        bgp_speakers \u003d self._bgp_speakers_for_gw_network_by_family("},{"line_number":237,"context_line":"            ctx,"},{"line_number":238,"context_line":"            kwargs[\u0027floating_network_id\u0027],"},{"line_number":239,"context_line":"            n_const.IP_VERSION_4)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fddfc0a2_31071f79","line":236,"updated":"2021-04-15 13:14:06.000000000","message":"nit: \"dest \u003d str(floating_ip_address) + \u0027/32\u0027\" would be a bit clearer for a future maintainer","commit_id":"baa331c765b2ed7b1e6e71a05738c2c6e2accc88"}],"neutron_dynamic_routing/tests/unit/services/bgp/test_bgp_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"630039f9b8fee2e2555da64474d49577589de98e","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from netaddr import IPAddress"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":"from neutron_lib.callbacks import events"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fb7b981_6ef65863","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"updated":"2021-04-15 15:55:52.000000000","message":"1) please, import the module, not the class\n2) group this import in the upper section, standard libraries\nhttps://www.python.org/dev/peps/pep-0008/#imports","commit_id":"501e433286b85a100c851f49d55fd6a65c345257"},{"author":{"_account_id":31503,"name":"Angelos Kolaitis","email":"angelos.kolaitis@canonical.com","username":"neoaggelos"},"change_message_id":"da18aadfd40abfa0837125ce9f9ea5627d4dbe5b","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from netaddr import IPAddress"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":"from neutron_lib.callbacks import events"}],"source_content_type":"text/x-python","patch_set":3,"id":"706b3f59_171e7453","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"in_reply_to":"1fb7b981_6ef65863","updated":"2021-04-15 18:08:16.000000000","message":"Grouping the netaddr and mock imports yields an error message that they are not ordered (see https://zuul.opendev.org/t/openstack/build/9a535ae94f084d48b94b8e2d38f3aad9)\n\nMoved it along with the neutron imports, as is the case in https://opendev.org/openstack/neutron-dynamic-routing/src/branch/master/neutron_dynamic_routing/tests/unit/db/test_bgp_db.py#L18","commit_id":"501e433286b85a100c851f49d55fd6a65c345257"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"630039f9b8fee2e2555da64474d49577589de98e","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        kwargs \u003d {\u0027floating_ip_address\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":96,"context_line":"            \u0027router_id\u0027: \u0027\u0027, \u0027floating_network_id\u0027: \u0027\u0027}"},{"line_number":97,"context_line":"        self.plugin.floatingip_update_callback("},{"line_number":98,"context_line":"            None, events.AFTER_UPDATE, None, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"052f0d6e_3cf89542","line":98,"updated":"2021-04-15 15:55:52.000000000","message":"nit: this test is implicitly checking that the method do not raise an exception. Testing should be explicit. For example, reading from \"stop_route_advertisements\" or \"start_route_advertisements\" calls that the host_route[\u0027destination\u0027] contains the IP correctly formatted.","commit_id":"501e433286b85a100c851f49d55fd6a65c345257"},{"author":{"_account_id":31503,"name":"Angelos Kolaitis","email":"angelos.kolaitis@canonical.com","username":"neoaggelos"},"change_message_id":"da18aadfd40abfa0837125ce9f9ea5627d4dbe5b","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        kwargs \u003d {\u0027floating_ip_address\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":96,"context_line":"            \u0027router_id\u0027: \u0027\u0027, \u0027floating_network_id\u0027: \u0027\u0027}"},{"line_number":97,"context_line":"        self.plugin.floatingip_update_callback("},{"line_number":98,"context_line":"            None, events.AFTER_UPDATE, None, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1006bd77_77962fa3","line":98,"in_reply_to":"052f0d6e_3cf89542","updated":"2021-04-15 18:08:16.000000000","message":"Added a test that reads from stop_route_advertisements.","commit_id":"501e433286b85a100c851f49d55fd6a65c345257"}]}