)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ad47ab59de268e9a2041bcfd6da6612b705cda40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c312dbe_36c950e8","updated":"2022-05-19 12:39:46.000000000","message":"Are you running this patch in production already? It looks fine to me in general but it is difficult for me to judge its effect without tests in place that could actually show the difference in performance.","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1dfc56a1fa9594ad4c3e63dbe6abe2f718e2ff50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"92550056_75e5761e","updated":"2022-05-23 09:59:31.000000000","message":"Let\u0027s wait till frickler votes 😊","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"73e47a5f2081f8b826f629a1e789ff4958293c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9bcd7091_1556dac9","updated":"2022-05-23 09:58:38.000000000","message":"Looks ok and in sync with L3RouterPlugin for example","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c25a4459ddf03c86f8f5d379562e3a7a8c25e62b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7067167_34b3fd4c","updated":"2022-07-08 13:24:31.000000000","message":"Makes sense and looks OK","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"137f04891ccc79b2b151411262814c3f5ff104bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"feae55d7_db8635ff","updated":"2022-07-01 12:34:11.000000000","message":"Tested locally and works fine. I\u0027d still like a review from someone familiar with the RPC code.","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1cc1ffce7560d99ce45eef1bb0462c5145230913","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1cb6662_fb15d999","in_reply_to":"6a81226f_3cda6e03","updated":"2022-05-23 10:00:34.000000000","message":"Is it possible for you to add load also? Would be good to have feedback of it, as in CI in openstack we have no option for such tests","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":33249,"name":"Renat Nurgaliyev","email":"renat@rnu.one","username":"rnurgaliyev"},"change_message_id":"d597594ba95ceebc5067e30ed1dee6863fae9e78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a81226f_3cda6e03","in_reply_to":"9c312dbe_36c950e8","updated":"2022-05-19 13:31:55.000000000","message":"We used to have regular AMQP connection drops due to unprocessed heartbeats in both production and even completely empty testing environments, which turned out to be related to the problem this patch solves. So far we have confirmed that connection drops are gone completely in the lab environment, and dynamic routing functionality is not affected. We didn\u0027t test this patch under heavy load in production yet.","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"},{"author":{"_account_id":33249,"name":"Renat Nurgaliyev","email":"renat@rnu.one","username":"rnurgaliyev"},"change_message_id":"1d9aa10677009a4b38d1a0f15d80698e24829a6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9939a309_ecf3b5f5","in_reply_to":"a1cb6662_fb15d999","updated":"2022-06-03 13:31:16.000000000","message":"We need no load at all to spot the issue - 3 neutron controllers, 2 nodes with DrAgent, one BGP peering configured on each, and everything is 100% idle. RabbitMQ connection drops will already appear in logs. If the load that you wanted to see is the load that we run with the patch applied, it is not so high too - again 3 neutron controllers, 2 nodes with DrAgents, 2 BGP peers, ~200 prefixes advertised, stable network with not so much changes per minute.","commit_id":"b9c085b85f3f2912d77050a33667f88b8edd6ca0"}]}