)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19deec3f809885ebc055a0617c0e1d3ed1caafa7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"By removing these routes we allow these upstream routers do directly"},{"line_number":14,"context_line":"drop the traffic to these addresses instead of trying to forward it to"},{"line_number":15,"context_line":"neutron routers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icd6803769f37a04bf7581afb9722c78a44737374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"75043334_2da9f9ce","line":16,"updated":"2023-05-08 12:56:51.000000000","message":"Hi Felix, do you have a LP bug describing the rationale of this patch? Thanks!","commit_id":"8e55adfb6a701d845c501f07153ff708af27d8d6"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"c577f8acb651d5894607a6b98fbfd8fb23b965ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"By removing these routes we allow these upstream routers do directly"},{"line_number":14,"context_line":"drop the traffic to these addresses instead of trying to forward it to"},{"line_number":15,"context_line":"neutron routers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icd6803769f37a04bf7581afb9722c78a44737374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74a3a573_aa230491","line":16,"in_reply_to":"75043334_2da9f9ce","updated":"2023-05-09 12:26:20.000000000","message":"https://launchpad.net/bugs/2018737","commit_id":"8e55adfb6a701d845c501f07153ff708af27d8d6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"8e315597bd6061fa58a55cbb814ea0c9c843529d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56b74f34_bf028c20","updated":"2023-05-08 13:55:57.000000000","message":"Thanks for the hint. Created one here: https://bugs.launchpad.net/neutron/+bug/2018737","commit_id":"07d4993142d923073056b0bf4559f103be78c47d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"fce0c9aa8eb30360abfe25779768862addb92d2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de9bcad1_fd324546","updated":"2023-05-10 18:35:17.000000000","message":"This makes sense, interesting that it hasn\u0027t been caught earlier but I guess most people don\u0027t set admin down on their routers :) I think it would make sense to add a test with two routers to make sure the codepath doesn\u0027t filter out everything.\n\neither way this LGTM otherwise","commit_id":"07d4993142d923073056b0bf4559f103be78c47d"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"c577f8acb651d5894607a6b98fbfd8fb23b965ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9a9f845_24b6fdca","updated":"2023-05-09 12:26:20.000000000","message":"linting now fixes. Unittests are failing because of 670cc383e0345063c0bf9022f8829d5817457e00 in neutron. Probably needs a fix somewhere else","commit_id":"07d4993142d923073056b0bf4559f103be78c47d"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"bb28879595703ca4d22f4d964c724fbfc7ae4065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48d1c370_e892a8fa","in_reply_to":"de9bcad1_fd324546","updated":"2023-05-17 12:44:13.000000000","message":"thank you, i added an additional test for this case.","commit_id":"07d4993142d923073056b0bf4559f103be78c47d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"44b40e5c67800c30b1d67e31a8674e18ca026901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a8459f09_2177a168","updated":"2023-11-14 08:36:42.000000000","message":"I\u0027m mostly fine with this, but I think that it need a release note since it changes the existing handling of admin-down routers.\n\nAlso some minor style comments inline.","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e14cf4f738cfbc04409b196401134ce9fde6c57f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2613e5f7_da70488e","updated":"2023-05-24 15:13:56.000000000","message":"LGTM","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"cef15148c447f10400c89384768351051c6f6f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ea144788_25418df7","updated":"2023-10-05 17:23:06.000000000","message":"LGTM","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1c781a89d639b5ff1eb865cf1838e00fb541227f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"261562c4_9638789c","updated":"2024-08-22 09:12:48.000000000","message":"lets see if i messed up the rebase or not","commit_id":"6d48164ea44cfab0b6970548d15ef6c43f27f195"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3486fbddd0165ffc36680e86571ec8c51e7b833c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19242d9b_4124bc3f","updated":"2024-08-22 13:20:48.000000000","message":"Thanks","commit_id":"06232f0b2c555578bb983c5cefcd8a573761f87a"}],"neutron_dynamic_routing/services/bgp/bgp_plugin.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"44b40e5c67800c30b1d67e31a8674e18ca026901","unresolved":true,"context_lines":[{"line_number":370,"context_line":"        if external_gateway_info is None:"},{"line_number":371,"context_line":"            return"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        gw_network \u003d external_gateway_info[\"network_id\"]"},{"line_number":374,"context_line":"        gateway_ips \u003d ["},{"line_number":375,"context_line":"            x[\"ip_address\"] for x in"},{"line_number":376,"context_line":"            external_gateway_info[\"external_fixed_ips\"]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"caf98f95_d84b900c","line":373,"updated":"2023-11-14 08:36:42.000000000","message":"this is only needed within the if, so you can move it next to the router_id definition for consistency","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"838be8dec34a4ee12fee4692573d580ddbfce0c2","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        if external_gateway_info is None:"},{"line_number":371,"context_line":"            return"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        gw_network \u003d external_gateway_info[\"network_id\"]"},{"line_number":374,"context_line":"        gateway_ips \u003d ["},{"line_number":375,"context_line":"            x[\"ip_address\"] for x in"},{"line_number":376,"context_line":"            external_gateway_info[\"external_fixed_ips\"]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"39ab5431_c2958b24","line":373,"in_reply_to":"caf98f95_d84b900c","updated":"2024-08-22 09:09:36.000000000","message":"Done","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"44b40e5c67800c30b1d67e31a8674e18ca026901","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        gw_network \u003d external_gateway_info[\"network_id\"]"},{"line_number":374,"context_line":"        gateway_ips \u003d ["},{"line_number":375,"context_line":"            x[\"ip_address\"] for x in"},{"line_number":376,"context_line":"            external_gateway_info[\"external_fixed_ips\"]]"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if \"admin_state_up\" in original_router and \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"43731bac_d6d0f9dd","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":13},"updated":"2023-11-14 08:36:42.000000000","message":"x is a rather ugly variable name, maybe use something like \"ext_ip\" or \"external_fixed_ip\"?","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"838be8dec34a4ee12fee4692573d580ddbfce0c2","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        gw_network \u003d external_gateway_info[\"network_id\"]"},{"line_number":374,"context_line":"        gateway_ips \u003d ["},{"line_number":375,"context_line":"            x[\"ip_address\"] for x in"},{"line_number":376,"context_line":"            external_gateway_info[\"external_fixed_ips\"]]"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if \"admin_state_up\" in original_router and \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"851ff16d_11879692","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":13},"in_reply_to":"14900bcc_a077d25d","updated":"2024-08-22 09:09:36.000000000","message":"Done","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7904121a75737b0892b7b6d3f7ad282e7dfe17f5","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        gw_network \u003d external_gateway_info[\"network_id\"]"},{"line_number":374,"context_line":"        gateway_ips \u003d ["},{"line_number":375,"context_line":"            x[\"ip_address\"] for x in"},{"line_number":376,"context_line":"            external_gateway_info[\"external_fixed_ips\"]]"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if \"admin_state_up\" in original_router and \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"14900bcc_a077d25d","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":13},"in_reply_to":"43731bac_d6d0f9dd","updated":"2024-01-10 12:59:03.000000000","message":"+1, though this is only inside a comprehension","commit_id":"d3d1a4ef473d979a82a5c0dfb9286e00d3ae9cb1"}]}