)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"de5cc05dd264d7839f1bde69e1a161dbdcb75da2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-07-18 17:51:55 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mixed IP version for advertised routes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In advertise_route_via_bgp_speaker() a check for the matching ip_version was missing, leading to neutron-dynamic-routing trying to announce prefixes with mixed IP versions in the CIDR route and next-hop."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This type of advertisement makes no sense because the IP version of the route must always be the same as the next-hop."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2023632"},{"line_number":14,"context_line":"Change-Id: I175692406262d748763ce67b186b19018368b97f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"68e7b2ef_48b018a2","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":118},"updated":"2024-01-10 12:50:39.000000000","message":"nit: could you please break these lines to less than 72 chars?\nSee : https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"eed237f8b0a8971bc78e333c3a0adc4da0700b68"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"d77496ae269045f1bd35b80586daf4a73aa0d916","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-07-18 17:51:55 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mixed IP version for advertised routes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In advertise_route_via_bgp_speaker() a check for the matching ip_version was missing, leading to neutron-dynamic-routing trying to announce prefixes with mixed IP versions in the CIDR route and next-hop."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This type of advertisement makes no sense because the IP version of the route must always be the same as the next-hop."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2023632"},{"line_number":14,"context_line":"Change-Id: I175692406262d748763ce67b186b19018368b97f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fe2dddd0_6631e920","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":118},"in_reply_to":"68e7b2ef_48b018a2","updated":"2024-01-11 11:38:29.000000000","message":"Thanks for the review Lajos. \nSorry, my bad... I hadn\u0027t seen that the commit message was without formatting. Thank you!","commit_id":"eed237f8b0a8971bc78e333c3a0adc4da0700b68"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"de5cc05dd264d7839f1bde69e1a161dbdcb75da2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"02798b30_54f1914f","updated":"2024-01-10 12:50:39.000000000","message":"Thanks for the patch, my only concern/nit is for the commit msg.","commit_id":"eed237f8b0a8971bc78e333c3a0adc4da0700b68"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"2b1559633013c4805097356d752680c70e1b8778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9026d19_8412cb9e","updated":"2023-07-19 11:44:02.000000000","message":"recheck","commit_id":"eed237f8b0a8971bc78e333c3a0adc4da0700b68"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9716913d8c956621936a985646a8265dec88776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11c8be98_90aed0e9","updated":"2023-07-19 11:58:48.000000000","message":"recheck devstack fixed","commit_id":"eed237f8b0a8971bc78e333c3a0adc4da0700b68"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d5d58ef099dba8d61c1190c24b418c0fadcb9c62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a578c07_c45c976c","updated":"2024-01-23 07:56:29.000000000","message":"\u003eThis type of advertisement makes no sense because the IP version of\nthe route must always be the same as the next-hop.\n\nThis is not really true though? We explicitly enabled MP-BGP capabilities in [1] to make this possible and this would be up to the operator configuring the peers, do you mean that you want a config option for this to filter it out and not remove the possibility completely?\n\n[1] https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/608302","commit_id":"54257b431810e6f7ddc425b78607dbd72ebc0f05"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"202d5e3b14291ef9f9a87b696bccd8df2c6b01ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21859753_cbc9f79d","in_reply_to":"01a687c8_7e0f9388","updated":"2024-02-20 21:43:38.000000000","message":"That makes it possible to announce IPv6 prefixes over IPv4 peers, but looking I think this patch doesn\u0027t touch that but only nexthop so kind of irrelevant message from me above.\n\nIt still a valid point in my first message, but if you say that os_ken doesn\u0027t support announcing IPv4 routes with IPv6 nexthops (v4-via-v6) for example then this is probably fine.","commit_id":"54257b431810e6f7ddc425b78607dbd72ebc0f05"},{"author":{"_account_id":35432,"name":"Roberto Acosta","display_name":"rbartzen","email":"rbartzen@gmail.com","username":"rbartzen"},"change_message_id":"2c7945ed77b884c9198b8f50030e3db11198114b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a36b314c_497f54fb","in_reply_to":"1a578c07_c45c976c","updated":"2024-02-20 18:09:43.000000000","message":"From a BGP-world perspective, this may be possible as long as it\u0027s used with Multiprotocol BGP (MP-BGP). However, the n-d-r BGP driver (os_ken), doesn\u0027t support it. \n\nAlso, Neutron requires address scopes to be configured per address family, just like BGP speakers, and other BGP configurations. It seems strange to have everything separated by address family but want the speaker to mix in the advertisement.... I mean, os_ken validates the address family of the address scope with the provided nexthop and rejects the route at the BGP driver layer.\n\nFor my use case and I believe it is normal use case for those who operate with a dual stack cloud, I have a speaker for the IPv6 address family and a speaker for the IPv4 address family, each with its nexthop using the same address family of address scope.\n\nThe use case with MP-BGP could be configured via n-d-r config option but since os_key became the n-d-r BGP driver, this functionality never worked. So it doesn\u0027t make sense from my point of view to leave it configurable in the upstream code that uses os_ken.","commit_id":"54257b431810e6f7ddc425b78607dbd72ebc0f05"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5308f1fc84202534715f53502937ee2cf73aa9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01a687c8_7e0f9388","in_reply_to":"a36b314c_497f54fb","updated":"2024-02-20 21:36:18.000000000","message":"I\u0027m specifically thinking about this bug/fix that we did some years ago [1], am I missing something?\n\n[1] https://bugs.launchpad.net/neutron/+bug/1784590","commit_id":"54257b431810e6f7ddc425b78607dbd72ebc0f05"}]}