)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"57122b726bc432ceb6bc0c2ec7084c110e93e829","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/919787"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d62c0175_3b92ccee","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":45},"updated":"2024-05-29 10:54:11.000000000","message":"have to change to https://review.opendev.org/c/openstack/neutron-lib/+/917263","commit_id":"ebc936f73d8c199ecb121e1dc7ff3dceeb209dfa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10eb549ee33dd6d4d259afe752ab94f14c38d394","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c26623a8_48c58383","line":13,"updated":"2024-05-30 18:43:46.000000000","message":"If this depends on a neutron-lib change, don\u0027t we need to wait for it to be available and move requirements forward? Or I guess this works today since it passes the gate jobs.","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"efe5caa1ed32ddf8d7881bb8f2998685697ec5d3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ac9230d8_e6625e80","line":13,"in_reply_to":"3e2103f0_b2748a73","updated":"2024-06-06 01:03:23.000000000","message":"The code changed doesn\u0027t even use neutron-lib. I don\u0027t understand how it can be affected by presence - or absence - of any patch in neutron-lib. The change this patch is dealing with is in netaddr library, and for what I see and understand, it will work fine with both \u003c1 and 1+ versions of the library.\n\n1. with \u003c1, is_valid() functions won\u0027t raise TypeErrors, so the control flow will fall to our own `raise TypeError`. It will raise, get caught, and will finally raise our own exception.\n2. with 1+, is_valid() functions will raise TypeErrors. Again, these will be caught and we\u0027ll raise our own exception.\n\nI don\u0027t see where this patch, merged, would fail.","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bebe34b4d032dbfa84d3be4929b2b92f9e22e5ba","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3e2103f0_b2748a73","line":13,"in_reply_to":"6643ea92_0a487734","updated":"2024-06-04 16:24:27.000000000","message":"locally yes, but I suppose till the netaddr bump is not merged in req repo we are safe in the gate.","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"964ca5bbae12aa2058f702f015be335693d2badb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e6310eb2_972513bb","line":13,"in_reply_to":"c26623a8_48c58383","updated":"2024-05-30 19:20:11.000000000","message":"Honestly I don\u0027t think this is relevant / needed at all? @lajoskatona what\u0027s the relationship between these two patches?","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c136a15024fc2dfd09584e98e41e637b04ad23e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6643ea92_0a487734","line":13,"in_reply_to":"d30a6c81_0f457a9c","updated":"2024-06-04 14:14:58.000000000","message":"Does it? The Depends-On on neutron-lib patch doesn\u0027t pull it into the env for the test run. Only when it\u0027s released in a new version and upper-constraints are updated, only then the n-lib patch will be present. And I see Zuul passing here just fine.","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1777e9be87112ed9f47ada87e64e5635aa1833cb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"invalid format, catch that and raise"},{"line_number":11,"context_line":"bgp_driver_exc.InvalidParamType."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/917263"},{"line_number":14,"context_line":"Change-Id: I46940432333d2cb422ead2f0874a8fbf95d93abe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d30a6c81_0f457a9c","line":13,"in_reply_to":"e6310eb2_972513bb","updated":"2024-06-04 11:33:42.000000000","message":"without the n-lib patch + netaddr\u003e1.0.0 neutron_dynamic_routing.tests.unit.db.test_bgp_db.Ml2BgpTests.test_ha_router_fips_has_no_next_hop_to_fip_agent_gateway is the test that fails","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e894c00570ca8eeae0baff43fee18aa64caeeb99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a818f3b_124e0b61","updated":"2024-05-21 15:03:08.000000000","message":"That\u0027s progress.","commit_id":"ebc936f73d8c199ecb121e1dc7ff3dceeb209dfa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8c200ea1cfe758771dd39f5cea2d615a76dae102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"49ee57a3_42443a2a","updated":"2024-06-06 01:04:26.000000000","message":"For what I wonder, I am ok merging with or without Depends-On. I think it\u0027s redundant, but I always considered it more of a gate automation piece and less of for documentation purposes. But if it will help to land this, I am all for removing the tag from the commit message.","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"77fcad1574f85c579e3a9e8b192b227f8da0efa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5b120b2_19e10f40","updated":"2024-05-30 16:30:57.000000000","message":"That will do","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3bedfcd60401152cd5b535f9a0823becd687e41d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ecc7b36d_07fc61f1","in_reply_to":"49ee57a3_42443a2a","updated":"2024-06-10 07:38:31.000000000","message":"As I see with neutron-lib 3.13.0 it is released, so the depends-on can be removed","commit_id":"d03996efa1dde9ee9c08eca0d1fd5dfd360f951a"}],"neutron_dynamic_routing/services/bgp/agent/driver/utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"707998a4126cf013ab03989737162491ac2de3db","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"                                                  param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"    except TypeError:"},{"line_number":63,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"91c55dc1_793f9fe3","line":60,"updated":"2024-05-17 20:18:30.000000000","message":"you can raise TypeError here and this will allow you to not repeat the exception creation code.","commit_id":"a96761656e51a0ea918b0708e65c95d190fec9ad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5ee638b7874f7cb754d93f7565a2d73474e46e04","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"                                                  param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"    except TypeError:"},{"line_number":63,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e41a247_b90047d2","line":60,"in_reply_to":"91c55dc1_793f9fe3","updated":"2024-05-21 14:13:01.000000000","message":"Done","commit_id":"a96761656e51a0ea918b0708e65c95d190fec9ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"707998a4126cf013ab03989737162491ac2de3db","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"                                                  param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"    except TypeError:"},{"line_number":63,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":64,"context_line":"                                              param_type\u003d\u0027ip-address\u0027)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"090e013d_013dc63e","line":62,"updated":"2024-05-17 20:18:30.000000000","message":"I suspect TypeError (or another exception type) is not part of promised netaddr behavior. Should we just catch any exceptions from the library?","commit_id":"a96761656e51a0ea918b0708e65c95d190fec9ad"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5ee638b7874f7cb754d93f7565a2d73474e46e04","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"                                                  param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"    except TypeError:"},{"line_number":63,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":64,"context_line":"                                              param_type\u003d\u0027ip-address\u0027)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8336b5b4_93eacbb6","line":62,"in_reply_to":"090e013d_013dc63e","updated":"2024-05-21 14:13:01.000000000","message":"good idea.\nI checked again and it seems that TypeError is now the expected behaviour:\nhttps://github.com/netaddr/netaddr/blob/master/netaddr/strategy/ipv4.py#L98\n\nhttps://github.com/netaddr/netaddr/pull/371","commit_id":"a96761656e51a0ea918b0708e65c95d190fec9ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38b74b1fe2a1a5fd41afcc4666a93ffee849a9e6","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"                                                  param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"    except TypeError:"},{"line_number":63,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":64,"context_line":"                                              param_type\u003d\u0027ip-address\u0027)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ad1a8d7_9d076e86","line":62,"in_reply_to":"8336b5b4_93eacbb6","updated":"2024-05-21 14:16:31.000000000","message":"Yeah. Question is - are they sticking to this as official API, or is it just something they may change willy nilly further? Depending on the answer, we should either catch this type explicitly only, or we may want to have a catch-all handler for any exceptions coming from the library. I don\u0027t know which is the case.","commit_id":"a96761656e51a0ea918b0708e65c95d190fec9ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"244c3a5cb789ca5c74e368d21cdc6115fa682218","unresolved":true,"context_lines":[{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            # raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"            #                                       param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"            raise TypeError"},{"line_number":63,"context_line":"    except TypeError:"},{"line_number":64,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"148e9f82_1aede86b","line":61,"updated":"2024-05-21 14:04:51.000000000","message":"?","commit_id":"1903ea67990e6aa8212cd8f9eba1d84cf209d47b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4933dc81637dbfcf611ae80658decb8b519894c3","unresolved":true,"context_lines":[{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            # raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":61,"context_line":"            #                                       param_type\u003d\u0027ip-address\u0027)"},{"line_number":62,"context_line":"            raise TypeError"},{"line_number":63,"context_line":"    except TypeError:"},{"line_number":64,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"11a202a4_2f87ea69","line":61,"in_reply_to":"148e9f82_1aede86b","updated":"2024-05-21 14:57:46.000000000","message":"🤦","commit_id":"1903ea67990e6aa8212cd8f9eba1d84cf209d47b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e894c00570ca8eeae0baff43fee18aa64caeeb99","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            return lib_consts.IP_VERSION_4"},{"line_number":57,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise TypeError"},{"line_number":61,"context_line":"    except TypeError:"},{"line_number":62,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1a83215_ace93ba2","line":59,"updated":"2024-05-21 15:03:08.000000000","message":"nit: actually could remove `else`.","commit_id":"ebc936f73d8c199ecb121e1dc7ff3dceeb209dfa"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d76e6af5f5f5160e8a6b79b03a61e0248e98abd0","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            return lib_consts.IP_VERSION_4"},{"line_number":57,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise TypeError"},{"line_number":61,"context_line":"    except TypeError:"},{"line_number":62,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5beaa80b_ea2ce425","line":59,"in_reply_to":"e87eb95c_c0c5b32a","updated":"2024-05-29 10:53:36.000000000","message":"the trick is that if else is not there tests start to fail with both current \u003e1 netaddr. \nI check it to see the reason","commit_id":"ebc936f73d8c199ecb121e1dc7ff3dceeb209dfa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9a390957bbda1c85e0f9b6148a01c46072dba2ed","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            return lib_consts.IP_VERSION_4"},{"line_number":57,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":58,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            raise TypeError"},{"line_number":61,"context_line":"    except TypeError:"},{"line_number":62,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e87eb95c_c0c5b32a","line":59,"in_reply_to":"f1a83215_ace93ba2","updated":"2024-05-29 02:36:48.000000000","message":"+1, in neutron tree the lint rules would have complained","commit_id":"ebc936f73d8c199ecb121e1dc7ff3dceeb209dfa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0ba09768a547a80d092d348a93bad90ce6418b2b","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            return lib_consts.IP_VERSION_4"},{"line_number":55,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":56,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":57,"context_line":"    except Exception:"},{"line_number":58,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":59,"context_line":"                                              param_type\u003d\u0027ip-address\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b44c870c_cf7c9201","line":57,"updated":"2024-05-29 15:06:30.000000000","message":"wait... shouldn\u0027t you raise if it\u0027s neither valid_ipv4 nor valid_ipv6?..\n\nI previously suggested to remove `else:`. But I didn\u0027t suggest to remove `raise TypeError` (that previously guaranteed that we\u0027d always get to line 58. - not anymore!)","commit_id":"5869404b9b747ea75eee1877ee5a8eac96091b45"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"316201032c13382030fdbfa4af9d7a7193a833ba","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            return lib_consts.IP_VERSION_4"},{"line_number":55,"context_line":"        elif netaddr.valid_ipv6(ip_addr):"},{"line_number":56,"context_line":"            return lib_consts.IP_VERSION_6"},{"line_number":57,"context_line":"    except Exception:"},{"line_number":58,"context_line":"        raise bgp_driver_exc.InvalidParamType(param\u003dip_addr,"},{"line_number":59,"context_line":"                                              param_type\u003d\u0027ip-address\u0027)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8508fd6b_6c1ea716","line":57,"in_reply_to":"b44c870c_cf7c9201","updated":"2024-05-30 16:22:51.000000000","message":"I really have to stop multitasking....\nRecently I have to learn go and seems like that also has bad consequesnces on my sense of exceptions....","commit_id":"5869404b9b747ea75eee1877ee5a8eac96091b45"}]}