)]}'
{"neutron_dynamic_routing/services/bgp/bgp_plugin.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a7ded706c2951616f08fa351318408e2f49a9ab2","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            gw_network \u003d payload.metadata.get(\u0027network_id\u0027)"},{"line_number":275,"context_line":"            next_hops \u003d self._next_hops_from_gateway_ips("},{"line_number":276,"context_line":"                payload.metadata.get(\u0027gateway_ips\u0027))"},{"line_number":277,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":278,"context_line":"            speakers \u003d self._bgp_speakers_for_gateway_network(ctx, gw_network)"},{"line_number":279,"context_line":"            for speaker in speakers:"},{"line_number":280,"context_line":"                routes \u003d self._route_list_from_prefixes_and_next_hop("}],"source_content_type":"text/x-python","patch_set":1,"id":"4f74be05_3f3b20e7","line":277,"updated":"2025-01-16 13:32:06.000000000","message":"shouldn\u0027t this also be wrapped?","commit_id":"ec4ff7a3de788f38a506da9517fcd6adb98e86af"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fa163717781c2fb30230b5ab4c0cb849c848db47","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            gw_network \u003d payload.metadata.get(\u0027network_id\u0027)"},{"line_number":275,"context_line":"            next_hops \u003d self._next_hops_from_gateway_ips("},{"line_number":276,"context_line":"                payload.metadata.get(\u0027gateway_ips\u0027))"},{"line_number":277,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":278,"context_line":"            speakers \u003d self._bgp_speakers_for_gateway_network(ctx, gw_network)"},{"line_number":279,"context_line":"            for speaker in speakers:"},{"line_number":280,"context_line":"                routes \u003d self._route_list_from_prefixes_and_next_hop("}],"source_content_type":"text/x-python","patch_set":1,"id":"45b23888_a5047dc2","line":277,"in_reply_to":"4f74be05_3f3b20e7","updated":"2025-01-16 13:53:25.000000000","message":"I just wrapper the places where session.begin was used. I don\u0027t know if this section should have this consideration.","commit_id":"ec4ff7a3de788f38a506da9517fcd6adb98e86af"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f38a647650370221741225bb28521115bee374f4","unresolved":true,"context_lines":[{"line_number":287,"context_line":"            return"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":290,"context_line":"        with db_api.CONTEXT_READER.using(ctx):"},{"line_number":291,"context_line":"            speakers \u003d self._bgp_speakers_for_gateway_network(ctx,"},{"line_number":292,"context_line":"                                                              gw_network)"},{"line_number":293,"context_line":"            next_hops \u003d self._next_hops_from_gateway_ips("}],"source_content_type":"text/x-python","patch_set":1,"id":"ac9a504d_c51e2363","line":290,"updated":"2025-01-17 11:47:35.000000000","message":"this is already done within _bgp_speakers_for_gateway_network() and _tenant_prefixes_by_router(), I\u0027m not sure having these calls nested is correct?","commit_id":"ec4ff7a3de788f38a506da9517fcd6adb98e86af"}]}
