)]}'
{"neutron_fwaas/services/firewall/drivers/cisco/csr_acl_driver.py":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"3b5753f2067b14415e63b9f37dad8c014067aaf4","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            return False"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        acl_id \u003d firewall[\u0027vendor_ext\u0027].get(\u0027acl_id\u0027)"},{"line_number":302,"context_line":"        if not acl_id:"},{"line_number":303,"context_line":"            LOG.error(_LE(\"firewal (%s) has no acl_id\"), firewall[\u0027id\u0027])"},{"line_number":304,"context_line":"            return False"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_8f406637","line":302,"updated":"2015-10-23 19:12:28.000000000","message":"firewal should be firewall","commit_id":"266163b77c864720ac073394e095809bbf188bc6"}],"neutron_fwaas/services/firewall/drivers/mcafee/ngfw_fwaas.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e1fc01b82b0eeeab49864910d4c9cf8585d9a3f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            service_dict \u003d {\"service\": [srv_ref]}"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        elif rule[\u0027protocol\u0027] is None:"},{"line_number":231,"context_line":"            # protocol \"ANY\" is translated to accept all, no service create"},{"line_number":232,"context_line":"            # here"},{"line_number":233,"context_line":"            # TODO(yalie): add rules for different protocol, not ignore the"},{"line_number":234,"context_line":"            # other value like ports."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_e697e337","line":231,"updated":"2015-10-23 02:00:38.000000000","message":"Can this be reframed?\nIMHO, I am not able to understand this line clearly.(The ´no service create here´ confuses me)","commit_id":"ce66a9de01f6b90e593669f0592a8afdcb829e2a"},{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"5397aea2021d644187728b4cc7c1b769e1a4505a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            service_dict \u003d {\"service\": [srv_ref]}"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        elif rule[\u0027protocol\u0027] is None:"},{"line_number":231,"context_line":"            # protocol \"ANY\" is translated to accept all, no service create"},{"line_number":232,"context_line":"            # here"},{"line_number":233,"context_line":"            # TODO(yalie): add rules for different protocol, not ignore the"},{"line_number":234,"context_line":"            # other value like ports."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_dc58768c","line":231,"in_reply_to":"3a29b11f_e697e337","updated":"2015-10-23 04:31:44.000000000","message":"Not really attempting to rework the comments here - especially for an external vendor - just fixing some glaringly obvious typos that make OpenStack code look less professional than is necessary.\n\nKindly reach out to McAfee folks if need clarification on semantic meaning.","commit_id":"ce66a9de01f6b90e593669f0592a8afdcb829e2a"}],"neutron_fwaas/services/firewall/drivers/mcafee/smc_api.py":[{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"bd68d013dd96d3a6c7543d669f94e062562f7769","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    For login/logout operation, users should set server IP, API version and"},{"line_number":62,"context_line":"    auth key first. For get/put/delete operation, users should provide the"},{"line_number":63,"context_line":"    target element path, and special json format data section followed \"SMC"},{"line_number":64,"context_line":"    API User\u0027s Guide\"."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    def __init__(self, host, api_version, authentication_key):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_666bd385","line":63,"updated":"2015-10-23 01:52:43.000000000","message":"I think it is better to rewrite here with \" elements\u0027 \".","commit_id":"ce66a9de01f6b90e593669f0592a8afdcb829e2a"},{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"5397aea2021d644187728b4cc7c1b769e1a4505a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    For login/logout operation, users should set server IP, API version and"},{"line_number":62,"context_line":"    auth key first. For get/put/delete operation, users should provide the"},{"line_number":63,"context_line":"    target element path, and special json format data section followed \"SMC"},{"line_number":64,"context_line":"    API User\u0027s Guide\"."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    def __init__(self, host, api_version, authentication_key):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_3ccdea30","line":63,"in_reply_to":"3a29b11f_666bd385","updated":"2015-10-23 04:31:44.000000000","message":"Changed to \"element\u0027s\" possessive form.","commit_id":"ce66a9de01f6b90e593669f0592a8afdcb829e2a"},{"author":{"_account_id":14033,"name":"James Reeves","email":"james.reeves5546@gmail.com","username":"trombongod"},"change_message_id":"e34c655e936022e1e5a27d7bbaa36307903cdd8f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    For login/logout operation, users should set server IP, API version and"},{"line_number":62,"context_line":"    auth key first. For get/put/delete operation, users should provide the"},{"line_number":63,"context_line":"    target element\u0027s path, and special json format data section followed \"SMC"},{"line_number":64,"context_line":"    API User\u0027s Guide\"."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    def __init__(self, host, api_version, authentication_key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_6f194a79","line":63,"updated":"2015-10-23 19:01:57.000000000","message":"minor nit...but I think the wording should be \u0027special json format data section following\u0027 or \u0027that follows\u0027","commit_id":"266163b77c864720ac073394e095809bbf188bc6"}],"neutron_fwaas/tests/functional/test_fwaas_driver.py":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"3b5753f2067b14415e63b9f37dad8c014067aaf4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestFWaaSDriver(base.BaseSudoTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    \"\"\"Test the Iptables implementation of the FWaaS driver.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # NOTE: Tests may be added/removed/changed, when this is fleshed out"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_4fbd6e01","line":23,"updated":"2015-10-23 19:12:28.000000000","message":"Iptables starts normally with lower case i.","commit_id":"266163b77c864720ac073394e095809bbf188bc6"}]}