)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"fa72213ec150a2776ee8c47fd63ada5f9ffe4005","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zoukeke \u003czoukeke@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-07 19:54:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix fwaas tempest api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. add cleanup for firewall rule"},{"line_number":10,"context_line":"2. add confirmation for firewall deletion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_79eff71d","line":7,"updated":"2017-02-08 11:43:44.000000000","message":"You just added API tests, didn\u0027t you?  How about changing like as follows?\n\nAdd tempest API tests\n\nThis patch adds following tests:\n...","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"},{"author":{"_account_id":19642,"name":"Zou Keke","email":"zoukeke@cmss.chinamobile.com","username":"zoukeke"},"change_message_id":"34ac7061281689a120f1091b4a4c9c7b9421400b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zoukeke \u003czoukeke@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-07 19:54:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix fwaas tempest api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. add cleanup for firewall rule"},{"line_number":10,"context_line":"2. add confirmation for firewall deletion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_ac3d7b2c","line":7,"in_reply_to":"1a430d35_79eff71d","updated":"2017-02-09 02:02:54.000000000","message":"I did not add any API test, just optimize them by adding cleanup and confirmation:)","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"21fea4596929a82d763e7ac0ca2bc6db3e1f5dc1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zoukeke \u003czoukeke@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-07 19:54:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix fwaas tempest api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. add cleanup for firewall rule"},{"line_number":10,"context_line":"2. add confirmation for firewall deletion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a430d35_3928e632","line":7,"in_reply_to":"1a430d35_ac3d7b2c","updated":"2017-02-09 04:24:04.000000000","message":"OK.  However, I think \"fix\" seems to include bug and fix it.  In case of this patch, it seems to be refactored or something.  In addition, could you add an explanation  \u0027why\u0027 you added following logics?  It\u0027s better to understand what this commit is by reading commit message.","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"}],"neutron_fwaas/tests/tempest_plugin/tests/api/test_fwaas_extensions.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"fa72213ec150a2776ee8c47fd63ada5f9ffe4005","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Confirm deletion"},{"line_number":270,"context_line":"        firewalls \u003d self.firewalls_client.list_firewalls()"},{"line_number":271,"context_line":"        firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":272,"context_line":"        self.assertNotIn(firewall_id, [m[\u0027id\u0027] for m in firewalls])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00271355cf5c-77d4-4bb9-87d7-e50c194d08b5\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_b9223fa1","line":271,"updated":"2017-02-08 11:43:44.000000000","message":"nit: firewalls \u003d self.firewalls_client.list_firewalls()[\u0027firewalls\u0027]","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"},{"author":{"_account_id":19642,"name":"Zou Keke","email":"zoukeke@cmss.chinamobile.com","username":"zoukeke"},"change_message_id":"34ac7061281689a120f1091b4a4c9c7b9421400b","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Confirm deletion"},{"line_number":270,"context_line":"        firewalls \u003d self.firewalls_client.list_firewalls()"},{"line_number":271,"context_line":"        firewalls \u003d firewalls[\u0027firewalls\u0027]"},{"line_number":272,"context_line":"        self.assertNotIn(firewall_id, [m[\u0027id\u0027] for m in firewalls])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @decorators.idempotent_id(\u00271355cf5c-77d4-4bb9-87d7-e50c194d08b5\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_ac6bbb1c","line":271,"in_reply_to":"1a430d35_b9223fa1","updated":"2017-02-09 02:02:54.000000000","message":"Done","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ffe2e442183e873d9d5cbaf2c869d55419bb21de","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                return True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"            fw_status \u003d firewall[\u0027firewall\u0027][\u0027status\u0027]"},{"line_number":117,"context_line":"            if fw_status \u003d\u003d \u0027ERROR\u0027:"},{"line_number":118,"context_line":"                raise lib_exc.DeleteErrorException(resource_id\u003dfw_id)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not test_utils.call_until_true(_wait, CONF.network.build_timeout,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bff0334d_2db973e8","line":117,"range":{"start_line":117,"start_character":29,"end_line":117,"end_character":34},"updated":"2017-04-07 04:34:38.000000000","message":"can this only be Error ?","commit_id":"74b84c57ac779621e801c78661e875ddc07f7f7c"}],"neutron_fwaas/tests/tempest_plugin/tests/api/test_fwaasv2_extensions.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"fa72213ec150a2776ee8c47fd63ada5f9ffe4005","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # Confirm deletion"},{"line_number":304,"context_line":"        firewall_groups \u003d self.firewall_groups_client.list_firewall_groups()"},{"line_number":305,"context_line":"        fwgs \u003d firewall_groups[\u0027firewall_groups\u0027]"},{"line_number":306,"context_line":"        self.assertNotIn(fwg_id, [m[\u0027id\u0027] for m in fwgs])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @decorators.idempotent_id(\u0027e021baab-d4f7-4bad-b382-bde4946e0e0b\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_59087bda","line":305,"updated":"2017-02-08 11:43:44.000000000","message":"fwgs \u003d self.firewall_groups_client.list_firewall_groups()[\u0027firewall_groups\u0027]","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"},{"author":{"_account_id":19642,"name":"Zou Keke","email":"zoukeke@cmss.chinamobile.com","username":"zoukeke"},"change_message_id":"34ac7061281689a120f1091b4a4c9c7b9421400b","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # Confirm deletion"},{"line_number":304,"context_line":"        firewall_groups \u003d self.firewall_groups_client.list_firewall_groups()"},{"line_number":305,"context_line":"        fwgs \u003d firewall_groups[\u0027firewall_groups\u0027]"},{"line_number":306,"context_line":"        self.assertNotIn(fwg_id, [m[\u0027id\u0027] for m in fwgs])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @decorators.idempotent_id(\u0027e021baab-d4f7-4bad-b382-bde4946e0e0b\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_6c8553cd","line":305,"in_reply_to":"1a430d35_59087bda","updated":"2017-02-09 02:02:54.000000000","message":"Done","commit_id":"7e9bfead6c51b7af3b2dc6a2a660339758d0ab75"}]}