)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"309d5948fa0161e6ccb128b429aed9cadf186b72","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huang liujie \u003chuang.liujie@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-26 04:29:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix the bug: when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_07ad4683","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":12},"updated":"2018-07-26 04:36:51.000000000","message":"I think it is not necessary.","commit_id":"e676d6a206381b8f3442bf40255c220a60b10fee"},{"author":{"_account_id":28743,"name":"huang liujie","email":"huang.liujie@99cloud.net","username":"ljhuang"},"change_message_id":"5af73c03ccf7f7d19afc80ab1d9505063e9c2a8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huang liujie \u003chuang.liujie@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-26 04:29:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix the bug: when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_79fcbf3e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":12},"in_reply_to":"5f7c97a3_07ad4683","updated":"2019-09-14 15:28:20.000000000","message":"Done","commit_id":"e676d6a206381b8f3442bf40255c220a60b10fee"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"bccedae8887af27319c2ce1eb4b5d59dcc9d6eb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huang liujie \u003chuang.liujie@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-26 08:34:43 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"},{"line_number":11,"context_line":"add_router if router existed.in firewall agent,a firewall group will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_3e4389b1","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":6},"updated":"2018-08-10 10:08:07.000000000","message":"Please update commit message.  You can see the following link:\n\n* https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"aadce0197c75ba73694f6a79e7a6363aa206efaa"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"bccedae8887af27319c2ce1eb4b5d59dcc9d6eb4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"},{"line_number":11,"context_line":"add_router if router existed.in firewall agent,a firewall group will"},{"line_number":12,"context_line":"check if port bind in has_port_insertion_fields.in this method,judge if"},{"line_number":13,"context_line":"\u0027add-port-ids\u0027 is in method,when no port bind,the group will has"},{"line_number":14,"context_line":"\u0027add-port-ids\u0027 field,however the value is empty list.this will change"},{"line_number":15,"context_line":"group status and notify plugin."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ife294430409a9fb2944917a28a08323f41c89c0d"},{"line_number":18,"context_line":"Closes-Bug:#1783327"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_7e6b411d","line":15,"range":{"start_line":10,"start_character":0,"end_line":15,"end_character":31},"updated":"2018-08-10 10:08:07.000000000","message":"I think it\u0027s better to describe the following points.\n\n* What does this commit change/fix ?\n    * with more detail information\n* What was the previous issue?\n\nIt is also helpful: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"aadce0197c75ba73694f6a79e7a6363aa206efaa"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"7bf556bb6398e70f853f98d650acaadb29fa3a36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huang liujie \u003chuang.liujie@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-29 07:59:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"},{"line_number":11,"context_line":"add_router if router existed.in firewall agent,a firewall group will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f79a3b5_8278cdf6","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":6},"updated":"2018-10-30 06:33:09.000000000","message":"Ignore fwg which has no ports when restarting l3-agent","commit_id":"0729f1dd266a73ef2a51e5d83a5a68c4165f5da9"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"7bf556bb6398e70f853f98d650acaadb29fa3a36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"when i restart l3-agent,inactive group will change to"},{"line_number":8,"context_line":"acitve"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"when restart l3-agent,l3 extension manager will call all l3 agents"},{"line_number":11,"context_line":"add_router if router existed.in firewall agent,a firewall group will"},{"line_number":12,"context_line":"check if port bind in has_port_insertion_fields.in this method,judge if"},{"line_number":13,"context_line":"\u0027add-port-ids\u0027 is in method,when no port bind,the group will has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f79a3b5_227bf9f2","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2018-10-30 06:33:09.000000000","message":"W","commit_id":"0729f1dd266a73ef2a51e5d83a5a68c4165f5da9"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"7bf556bb6398e70f853f98d650acaadb29fa3a36","unresolved":false,"context_lines":[{"line_number":11,"context_line":"add_router if router existed.in firewall agent,a firewall group will"},{"line_number":12,"context_line":"check if port bind in has_port_insertion_fields.in this method,judge if"},{"line_number":13,"context_line":"\u0027add-port-ids\u0027 is in method,when no port bind,the group will has"},{"line_number":14,"context_line":"\u0027add-port-ids\u0027 field,however the value is empty list.this will change"},{"line_number":15,"context_line":"group status and notify plugin."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ife294430409a9fb2944917a28a08323f41c89c0d"},{"line_number":18,"context_line":"Closes-Bug:#1783327"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f79a3b5_e268a122","line":15,"range":{"start_line":14,"start_character":21,"end_line":15,"end_character":31},"updated":"2018-10-30 06:33:09.000000000","message":"This patch skips updating the status of firewall group which has no ports.","commit_id":"0729f1dd266a73ef2a51e5d83a5a68c4165f5da9"}],"neutron_fwaas/services/firewall/service_drivers/agents/l3reference/firewall_l3_agent_v2.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"309d5948fa0161e6ccb128b429aed9cadf186b72","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            ports_to_process \u003d (set(firewall_group[\u0027add-port-ids\u0027] +"},{"line_number":272,"context_line":"                                    firewall_group[\u0027del-port-ids\u0027]) \u0026"},{"line_number":273,"context_line":"                                all_router_ports)"},{"line_number":274,"context_line":"            # ensure no port in route is associated with the firewall group"},{"line_number":275,"context_line":"            if not ports_to_process:"},{"line_number":276,"context_line":"                continue"},{"line_number":277,"context_line":"            # A port can have at most one firewall group."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_678d1a28","line":274,"range":{"start_line":274,"start_character":31,"end_line":274,"end_character":37},"updated":"2018-07-26 04:36:51.000000000","message":"router","commit_id":"e676d6a206381b8f3442bf40255c220a60b10fee"},{"author":{"_account_id":28743,"name":"huang liujie","email":"huang.liujie@99cloud.net","username":"ljhuang"},"change_message_id":"5af73c03ccf7f7d19afc80ab1d9505063e9c2a8d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            ports_to_process \u003d (set(firewall_group[\u0027add-port-ids\u0027] +"},{"line_number":272,"context_line":"                                    firewall_group[\u0027del-port-ids\u0027]) \u0026"},{"line_number":273,"context_line":"                                all_router_ports)"},{"line_number":274,"context_line":"            # ensure no port in route is associated with the firewall group"},{"line_number":275,"context_line":"            if not ports_to_process:"},{"line_number":276,"context_line":"                continue"},{"line_number":277,"context_line":"            # A port can have at most one firewall group."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_59d6a3c6","line":274,"range":{"start_line":274,"start_character":31,"end_line":274,"end_character":37},"in_reply_to":"5f7c97a3_678d1a28","updated":"2019-09-14 15:28:20.000000000","message":"Done","commit_id":"e676d6a206381b8f3442bf40255c220a60b10fee"}]}