)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Homolka \u003cdavid.homolka@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-23 15:43:09 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Default firewall rules from configuration file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new options to configuration file for using in Default firewall"},{"line_number":10,"context_line":"rules. Separate ingress and egress: action, source ipv4, source ipv6,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_21fb2c15","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":16},"updated":"2018-11-08 15:45:25.000000000","message":"firewall group","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Default firewall rules from configuration file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new options to configuration file for using in Default firewall"},{"line_number":10,"context_line":"rules. Separate ingress and egress: action, source ipv4, source ipv6,"},{"line_number":11,"context_line":"source port, destination ipv4, destination ipv6, destination port."},{"line_number":12,"context_line":"Shared options for ingress and egress: protocol, enabled and shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_01fb9079","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":37},"updated":"2018-11-08 15:45:25.000000000","message":"I think neutron_fwaas.conf is suitable to define with [default_firewall_group_rules] section.","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Default firewall rules from configuration file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new options to configuration file for using in Default firewall"},{"line_number":10,"context_line":"rules. Separate ingress and egress: action, source ipv4, source ipv6,"},{"line_number":11,"context_line":"source port, destination ipv4, destination ipv6, destination port."},{"line_number":12,"context_line":"Shared options for ingress and egress: protocol, enabled and shared."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_41fe6804","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":67},"updated":"2018-11-08 15:45:25.000000000","message":"firewall group","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"value are same as before this change, ingress (deny all),"},{"line_number":16,"context_line":"egress (allow all)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1799358"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic48872f3b7dfd4a87065799b7d3656de3d06e4c3"},{"line_number":21,"context_line":"Closes-Bug: 1799358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_4183c855","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":51},"updated":"2018-11-08 15:45:25.000000000","message":"It is enough to specify Closes-Bug: #1799358\nPlease remove this line.","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1799358"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic48872f3b7dfd4a87065799b7d3656de3d06e4c3"},{"line_number":21,"context_line":"Closes-Bug: 1799358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_e1753487","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":19},"updated":"2018-11-08 15:45:25.000000000","message":"nit: #1799358","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"}],"neutron_fwaas/db/firewall/v2/firewall_db_v2.py":[{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"6e93da56bf9502898ec6aae6bcf9f3c915d8958e","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        # NOTE(xgerman) Maybe generating the final set of rules from a"},{"line_number":411,"context_line":"        # configuration file makes sense. Can be done some time later"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        # 1. Drop any IPv4 packets for ingress traffic"},{"line_number":414,"context_line":"        in_fwr_v4 \u003d {"},{"line_number":415,"context_line":"            \u0027description\u0027: \u0027default ingress rule for IPv4\u0027,"},{"line_number":416,"context_line":"            \u0027name\u0027: \u0027default ingress ipv4\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_bd640c23","line":413,"range":{"start_line":413,"start_character":13,"end_line":413,"end_character":17},"updated":"2019-08-06 11:00:08.000000000","message":"This depends on the config now","commit_id":"cc61e7adc6d8bfaff39ebd49731dd6ede2bd1ec8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5dd1d19f0fd846959b4a56ef7b962a3b39ed6d68","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        # NOTE(xgerman) Maybe generating the final set of rules from a"},{"line_number":411,"context_line":"        # configuration file makes sense. Can be done some time later"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        # 1. Drop any IPv4 packets for ingress traffic"},{"line_number":414,"context_line":"        in_fwr_v4 \u003d {"},{"line_number":415,"context_line":"            \u0027description\u0027: \u0027default ingress rule for IPv4\u0027,"},{"line_number":416,"context_line":"            \u0027name\u0027: \u0027default ingress ipv4\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_9b68f587","line":413,"range":{"start_line":413,"start_character":13,"end_line":413,"end_character":17},"in_reply_to":"7faddb67_bd640c23","updated":"2019-08-26 12:21:20.000000000","message":"Yes, it depends on the config now, but it is dropping by default. I will change the comment to be more describing.","commit_id":"cc61e7adc6d8bfaff39ebd49731dd6ede2bd1ec8"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"6e93da56bf9502898ec6aae6bcf9f3c915d8958e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                    ingress_destination_ipv4_address,"},{"line_number":431,"context_line":"        }"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # 2. Drop any IPv6 packets for ingress traffic"},{"line_number":434,"context_line":"        in_fwr_v6 \u003d copy.deepcopy(in_fwr_v4)"},{"line_number":435,"context_line":"        in_fwr_v6[\u0027description\u0027] \u003d \u0027default ingress rule for IPv6\u0027"},{"line_number":436,"context_line":"        in_fwr_v6[\u0027name\u0027] \u003d \u0027default ingress ipv6\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_dd678824","line":433,"range":{"start_line":433,"start_character":13,"end_line":433,"end_character":17},"updated":"2019-08-06 11:00:08.000000000","message":"same as above","commit_id":"cc61e7adc6d8bfaff39ebd49731dd6ede2bd1ec8"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"6e93da56bf9502898ec6aae6bcf9f3c915d8958e","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        in_fwr_v6[\u0027destination_ip_address\u0027] \u003d \\"},{"line_number":441,"context_line":"            cfg.CONF.default_fwg_rules.ingress_destination_ipv6_address"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # 3. Allow any IPv4 packets for egress traffic"},{"line_number":444,"context_line":"        eg_fwr_v4 \u003d copy.deepcopy(in_fwr_v4)"},{"line_number":445,"context_line":"        eg_fwr_v4[\u0027description\u0027] \u003d \u0027default egress rule for IPv4\u0027"},{"line_number":446,"context_line":"        eg_fwr_v4[\u0027name\u0027] \u003d \u0027default egress ipv4\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_7d6a14ed","line":443,"range":{"start_line":443,"start_character":13,"end_line":443,"end_character":18},"updated":"2019-08-06 11:00:08.000000000","message":"same as above","commit_id":"cc61e7adc6d8bfaff39ebd49731dd6ede2bd1ec8"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"6e93da56bf9502898ec6aae6bcf9f3c915d8958e","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        eg_fwr_v4[\u0027destination_ip_address\u0027] \u003d \\"},{"line_number":455,"context_line":"            cfg.CONF.default_fwg_rules.egress_destination_ipv4_address"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        # 4. Allow any IPv6 packets for egress traffic"},{"line_number":458,"context_line":"        eg_fwr_v6 \u003d copy.deepcopy(in_fwr_v6)"},{"line_number":459,"context_line":"        eg_fwr_v6[\u0027description\u0027] \u003d \u0027default egress rule for IPv6\u0027"},{"line_number":460,"context_line":"        eg_fwr_v6[\u0027name\u0027] \u003d \u0027default egress ipv6\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_9d6d9004","line":457,"range":{"start_line":457,"start_character":13,"end_line":457,"end_character":18},"updated":"2019-08-06 11:00:08.000000000","message":"same as above","commit_id":"cc61e7adc6d8bfaff39ebd49731dd6ede2bd1ec8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3ab139c9d1cf21542c3bdb09d510caac479ac14","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from sqlalchemy import or_"},{"line_number":34,"context_line":"from sqlalchemy import orm"},{"line_number":35,"context_line":"from sqlalchemy.orm import exc"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from oslo_config import cfg"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron_fwaas.common import fwaas_constants as const"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_093b7739","line":36,"updated":"2019-08-23 07:59:22.000000000","message":"oslo_config should belong to the above import group.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"}],"neutron_fwaas/extensions/firewall_v2.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    f_exc.FirewallRuleAlreadyAssociated, \u0027FirewallRuleAlreadyAssociated\u0027,"},{"line_number":89,"context_line":"    __name__)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"default_firewall_rule_opts \u003d ["},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027ingress_action\u0027,"},{"line_number":93,"context_line":"               default\u003d\"deny\","},{"line_number":94,"context_line":"               help\u003d_(\u0027Firewall rule action allow or \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_21b48cd3","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":26},"updated":"2018-11-08 15:45:25.000000000","message":"How about \u0027default_fwg_rules\u0027 ?","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d3026b62f8d1aa82715a1f085cab8d726807dee1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                help\u003d_(\u0027Firewall rule enabled. \u0027"},{"line_number":173,"context_line":"                       \u0027Default is True.\u0027)),"},{"line_number":174,"context_line":"]"},{"line_number":175,"context_line":"cfg.CONF.register_opts(default_firewall_rule_opts, \u0027default_firewall_rules\u0027)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# TODO(Reedip): Remove the convert_to functionality after bug1706061 is fixed."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a1cbbc70","line":175,"range":{"start_line":175,"start_character":52,"end_line":175,"end_character":74},"updated":"2018-11-08 15:45:25.000000000","message":"default_firewall_group_rules","commit_id":"16f6dae28c42af0ca468bc61543e97098879b09a"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cb63f14ac16a1d003fd30de0f61864d3d69446e2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"default_fwg_rules_opts \u003d ["},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027ingress_action\u0027,"},{"line_number":93,"context_line":"               default\u003d\"deny\","},{"line_number":94,"context_line":"               help\u003d_(\u0027Firewall rule action allow or \u0027"},{"line_number":95,"context_line":"                      \u0027deny or reject for ingress. \u0027"},{"line_number":96,"context_line":"                      \u0027Default is deny.\u0027)),"},{"line_number":97,"context_line":"    cfg.StrOpt(\u0027ingress_source_ipv4_address\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_80503560","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":31},"updated":"2019-07-30 00:18:25.000000000","message":"Firewall group","commit_id":"5f616dd499ef6749201995a79704e94cfa154c43"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cb63f14ac16a1d003fd30de0f61864d3d69446e2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                      \u0027Default is None.\u0027)),"},{"line_number":127,"context_line":"    cfg.StrOpt(\u0027egress_action\u0027,"},{"line_number":128,"context_line":"               default\u003d\"allow\","},{"line_number":129,"context_line":"               help\u003d_(\u0027Firewall rule action allow or \u0027"},{"line_number":130,"context_line":"                      \u0027deny or reject for egress. \u0027"},{"line_number":131,"context_line":"                      \u0027Default is allow.\u0027)),"},{"line_number":132,"context_line":"    cfg.StrOpt(\u0027egress_source_ipv4_address\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_204f01be","line":129,"range":{"start_line":129,"start_character":23,"end_line":129,"end_character":31},"updated":"2019-07-30 00:18:25.000000000","message":"Firewall group","commit_id":"5f616dd499ef6749201995a79704e94cfa154c43"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cb63f14ac16a1d003fd30de0f61864d3d69446e2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                      \u0027Default is None.\u0027)),"},{"line_number":162,"context_line":"    cfg.BoolOpt(\u0027shared\u0027,"},{"line_number":163,"context_line":"                default\u003dFalse,"},{"line_number":164,"context_line":"                help\u003d_(\u0027Firewall rule shared. \u0027"},{"line_number":165,"context_line":"                       \u0027Default is False.\u0027)),"},{"line_number":166,"context_line":"    cfg.StrOpt(\u0027protocol\u0027,"},{"line_number":167,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e0c6c916","line":164,"range":{"start_line":164,"start_character":24,"end_line":164,"end_character":32},"updated":"2019-07-30 00:18:25.000000000","message":"Firewall group","commit_id":"5f616dd499ef6749201995a79704e94cfa154c43"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cb63f14ac16a1d003fd30de0f61864d3d69446e2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                      \u0027Default is None.\u0027)),"},{"line_number":170,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":171,"context_line":"                default\u003dTrue,"},{"line_number":172,"context_line":"                help\u003d_(\u0027Firewall rule enabled. \u0027"},{"line_number":173,"context_line":"                       \u0027Default is True.\u0027)),"},{"line_number":174,"context_line":"]"},{"line_number":175,"context_line":"cfg.CONF.register_opts(default_fwg_rules_opts, \u0027default_fwg_rules\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_00ca0519","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":32},"updated":"2019-07-30 00:18:25.000000000","message":"Firewall group","commit_id":"5f616dd499ef6749201995a79704e94cfa154c43"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"default_fwg_rules_opts \u003d ["},{"line_number":92,"context_line":"    cfg.StrOpt(\u0027ingress_action\u0027,"},{"line_number":93,"context_line":"               default\u003d\"deny\","},{"line_number":94,"context_line":"               help\u003d_(\u0027Firewall group rule action allow or \u0027"},{"line_number":95,"context_line":"                      \u0027deny or reject for ingress. \u0027"},{"line_number":96,"context_line":"                      \u0027Default is deny.\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_09f5b7cc","line":93,"range":{"start_line":93,"start_character":23,"end_line":93,"end_character":29},"updated":"2019-08-23 07:46:12.000000000","message":"Use a constant rather than a literal string.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"}],"neutron_fwaas/tests/unit/db/firewall/v2/test_firewall_db_v2.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f9ed332baf65f7f36a9f4f9e30e59df419e53c40","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                \"keys\": [\"description\", \"action\", \"protocol\", \"enabled\","},{"line_number":823,"context_line":"                         \"ip_version\", \"name\"],"},{"line_number":824,"context_line":"                \"data\": ["},{"line_number":825,"context_line":"                    (\"default ingress rule for IPv4\", \"deny\", None, True, 4,"},{"line_number":826,"context_line":"                     \"default ingress ipv4\"),"},{"line_number":827,"context_line":"                    (\"default egress rule for IPv4\", \"allow\", None, True, 4,"},{"line_number":828,"context_line":"                     \"default egress ipv4\"),"},{"line_number":829,"context_line":"                    (\"default ingress rule for IPv6\", \"deny\", None, True, 6,"},{"line_number":830,"context_line":"                     \"default ingress ipv6\"),"},{"line_number":831,"context_line":"                    (\"default egress rule for IPv6\", \"allow\", None, True, 6,"},{"line_number":832,"context_line":"                     \"default egress ipv6\")]"},{"line_number":833,"context_line":"            }"},{"line_number":834,"context_line":"        }"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_a258fe55","line":832,"range":{"start_line":825,"start_character":0,"end_line":832,"end_character":44},"updated":"2019-02-08 02:30:30.000000000","message":"I think this change is not testing whether default fwg rule are configurable or not.  Could you add 1 test that changing default_fwg_rules and the rules were generated as you defined?","commit_id":"dba416c01c3bddf3c53c6b4b7874078d90902787"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        self.assertEqual(set([ctx_admin.tenant_id, ctx.tenant_id]),"},{"line_number":833,"context_line":"                         set([r[\u0027tenant_id\u0027] for r in res]))"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"    def test_create_firewall_from_config(self):"},{"line_number":836,"context_line":"        \"\"\""},{"line_number":837,"context_line":"        Tests if configurable default values propagate to created default"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_296d1399","line":835,"range":{"start_line":835,"start_character":13,"end_line":835,"end_character":28},"updated":"2019-08-23 07:46:12.000000000","message":"..._create_default_firewall_... would be a better name","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                         set([r[\u0027tenant_id\u0027] for r in res]))"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"    def test_create_firewall_from_config(self):"},{"line_number":836,"context_line":"        \"\"\""},{"line_number":837,"context_line":"        Tests if configurable default values propagate to created default"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        group \u003d \u0027default_fwg_rules\u0027"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        cfg.CONF.set_override(\u0027shared\u0027, True, group)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_6910eb01","line":839,"range":{"start_line":836,"start_character":8,"end_line":839,"end_character":11},"updated":"2019-08-23 07:46:12.000000000","message":"Could you drop it? The docstring is useful in general, but if we have docstring for test, we no longer see the full path of the test.\nInstead let\u0027s make the test name more descriptive and if you need more use a usual comment.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"}],"releasenotes/notes/bug-1799358-360c6ab27a32e0ac.yaml":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f9ed332baf65f7f36a9f4f9e30e59df419e53c40","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."},{"line_number":8,"context_line":"    Default firewall group\u0027s rules is hardcoded in a code."},{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":11,"context_line":"    If configuration is not touched, everything is working"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_62c69619","line":8,"range":{"start_line":8,"start_character":35,"end_line":8,"end_character":37},"updated":"2019-02-08 02:30:30.000000000","message":"are","commit_id":"dba416c01c3bddf3c53c6b4b7874078d90902787"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f9ed332baf65f7f36a9f4f9e30e59df419e53c40","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."},{"line_number":8,"context_line":"    Default firewall group\u0027s rules is hardcoded in a code."},{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":11,"context_line":"    If configuration is not touched, everything is working"},{"line_number":12,"context_line":"    as before - when rules were hardcoded in a code."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fdfeff1_624bf686","line":10,"range":{"start_line":9,"start_character":20,"end_line":10,"end_character":53},"updated":"2019-02-08 02:30:30.000000000","message":"Please also mention at commit message.  In addition, is there any example to define at neutron_fwaas.conf ??  It\u0027s more helpful to check the example.","commit_id":"dba416c01c3bddf3c53c6b4b7874078d90902787"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    When neutron-fwaas is deployed to already working openstack with neutron,"},{"line_number":4,"context_line":"    default firewall group rules disallow connections to running instances."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_899d276e","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":75},"updated":"2019-08-23 07:46:12.000000000","message":"This prelude looks unnecessary. This only describes what we have now. This file will be rendered as a release note of Train release, so this sentence would be confusing if users see it as part of Train release note.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    default firewall group rules disallow connections to running instances."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."},{"line_number":8,"context_line":"    Default firewall group\u0027s rules are hardcoded in a code."},{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_091e170d","line":7,"updated":"2019-08-23 07:46:12.000000000","message":"- is -\u003e was\n- no way how to define -\u003e no way to define","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."},{"line_number":8,"context_line":"    Default firewall group\u0027s rules are hardcoded in a code."},{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":11,"context_line":"    If configuration is not touched, everything is working"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_e914dbeb","line":8,"range":{"start_line":8,"start_character":35,"end_line":8,"end_character":38},"updated":"2019-08-23 07:46:12.000000000","message":"are -\u003e were","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    There is no way how to define default firewall group rules."},{"line_number":8,"context_line":"    Default firewall group\u0027s rules are hardcoded in a code."},{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":11,"context_line":"    If configuration is not touched, everything is working"},{"line_number":12,"context_line":"    as before - when rules were hardcoded in a code."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_09913754","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":18},"updated":"2019-08-23 07:46:12.000000000","message":"When this file is rendered as part of the release notes, \"this fix\" cannot be identified.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ddb79fb8178b1ddd14146f011648be8a6d0b58e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    After this fix, default firewall group rules can be defined in"},{"line_number":10,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":11,"context_line":"    If configuration is not touched, everything is working"},{"line_number":12,"context_line":"    as before - when rules were hardcoded in a code."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_a98b431c","line":12,"updated":"2019-08-23 07:46:12.000000000","message":"It is also better to mention it does not affect existing default rules. It only affects default rules for new firewall group.","commit_id":"0a7f47c3692ca46e01748df78010a949739ef516"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3a40a1a3a68526006fc4ef000a1de341f72d3a68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    Default firewall group\u0027s rules were hardcoded in a code."},{"line_number":6,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":7,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":8,"context_line":"    If configuration is not touched, everything is working"},{"line_number":9,"context_line":"    as before - when rules were hardcoded in a code."},{"line_number":10,"context_line":"    This change does not affect existing default rules. It only"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_3a086d7e","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":53},"updated":"2019-09-02 07:30:35.000000000","message":"please put it in `` ``, so it will be something like: ``default_fwg_rules``","commit_id":"2b9e4c54b3cd4b7afdd943546c5ef9d35633eb41"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45fcd93b12c33209fa678bae62db6e507e16042a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    Default firewall group\u0027s rules were hardcoded in a code."},{"line_number":6,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":7,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":8,"context_line":"    If configuration is not touched, everything is working"},{"line_number":9,"context_line":"    as before - when rules were hardcoded in a code."},{"line_number":10,"context_line":"    This change does not affect existing default rules. It only"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_6ee9437d","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":53},"in_reply_to":"7faddb67_3a086d7e","updated":"2019-09-02 13:23:35.000000000","message":"Done","commit_id":"2b9e4c54b3cd4b7afdd943546c5ef9d35633eb41"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3a40a1a3a68526006fc4ef000a1de341f72d3a68","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Default firewall group\u0027s rules were hardcoded in a code."},{"line_number":6,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":7,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":8,"context_line":"    If configuration is not touched, everything is working"},{"line_number":9,"context_line":"    as before - when rules were hardcoded in a code."},{"line_number":10,"context_line":"    This change does not affect existing default rules. It only"},{"line_number":11,"context_line":"    affects default rules for new firewall group."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_7a1265b6","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":52},"updated":"2019-09-02 07:30:35.000000000","message":"I would say here that \"default values are the same as hardcoded values before.\" Or something like that.","commit_id":"2b9e4c54b3cd4b7afdd943546c5ef9d35633eb41"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45fcd93b12c33209fa678bae62db6e507e16042a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Default firewall group\u0027s rules were hardcoded in a code."},{"line_number":6,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":7,"context_line":"    neutron_fwaas.conf in section [default_fwg_rules]."},{"line_number":8,"context_line":"    If configuration is not touched, everything is working"},{"line_number":9,"context_line":"    as before - when rules were hardcoded in a code."},{"line_number":10,"context_line":"    This change does not affect existing default rules. It only"},{"line_number":11,"context_line":"    affects default rules for new firewall group."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_0e020f3f","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":52},"in_reply_to":"7faddb67_7a1265b6","updated":"2019-09-02 13:23:35.000000000","message":"Done","commit_id":"2b9e4c54b3cd4b7afdd943546c5ef9d35633eb41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8da528c1f7ecc49a0f5b3b0536ce34f82cd4b53","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":6,"context_line":"    neutron_fwaas.conf in section ``default_fwg_rules``."},{"line_number":7,"context_line":"    Default firewall group rules are the same as hardcoded values before."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_497ec11b","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":21},"updated":"2019-09-02 14:09:12.000000000","message":"Again \"this change\" cannot be identified after it is rendered as HTML release notes. I would suggest \"Default firewall group can .... in ``default_fwg_rules`` section now\".","commit_id":"681bf20080d06eec4dbdf0059b0350770ffcaba8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8da528c1f7ecc49a0f5b3b0536ce34f82cd4b53","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":6,"context_line":"    neutron_fwaas.conf in section ``default_fwg_rules``."},{"line_number":7,"context_line":"    Default firewall group rules are the same as hardcoded values before."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_2979052e","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":55},"updated":"2019-09-02 14:09:12.000000000","message":"``default_fwg_rules` section or the section ``default_fwg_rules`` is better.","commit_id":"681bf20080d06eec4dbdf0059b0350770ffcaba8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8da528c1f7ecc49a0f5b3b0536ce34f82cd4b53","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    After this change, default firewall group rules can be defined in"},{"line_number":6,"context_line":"    neutron_fwaas.conf in section ``default_fwg_rules``."},{"line_number":7,"context_line":"    Default firewall group rules are the same as hardcoded values before."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_898d992b","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":40},"updated":"2019-09-02 14:09:12.000000000","message":"-\u003e are same as the hardcoded ....","commit_id":"681bf20080d06eec4dbdf0059b0350770ffcaba8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ded258595f64a41fa9faa2120d2d57c5cbeb342","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There was no way to define default firewall group rules."},{"line_number":5,"context_line":"    Default firewall group rules can be now defined in neutron_fwaas.conf"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5faad753_2b13790f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2019-09-11 11:46:09.000000000","message":"IMHO this is a mini \"feature\" (but okay as the bug is prioritised as Low). It\u0027s not blocking.","commit_id":"f28c59df2b9be75a1b81133b0d9803078de87fe6"}]}