)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4b39c2aaa87999b679e4296726ef23cb91499377","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing FWaaS v1 source code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As German Eichberger\u0027s email at"},{"line_number":10,"context_line":"https://markmail.org/message/2kva4b3lwgddyeau. So This patch intend to"},{"line_number":11,"context_line":"removes source code related FWaaS V1."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4e440c854e5aa11193d38946e659481f4fefded2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_32b79cfa","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":45},"updated":"2018-12-13 06:43:21.000000000","message":"Let\u0027s use an URL from lists.openstack.org.","commit_id":"e38e0b4bde75e953d4461c8893c5c95cb1eb0ae2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4b39c2aaa87999b679e4296726ef23cb91499377","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing FWaaS v1 source code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As German Eichberger\u0027s email at"},{"line_number":10,"context_line":"https://markmail.org/message/2kva4b3lwgddyeau. So This patch intend to"},{"line_number":11,"context_line":"removes source code related FWaaS V1."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4e440c854e5aa11193d38946e659481f4fefded2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_d2abc88e","line":11,"range":{"start_line":10,"start_character":50,"end_line":11,"end_character":7},"updated":"2018-12-13 06:43:21.000000000","message":"-\u003e this patch removes ....\n\n(\"intend to\" looks unnecessary)","commit_id":"e38e0b4bde75e953d4461c8893c5c95cb1eb0ae2"}],"devstack/README.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4b39c2aaa87999b679e4296726ef23cb91499377","unresolved":false,"context_lines":[{"line_number":6,"context_line":"see the `DevStack Plugins documentation"},{"line_number":7,"context_line":"\u003chttps://docs.openstack.org/devstack/latest/plugins.html\u003e`_."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Please note that the old \u0027q-fwaas\u0027 keyword still exists, You can specify"},{"line_number":10,"context_line":"enable_service q-fwaas or enable_service q-fwaas-v2 in local.conf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"How to run FWaaS V2 in DevStack"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_120aa07a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":56},"updated":"2018-12-13 06:43:21.000000000","message":"Does it still work? Looking at devstack/plugin.sh, q-fwaas is not enough and it seems we must specify q-fwaas-v2. It is a good chance to check it.","commit_id":"e38e0b4bde75e953d4461c8893c5c95cb1eb0ae2"}],"devstack/plugin.sh":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"0f28694aa340951388f9d30c6258498dcb7c04e5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # Configure after the other layer 1 and 2 services have been configured"},{"line_number":104,"context_line":"        neutron_fwaas_configure_common"},{"line_number":105,"context_line":"        neutron_fwaas_generate_config_files"},{"line_number":106,"context_line":"        if is_service_enabled q-fwaas-v2 neutron-fwaas-v2; then"},{"line_number":107,"context_line":"            echo_summary \"Configuring neutron-fwaas for FWaaS v2\""},{"line_number":108,"context_line":"            configure_fwaas_v2"},{"line_number":109,"context_line":"            if is_service_enabled q-log neutron-log; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_e9eafa0a","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":63},"updated":"2018-11-08 17:11:22.000000000","message":"I believe this if is now redundant with the if on L95, so this if can be removed.  If you get this far, the things inside this if should always be executed.","commit_id":"5acc3ccbdf1c702e45e230c1b9bc447411a6f457"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"9b06cc656c7fd23b211874b9e71ab55c6cb4be34","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # Configure after the other layer 1 and 2 services have been configured"},{"line_number":104,"context_line":"        neutron_fwaas_configure_common"},{"line_number":105,"context_line":"        neutron_fwaas_generate_config_files"},{"line_number":106,"context_line":"        if is_service_enabled q-fwaas-v2 neutron-fwaas-v2; then"},{"line_number":107,"context_line":"            echo_summary \"Configuring neutron-fwaas for FWaaS v2\""},{"line_number":108,"context_line":"            configure_fwaas_v2"},{"line_number":109,"context_line":"            if is_service_enabled q-log neutron-log; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_a5fad740","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":63},"in_reply_to":"3f79a3b5_e9eafa0a","updated":"2018-11-09 09:52:38.000000000","message":"Thanks Nate! Done.","commit_id":"5acc3ccbdf1c702e45e230c1b9bc447411a6f457"}],"etc/neutron/policy.d/neutron-fwaas.json":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4b39c2aaa87999b679e4296726ef23cb91499377","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"shared_firewalls\": \"field:firewalls:shared\u003dTrue\","},{"line_number":3,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":4,"context_line":"    \"shared_firewall_rules\": \"field:firewall_rules:shared\u003dTrue\","},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"create_firewall\": \"\","},{"line_number":7,"context_line":"    \"update_firewall\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_921d50c2","side":"PARENT","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":64},"updated":"2018-12-13 06:43:21.000000000","message":"This is a bit surprising, but this is correct.\nThey are defined in L.17-18, so L.3-4 can be dropped safely.","commit_id":"e44156e8e15571e44372055354cc458de432381a"}],"neutron_fwaas/db/firewall/firewall_db.py":[{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"94da4377dc25a8ed3c9788c77dbee6be74e9364f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_03d08af4","side":"PARENT","line":1,"updated":"2018-11-25 07:36:51.000000000","message":"Can we consider keeping the old DB structures for migration purposes? please see https://review.openstack.org/#/c/619479/","commit_id":"f2c2a51a9f2716f4135c6336cb99e0023d604b62"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"04ddbbd22c9b5092e170e7e7cde5c06aaa79c5f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b4cb0aa5","side":"PARENT","line":1,"in_reply_to":"3f79a3b5_03d08af4","updated":"2018-11-26 01:42:30.000000000","message":"Done","commit_id":"f2c2a51a9f2716f4135c6336cb99e0023d604b62"}],"setup.cfg":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c435d81a7ec2520b876409e9f51c4f0cc09fbc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"firewall_drivers \u003d"},{"line_number":35,"context_line":"    # These are for backwards compat with Juno firewall service provider"},{"line_number":36,"context_line":"    # configuration values"},{"line_number":37,"context_line":"    neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas:IptablesFwaasDriver"},{"line_number":38,"context_line":"    iptables_v2 \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2:IptablesFwaasDriver"},{"line_number":39,"context_line":"neutron.service_plugins \u003d"},{"line_number":40,"context_line":"    firewall_v2 \u003d neutron_fwaas.services.firewall.fwaas_plugin_v2:FirewallPluginV2"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"9fdfeff1_30435d44","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":184},"updated":"2019-02-01 17:28:01.000000000","message":"This is also related to fwaas v1 driver. Let\u0027s drop it.\n\nThe above comment is also unnecessary.","commit_id":"2b9ca1ca981d824c9529a5ebb986b99aa456746b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9e3a377c6bb32501ec7616b2cdd7d38f8fd6f713","unresolved":false,"context_lines":[{"line_number":34,"context_line":"firewall_drivers \u003d"},{"line_number":35,"context_line":"    # These are for backwards compat with Juno firewall service provider"},{"line_number":36,"context_line":"    # configuration values"},{"line_number":37,"context_line":"    neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas:IptablesFwaasDriver"},{"line_number":38,"context_line":"    iptables_v2 \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2:IptablesFwaasDriver"},{"line_number":39,"context_line":"neutron.service_plugins \u003d"},{"line_number":40,"context_line":"    firewall_v2 \u003d neutron_fwaas.services.firewall.fwaas_plugin_v2:FirewallPluginV2"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"9fdfeff1_f0b6353e","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":184},"in_reply_to":"9fdfeff1_30435d44","updated":"2019-02-01 17:28:19.000000000","message":"Done","commit_id":"2b9ca1ca981d824c9529a5ebb986b99aa456746b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c435d81a7ec2520b876409e9f51c4f0cc09fbc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    iptables_v2 \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2:IptablesFwaasDriver"},{"line_number":39,"context_line":"neutron.service_plugins \u003d"},{"line_number":40,"context_line":"    firewall_v2 \u003d neutron_fwaas.services.firewall.fwaas_plugin_v2:FirewallPluginV2"},{"line_number":41,"context_line":"    neutron.services.firewall.fwaas_plugin.FirewallPlugin \u003d neutron_fwaas.services.firewall.fwaas_plugin:FirewallPlugin"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"neutron.db.alembic_migrations \u003d"},{"line_number":44,"context_line":"    neutron-fwaas \u003d neutron_fwaas.db.migration:alembic_migrations"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"9fdfeff1_10441946","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":119},"updated":"2019-02-01 17:28:01.000000000","message":"This is unnecessary too.","commit_id":"2b9ca1ca981d824c9529a5ebb986b99aa456746b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9e3a377c6bb32501ec7616b2cdd7d38f8fd6f713","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    iptables_v2 \u003d neutron_fwaas.services.firewall.service_drivers.agents.drivers.linux.iptables_fwaas_v2:IptablesFwaasDriver"},{"line_number":39,"context_line":"neutron.service_plugins \u003d"},{"line_number":40,"context_line":"    firewall_v2 \u003d neutron_fwaas.services.firewall.fwaas_plugin_v2:FirewallPluginV2"},{"line_number":41,"context_line":"    neutron.services.firewall.fwaas_plugin.FirewallPlugin \u003d neutron_fwaas.services.firewall.fwaas_plugin:FirewallPlugin"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"neutron.db.alembic_migrations \u003d"},{"line_number":44,"context_line":"    neutron-fwaas \u003d neutron_fwaas.db.migration:alembic_migrations"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"9fdfeff1_10b2d949","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":119},"in_reply_to":"9fdfeff1_10441946","updated":"2019-02-01 17:28:19.000000000","message":"Done","commit_id":"2b9ca1ca981d824c9529a5ebb986b99aa456746b"}]}