)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f6cabf0a5fab84864db389b5ed147963000aeb28","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug when updating policy in firewall group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating the policy in firewall group, the fwg status is inactive"},{"line_number":10,"context_line":"and iptables in the router namespace are not changed. This patch fixes"},{"line_number":11,"context_line":"the above problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1a4bc0a8258fbbc340825cccb6d287c94304d3c5"},{"line_number":14,"context_line":"Closes-Bug: #1836015"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_15390240","line":11,"range":{"start_line":10,"start_character":54,"end_line":11,"end_character":18},"updated":"2019-07-10 13:41:10.000000000","message":"Please describe what the root cause of the issue is.","commit_id":"c474fbbc1918942be7b252b9aae264851d93896d"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"1b152a0e795388bd014ae79d12ad127dc41ba19d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug when updating policy in firewall group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating the policy in firewall group, the fwg status is inactive"},{"line_number":10,"context_line":"and iptables in the router namespace are not changed. This patch fixes"},{"line_number":11,"context_line":"the above problem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1a4bc0a8258fbbc340825cccb6d287c94304d3c5"},{"line_number":14,"context_line":"Closes-Bug: #1836015"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_202f0cf7","line":11,"range":{"start_line":10,"start_character":54,"end_line":11,"end_character":18},"in_reply_to":"7faddb67_15390240","updated":"2019-08-06 01:04:04.000000000","message":"Done","commit_id":"c474fbbc1918942be7b252b9aae264851d93896d"}],"neutron_fwaas/services/firewall/service_drivers/agents/l3reference/firewall_l3_agent_v2.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f6cabf0a5fab84864db389b5ed147963000aeb28","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _get_firewall_group_ports(self, context, firewall_group,"},{"line_number":144,"context_line":"            to_delete\u003dFalse, require_new_plugin\u003dFalse):"},{"line_number":145,"context_line":"        \"\"\"Returns in-namespace ports, either from firewall group dict if newer"},{"line_number":146,"context_line":"           version of plugin or from project routers otherwise."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"           NOTE: Vernacular move from \"tenant\" to \"project\" doesn\u0027t yet appear"},{"line_number":149,"context_line":"           as a key in router or firewall group objects."}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_954bb2ae","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":63},"updated":"2019-07-10 13:41:10.000000000","message":"This description is no longer accurate with your change so you will need to adjust the wording.","commit_id":"c474fbbc1918942be7b252b9aae264851d93896d"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"1b152a0e795388bd014ae79d12ad127dc41ba19d","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _get_firewall_group_ports(self, context, firewall_group,"},{"line_number":144,"context_line":"            to_delete\u003dFalse, require_new_plugin\u003dFalse):"},{"line_number":145,"context_line":"        \"\"\"Returns in-namespace ports, either from firewall group dict if newer"},{"line_number":146,"context_line":"           version of plugin or from project routers otherwise."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"           NOTE: Vernacular move from \"tenant\" to \"project\" doesn\u0027t yet appear"},{"line_number":149,"context_line":"           as a key in router or firewall group objects."}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e038143e","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":63},"in_reply_to":"7faddb67_954bb2ae","updated":"2019-08-06 01:04:04.000000000","message":"Done","commit_id":"c474fbbc1918942be7b252b9aae264851d93896d"}],"neutron_fwaas/tests/unit/services/firewall/service_drivers/agents/l3reference/test_firewall_l3_agent_v2.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8f5774d1305c7425ef9c92db4554a099839cce88","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_update_firewall_group_with_ports_added_and_deleted(self):"},{"line_number":142,"context_line":"        firewall_group \u003d {\u0027id\u0027: 0, \u0027project_id\u0027: 1,"},{"line_number":143,"context_line":"                          \u0027tenant_id\u0027: 1,"},{"line_number":144,"context_line":"                          \u0027admin_state_up\u0027: True,"},{"line_number":145,"context_line":"                          \u0027ports\u0027: [1, 2, 3, 4],"},{"line_number":146,"context_line":"                          \u0027add-port-ids\u0027: [1, 2],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_69381aed","line":143,"updated":"2019-08-06 07:32:35.000000000","message":"how this is related to the change exactly? And the same question if for any other addition of \"tenant_id\" in those tests","commit_id":"160a48173a6f602cce020e27acb36a7f9373a46f"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"04a8b170ccbd9e3dd0868cf5a68f0ab14cecf6b6","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_update_firewall_group_with_ports_added_and_deleted(self):"},{"line_number":142,"context_line":"        firewall_group \u003d {\u0027id\u0027: 0, \u0027project_id\u0027: 1,"},{"line_number":143,"context_line":"                          \u0027tenant_id\u0027: 1,"},{"line_number":144,"context_line":"                          \u0027admin_state_up\u0027: True,"},{"line_number":145,"context_line":"                          \u0027ports\u0027: [1, 2, 3, 4],"},{"line_number":146,"context_line":"                          \u0027add-port-ids\u0027: [1, 2],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_6ce7c8ad","line":143,"in_reply_to":"7faddb67_69381aed","updated":"2019-08-06 08:15:38.000000000","message":"Hi Slawek Kaplonski ,This has nothing to do with the actual modification, I just see that this parameter is used when calling the firewall group interface, so I added it and I will delete all these changes.","commit_id":"160a48173a6f602cce020e27acb36a7f9373a46f"}]}