)]}'
{"neutron_fwaas/services/firewall/service_drivers/agents/agents.py":[{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"2a8ec057ca56717feed553e158dfb18398a77f26","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        )"},{"line_number":298,"context_line":"        admin_state_updated \u003d (new_firewall_group[\u0027admin_state_up\u0027] !\u003d"},{"line_number":299,"context_line":"                               old_firewall_group[\u0027admin_state_up\u0027])"},{"line_number":300,"context_line":"        if (port_updated and new_firewall_group[\u0027admin_state_up\u0027] and"},{"line_number":301,"context_line":"                (new_firewall_group[\u0027ingress_firewall_policy_id\u0027] or"},{"line_number":302,"context_line":"                 new_firewall_group[\u0027egress_firewall_policy_id\u0027])):"},{"line_number":303,"context_line":"            return True"},{"line_number":304,"context_line":"        if (policies_updated and new_firewall_group[\u0027admin_state_up\u0027] and"},{"line_number":305,"context_line":"                new_firewall_group[\u0027ports\u0027]):"},{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":"        if (admin_state_updated and"},{"line_number":308,"context_line":"                (new_firewall_group[\u0027ingress_firewall_policy_id\u0027] or"},{"line_number":309,"context_line":"                 new_firewall_group[\u0027egress_firewall_policy_id\u0027]) and"},{"line_number":310,"context_line":"                new_firewall_group[\u0027ports\u0027]):"},{"line_number":311,"context_line":"            return True"},{"line_number":312,"context_line":"        return False"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def update_firewall_group_precommit(self, context, old_firewall_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_db9a5e6d","line":311,"range":{"start_line":300,"start_character":8,"end_line":311,"end_character":23},"updated":"2019-10-14 01:29:03.000000000","message":"I think there is a problem with the logic here. If the port and policy are updated, admin_state is not updated. If it is only admin_state update, is there a problem?","commit_id":"0d1b59510002f27190ec939c459390f8e3381232"},{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"14e0d3a883632576db2bc3935da76f3e6e77476b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        )"},{"line_number":298,"context_line":"        admin_state_updated \u003d (new_firewall_group[\u0027admin_state_up\u0027] !\u003d"},{"line_number":299,"context_line":"                               old_firewall_group[\u0027admin_state_up\u0027])"},{"line_number":300,"context_line":"        if (port_updated and new_firewall_group[\u0027admin_state_up\u0027] and"},{"line_number":301,"context_line":"                (new_firewall_group[\u0027ingress_firewall_policy_id\u0027] or"},{"line_number":302,"context_line":"                 new_firewall_group[\u0027egress_firewall_policy_id\u0027])):"},{"line_number":303,"context_line":"            return True"},{"line_number":304,"context_line":"        if (policies_updated and new_firewall_group[\u0027admin_state_up\u0027] and"},{"line_number":305,"context_line":"                new_firewall_group[\u0027ports\u0027]):"},{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":"        if (admin_state_updated and"},{"line_number":308,"context_line":"                (new_firewall_group[\u0027ingress_firewall_policy_id\u0027] or"},{"line_number":309,"context_line":"                 new_firewall_group[\u0027egress_firewall_policy_id\u0027]) and"},{"line_number":310,"context_line":"                new_firewall_group[\u0027ports\u0027]):"},{"line_number":311,"context_line":"            return True"},{"line_number":312,"context_line":"        return False"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def update_firewall_group_precommit(self, context, old_firewall_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2fbc176b","line":311,"range":{"start_line":300,"start_character":8,"end_line":311,"end_character":23},"in_reply_to":"3fa7e38b_db9a5e6d","updated":"2019-10-22 06:54:36.000000000","message":"If only admin_state is updated, and there is already a policy and port/s in the fw group than it will return True, as it should. I think it is fine.","commit_id":"0d1b59510002f27190ec939c459390f8e3381232"}]}