)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a8ad827a06150819b002ac821f2012e29a9fa48d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the fwaas_v1 code has been removed in the Stein cycle[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.opendev.org/#/c/616410/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I26d23c74123302ef167bd621acdafd9e0e02c6a0"},{"line_number":16,"context_line":"Closes-bug: #1850602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_05009701","line":14,"updated":"2019-10-30 14:15:49.000000000","message":"Please add a line:\n\nNeeded-By: https://review.opendev.org/692068","commit_id":"2a712acaeed35a4f74cff79e1baad28f57bb71b8"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"634674ca6fbcc6a12bd55654b8e56c19d310e692","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the fwaas_v1 code has been removed in the Stein cycle[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.opendev.org/#/c/616410/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I26d23c74123302ef167bd621acdafd9e0e02c6a0"},{"line_number":16,"context_line":"Closes-bug: #1850602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f2eaaa9d","line":14,"in_reply_to":"3fa7e38b_05009701","updated":"2019-11-04 13:29:35.000000000","message":"Done","commit_id":"2a712acaeed35a4f74cff79e1baad28f57bb71b8"}],"neutron_fwaas/extensions/firewall.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a8ad827a06150819b002ac821f2012e29a9fa48d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    f_exc.FirewallRuleConflict, \u0027FirewallRuleConflict\u0027, __name__)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"firewall_quota_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":84,"context_line":"               default\u003d10,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant. \u0027"},{"line_number":86,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":88,"context_line":"               default\u003d10,"},{"line_number":89,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant. \u0027"},{"line_number":90,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027quota_firewall_rule\u0027,"},{"line_number":92,"context_line":"               default\u003d100,"},{"line_number":93,"context_line":"               help\u003d_(\u0027Number of firewall rules allowed per tenant. \u0027"},{"line_number":94,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":"cfg.CONF.register_opts(firewall_quota_opts, \u0027QUOTAS\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(Reedip): Remove the convert_to functionality after bug1706061 is fixed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_802235a2","side":"PARENT","line":96,"range":{"start_line":82,"start_character":0,"end_line":96,"end_character":53},"updated":"2019-10-30 14:15:49.000000000","message":"I think this content needs to be migrated to a new location.","commit_id":"b76709009155131b933b2adc7608165413572d71"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7347dfa928ff345ec51d4e40ec40206dd70112ae","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    f_exc.FirewallRuleConflict, \u0027FirewallRuleConflict\u0027, __name__)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"firewall_quota_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":84,"context_line":"               default\u003d10,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant. \u0027"},{"line_number":86,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":88,"context_line":"               default\u003d10,"},{"line_number":89,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant. \u0027"},{"line_number":90,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027quota_firewall_rule\u0027,"},{"line_number":92,"context_line":"               default\u003d100,"},{"line_number":93,"context_line":"               help\u003d_(\u0027Number of firewall rules allowed per tenant. \u0027"},{"line_number":94,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":"cfg.CONF.register_opts(firewall_quota_opts, \u0027QUOTAS\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(Reedip): Remove the convert_to functionality after bug1706061 is fixed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bc13ce5b","side":"PARENT","line":96,"range":{"start_line":82,"start_character":0,"end_line":96,"end_character":53},"in_reply_to":"3fa7e38b_802235a2","updated":"2019-10-31 10:58:03.000000000","message":"+1 to relocation.\n\nQuota related options need to have names like \"quota_\u003cresource_name\u003e\" in QUOTAS group. quota_firewall_policy and quota_firewall_rule are used in FWaaS v2 too.\n\nquota_firewall is unnecessary as it is specific to FWaaS v1.\n\nIn FWaaS v2, the top level concept is \"firewall group\", so we need quota_firewall_group. Regarding this, I think we can do it in a separate patch or this patch. I am okay with either.","commit_id":"b76709009155131b933b2adc7608165413572d71"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"634674ca6fbcc6a12bd55654b8e56c19d310e692","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    f_exc.FirewallRuleConflict, \u0027FirewallRuleConflict\u0027, __name__)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"firewall_quota_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":84,"context_line":"               default\u003d10,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant. \u0027"},{"line_number":86,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":88,"context_line":"               default\u003d10,"},{"line_number":89,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant. \u0027"},{"line_number":90,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027quota_firewall_rule\u0027,"},{"line_number":92,"context_line":"               default\u003d100,"},{"line_number":93,"context_line":"               help\u003d_(\u0027Number of firewall rules allowed per tenant. \u0027"},{"line_number":94,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":"cfg.CONF.register_opts(firewall_quota_opts, \u0027QUOTAS\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(Reedip): Remove the convert_to functionality after bug1706061 is fixed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_123f4625","side":"PARENT","line":96,"range":{"start_line":82,"start_character":0,"end_line":96,"end_character":53},"in_reply_to":"3fa7e38b_802235a2","updated":"2019-11-04 13:29:35.000000000","message":"Done","commit_id":"b76709009155131b933b2adc7608165413572d71"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"634674ca6fbcc6a12bd55654b8e56c19d310e692","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    f_exc.FirewallRuleConflict, \u0027FirewallRuleConflict\u0027, __name__)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"firewall_quota_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":84,"context_line":"               default\u003d10,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant. \u0027"},{"line_number":86,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":87,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":88,"context_line":"               default\u003d10,"},{"line_number":89,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant. \u0027"},{"line_number":90,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027quota_firewall_rule\u0027,"},{"line_number":92,"context_line":"               default\u003d100,"},{"line_number":93,"context_line":"               help\u003d_(\u0027Number of firewall rules allowed per tenant. \u0027"},{"line_number":94,"context_line":"                      \u0027A negative value means unlimited.\u0027)),"},{"line_number":95,"context_line":"]"},{"line_number":96,"context_line":"cfg.CONF.register_opts(firewall_quota_opts, \u0027QUOTAS\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# TODO(Reedip): Remove the convert_to functionality after bug1706061 is fixed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b22e72f7","side":"PARENT","line":96,"range":{"start_line":82,"start_character":0,"end_line":96,"end_character":53},"in_reply_to":"3fa7e38b_bc13ce5b","updated":"2019-11-04 13:29:35.000000000","message":"Done","commit_id":"b76709009155131b933b2adc7608165413572d71"}],"neutron_fwaas/opts.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"a8ad827a06150819b002ac821f2012e29a9fa48d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_opts():"},{"line_number":30,"context_line":"    return ["},{"line_number":31,"context_line":"        (\u0027quotas\u0027,"},{"line_number":32,"context_line":"         neutron_fwaas.extensions.firewall.firewall_quota_opts),"},{"line_number":33,"context_line":"        (\u0027service_providers\u0027,"},{"line_number":34,"context_line":"         neutron.conf.services.provider_configuration.serviceprovider_opts),"},{"line_number":35,"context_line":"        (\u0027default_fwg_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e030c9eb","side":"PARENT","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":64},"updated":"2019-10-30 14:15:49.000000000","message":"I believe this should reflect the move of these option definitions to a new location, which I mention elsewhere.","commit_id":"b76709009155131b933b2adc7608165413572d71"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"634674ca6fbcc6a12bd55654b8e56c19d310e692","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_opts():"},{"line_number":30,"context_line":"    return ["},{"line_number":31,"context_line":"        (\u0027quotas\u0027,"},{"line_number":32,"context_line":"         neutron_fwaas.extensions.firewall.firewall_quota_opts),"},{"line_number":33,"context_line":"        (\u0027service_providers\u0027,"},{"line_number":34,"context_line":"         neutron.conf.services.provider_configuration.serviceprovider_opts),"},{"line_number":35,"context_line":"        (\u0027default_fwg_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d2444eba","side":"PARENT","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":64},"in_reply_to":"3fa7e38b_e030c9eb","updated":"2019-11-04 13:29:35.000000000","message":"Done","commit_id":"b76709009155131b933b2adc7608165413572d71"}]}