)]}'
{"neutron_fwaas/services/firewall/service_drivers/agents/l3reference/firewall_l3_agent_v2.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d902db3f4f07e06e0b6e76a12083b12ae02f6cdb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            routers \u003d self.agent_api.get_routers_in_project("},{"line_number":159,"context_line":"                    firewall_group[\u0027tenant_id\u0027])"},{"line_number":160,"context_line":"            for router in routers:"},{"line_number":161,"context_line":"                if router.router[\u0027tenant_id\u0027] \u003d\u003d firewall_group[\u0027tenant_id\u0027]:"},{"line_number":162,"context_line":"                    fwg_port_ids.extend([p[\u0027id\u0027] for p in"},{"line_number":163,"context_line":"                            router.internal_ports])"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_9e22a151","side":"PARENT","line":161,"range":{"start_line":161,"start_character":16,"end_line":161,"end_character":77},"updated":"2020-05-14 03:48:56.000000000","message":"Why remove this line?","commit_id":"94c0d54ded5006174ca9623a21ff8b3e995caa03"},{"author":{"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"},"change_message_id":"6b3edca395c28cf7db7af004dded41f9a4892f8a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            routers \u003d self.agent_api.get_routers_in_project("},{"line_number":159,"context_line":"                    firewall_group[\u0027tenant_id\u0027])"},{"line_number":160,"context_line":"            for router in routers:"},{"line_number":161,"context_line":"                if router.router[\u0027tenant_id\u0027] \u003d\u003d firewall_group[\u0027tenant_id\u0027]:"},{"line_number":162,"context_line":"                    fwg_port_ids.extend([p[\u0027id\u0027] for p in"},{"line_number":163,"context_line":"                            router.internal_ports])"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_def1b9cf","side":"PARENT","line":161,"range":{"start_line":161,"start_character":16,"end_line":161,"end_character":77},"in_reply_to":"ff570b3c_9e22a151","updated":"2020-05-14 03:53:24.000000000","message":"Because the tenant_id has been specified when getting the routers, there is no need to judge again.\n\n------------------------------------------------\nrouters \u003d self.agent_api.get_routers_in_project(\n             firewall_group[\u0027tenant_id\u0027])","commit_id":"94c0d54ded5006174ca9623a21ff8b3e995caa03"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d63b1302cf16badc8b80969cf1f0392738468f0b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            routers \u003d self.agent_api.get_routers_in_project("},{"line_number":159,"context_line":"                    firewall_group[\u0027tenant_id\u0027])"},{"line_number":160,"context_line":"            for router in routers:"},{"line_number":161,"context_line":"                if router.router[\u0027tenant_id\u0027] \u003d\u003d firewall_group[\u0027tenant_id\u0027]:"},{"line_number":162,"context_line":"                    fwg_port_ids.extend([p[\u0027id\u0027] for p in"},{"line_number":163,"context_line":"                            router.internal_ports])"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_7e906d4f","side":"PARENT","line":161,"range":{"start_line":161,"start_character":16,"end_line":161,"end_character":77},"in_reply_to":"ff570b3c_def1b9cf","updated":"2020-05-14 03:57:18.000000000","message":"Nice catch, thanks.","commit_id":"94c0d54ded5006174ca9623a21ff8b3e995caa03"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d902db3f4f07e06e0b6e76a12083b12ae02f6cdb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            else:"},{"line_number":156,"context_line":"                fwg_port_ids \u003d firewall_group[\u0027add-port-ids\u0027]"},{"line_number":157,"context_line":"        if firewall_group[\u0027ports\u0027] and not require_new_plugin and \\"},{"line_number":158,"context_line":"            not fwg_port_ids:"},{"line_number":159,"context_line":"            routers \u003d self.agent_api.get_routers_in_project("},{"line_number":160,"context_line":"                    firewall_group[\u0027tenant_id\u0027])"},{"line_number":161,"context_line":"            for router in routers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_7e1d0d0e","line":158,"updated":"2020-05-14 03:48:56.000000000","message":"Please consider use like this, not use slash:\nif (firewall_group[\u0027ports\u0027] and not require_new_plugin and\n    not fwg_port_ids):","commit_id":"dcd603e019172bf1fad88224cf3d78bea3c50ed6"}]}