)]}'
{".zuul.yaml":[{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"a10e5cc67a81521953c7549a844e36d576aa22f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-cover-jobs-neutron"},{"line_number":5,"context_line":"      - openstack-lower-constraints-jobs-neutron"},{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs-neutron"},{"line_number":7,"context_line":"      - periodic-stable-jobs-neutron"},{"line_number":8,"context_line":"      - publish-openstack-docs-pti"},{"line_number":9,"context_line":"      - release-notes-jobs-python3"},{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - neutron-fwaas-functional"},{"line_number":13,"context_line":"        - neutron-tempest-plugin-fwaas"},{"line_number":14,"context_line":"        - neutron-fwaas-v2-dsvm-tempest-multinode:"},{"line_number":15,"context_line":"            voting: false"},{"line_number":16,"context_line":"    gate:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - neutron-fwaas-functional"},{"line_number":19,"context_line":"        - neutron-tempest-plugin-fwaas"},{"line_number":20,"context_line":"    experimental:"},{"line_number":21,"context_line":"      jobs:"},{"line_number":22,"context_line":"        - neutron-fwaas-fullstack"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- job:"},{"line_number":25,"context_line":"    name: neutron-fwaas-functional"},{"line_number":26,"context_line":"    parent: neutron-functional"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2702306c_79e767f0","line":23,"range":{"start_line":1,"start_character":2,"end_line":23,"end_character":0},"in_reply_to":"9669ae78_4bc24ca2","updated":"2022-02-09 02:35:33.000000000","message":"thanks ghan, I have submitted a patch(https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/828443)  readd jobs for neutron-fwaas master branch.","commit_id":"0e1e137c8c20ddf76a2bad551aaf44ad8244a6cf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c235e443257b1119d90b3e82e010c16aee54b3bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-cover-jobs-neutron"},{"line_number":5,"context_line":"      - openstack-lower-constraints-jobs-neutron"},{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs-neutron"},{"line_number":7,"context_line":"      - periodic-stable-jobs-neutron"},{"line_number":8,"context_line":"      - publish-openstack-docs-pti"},{"line_number":9,"context_line":"      - release-notes-jobs-python3"},{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - neutron-fwaas-functional"},{"line_number":13,"context_line":"        - neutron-tempest-plugin-fwaas"},{"line_number":14,"context_line":"        - neutron-fwaas-v2-dsvm-tempest-multinode:"},{"line_number":15,"context_line":"            voting: false"},{"line_number":16,"context_line":"    gate:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - neutron-fwaas-functional"},{"line_number":19,"context_line":"        - neutron-tempest-plugin-fwaas"},{"line_number":20,"context_line":"    experimental:"},{"line_number":21,"context_line":"      jobs:"},{"line_number":22,"context_line":"        - neutron-fwaas-fullstack"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- job:"},{"line_number":25,"context_line":"    name: neutron-fwaas-functional"},{"line_number":26,"context_line":"    parent: neutron-functional"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9669ae78_4bc24ca2","line":23,"range":{"start_line":1,"start_character":2,"end_line":23,"end_character":0},"in_reply_to":"d74e12aa_1aa1ff96","updated":"2022-02-08 18:56:04.000000000","message":"\u003e Job neutron-tempest-plugin-fwaas not defined\n\nI think neutron-tempest-plugin-fwaas was merged neutron-tempest-plugin ? if so then we need to update the jobs here too.","commit_id":"0e1e137c8c20ddf76a2bad551aaf44ad8244a6cf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c30c7254a3ff4df3d31b78ca10dbee01acdc13ea","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        q-fwaas-v2: true"},{"line_number":58,"context_line":"      devstack_localrc:"},{"line_number":59,"context_line":"        NETWORK_API_EXTENSIONS: \"agent,binding,dhcp_agent_scheduler,external-net,ext-gw-mode,extra_dhcp_opts,quotas,router,security-group,subnet_allocation,network-ip-availability,auto-allocated-topology,timestamp_core,tag,service-type,rbac-policies,standard-attr-description,pagination,sorting,project-id,fwaas_v2\""},{"line_number":60,"context_line":"        Q_AGENT: openvswitch"},{"line_number":61,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"},{"line_number":62,"context_line":"        Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch"},{"line_number":63,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"46f4753d_cf4b9904","line":60,"updated":"2022-02-21 07:19:35.000000000","message":"AFAIK, You want to do fwaas for ovn now, will You support and maintain ML2/OVS backend too?","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"6e4d6c7326aff9cb54a1599337ba31d1009c4550","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        q-fwaas-v2: true"},{"line_number":58,"context_line":"      devstack_localrc:"},{"line_number":59,"context_line":"        NETWORK_API_EXTENSIONS: \"agent,binding,dhcp_agent_scheduler,external-net,ext-gw-mode,extra_dhcp_opts,quotas,router,security-group,subnet_allocation,network-ip-availability,auto-allocated-topology,timestamp_core,tag,service-type,rbac-policies,standard-attr-description,pagination,sorting,project-id,fwaas_v2\""},{"line_number":60,"context_line":"        Q_AGENT: openvswitch"},{"line_number":61,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"},{"line_number":62,"context_line":"        Q_ML2_PLUGIN_MECHANISM_DRIVERS: openvswitch"},{"line_number":63,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ce8ca8ec_c76f5b0b","line":60,"in_reply_to":"46f4753d_cf4b9904","updated":"2022-02-21 07:40:22.000000000","message":"The current plan is to maintain both ovs and ovn. ovn driver has not fully realized its original functions.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"}],"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c872241cd1fd3b255af41b67510543322d6ae8a4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     zhouhenglc \u003czhouhenglc@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-28 13:39:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Retire neutron-fwaas project\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit caae7b6a6f5e8944dbe359b6472be2507bbf5e12."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"9c571cca_ccad1e0b","line":7,"updated":"2022-02-28 11:02:10.000000000","message":"I think the summary line of \"Revert\" is no longer correct as it contains a lot of updates to pass the tests. How about \"Revive neutron-fwaas project\"?\nIf there is a chance to update it, it would be nice.","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"8eeb756e1868c496009a5914d31b04195390a745","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhouhenglc \u003czhouhenglc@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-28 13:39:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Retire neutron-fwaas project\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit caae7b6a6f5e8944dbe359b6472be2507bbf5e12."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"8c60aa95_529502fc","line":7,"in_reply_to":"9c571cca_ccad1e0b","updated":"2022-03-01 01:03:00.000000000","message":"Done","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c872241cd1fd3b255af41b67510543322d6ae8a4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Replace \"neutron_lib.callbacks.registry.notify\" with \"registry.publish\""},{"line_number":21,"context_line":"Replace rootwrap execution with privsep context execution."},{"line_number":22,"context_line":"Set table firewall_group_port_associations_v2\u0027s two columns"},{"line_number":23,"context_line":"nullable\u003dFalse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-01-28-14.00.log.html#l-14"},{"line_number":26,"context_line":"[2] https://review.opendev.org/c/openstack/neutron-lib/+/761728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"2449d09e_b14fb876","line":23,"updated":"2022-02-28 11:02:10.000000000","message":"nit: the last change happens in the db migration. Perhaps it is better to mention it is about the migration script. If you have a chance to update the commit, please update it.\n\n(Anyway we can check adjustments in this revert by comparing the latest from patch set 1)","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"8eeb756e1868c496009a5914d31b04195390a745","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Replace \"neutron_lib.callbacks.registry.notify\" with \"registry.publish\""},{"line_number":21,"context_line":"Replace rootwrap execution with privsep context execution."},{"line_number":22,"context_line":"Set table firewall_group_port_associations_v2\u0027s two columns"},{"line_number":23,"context_line":"nullable\u003dFalse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-01-28-14.00.log.html#l-14"},{"line_number":26,"context_line":"[2] https://review.opendev.org/c/openstack/neutron-lib/+/761728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"0586d603_fee1452c","line":23,"in_reply_to":"2449d09e_b14fb876","updated":"2022-03-01 01:03:00.000000000","message":"Done","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"a5bd608df4bf347bcfd04a8e5114f2edb972d5db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1398e735_d452098b","updated":"2022-02-09 00:06:44.000000000","message":"+1 to Nate (hello Nate :-) ) - if someone can take this up and maintain it - I am happy to +2 as well and provide any background - although I have been out of openstack for a while.","commit_id":"0e1e137c8c20ddf76a2bad551aaf44ad8244a6cf"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"c4ecab9989aab3088230d714f684e3a15915923f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d46b7a84_c514d5c7","updated":"2022-02-08 19:06:46.000000000","message":"As the last remaining core of neutron-fwaas from the previous iteration of the project, I would be happy to +2+W this, but the job issue Ghanshyam mentioned does need to be rectified.","commit_id":"0e1e137c8c20ddf76a2bad551aaf44ad8244a6cf"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ade314b808c54cfc3c7278a1f258104c5afa542c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1ed1fbd0_1d81456d","updated":"2022-02-11 00:24:57.000000000","message":"recheck","commit_id":"19d4a5f28abd4ede0d8493e9b5d60aacda5286a6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"045c0b21eaf61c2e6806596d9fb4bd2a0a008e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c50cca08_6cddddac","updated":"2022-02-14 09:18:12.000000000","message":"Many things have been updated in this patch, which is not convenient for review. Add another patch to solve the functional test problem.","commit_id":"451818a750e10a173b7bc3a51d5369992c4730b6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"f53d1a26d6235e37a4dbb7278e036098fa7f10ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1818b5bc_24fa0a9e","updated":"2022-02-12 05:54:06.000000000","message":"The functional test failed because it was retired for a long time, needed some time to repair.","commit_id":"451818a750e10a173b7bc3a51d5369992c4730b6"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"3091bcb3195d4402290949bd5bfe7f6767a0a11a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"58e1bcc1_f7d51a2e","updated":"2022-02-12 02:15:44.000000000","message":"recheck","commit_id":"451818a750e10a173b7bc3a51d5369992c4730b6"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"change_message_id":"b5f46435720f8fd3dbddbdcb3275fad10ab7b8c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"bfee5522_946e05e9","updated":"2022-02-16 06:15:45.000000000","message":"For someone who was on the project from the first release - gratifying to see it getting resurrected now that folks are ready to maintain it. There is more work to be done probably to refine - but a start is needed so I am ok. If there are no objections from neutron folks - I can also +2.","commit_id":"932a5ed4c82c2593e10b4186ea89c876b38d8205"},{"author":{"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},"change_message_id":"cd1032c4fc4e3284cce7ffbf2d4cc79f148618f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d0380fcb_daa91b51","updated":"2022-02-16 06:23:34.000000000","message":"LGTM,there is still a lot of work to be done, but we hope this project can be revived soon","commit_id":"932a5ed4c82c2593e10b4186ea89c876b38d8205"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ac6f8366541cf35b78db8db68cba7cfd74531b5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5133a13b_ce533c30","updated":"2022-02-16 05:42:29.000000000","message":"LGTM. IMO, the initial patch need to be merged, it\u0027s not easy to trace.","commit_id":"932a5ed4c82c2593e10b4186ea89c876b38d8205"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4829448388de5493a7db07323ff71c47f9804ea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fdda77ac_68d544c1","updated":"2022-02-16 10:44:42.000000000","message":"Thanks for taking care","commit_id":"932a5ed4c82c2593e10b4186ea89c876b38d8205"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3dd432656f3dacbba1a47571bf191fb90554eff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"59c56241_5d1ecdd2","updated":"2022-02-16 10:45:59.000000000","message":"next steps could be to make functional and multinode tempest jobs voting again","commit_id":"932a5ed4c82c2593e10b4186ea89c876b38d8205"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f2e303cea9f7eba8976c7283232860b31f961f17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"8bd54ba2_099d5200","updated":"2022-02-21 06:45:09.000000000","message":"I\u0027ll wait for Slawek\u0027s reply in https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/828443","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8c4b9c2a029d19f3975bc3cbe45ad1162df06819","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9d0dbd4e_47231005","updated":"2022-02-28 07:13:53.000000000","message":"LGTM","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c872241cd1fd3b255af41b67510543322d6ae8a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8ebb1dd0_b742ac63","updated":"2022-02-28 11:02:10.000000000","message":"Looks good. My comments on the commit message are nits and not blocking. Thanks.","commit_id":"68c67121c49b74bd4720667192c3c67656f85a59"}],"etc/neutron/rootwrap.d/fwaas-privsep.filters":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c30c7254a3ff4df3d31b78ca10dbee01acdc13ea","unresolved":true,"context_lines":[{"line_number":22,"context_line":"sysctl: CommandFilter, sysctl, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# neutron/agent/linux/ip_conntrack.py"},{"line_number":25,"context_line":"conntrack: CommandFilter, conntrack, root"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"d2713179_f6edd62d","line":25,"updated":"2022-02-21 07:19:35.000000000","message":"is this addition part of the revert of old commit? Or something what needed to be added extra now? If it\u0027s an extra addition, I think it should be mentioned in the commit message too.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"38139c6b9c84d040e15877db7a1e556af365a9a3","unresolved":true,"context_lines":[{"line_number":22,"context_line":"sysctl: CommandFilter, sysctl, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# neutron/agent/linux/ip_conntrack.py"},{"line_number":25,"context_line":"conntrack: CommandFilter, conntrack, root"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"36ffd79f_82d6d6b5","line":25,"in_reply_to":"14a1a66d_25bdd5a5","updated":"2022-02-21 08:52:46.000000000","message":"Yes but we removed this dependency in Neutron. This is not needed anymore as long as ip_conntrack module uses now privsep.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"e3b569e9d268d3c3834b974e8e614a7d9a422656","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sysctl: CommandFilter, sysctl, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# neutron/agent/linux/ip_conntrack.py"},{"line_number":25,"context_line":"conntrack: CommandFilter, conntrack, root"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"4de55a1f_0677918b","line":25,"in_reply_to":"36ffd79f_82d6d6b5","updated":"2022-02-21 09:34:12.000000000","message":"Done","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"6e4d6c7326aff9cb54a1599337ba31d1009c4550","unresolved":true,"context_lines":[{"line_number":22,"context_line":"sysctl: CommandFilter, sysctl, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# neutron/agent/linux/ip_conntrack.py"},{"line_number":25,"context_line":"conntrack: CommandFilter, conntrack, root"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"14a1a66d_25bdd5a5","line":25,"in_reply_to":"d2713179_f6edd62d","updated":"2022-02-21 07:40:22.000000000","message":"This is not old code, it is added for functional testing. Originally, this part of the code is in neutron/etc/neutron/rootwrap.d/iptables-firewall.filters. neutron-fwass use \"neutron/agent/linux/ip_conntrack.py\" to manage conntrack.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"}],"neutron_fwaas/db/migration/alembic_migrations/versions/newton/expand/d6a12e637e28_neutron_fwaas_v2_0.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c30c7254a3ff4df3d31b78ca10dbee01acdc13ea","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                  nullable\u003dFalse),"},{"line_number":102,"context_line":"        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":103,"context_line":"                  sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":104,"context_line":"                  nullable\u003dFalse)"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    op.create_table("}],"source_content_type":"text/x-python","patch_set":21,"id":"d0796a9a_56837355","line":104,"updated":"2022-02-21 07:19:35.000000000","message":"same here","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b39463d6e4b81b71e47569df6d84cebf26289407","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                  nullable\u003dFalse),"},{"line_number":102,"context_line":"        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":103,"context_line":"                  sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":104,"context_line":"                  nullable\u003dFalse)"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    op.create_table("}],"source_content_type":"text/x-python","patch_set":21,"id":"d364d975_cec367c2","line":104,"in_reply_to":"85391095_71997c6b","updated":"2022-02-21 09:18:30.000000000","message":"Ok, but my point is to add info about those changes in the commit message as those aren\u0027t simply revert of the other commit but some additional changes, so it would be good to have info about why those extra changes where needed.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"38139c6b9c84d040e15877db7a1e556af365a9a3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                  nullable\u003dFalse),"},{"line_number":102,"context_line":"        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":103,"context_line":"                  sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":104,"context_line":"                  nullable\u003dFalse)"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    op.create_table("}],"source_content_type":"text/x-python","patch_set":21,"id":"85391095_71997c6b","line":104,"in_reply_to":"a8165c39_d1047577","updated":"2022-02-21 08:52:46.000000000","message":"Right, makes sense","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"6e4d6c7326aff9cb54a1599337ba31d1009c4550","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                  nullable\u003dFalse),"},{"line_number":102,"context_line":"        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":103,"context_line":"                  sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":104,"context_line":"                  nullable\u003dFalse)"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    op.create_table("}],"source_content_type":"text/x-python","patch_set":21,"id":"a8165c39_d1047577","line":104,"in_reply_to":"d0796a9a_56837355","updated":"2022-02-21 07:40:22.000000000","message":"it is also added for functional testing. if not add, will raise \"Models and migration scripts aren\u0027t in sync\", this two column is ForeignKey, so i update migration code, not Model code.","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"e3b569e9d268d3c3834b974e8e614a7d9a422656","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                  nullable\u003dFalse),"},{"line_number":102,"context_line":"        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":103,"context_line":"                  sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":104,"context_line":"                  nullable\u003dFalse)"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    op.create_table("}],"source_content_type":"text/x-python","patch_set":21,"id":"e1241168_758b6d13","line":104,"in_reply_to":"d364d975_cec367c2","updated":"2022-02-21 09:34:12.000000000","message":"Done","commit_id":"29302423a247313ee73685d3cf52f330955e0b75"}]}