)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11238f804d1b4dfa914483b7471ef615185e7f13","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch set firewall group status to ACTIVE when it has associate"},{"line_number":12,"context_line":"with policies."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: #2047325"},{"line_number":15,"context_line":"Change-Id: I86e5f2becda788fdf1d1d546aa0cb22a124e6a20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dac9763f_a4d0c6bb","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":7},"updated":"2024-01-04 10:19:21.000000000","message":"s/Related/Closes","commit_id":"104d0e09e4e832d8fd33115f1f6428b8a0752c99"}],"neutron_fwaas/services/firewall/service_drivers/agents/l3reference/firewall_l3_agent_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d922f04c05e0649aa81d97b234b4da28ea1132a","unresolved":true,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            # Prepare firewall group status to return to plugin; may be"},{"line_number":219,"context_line":"            # overwritten if call to driver fails."},{"line_number":220,"context_line":"            if firewall_group[\u0027admin_state_up\u0027]:"},{"line_number":221,"context_line":"                if firewall_group[\u0027ingress_firewall_policy_id\u0027] or \\"},{"line_number":222,"context_line":"                        firewall_group[\u0027egress_firewall_policy_id\u0027]:"},{"line_number":223,"context_line":"                    status \u003d nl_constants.ACTIVE"}],"source_content_type":"text/x-python","patch_set":3,"id":"592d23e1_9e4dcd7d","line":220,"range":{"start_line":220,"start_character":12,"end_line":220,"end_character":48},"updated":"2024-01-02 11:34:21.000000000","message":"There is a method in ``FWaaSV2AgentExtension`` called ``_compute_status``. That method returns the status of a FW group depending on several parameters. Instead of re-implementing that here, we should use a common method.","commit_id":"b5cab4ee83da925f19374f9eace3b8546e76fe20"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d922f04c05e0649aa81d97b234b4da28ea1132a","unresolved":true,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # Set firewall group status; will be overwritten if call to driver"},{"line_number":380,"context_line":"        # fails."},{"line_number":381,"context_line":"        if firewall_group[\u0027admin_state_up\u0027]:"},{"line_number":382,"context_line":"            status \u003d nl_constants.ACTIVE"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            status \u003d nl_constants.DOWN"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c061076_4e4eb0af","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":44},"updated":"2024-01-02 11:34:21.000000000","message":"Same here","commit_id":"b5cab4ee83da925f19374f9eace3b8546e76fe20"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d922f04c05e0649aa81d97b234b4da28ea1132a","unresolved":true,"context_lines":[{"line_number":437,"context_line":"            # Set firewall group\u0027s status; will be overwritten if call to"},{"line_number":438,"context_line":"            # driver fails."},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"            if firewall_group[\u0027admin_state_up\u0027]:"},{"line_number":441,"context_line":"                status \u003d nl_constants.ACTIVE"},{"line_number":442,"context_line":"                if firewall_group[\u0027last-port\u0027]:"},{"line_number":443,"context_line":"                    status \u003d nl_constants.INACTIVE"}],"source_content_type":"text/x-python","patch_set":3,"id":"87df4fca_2a6ced88","line":440,"range":{"start_line":440,"start_character":0,"end_line":440,"end_character":2},"updated":"2024-01-02 11:34:21.000000000","message":"Same here","commit_id":"b5cab4ee83da925f19374f9eace3b8546e76fe20"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d922f04c05e0649aa81d97b234b4da28ea1132a","unresolved":true,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"                # Set firewall group status, which will be overwritten if call"},{"line_number":470,"context_line":"                # to driver fails."},{"line_number":471,"context_line":"                if firewall_group[\u0027admin_state_up\u0027]:"},{"line_number":472,"context_line":"                    status \u003d nl_constants.ACTIVE"},{"line_number":473,"context_line":"                else:"},{"line_number":474,"context_line":"                    status \u003d nl_constants.DOWN"}],"source_content_type":"text/x-python","patch_set":3,"id":"120110d2_2f438784","line":471,"range":{"start_line":471,"start_character":17,"end_line":471,"end_character":52},"updated":"2024-01-02 11:34:21.000000000","message":"Same here","commit_id":"b5cab4ee83da925f19374f9eace3b8546e76fe20"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d922f04c05e0649aa81d97b234b4da28ea1132a","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # Set the firewall group\u0027s status to return to plugin; status may be"},{"line_number":516,"context_line":"        # overwritten if call to driver fails."},{"line_number":517,"context_line":"        if firewall_group[\u0027admin_state_up\u0027]:"},{"line_number":518,"context_line":"            status \u003d nl_constants.ACTIVE"},{"line_number":519,"context_line":"        else:"},{"line_number":520,"context_line":"            status \u003d nl_constants.DOWN"}],"source_content_type":"text/x-python","patch_set":3,"id":"435ff93b_2518c9ad","line":517,"range":{"start_line":517,"start_character":8,"end_line":517,"end_character":44},"updated":"2024-01-02 11:34:21.000000000","message":"And here","commit_id":"b5cab4ee83da925f19374f9eace3b8546e76fe20"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11238f804d1b4dfa914483b7471ef615185e7f13","unresolved":true,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"            # Prepare firewall group status to return to plugin; may be"},{"line_number":222,"context_line":"            # overwritten if call to driver fails."},{"line_number":223,"context_line":"            status \u003d self.fw_l2_extension._compute_status(firewall_group, True)"},{"line_number":224,"context_line":"            # Call the driver."},{"line_number":225,"context_line":"            try:"},{"line_number":226,"context_line":"                self.fwaas_driver.update_firewall_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7009f2_c0800e01","line":223,"range":{"start_line":223,"start_character":13,"end_line":223,"end_character":79},"updated":"2024-01-04 10:19:21.000000000","message":"That\u0027s ok, but what about the change related to LP#2047325? Where are you testing now that the FW group is not associated to a policy? You should change \"_compute_status\" method.","commit_id":"104d0e09e4e832d8fd33115f1f6428b8a0752c99"}]}